Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95080/?format=api
{ "id": 95080, "url": "http://patchwork.dpdk.org/api/patches/95080/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210630135158.8108-2-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210630135158.8108-2-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210630135158.8108-2-olivier.matz@6wind.com", "date": "2021-06-30T13:51:55", "name": "[v2,1/4] net/tap: fix Rx cksum flags on IP options packets", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c9ef88f8340788f08650ac4c564c6ca6d1029144", "submitter": { "id": 8, "url": "http://patchwork.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": { "id": 3961, "url": "http://patchwork.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210630135158.8108-2-olivier.matz@6wind.com/mbox/", "series": [ { "id": 17552, "url": "http://patchwork.dpdk.org/api/series/17552/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17552", "date": "2021-06-30T13:51:54", "name": "net/tap: fix Rx cksum", "version": 2, "mbox": "http://patchwork.dpdk.org/series/17552/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/95080/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/95080/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 084C7A0A0F;\n\tWed, 30 Jun 2021 15:52:37 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 11AF54127A;\n\tWed, 30 Jun 2021 15:52:32 +0200 (CEST)", "from mail-wr1-f46.google.com (mail-wr1-f46.google.com\n [209.85.221.46]) by mails.dpdk.org (Postfix) with ESMTP id 6D5BC41221\n for <dev@dpdk.org>; Wed, 30 Jun 2021 15:52:28 +0200 (CEST)", "by mail-wr1-f46.google.com with SMTP id j2so3711617wrs.12\n for <dev@dpdk.org>; Wed, 30 Jun 2021 06:52:28 -0700 (PDT)", "from gojira.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n [62.23.145.78])\n by smtp.gmail.com with ESMTPSA id g15sm193026wrs.50.2021.06.30.06.52.27\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 30 Jun 2021 06:52:27 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=r0c+JEWF44KsZ3Jo9Za0B/o6DO1SFW7AcGoN6uYcS6w=;\n b=DLkhOzdhV+mOhBsg5zcG1ZFbGdE+9a5jYTa6fBh5DX6WQ6QTeYZiLZiImT1QYjqbRC\n JgflF46gzNkA99ehlSrrjeEBgs6abUte7JtgV58LpFIC7Kw2TtQWQ1qztDCwY7mM0X0Z\n acLqjOxOxL5y1Njf6mzf/R0sKk6RfmLGUKzrEuHqtpUQ08bBv6Zyw9kwgB+xhOmOiO7T\n V+LfonsogPkS5WSKZ+2ryIx11e1GB3cBBf+ADFg3UyIfJL5qgkPXy/7LpBsiHmm1osOi\n a3n1s2AQW+VnYPQVhMelm1aNuIW0lSR6sdYp7gqqa2iCr3bC/YnqA8pGbb6knat6lgop\n jdcw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=r0c+JEWF44KsZ3Jo9Za0B/o6DO1SFW7AcGoN6uYcS6w=;\n b=Cbj9GZhL1QFaKe+0YMsxsdRA//+cdh1nn50bTY9lsNxGmp2qkYj0fJjqyAO0F+xW/B\n yb5WDhy0Z7FWsmhjOzBBlBmgYfZML7K13xbnv8lrylVtuFnZI9XK2e3LGivVep4QhfSJ\n uqNXjl+2kfqhjYXVkhBJsgPCnffTBexXXhULmizVgniDiS8YvTpFtsvupSzgpcnZS/w3\n tzdcZ79zU4r7CvPjtV7ZZJEB1XxhW2WTNxN0SJVcZGh5i3y3G6xd0ubxGUwb98k9iWRe\n wPs/5d+tWSecjquAewQa8PUvFdp3YRgj1m4y3QN5WhTGpGxCh8tpoRWXP+EYj24l3AkY\n fUXw==", "X-Gm-Message-State": "AOAM533/R+51s7WKJpGtlYWktVulhW/FjZXNljLdIp2ESZVolh0nkp8u\n MozkKfXTUpvfJDYey9GPnBivQzQvQXo2Pw==", "X-Google-Smtp-Source": "\n ABdhPJxgB+xAgNUE3Uq/1GcRcc+UtQY2vSMfpXFvQ8hGdQq9FklD3RJiJRJ3ptLZmFEhuxab9Hm4Yg==", "X-Received": "by 2002:a5d:6b82:: with SMTP id n2mr38760387wrx.206.1625061148173;\n Wed, 30 Jun 2021 06:52:28 -0700 (PDT)", "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Cc": "guohongzhi1@huawei.com, keith.wiles@intel.com, mb@smartsharesystems.com,\n thomas@monjalon.net, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru,\n stable@dpdk.org", "Date": "Wed, 30 Jun 2021 15:51:55 +0200", "Message-Id": "<20210630135158.8108-2-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.29.2", "In-Reply-To": "<20210630135158.8108-1-olivier.matz@6wind.com>", "References": "<20210427135755.927-1-olivier.matz@6wind.com>\n <20210630135158.8108-1-olivier.matz@6wind.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/4] net/tap: fix Rx cksum flags on IP options\n packets", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When packet type is IPV4_EXT, the checksum is always marked as good in\nthe mbuf offload flags.\n\nSince we know the header lengths, we can easily call\nrte_ipv4_udptcp_cksum() in this case too.\n\nFixes: 8ae3023387e9 (\"net/tap: add Rx/Tx checksum offload support\")\nCc: stable@dpdk.org\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\n---\n drivers/net/tap/rte_eth_tap.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 5735988e7c..5513cfd2d7 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -342,7 +342,11 @@ tap_verify_csum(struct rte_mbuf *mbuf)\n \t\t\t\trte_pktmbuf_data_len(mbuf))\n \t\t\treturn;\n \t} else {\n-\t\t/* IPv6 extensions are not supported */\n+\t\t/* - RTE_PTYPE_L3_IPV4_EXT_UNKNOWN cannot happen because\n+\t\t * mbuf->packet_type is filled by rte_net_get_ptype() which\n+\t\t * never returns this value.\n+\t\t * - IPv6 extensions are not supported.\n+\t\t */\n \t\treturn;\n \t}\n \tif (l4 == RTE_PTYPE_L4_UDP || l4 == RTE_PTYPE_L4_TCP) {\n@@ -350,7 +354,7 @@ tap_verify_csum(struct rte_mbuf *mbuf)\n \t\t/* Don't verify checksum for multi-segment packets. */\n \t\tif (mbuf->nb_segs > 1)\n \t\t\treturn;\n-\t\tif (l3 == RTE_PTYPE_L3_IPV4) {\n+\t\tif (l3 == RTE_PTYPE_L3_IPV4 || l3 == RTE_PTYPE_L3_IPV4_EXT) {\n \t\t\tif (l4 == RTE_PTYPE_L4_UDP) {\n \t\t\t\tudp_hdr = (struct rte_udp_hdr *)l4_hdr;\n \t\t\t\tif (udp_hdr->dgram_cksum == 0) {\n@@ -364,7 +368,7 @@ tap_verify_csum(struct rte_mbuf *mbuf)\n \t\t\t\t}\n \t\t\t}\n \t\t\tcksum = ~rte_ipv4_udptcp_cksum(l3_hdr, l4_hdr);\n-\t\t} else if (l3 == RTE_PTYPE_L3_IPV6) {\n+\t\t} else { /* l3 == RTE_PTYPE_L3_IPV6, checked above */\n \t\t\tcksum = ~rte_ipv6_udptcp_cksum(l3_hdr, l4_hdr);\n \t\t}\n \t\tmbuf->ol_flags |= cksum ?\n", "prefixes": [ "v2", "1/4" ] }