Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95363/?format=api
{ "id": 95363, "url": "http://patchwork.dpdk.org/api/patches/95363/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210706095545.10776-20-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210706095545.10776-20-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210706095545.10776-20-jiawenwu@trustnetic.com", "date": "2021-07-06T09:55:45", "name": "[v7,19/19] net/ngbe: support to close and reset device", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "8aa730d7f0a3c7fb047ede13ec38dc7a62ca889d", "submitter": { "id": 1932, "url": "http://patchwork.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 3961, "url": "http://patchwork.dpdk.org/api/users/3961/?format=api", "username": "arybchenko", "first_name": "Andrew", "last_name": "Rybchenko", "email": "andrew.rybchenko@oktetlabs.ru" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210706095545.10776-20-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 17659, "url": "http://patchwork.dpdk.org/api/series/17659/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17659", "date": "2021-07-06T09:55:28", "name": "net: ngbe PMD", "version": 7, "mbox": "http://patchwork.dpdk.org/series/17659/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/95363/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/95363/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0C7D3A0C47;\n\tTue, 6 Jul 2021 11:59:02 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 334854139A;\n\tTue, 6 Jul 2021 11:56:31 +0200 (CEST)", "from smtpproxy21.qq.com (smtpbg704.qq.com [203.205.195.105])\n by mails.dpdk.org (Postfix) with ESMTP id C1B184139A\n for <dev@dpdk.org>; Tue, 6 Jul 2021 11:56:29 +0200 (CEST)", "from jiawenwu.trustnetic.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Tue, 06 Jul 2021 17:56:24 +0800 (CST)" ], "X-QQ-mid": "bizesmtp51t1625565384tdiryj2k", "X-QQ-SSF": "01400000002000D0E000B00A0000000", "X-QQ-FEAT": "b0oIbfUHMAhRBxH1Im2wp0dSOz0QVSrHWvtb+y3siJaQbXd/PaWRp3favXIG+\n JZIDWKNQojUqgZhD1pCW1GYZjNUXa1z7VO5gma/gUG9miRn8PGYT4/xl1aEeuDCx8kvUrUv\n 0avRanD5MaUNsemB1TQHf1EgA3ytUwMP8Fh8BXZAsQXoaAG1m9u7BEnmWc6yZejtKv2PkB6\n igg5n/sVVHQyjwaDQsggBjApCQeiRGEqYJtS+c5BrKJTDvwr744hElkbHuXywtqkEd3fyIc\n zHTRorptkx5DwpUEi0dwkfytchTLCMH+ahNVR8kXim9yFqfSmunfmqII9Lr7XsnulwYrX+/\n 2TEkJHuks4eD2fcktECv3V4BLxwfYKevpvp9vTl", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>", "Date": "Tue, 6 Jul 2021 17:55:45 +0800", "Message-Id": "<20210706095545.10776-20-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20210706095545.10776-1-jiawenwu@trustnetic.com>", "References": "<20210706095545.10776-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign7", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH v7 19/19] net/ngbe: support to close and reset\n device", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support to close and reset device.\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/ngbe/ngbe_ethdev.c | 63 ++++++++++++++++++++++++++++++++--\n drivers/net/ngbe/ngbe_ethdev.h | 2 ++\n drivers/net/ngbe/ngbe_rxtx.c | 20 +++++++++++\n 3 files changed, 82 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ngbe/ngbe_ethdev.c b/drivers/net/ngbe/ngbe_ethdev.c\nindex 944fea6a11..1e3c11533b 100644\n--- a/drivers/net/ngbe/ngbe_ethdev.c\n+++ b/drivers/net/ngbe/ngbe_ethdev.c\n@@ -256,7 +256,7 @@ eth_ngbe_dev_uninit(struct rte_eth_dev *eth_dev)\n \n \tngbe_dev_close(eth_dev);\n \n-\treturn -EINVAL;\n+\treturn 0;\n }\n \n static int\n@@ -557,11 +557,66 @@ ngbe_dev_stop(struct rte_eth_dev *dev)\n static int\n ngbe_dev_close(struct rte_eth_dev *dev)\n {\n+\tstruct ngbe_hw *hw = ngbe_dev_hw(dev);\n+\tstruct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);\n+\tstruct rte_intr_handle *intr_handle = &pci_dev->intr_handle;\n+\tint retries = 0;\n+\tint ret;\n+\n \tPMD_INIT_FUNC_TRACE();\n \n-\tRTE_SET_USED(dev);\n+\tngbe_pf_reset_hw(hw);\n+\n+\tret = ngbe_dev_stop(dev);\n+\n+\tngbe_dev_free_queues(dev);\n+\n+\t/* reprogram the RAR[0] in case user changed it. */\n+\tngbe_set_rar(hw, 0, hw->mac.addr, 0, true);\n+\n+\t/* Unlock any pending hardware semaphore */\n+\tngbe_swfw_lock_reset(hw);\n+\n+\t/* disable uio intr before callback unregister */\n+\trte_intr_disable(intr_handle);\n+\n+\tdo {\n+\t\tret = rte_intr_callback_unregister(intr_handle,\n+\t\t\t\tngbe_dev_interrupt_handler, dev);\n+\t\tif (ret >= 0 || ret == -ENOENT) {\n+\t\t\tbreak;\n+\t\t} else if (ret != -EAGAIN) {\n+\t\t\tPMD_INIT_LOG(ERR,\n+\t\t\t\t\"intr callback unregister failed: %d\",\n+\t\t\t\tret);\n+\t\t}\n+\t\trte_delay_ms(100);\n+\t} while (retries++ < (10 + NGBE_LINK_UP_TIME));\n+\n+\trte_free(dev->data->mac_addrs);\n+\tdev->data->mac_addrs = NULL;\n+\n+\trte_free(dev->data->hash_mac_addrs);\n+\tdev->data->hash_mac_addrs = NULL;\n+\n+\treturn ret;\n+}\n+\n+/*\n+ * Reset PF device.\n+ */\n+static int\n+ngbe_dev_reset(struct rte_eth_dev *dev)\n+{\n+\tint ret;\n+\n+\tret = eth_ngbe_dev_uninit(dev);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tret = eth_ngbe_dev_init(dev, NULL);\n \n-\treturn -EINVAL;\n+\treturn ret;\n }\n \n static int\n@@ -1094,6 +1149,8 @@ static const struct eth_dev_ops ngbe_eth_dev_ops = {\n \t.dev_infos_get = ngbe_dev_info_get,\n \t.dev_start = ngbe_dev_start,\n \t.dev_stop = ngbe_dev_stop,\n+\t.dev_close = ngbe_dev_close,\n+\t.dev_reset = ngbe_dev_reset,\n \t.link_update = ngbe_dev_link_update,\n \t.rx_queue_start\t = ngbe_dev_rx_queue_start,\n \t.rx_queue_stop = ngbe_dev_rx_queue_stop,\ndiff --git a/drivers/net/ngbe/ngbe_ethdev.h b/drivers/net/ngbe/ngbe_ethdev.h\nindex 5a2f45cc2f..af16d0c3f7 100644\n--- a/drivers/net/ngbe/ngbe_ethdev.h\n+++ b/drivers/net/ngbe/ngbe_ethdev.h\n@@ -67,6 +67,8 @@ ngbe_dev_intr(struct rte_eth_dev *dev)\n */\n void ngbe_dev_clear_queues(struct rte_eth_dev *dev);\n \n+void ngbe_dev_free_queues(struct rte_eth_dev *dev);\n+\n void ngbe_dev_rx_queue_release(void *rxq);\n \n void ngbe_dev_tx_queue_release(void *txq);\ndiff --git a/drivers/net/ngbe/ngbe_rxtx.c b/drivers/net/ngbe/ngbe_rxtx.c\nindex 8dca07c6d9..0547e36fa9 100644\n--- a/drivers/net/ngbe/ngbe_rxtx.c\n+++ b/drivers/net/ngbe/ngbe_rxtx.c\n@@ -906,6 +906,26 @@ ngbe_dev_clear_queues(struct rte_eth_dev *dev)\n \t}\n }\n \n+void\n+ngbe_dev_free_queues(struct rte_eth_dev *dev)\n+{\n+\tunsigned int i;\n+\n+\tPMD_INIT_FUNC_TRACE();\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\tngbe_dev_rx_queue_release(dev->data->rx_queues[i]);\n+\t\tdev->data->rx_queues[i] = NULL;\n+\t}\n+\tdev->data->nb_rx_queues = 0;\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\tngbe_dev_tx_queue_release(dev->data->tx_queues[i]);\n+\t\tdev->data->tx_queues[i] = NULL;\n+\t}\n+\tdev->data->nb_tx_queues = 0;\n+}\n+\n static int __rte_cold\n ngbe_alloc_rx_queue_mbufs(struct ngbe_rx_queue *rxq)\n {\n", "prefixes": [ "v7", "19/19" ] }