Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 95820,
    "url": "http://patchwork.dpdk.org/api/patches/95820/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210713154118.32111-4-mk@semihalf.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210713154118.32111-4-mk@semihalf.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210713154118.32111-4-mk@semihalf.com",
    "date": "2021-07-13T15:41:15",
    "name": "[3/6] net/ena: trigger reset when Tx prepare fails",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "5ddc3f9604eaa32a188814fce37842ee6993cdf9",
    "submitter": {
        "id": 786,
        "url": "http://patchwork.dpdk.org/api/people/786/?format=api",
        "name": "Michal Krawczyk",
        "email": "mk@semihalf.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210713154118.32111-4-mk@semihalf.com/mbox/",
    "series": [
        {
            "id": 17808,
            "url": "http://patchwork.dpdk.org/api/series/17808/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17808",
            "date": "2021-07-13T15:41:12",
            "name": "net/ena: v2.4.0 driver update",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/17808/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/95820/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/95820/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F2047A0C4C;\n\tTue, 13 Jul 2021 17:42:04 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EF758412E0;\n\tTue, 13 Jul 2021 17:41:48 +0200 (CEST)",
            "from mail-lj1-f171.google.com (mail-lj1-f171.google.com\n [209.85.208.171])\n by mails.dpdk.org (Postfix) with ESMTP id 3D0F7412C9\n for <dev@dpdk.org>; Tue, 13 Jul 2021 17:41:46 +0200 (CEST)",
            "by mail-lj1-f171.google.com with SMTP id h9so15304401ljm.5\n for <dev@dpdk.org>; Tue, 13 Jul 2021 08:41:46 -0700 (PDT)",
            "from DESKTOP-U5LNN3J.localdomain (89-79-189-199.dynamic.chello.pl.\n [89.79.189.199])\n by smtp.gmail.com with ESMTPSA id s15sm1488415lfp.216.2021.07.13.08.41.44\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 13 Jul 2021 08:41:44 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=V4S5VuFuIVM0xDiwmw+bkutu1YZQ0xs0EYeC39TGHVY=;\n b=0XG4mOUrcrM+bU7KH7HmgDlcCK8VamdoRZv532NM5k4lXcIKLP8Ujr2Ow3JIV1hTye\n m1/eKRbHitupwT2qKtZCvIcV9kILUsKec1lFGeAW5in1fIIPyTIcKhL6AXBdCHIUJRxl\n TCjP5fd++iCNe9C6HdhxDqA3pl2NYoq0R26V/41C0oXvpPV17YUkYb4U2aCpwwI6cHiS\n qOq6Onn/XePftQkA1h8pj2rO59R4hh2Jw+ib/rQIn2ApikectiNCQ0G8YqBvXEnF3IYv\n L/UJswFoGEkewmOQYxu2PXiV9jhf5Bj1g0IBqban9jli0rMaNJeimeiEaMqOMj3ubOja\n w38w==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=V4S5VuFuIVM0xDiwmw+bkutu1YZQ0xs0EYeC39TGHVY=;\n b=V3D1iyjA+Zu+SOc2HyI+TLiX4GhdP6P+dAek7yDn2AseUb0JuMuTyy5NfIrNnSYDd7\n cBOagp8EkviXK38+pjjhbhWjMDR5uuo7S8gZ24LGSYU4eD/19W1Lx4+JbQ025ecTCoqj\n In0VFTQLM73V/Nnc8t599AFOKm3L9pebjtxTkEf1sOAJpu7qWu11tdtJj8nXDxihBHXe\n su08YcHCCx74awQms1TdZIN249UQ4Cfmumu1lvHpJlnON8xRxa4CMOoT4uoE8gp6SYM/\n 8iJmYNk8f1d1yBsnpfQx/YWI5maTzBBLqmNyzzCBPh1aWfIKkNr1HXLF6Y2f23jUd2yZ\n BDZg==",
        "X-Gm-Message-State": "AOAM530tD7t08SgSpx8oUyW2qD5/ptV49FRGaN9o0l9ST0Qj3hy6ZyGi\n Lvwt2I6ekgxWQ9Tzv7KoU2rdguAy3bYjXi7k",
        "X-Google-Smtp-Source": "\n ABdhPJyEcXXEhJMl3e+w5VTnMz2R1dhoOjEYkcDjH645Gg/qybr/ZDm2W/i4FF/b4krxfgi9FNlmZA==",
        "X-Received": "by 2002:a2e:9f11:: with SMTP id u17mr4718319ljk.16.1626190905584;\n Tue, 13 Jul 2021 08:41:45 -0700 (PDT)",
        "From": "Michal Krawczyk <mk@semihalf.com>",
        "To": "dev@dpdk.org",
        "Cc": "ndagan@amazon.com, shaibran@amazon.com, upstream@semihalf.com,\n Michal Krawczyk <mk@semihalf.com>, stable@dpdk.org,\n Shay Agroskin <shayagr@amazon.com>",
        "Date": "Tue, 13 Jul 2021 17:41:15 +0200",
        "Message-Id": "<20210713154118.32111-4-mk@semihalf.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20210713154118.32111-1-mk@semihalf.com>",
        "References": "<20210713154118.32111-1-mk@semihalf.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 3/6] net/ena: trigger reset when Tx prepare fails",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "If the prepare function failed, then it means the descriptors are in the\ninvalid state.\n\nThis condition now triggers the reset, which should be further handled\nby the application.\n\nTo notify the application about prepare function failure, the error log\nwas added. In general, it should never fail in normal conditions, as the\nTx function checks for the available space in the Tx ring before the\npreparation even starts.\n\nFixes: 2081d5e2e92d (\"net/ena: add reset routine\")\nCc: stable@dpdk.org\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Shay Agroskin <shayagr@amazon.com>\n---\n drivers/net/ena/ena_ethdev.c | 4 ++++\n 1 file changed, 4 insertions(+)",
    "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 2335436b6c..67cd91046a 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -2570,7 +2570,11 @@ static int ena_xmit_mbuf(struct ena_ring *tx_ring, struct rte_mbuf *mbuf)\n \trc = ena_com_prepare_tx(tx_ring->ena_com_io_sq,\t&ena_tx_ctx,\n \t\t&nb_hw_desc);\n \tif (unlikely(rc)) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to prepare Tx buffers, rc: %d\\n\", rc);\n \t\t++tx_ring->tx_stats.prepare_ctx_err;\n+\t\ttx_ring->adapter->reset_reason =\n+\t\t    ENA_REGS_RESET_DRIVER_INVALID_STATE;\n+\t\ttx_ring->adapter->trigger_reset = true;\n \t\treturn rc;\n \t}\n \n",
    "prefixes": [
        "3/6"
    ]
}