Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95860/?format=api
{ "id": 95860, "url": "http://patchwork.dpdk.org/api/patches/95860/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210714104405.23917-2-richael.zhuang@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210714104405.23917-2-richael.zhuang@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210714104405.23917-2-richael.zhuang@arm.com", "date": "2021-07-14T10:44:05", "name": "[v2,1/1] test/power: fix CPU frequency check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e10e2fd173b238e4e2ce5e5ae28b93a9e358c0f5", "submitter": { "id": 2178, "url": "http://patchwork.dpdk.org/api/people/2178/?format=api", "name": "Richael Zhuang", "email": "richael.zhuang@arm.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210714104405.23917-2-richael.zhuang@arm.com/mbox/", "series": [ { "id": 17820, "url": "http://patchwork.dpdk.org/api/series/17820/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17820", "date": "2021-07-14T10:44:04", "name": "test/power: fix CPU frequency check", "version": 2, "mbox": "http://patchwork.dpdk.org/series/17820/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/95860/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/95860/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7AB37A0C4B;\n\tWed, 14 Jul 2021 12:44:26 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6A4094131B;\n\tWed, 14 Jul 2021 12:44:26 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 2BFCF4130C;\n Wed, 14 Jul 2021 12:44:24 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9C6B0D6E;\n Wed, 14 Jul 2021 03:44:23 -0700 (PDT)", "from wls-arm-cavium06.shanghai.arm.com\n (wls-arm-cavium06.shanghai.arm.com [10.169.206.120])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 12E9A3F774;\n Wed, 14 Jul 2021 03:44:21 -0700 (PDT)" ], "From": "Richael Zhuang <richael.zhuang@arm.com>", "To": "dev@dpdk.org", "Cc": "zhiminx.huang@intel.com,\n\tdavid.hunt@intel.com,\n\tstable@dpdk.org", "Date": "Wed, 14 Jul 2021 18:44:05 +0800", "Message-Id": "<20210714104405.23917-2-richael.zhuang@arm.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210714104405.23917-1-richael.zhuang@arm.com>", "References": "<20210714084407.51979-2-richael.zhuang@arm.com>\n <20210714104405.23917-1-richael.zhuang@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/1] test/power: fix CPU frequency check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For acpi_cpufreq and cppc_cpufreq, both cpuinfo_cur_freq and\nscaling_cur_freq exist. For pstate, only scaling_cur_freq exists.\nAnd value in scaling_cur_freq and cpuinfo_cur_freq may not be the\nsame. For acpi_cpufreq and cppc_cpufreq, we should check\ncpuinfo_cur_freq but not scaling_cur_freq. So here change the\ncheck sequence to make sure it works for all cpufreq drivers.\nBesides, add rounding for pstate driver.\n\nFixes: ff6dfb8e492f (\"test/power: fix CPU frequency check\")\nCc: david.hunt@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Richael Zhuang <richael.zhuang@arm.com>\n---\n app/test/test_power_cpufreq.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c\nindex b8fc53925c..1a9549527e 100644\n--- a/app/test/test_power_cpufreq.c\n+++ b/app/test/test_power_cpufreq.c\n@@ -62,13 +62,13 @@ check_cur_freq(unsigned int lcore_id, uint32_t idx, bool turbo)\n \tint i;\n \n \tif (snprintf(fullpath, sizeof(fullpath),\n-\t\tTEST_POWER_SYSFILE_SCALING_FREQ, lcore_id) < 0) {\n+\t\tTEST_POWER_SYSFILE_CPUINFO_FREQ, lcore_id) < 0) {\n \t\treturn 0;\n \t}\n \tf = fopen(fullpath, \"r\");\n \tif (f == NULL) {\n \t\tif (snprintf(fullpath, sizeof(fullpath),\n-\t\t\tTEST_POWER_SYSFILE_CPUINFO_FREQ, lcore_id) < 0) {\n+\t\t\tTEST_POWER_SYSFILE_SCALING_FREQ, lcore_id) < 0) {\n \t\t\treturn 0;\n \t\t}\n \t\tf = fopen(fullpath, \"r\");\n@@ -85,7 +85,7 @@ check_cur_freq(unsigned int lcore_id, uint32_t idx, bool turbo)\n \t\tfreq_conv = cur_freq;\n \n \t\tenv = rte_power_get_env();\n-\t\tif (env == PM_ENV_CPPC_CPUFREQ) {\n+\t\tif (env == PM_ENV_CPPC_CPUFREQ || env == PM_ENV_PSTATE_CPUFREQ) {\n \t\t\t/* convert the frequency to nearest 100000 value\n \t\t\t * Ex: if cur_freq=1396789 then freq_conv=1400000\n \t\t\t * Ex: if cur_freq=800030 then freq_conv=800000\n", "prefixes": [ "v2", "1/1" ] }