Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95919/?format=api
{ "id": 95919, "url": "http://patchwork.dpdk.org/api/patches/95919/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210715164126.54073-14-shirik@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210715164126.54073-14-shirik@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210715164126.54073-14-shirik@nvidia.com", "date": "2021-07-15T16:41:23", "name": "[v8,13/16] crypto/mlx5: add statistic get and reset operations", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "b942fda36ca5945322ace66a8d8c0924b98395dc", "submitter": { "id": 1894, "url": "http://patchwork.dpdk.org/api/people/1894/?format=api", "name": "Shiri Kuzin", "email": "shirik@nvidia.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210715164126.54073-14-shirik@nvidia.com/mbox/", "series": [ { "id": 17843, "url": "http://patchwork.dpdk.org/api/series/17843/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17843", "date": "2021-07-15T16:41:10", "name": "drivers: introduce mlx5 crypto PMD", "version": 8, "mbox": "http://patchwork.dpdk.org/series/17843/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/95919/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/95919/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A0F66A0C41;\n\tThu, 15 Jul 2021 18:43:37 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7411241342;\n\tThu, 15 Jul 2021 18:42:35 +0200 (CEST)", "from NAM02-BN1-obe.outbound.protection.outlook.com\n (mail-bn1nam07on2060.outbound.protection.outlook.com [40.107.212.60])\n by mails.dpdk.org (Postfix) with ESMTP id 7BF504132E\n for <dev@dpdk.org>; Thu, 15 Jul 2021 18:42:26 +0200 (CEST)", "from MW4PR04CA0333.namprd04.prod.outlook.com (2603:10b6:303:8a::8)\n by DM6PR12MB4794.namprd12.prod.outlook.com (2603:10b6:5:163::27) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.23; Thu, 15 Jul\n 2021 16:42:25 +0000", "from CO1NAM11FT037.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:8a:cafe::e6) by MW4PR04CA0333.outlook.office365.com\n (2603:10b6:303:8a::8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.24 via Frontend\n Transport; Thu, 15 Jul 2021 16:42:25 +0000", "from mail.nvidia.com (216.228.112.34) by\n CO1NAM11FT037.mail.protection.outlook.com (10.13.174.91) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4331.21 via Frontend Transport; Thu, 15 Jul 2021 16:42:24 +0000", "from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 15 Jul\n 2021 16:42:21 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Kmqupppju3S0vZHUUGNZvRs/z8TpmwubSoMI88lOhR7alVcJjoiGVuPQDlfKbsZ83vcEe8Lk41x24ar2NUH5OrqdRHfpUDecixQaPO4SyuiMf+skVk7uXcnvQ3gdI6vvKncAa8BlTHcG8+tIr2VfUE5dHw8qqICB03dspVOvoTxILAyf1/NBIBEylHnjhAIWhdLpnEBuzxYV3WCix2AnIwgQ2JTy07cqI5kAHboWWXJsRgpjWLPuv1qjCugxdckjdZPU+eJiRBq3ZRHCuCz/ewN2ShpyFJa1eei6ZIXA/PJ7w7gqqn6lazy0jDvulkmIaTVv9yphXMHNVGXnepwZVQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=6B4z6RaT1FojXWmhe4rY3B30tW43xUwN3dCZ8+rmvOY=;\n b=O4FKGyEgXo8qFfGP+OwbZJw4gj+n/d1dtPMorv2nKq336re61FA5lS3hT74ZzgG2+0aBrJuJpox9TAcAMEaDSZYNNvXF1vyY1wnVT+VlmhOkxQyoRpZFzRa3S3QVzL6906PYZDpyuSB6/whoatFPsmhMTo4oUBhu+pEGtbzuw0fr2gImxmeillwehW1nh3walRbQMcZp4yUBIwxy08/ACrZpFjwjAWsoub7arnZIxyQQCXkXFuiOywK0fDZIxEJw5XuFockpV2yasUi3naAtviW0C+nAugtNtHuovqtIhXnQoY9rns+bIxVYpM7hdgpCZnQkuBnpAKbh4U6GnpgfUQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=6B4z6RaT1FojXWmhe4rY3B30tW43xUwN3dCZ8+rmvOY=;\n b=J3MYdzZz72NZXRNUpwKW+QGtfzcFRb5ko2Nv7rlwXrnbgNcvB7Z4qctH1ZvZ16H4iyQxbJRUwH/VoBcFj+dyvoxUT0eq0K7oFYG7umoIOxCtReCEKmx7ZCcv5UATtxUb0cML2czjIfZEKmbf8Ypzfdt1TwGdIYcFaRfxM6gJpHWdLQRoN5OdUtrSEhgQ8AsQ1rqW2YeTPuy0Dl0lB12vrs2W9YLKLYRvydDRgS0LyGXTY6mV2b+AHiGlHSUXBAWjaZOdPGL/4JoIm6jgzA3i3imSHV3LCfaWDp1X547ljTeLx1IdgR6mfzJNLuJyv6DseS9XbYUPgJj49y8BDpzKhQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; redhat.com; dkim=none (message not signed)\n header.d=none;redhat.com; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Shiri Kuzin <shirik@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<matan@nvidia.com>, <gakhil@marvell.com>, <suanmingm@nvidia.com>,\n <david.marchand@redhat.com>", "Date": "Thu, 15 Jul 2021 19:41:23 +0300", "Message-ID": "<20210715164126.54073-14-shirik@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210715164126.54073-1-shirik@nvidia.com>", "References": "<20210715150817.51485-1-shirik@nvidia.com>\n <20210715164126.54073-1-shirik@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.6]", "X-ClientProxiedBy": "HQMAIL105.nvidia.com (172.20.187.12) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "b4b027a2-0586-4e3b-a4e5-08d947af8679", "X-MS-TrafficTypeDiagnostic": "DM6PR12MB4794:", "X-Microsoft-Antispam-PRVS": "\n <DM6PR12MB47945A9C9A7044A132464AF2AA129@DM6PR12MB4794.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:158;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n gjb0BfkydR3woqE/Q82Ad/Wf/i1N5kF01RFnaAzOqh7fThPUHWzNqeANI4SUATXlLUiYptTs7OiUewYVtww8sCO9T1/kFEKRZ2nx48eUi/v7YaCH2B0oZ3g3nL/Kj2eAnKNIoiqDJ0a0sUL4E+NT8t29wM/nwMxXMZq1QoYHvY5oGRc4qcHJBB7kNf9+8MoLEp/37/r/nIIgxM60foXSkOfTlDH6V5KQGXkbraaUQm2DwNwPG8XMDDCSs/YmyQGWIsntE/RWNdNfVjcuQH+L27nezN8y0Av59iy6Uv5PNWKUdGKW4FI66XP9IAGXryy6/8SQE46671EyUc/L2Jgai+egBC851cY52dE6Wkl0es6SXaCpoQv7umNeBQabJ/e2sJlXSi6tZlbCHJCfp5NtNngkpZVijNxvjf90/Ygzr2JRD2vuWGuH4b4565d9PlUcoApya7eTsoAD2CFbsPtTQZgjsSTwtlXyVrGKr6nw0FfypEhNFoFP3QLoE7lsfnjoO0lnzr8/4SOX6pZIJYy0LhpDO2q+OxlKVqv3AJ781PVbxFyce99o0dcUaoTQ+JFoeMP9Mz16gQDZrZcXuOfADB0eSJToGPI/14hgixYzhxsoqIRR74uS1BTFvC6NumFmrjgDN6EGP/fXFI8d8Yjqlj6cu4ocdWlAhMtgYWoTH0z1wVxy4acA2HxpRgJSP1t1MK0MN7fDaK77sgWWhFKLaeYUMbfTGNk2QChaavTsZlg=", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(39860400002)(376002)(396003)(346002)(136003)(46966006)(36840700001)(83380400001)(36860700001)(82740400003)(1076003)(70206006)(6916009)(6286002)(7696005)(5660300002)(426003)(8676002)(316002)(34020700004)(36906005)(36756003)(82310400003)(2906002)(478600001)(54906003)(47076005)(55016002)(86362001)(16526019)(26005)(8936002)(7636003)(186003)(336012)(2616005)(4326008)(70586007)(356005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "15 Jul 2021 16:42:24.9574 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n b4b027a2-0586-4e3b-a4e5-08d947af8679", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT037.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB4794", "Subject": "[dpdk-dev] [PATCH v8 13/16] crypto/mlx5: add statistic get and\n reset operations", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Suanming Mou <suanmingm@nvidia.com>\n\nThis commit adds mlx5 crypto statistic get and reset operations.\n\nSigned-off-by: Suanming Mou <suanmingm@nvidia.com>\nSigned-off-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/crypto/mlx5/mlx5_crypto.c | 40 ++++++++++++++++++++++++++++---\n 1 file changed, 37 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/crypto/mlx5/mlx5_crypto.c b/drivers/crypto/mlx5/mlx5_crypto.c\nindex b467739a3c..0ecca32cce 100644\n--- a/drivers/crypto/mlx5/mlx5_crypto.c\n+++ b/drivers/crypto/mlx5/mlx5_crypto.c\n@@ -508,13 +508,17 @@ mlx5_crypto_enqueue_burst(void *queue_pair, struct rte_crypto_op **ops,\n \t\top = *ops++;\n \t\tumr = RTE_PTR_ADD(qp->umem_buf, priv->wqe_set_size * qp->pi);\n \t\tif (unlikely(mlx5_crypto_wqe_set(priv, qp, op, umr) == 0)) {\n-\t\t\tif (remain != nb_ops)\n+\t\t\tqp->stats.enqueue_err_count++;\n+\t\t\tif (remain != nb_ops) {\n+\t\t\t\tqp->stats.enqueued_count -= remain;\n \t\t\t\tbreak;\n+\t\t\t}\n \t\t\treturn 0;\n \t\t}\n \t\tqp->ops[qp->pi] = op;\n \t\tqp->pi = (qp->pi + 1) & mask;\n \t} while (--remain);\n+\tqp->stats.enqueued_count += nb_ops;\n \trte_io_wmb();\n \tqp->db_rec[MLX5_SND_DBR] = rte_cpu_to_be_32(qp->db_pi);\n \trte_wmb();\n@@ -531,6 +535,7 @@ mlx5_crypto_cqe_err_handle(struct mlx5_crypto_qp *qp, struct rte_crypto_op *op)\n \t\t\t\t\t\t\t&qp->cq_obj.cqes[idx];\n \n \top->status = RTE_CRYPTO_OP_STATUS_ERROR;\n+\tqp->stats.dequeue_err_count++;\n \tDRV_LOG(ERR, \"CQE ERR:%x.\\n\", rte_be_to_cpu_32(cqe->syndrome));\n }\n \n@@ -570,6 +575,7 @@ mlx5_crypto_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops,\n \tif (likely(i != 0)) {\n \t\trte_io_wmb();\n \t\tqp->cq_obj.db_rec[0] = rte_cpu_to_be_32(qp->ci);\n+\t\tqp->stats.dequeued_count += i;\n \t}\n \treturn i;\n }\n@@ -731,14 +737,42 @@ mlx5_crypto_queue_pair_setup(struct rte_cryptodev *dev, uint16_t qp_id,\n \treturn -1;\n }\n \n+static void\n+mlx5_crypto_stats_get(struct rte_cryptodev *dev,\n+\t\t struct rte_cryptodev_stats *stats)\n+{\n+\tint qp_id;\n+\n+\tfor (qp_id = 0; qp_id < dev->data->nb_queue_pairs; qp_id++) {\n+\t\tstruct mlx5_crypto_qp *qp = dev->data->queue_pairs[qp_id];\n+\n+\t\tstats->enqueued_count += qp->stats.enqueued_count;\n+\t\tstats->dequeued_count += qp->stats.dequeued_count;\n+\t\tstats->enqueue_err_count += qp->stats.enqueue_err_count;\n+\t\tstats->dequeue_err_count += qp->stats.dequeue_err_count;\n+\t}\n+}\n+\n+static void\n+mlx5_crypto_stats_reset(struct rte_cryptodev *dev)\n+{\n+\tint qp_id;\n+\n+\tfor (qp_id = 0; qp_id < dev->data->nb_queue_pairs; qp_id++) {\n+\t\tstruct mlx5_crypto_qp *qp = dev->data->queue_pairs[qp_id];\n+\n+\t\tmemset(&qp->stats, 0, sizeof(qp->stats));\n+\t}\n+}\n+\n static struct rte_cryptodev_ops mlx5_crypto_ops = {\n \t.dev_configure\t\t\t= mlx5_crypto_dev_configure,\n \t.dev_start\t\t\t= mlx5_crypto_dev_start,\n \t.dev_stop\t\t\t= mlx5_crypto_dev_stop,\n \t.dev_close\t\t\t= mlx5_crypto_dev_close,\n \t.dev_infos_get\t\t\t= mlx5_crypto_dev_infos_get,\n-\t.stats_get\t\t\t= NULL,\n-\t.stats_reset\t\t\t= NULL,\n+\t.stats_get\t\t\t= mlx5_crypto_stats_get,\n+\t.stats_reset\t\t\t= mlx5_crypto_stats_reset,\n \t.queue_pair_setup\t\t= mlx5_crypto_queue_pair_setup,\n \t.queue_pair_release\t\t= mlx5_crypto_queue_pair_release,\n \t.sym_session_get_size\t\t= mlx5_crypto_sym_session_get_size,\n", "prefixes": [ "v8", "13/16" ] }