Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95965/?format=api
http://patchwork.dpdk.org/api/patches/95965/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210716083545.34444-8-heinrich.kuhn@netronome.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210716083545.34444-8-heinrich.kuhn@netronome.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210716083545.34444-8-heinrich.kuhn@netronome.com", "date": "2021-07-16T08:35:46", "name": "[v2,7/7] net/nfp: batch file rename for consistency", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "99408775894702ad53e5e5ee53e282ac6aa34d42", "submitter": { "id": 1523, "url": "http://patchwork.dpdk.org/api/people/1523/?format=api", "name": "Heinrich Kuhn", "email": "heinrich.kuhn@netronome.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210716083545.34444-8-heinrich.kuhn@netronome.com/mbox/", "series": [ { "id": 17856, "url": "http://patchwork.dpdk.org/api/series/17856/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17856", "date": "2021-07-16T08:35:38", "name": "Refactor the NFP PMD", "version": 2, "mbox": "http://patchwork.dpdk.org/series/17856/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/95965/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/95965/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D31FCA0C50;\n\tFri, 16 Jul 2021 10:37:48 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9027941372;\n\tFri, 16 Jul 2021 10:37:19 +0200 (CEST)", "from mail-ed1-f46.google.com (mail-ed1-f46.google.com\n [209.85.208.46]) by mails.dpdk.org (Postfix) with ESMTP id 320DB4136B\n for <dev@dpdk.org>; Fri, 16 Jul 2021 10:37:18 +0200 (CEST)", "by mail-ed1-f46.google.com with SMTP id ca14so11967207edb.2\n for <dev@dpdk.org>; Fri, 16 Jul 2021 01:37:18 -0700 (PDT)", "from localhost.localdomain ([155.93.216.150])\n by smtp.gmail.com with ESMTPSA id e6sm3371650edk.63.2021.07.16.01.37.16\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Fri, 16 Jul 2021 01:37:17 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=netronome-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=htJXQf5ubuO5+HmqeXlW9ABTIEOGfGGlHc/OXoSdGzU=;\n b=Os9pz63asBQoRbH9UkfdQ+6B/k3LR4sf4yn0OUSkV3Jz6ser/1zOM8D9572sVYnxqX\n 13YmQbjmwVj+dZ6Wq3WMi0d8MZnvyHN+tilr1R7T0LqstMX9itlEbUepcJIOrUvWRWVk\n nqmZOq10WNKCq6GlpNUqMrTSVADhnpSAqa3T/Dy6w26jpItuTIgZEuM77DeeI+1jLmHR\n dsNyldKSCt3oZCRsayFXgMwgwfa/8WxMejeb5jwFmRG7UIvT2OxsrZ06kvGjn8wXulle\n 2gmdA8iuQ8Wbvflxu7oKt80yL9usHBE0lcRP5dT6H5yzVtmrBXmTmxn3iK86uFgUbM/i\n dCFw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=htJXQf5ubuO5+HmqeXlW9ABTIEOGfGGlHc/OXoSdGzU=;\n b=baMQ7wNql45ShtoJAX0cj8d0WojfT2/SgBUErPwCbT5u/NMDDIOy5D0EpFHjz8maoS\n 1wuMsN1JCQ6J9WDTo0I4iFl1gj3ApLrirNv009vqSvXOMMQhyrwR/9oz5Tq4qy3+KLbB\n EoLD4fSUoFyfv6sUrF86SgKrmr40SBRLmNC3WGcevsNSPW1nTM4W3RlxxlRbC2lDAlBo\n 1GbPCTF68x6R0jf2K1xjfMa4832G/yazzuHHpP6e+RhGWMXusps0273BWXBWvibg1UU1\n k28YbMXd6Jwhti+L3u6oZj5am2Af6qPhqwJI5OdiGRQ1Z0PkP6p4xjMR5Me89zjXRQhc\n 1T8Q==", "X-Gm-Message-State": "AOAM533KtEumhoQWrXvpLtg68z4a5I6GYeKQFUFjQRYXy57r7XZ9MDmS\n KIt4fJAOS/T5MGVuTaF3mlXoZLl1zekZdykrI1ZMxQRKPGw29UpSaZMg41+HBH3IKnOtB4E4ij3\n cZEPMYGuDk+blWGiCrrIV+tAVM3/GoN6UvGLw9sAVw4UYul2FIgti9/eNgdLtH/TT", "X-Google-Smtp-Source": "\n ABdhPJxzxQl35e/5sQNnS0MFuMw8jTdTPhhLcfLUVAHyx3SfuzDUWIZX3k9NoZzYTFtz1Mv2rhXc0w==", "X-Received": "by 2002:aa7:ca54:: with SMTP id\n j20mr13124864edt.137.1626424637787;\n Fri, 16 Jul 2021 01:37:17 -0700 (PDT)", "From": "Heinrich Kuhn <heinrich.kuhn@netronome.com>", "To": "dev@dpdk.org", "Cc": "Heinrich Kuhn <heinrich.kuhn@netronome.com>,\n Simon Horman <simon.horman@corigine.com>", "Date": "Fri, 16 Jul 2021 10:35:46 +0200", "Message-Id": "<20210716083545.34444-8-heinrich.kuhn@netronome.com>", "X-Mailer": "git-send-email 2.30.1 (Apple Git-130)", "In-Reply-To": "<20210716083545.34444-1-heinrich.kuhn@netronome.com>", "References": "<20210716082314.33865-1-heinrich.kuhn@netronome.com>\n <20210716083545.34444-1-heinrich.kuhn@netronome.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 7/7] net/nfp: batch file rename for consistency", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Rename the nfp_net.c file to nfp_common as it now contains functions\ncommon to VF and PF functionality. Rename the header file too to be\nconsistent. Also remove the \"net\" naming from the _ctrl and _logs files\nfor consistency across the PMD.\n\nSigned-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>\nSigned-off-by: Simon Horman <simon.horman@corigine.com>\n---\n drivers/net/nfp/meson.build | 2 +-\n drivers/net/nfp/{nfp_net.c => nfp_common.c} | 4 ++--\n drivers/net/nfp/{nfp_net_pmd.h => nfp_common.h} | 6 +++---\n drivers/net/nfp/nfp_cpp_bridge.c | 2 +-\n drivers/net/nfp/{nfp_net_ctrl.h => nfp_ctrl.h} | 6 +++---\n drivers/net/nfp/nfp_ethdev.c | 6 +++---\n drivers/net/nfp/nfp_ethdev_vf.c | 6 +++---\n drivers/net/nfp/{nfp_net_logs.h => nfp_logs.h} | 6 +++---\n drivers/net/nfp/nfp_rxtx.c | 6 +++---\n 9 files changed, 22 insertions(+), 22 deletions(-)\n rename drivers/net/nfp/{nfp_net.c => nfp_common.c} (99%)\n rename drivers/net/nfp/{nfp_net_pmd.h => nfp_common.h} (99%)\n rename drivers/net/nfp/{nfp_net_ctrl.h => nfp_ctrl.h} (99%)\n rename drivers/net/nfp/{nfp_net_logs.h => nfp_logs.h} (94%)", "diff": "diff --git a/drivers/net/nfp/meson.build b/drivers/net/nfp/meson.build\nindex ab64d0cac3..810f02ae5b 100644\n--- a/drivers/net/nfp/meson.build\n+++ b/drivers/net/nfp/meson.build\n@@ -18,7 +18,7 @@ sources = files(\n 'nfpcore/nfp_mutex.c',\n 'nfpcore/nfp_nsp_eth.c',\n 'nfpcore/nfp_hwinfo.c',\n- 'nfp_net.c',\n+ 'nfp_common.c',\n 'nfp_rxtx.c',\n 'nfp_cpp_bridge.c',\n 'nfp_ethdev_vf.c',\ndiff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_common.c\nsimilarity index 99%\nrename from drivers/net/nfp/nfp_net.c\nrename to drivers/net/nfp/nfp_common.c\nindex a6097eaab0..87e8f5f333 100644\n--- a/drivers/net/nfp/nfp_net.c\n+++ b/drivers/net/nfp/nfp_common.c\n@@ -8,9 +8,9 @@\n /*\n * vim:shiftwidth=8:noexpandtab\n *\n- * @file dpdk/pmd/nfp_net.c\n+ * @file dpdk/pmd/nfp_common.c\n *\n- * Netronome vNIC DPDK Poll-Mode Driver: Main entry point\n+ * Netronome vNIC DPDK Poll-Mode Driver: Common files\n */\n \n #include <rte_byteorder.h>\ndiff --git a/drivers/net/nfp/nfp_net_pmd.h b/drivers/net/nfp/nfp_common.h\nsimilarity index 99%\nrename from drivers/net/nfp/nfp_net_pmd.h\nrename to drivers/net/nfp/nfp_common.h\nindex dc05e888df..54ac937bd2 100644\n--- a/drivers/net/nfp/nfp_net_pmd.h\n+++ b/drivers/net/nfp/nfp_common.h\n@@ -11,8 +11,8 @@\n * Netronome NFP_NET PMD driver\n */\n \n-#ifndef _NFP_NET_PMD_H_\n-#define _NFP_NET_PMD_H_\n+#ifndef _NFP_COMMON_H_\n+#define _NFP_COMMON_H_\n \n #define NFP_NET_PMD_VERSION \"0.1\"\n #define PCI_VENDOR_ID_NETRONOME 0x19ee\n@@ -404,7 +404,7 @@ int nfp_net_rss_config_default(struct rte_eth_dev *dev);\n #define NFP_NET_DEV_PRIVATE_TO_PF(dev_priv)\\\n \t(((struct nfp_net_hw *)dev_priv)->pf_dev)\n \n-#endif /* _NFP_NET_PMD_H_ */\n+#endif /* _NFP_COMMON_H_ */\n /*\n * Local variables:\n * c-file-style: \"Linux\"\ndiff --git a/drivers/net/nfp/nfp_cpp_bridge.c b/drivers/net/nfp/nfp_cpp_bridge.c\nindex d916793338..74a0eacb3f 100644\n--- a/drivers/net/nfp/nfp_cpp_bridge.c\n+++ b/drivers/net/nfp/nfp_cpp_bridge.c\n@@ -19,7 +19,7 @@\n #include \"nfpcore/nfp_mip.h\"\n #include \"nfpcore/nfp_nsp.h\"\n \n-#include \"nfp_net_logs.h\"\n+#include \"nfp_logs.h\"\n #include \"nfp_cpp_bridge.h\"\n \n #include <sys/ioctl.h>\ndiff --git a/drivers/net/nfp/nfp_net_ctrl.h b/drivers/net/nfp/nfp_ctrl.h\nsimilarity index 99%\nrename from drivers/net/nfp/nfp_net_ctrl.h\nrename to drivers/net/nfp/nfp_ctrl.h\nindex 4f26ccf483..4dd62ef194 100644\n--- a/drivers/net/nfp/nfp_net_ctrl.h\n+++ b/drivers/net/nfp/nfp_ctrl.h\n@@ -8,8 +8,8 @@\n *\n * Netronome network device driver: Control BAR layout\n */\n-#ifndef _NFP_NET_CTRL_H_\n-#define _NFP_NET_CTRL_H_\n+#ifndef _NFP_CTRL_H_\n+#define _NFP_CTRL_H_\n \n /*\n * Configuration BAR size.\n@@ -317,7 +317,7 @@\n /* PF multiport offset */\n #define NFP_PF_CSR_SLICE_SIZE\t(32 * 1024)\n \n-#endif /* _NFP_NET_CTRL_H_ */\n+#endif /* _NFP_CTRL_H_ */\n /*\n * Local variables:\n * c-file-style: \"Linux\"\ndiff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c\nindex ab08906704..29e6bb128a 100644\n--- a/drivers/net/nfp/nfp_ethdev.c\n+++ b/drivers/net/nfp/nfp_ethdev.c\n@@ -30,10 +30,10 @@\n #include \"nfpcore/nfp_rtsym.h\"\n #include \"nfpcore/nfp_nsp.h\"\n \n-#include \"nfp_net_pmd.h\"\n+#include \"nfp_common.h\"\n #include \"nfp_rxtx.h\"\n-#include \"nfp_net_logs.h\"\n-#include \"nfp_net_ctrl.h\"\n+#include \"nfp_logs.h\"\n+#include \"nfp_ctrl.h\"\n #include \"nfp_cpp_bridge.h\"\n \n \ndiff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c\nindex 223142c0ed..b697b55865 100644\n--- a/drivers/net/nfp/nfp_ethdev_vf.c\n+++ b/drivers/net/nfp/nfp_ethdev_vf.c\n@@ -16,10 +16,10 @@\n #include \"nfpcore/nfp_mip.h\"\n #include \"nfpcore/nfp_rtsym.h\"\n \n-#include \"nfp_net_pmd.h\"\n+#include \"nfp_common.h\"\n #include \"nfp_rxtx.h\"\n-#include \"nfp_net_logs.h\"\n-#include \"nfp_net_ctrl.h\"\n+#include \"nfp_logs.h\"\n+#include \"nfp_ctrl.h\"\n \n static void nfp_netvf_read_mac(struct nfp_net_hw *hw);\n static int nfp_netvf_start(struct rte_eth_dev *dev);\ndiff --git a/drivers/net/nfp/nfp_net_logs.h b/drivers/net/nfp/nfp_logs.h\nsimilarity index 94%\nrename from drivers/net/nfp/nfp_net_logs.h\nrename to drivers/net/nfp/nfp_logs.h\nindex 27dd87611b..bd5a5e1ec5 100644\n--- a/drivers/net/nfp/nfp_net_logs.h\n+++ b/drivers/net/nfp/nfp_logs.h\n@@ -3,8 +3,8 @@\n * All rights reserved.\n */\n \n-#ifndef _NFP_NET_LOGS_H_\n-#define _NFP_NET_LOGS_H_\n+#ifndef _NFP_LOGS_H_\n+#define _NFP_LOGS_H_\n \n #include <rte_log.h>\n \n@@ -44,4 +44,4 @@ extern int nfp_logtype_driver;\n \trte_log(RTE_LOG_ ## level, nfp_logtype_driver, \\\n \t\t\"%s(): \" fmt \"\\n\", __func__, ## args)\n \n-#endif /* _NFP_NET_LOGS_H_ */\n+#endif /* _NFP_LOGS_H_ */\ndiff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c\nindex 9ee9e5c9a3..1402c5f84a 100644\n--- a/drivers/net/nfp/nfp_rxtx.c\n+++ b/drivers/net/nfp/nfp_rxtx.c\n@@ -16,10 +16,10 @@\n #include <ethdev_driver.h>\n #include <ethdev_pci.h>\n \n-#include \"nfp_net_pmd.h\"\n+#include \"nfp_common.h\"\n #include \"nfp_rxtx.h\"\n-#include \"nfp_net_logs.h\"\n-#include \"nfp_net_ctrl.h\"\n+#include \"nfp_logs.h\"\n+#include \"nfp_ctrl.h\"\n \n /* Prototypes */\n static int nfp_net_rx_fill_freelist(struct nfp_net_rxq *rxq);\n", "prefixes": [ "v2", "7/7" ] }{ "id": 95965, "url": "