Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/95983/?format=api
{ "id": 95983, "url": "http://patchwork.dpdk.org/api/patches/95983/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1626465089-17052-2-git-send-email-jiayu.hu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1626465089-17052-2-git-send-email-jiayu.hu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1626465089-17052-2-git-send-email-jiayu.hu@intel.com", "date": "2021-07-16T19:51:27", "name": "[v5,1/3] vhost: fix lock on device readiness notification", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1b53d7198327b9d592b4eded6f55886da680e2b1", "submitter": { "id": 539, "url": "http://patchwork.dpdk.org/api/people/539/?format=api", "name": "Hu, Jiayu", "email": "jiayu.hu@intel.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1626465089-17052-2-git-send-email-jiayu.hu@intel.com/mbox/", "series": [ { "id": 17867, "url": "http://patchwork.dpdk.org/api/series/17867/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17867", "date": "2021-07-16T19:51:26", "name": "provide thread unsafe async registration functions", "version": 5, "mbox": "http://patchwork.dpdk.org/series/17867/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/95983/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/95983/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 22DEBA0C50;\n\tFri, 16 Jul 2021 15:24:12 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8465741375;\n\tFri, 16 Jul 2021 15:24:10 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 9662E40151;\n Fri, 16 Jul 2021 15:24:06 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Jul 2021 06:24:06 -0700", "from npg_dpdk_virtio_jiayuhu_07.sh.intel.com ([10.67.119.25])\n by FMSMGA003.fm.intel.com with ESMTP; 16 Jul 2021 06:24:04 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10046\"; a=\"210718529\"", "E=Sophos;i=\"5.84,245,1620716400\"; d=\"scan'208\";a=\"210718529\"", "E=Sophos;i=\"5.84,245,1620716400\"; d=\"scan'208\";a=\"496728415\"" ], "X-ExtLoop1": "1", "From": "Jiayu Hu <jiayu.hu@intel.com>", "To": "dev@dpdk.org", "Cc": "maxime.coquelin@redhat.com, chenbo.xia@intel.com,\n Jiayu Hu <jiayu.hu@intel.com>, stable@dpdk.org", "Date": "Fri, 16 Jul 2021 15:51:27 -0400", "Message-Id": "<1626465089-17052-2-git-send-email-jiayu.hu@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1626465089-17052-1-git-send-email-jiayu.hu@intel.com>", "References": "<1626162383-89674-2-git-send-email-jiayu.hu@intel.com>\n <1626465089-17052-1-git-send-email-jiayu.hu@intel.com>", "Subject": "[dpdk-dev] [PATCH v5 1/3] vhost: fix lock on device readiness\n notification", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The vhost notifies the application of device readiness via\nvhost_user_notify_queue_state(), but calling this function\nis not protected by the lock. This patch is to make this\nfunction call lock protected.\n\nFixes: d0fcc38f5fa4 (\"vhost: improve device readiness notifications\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jiayu Hu <jiayu.hu@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/vhost_user.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c\nindex 031c578..31300e1 100644\n--- a/lib/vhost/vhost_user.c\n+++ b/lib/vhost/vhost_user.c\n@@ -2995,9 +2995,6 @@ vhost_user_msg_handler(int vid, int fd)\n \t\t}\n \t}\n \n-\tif (unlock_required)\n-\t\tvhost_user_unlock_all_queue_pairs(dev);\n-\n \t/* If message was not handled at this stage, treat it as an error */\n \tif (!handled) {\n \t\tVHOST_LOG_CONFIG(ERR,\n@@ -3032,6 +3029,8 @@ vhost_user_msg_handler(int vid, int fd)\n \t\t}\n \t}\n \n+\tif (unlock_required)\n+\t\tvhost_user_unlock_all_queue_pairs(dev);\n \n \tif (!virtio_is_ready(dev))\n \t\tgoto out;\n", "prefixes": [ "v5", "1/3" ] }