Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96125/?format=api
{ "id": 96125, "url": "http://patchwork.dpdk.org/api/patches/96125/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210721041505.10795-3-ivan.malov@oktetlabs.ru/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210721041505.10795-3-ivan.malov@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210721041505.10795-3-ivan.malov@oktetlabs.ru", "date": "2021-07-21T04:15:05", "name": "[v3,2/2] net/sfc: improve logging in MAE backend of RTE flow support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "39e98a28f7677e690c5505fddf9c49321fcf3e01", "submitter": { "id": 869, "url": "http://patchwork.dpdk.org/api/people/869/?format=api", "name": "Ivan Malov", "email": "Ivan.Malov@oktetlabs.ru" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210721041505.10795-3-ivan.malov@oktetlabs.ru/mbox/", "series": [ { "id": 17922, "url": "http://patchwork.dpdk.org/api/series/17922/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17922", "date": "2021-07-21T04:15:03", "name": "RTE flow support logging improvements", "version": 3, "mbox": "http://patchwork.dpdk.org/series/17922/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96125/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/96125/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 80301A0C47;\n\tWed, 21 Jul 2021 06:15:37 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 41D94410F1;\n\tWed, 21 Jul 2021 06:15:28 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 7FC8540F35\n for <dev@dpdk.org>; Wed, 21 Jul 2021 06:15:24 +0200 (CEST)", "from localhost.localdomain (unknown [5.144.120.226])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 2BD857F53F;\n Wed, 21 Jul 2021 07:15:23 +0300 (MSK)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 2BD857F53F", "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;\n s=default; t=1626840923;\n bh=LxZmtiAxPARgGDAyny29AjOTG4ghCwfdMakK6ylNwpQ=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=PRso3QAfuoKxx/EQ/PSGRahcpO4/ggv+U7f5r8gx/RtMzJLfxo2na4mG3jo0lB8Sv\n OJVZGgQ+sbP3SoTS7kK5MVf1fXgS5IsewyrPfUUqYjqd7FjvGtrJSVq1KNxQExuyAW\n N2vB5fjZzXk3fLkiQyjRI9XbwDOkQNDwb7YcS+f4=", "From": "Ivan Malov <ivan.malov@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "David Marchand <david.marchand@redhat.com>,\n Thomas Monjalon <thomas@monjalon.net>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>", "Date": "Wed, 21 Jul 2021 07:15:05 +0300", "Message-Id": "<20210721041505.10795-3-ivan.malov@oktetlabs.ru>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210721041505.10795-1-ivan.malov@oktetlabs.ru>", "References": "<20210707105628.16705-1-ivan.malov@oktetlabs.ru>\n <20210721041505.10795-1-ivan.malov@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 2/2] net/sfc: improve logging in MAE backend\n of RTE flow support", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Errors detected during parsing of pattern items and actions\nare reflected by setting RTE error, but the name of the bad\nelement is not disclosed, thus leaving the user to join the\ndots themselves. Adjust the code to log missing information.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nReviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc_flow.c | 22 ++++++++++++++++++---\n drivers/net/sfc/sfc_flow.h | 8 +++++---\n drivers/net/sfc/sfc_mae.c | 39 +++++++++++++++++++++++++++++++++++++-\n 3 files changed, 62 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c\nindex 0bfd284c9e..20b9e48ba1 100644\n--- a/drivers/net/sfc/sfc_flow.c\n+++ b/drivers/net/sfc/sfc_flow.c\n@@ -1124,6 +1124,7 @@ sfc_flow_parse_pppoex(const struct rte_flow_item *item,\n static const struct sfc_flow_item sfc_flow_items[] = {\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_VOID,\n+\t\t.name = \"VOID\",\n \t\t.prev_layer = SFC_FLOW_ITEM_ANY_LAYER,\n \t\t.layer = SFC_FLOW_ITEM_ANY_LAYER,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_FILTER,\n@@ -1131,6 +1132,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_ETH,\n+\t\t.name = \"ETH\",\n \t\t.prev_layer = SFC_FLOW_ITEM_START_LAYER,\n \t\t.layer = SFC_FLOW_ITEM_L2,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_FILTER,\n@@ -1138,6 +1140,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_VLAN,\n+\t\t.name = \"VLAN\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L2,\n \t\t.layer = SFC_FLOW_ITEM_L2,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_FILTER,\n@@ -1145,6 +1148,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_PPPOED,\n+\t\t.name = \"PPPOED\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L2,\n \t\t.layer = SFC_FLOW_ITEM_L2,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_FILTER,\n@@ -1152,6 +1156,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_PPPOES,\n+\t\t.name = \"PPPOES\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L2,\n \t\t.layer = SFC_FLOW_ITEM_L2,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_FILTER,\n@@ -1159,6 +1164,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_IPV4,\n+\t\t.name = \"IPV4\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L2,\n \t\t.layer = SFC_FLOW_ITEM_L3,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_FILTER,\n@@ -1166,6 +1172,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_IPV6,\n+\t\t.name = \"IPV6\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L2,\n \t\t.layer = SFC_FLOW_ITEM_L3,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_FILTER,\n@@ -1173,6 +1180,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_TCP,\n+\t\t.name = \"TCP\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L3,\n \t\t.layer = SFC_FLOW_ITEM_L4,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_FILTER,\n@@ -1180,6 +1188,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_UDP,\n+\t\t.name = \"UDP\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L3,\n \t\t.layer = SFC_FLOW_ITEM_L4,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_FILTER,\n@@ -1187,6 +1196,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_VXLAN,\n+\t\t.name = \"VXLAN\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L4,\n \t\t.layer = SFC_FLOW_ITEM_START_LAYER,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_FILTER,\n@@ -1194,6 +1204,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_GENEVE,\n+\t\t.name = \"GENEVE\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L4,\n \t\t.layer = SFC_FLOW_ITEM_START_LAYER,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_FILTER,\n@@ -1201,6 +1212,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_NVGRE,\n+\t\t.name = \"NVGRE\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L3,\n \t\t.layer = SFC_FLOW_ITEM_START_LAYER,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_FILTER,\n@@ -1296,7 +1308,8 @@ sfc_flow_get_item(const struct sfc_flow_item *items,\n }\n \n int\n-sfc_flow_parse_pattern(const struct sfc_flow_item *flow_items,\n+sfc_flow_parse_pattern(struct sfc_adapter *sa,\n+\t\t const struct sfc_flow_item *flow_items,\n \t\t unsigned int nb_flow_items,\n \t\t const struct rte_flow_item pattern[],\n \t\t struct sfc_flow_parse_ctx *parse_ctx,\n@@ -1380,8 +1393,11 @@ sfc_flow_parse_pattern(const struct sfc_flow_item *flow_items,\n \t\t}\n \n \t\trc = item->parse(pattern, parse_ctx, error);\n-\t\tif (rc != 0)\n+\t\tif (rc != 0) {\n+\t\t\tsfc_err(sa, \"failed to parse item %s: %s\",\n+\t\t\t\titem->name, strerror(-rc));\n \t\t\treturn rc;\n+\t\t}\n \n \t\tif (item->layer != SFC_FLOW_ITEM_ANY_LAYER)\n \t\t\tprev_layer = item->layer;\n@@ -2477,7 +2493,7 @@ sfc_flow_parse_rte_to_filter(struct rte_eth_dev *dev,\n \tctx.type = SFC_FLOW_PARSE_CTX_FILTER;\n \tctx.filter = &spec_filter->template;\n \n-\trc = sfc_flow_parse_pattern(sfc_flow_items, RTE_DIM(sfc_flow_items),\n+\trc = sfc_flow_parse_pattern(sa, sfc_flow_items, RTE_DIM(sfc_flow_items),\n \t\t\t\t pattern, &ctx, error);\n \tif (rc != 0)\n \t\tgoto fail_bad_value;\ndiff --git a/drivers/net/sfc/sfc_flow.h b/drivers/net/sfc/sfc_flow.h\nindex bd3b374d68..ab1097ddff 100644\n--- a/drivers/net/sfc/sfc_flow.h\n+++ b/drivers/net/sfc/sfc_flow.h\n@@ -136,13 +136,17 @@ typedef int (sfc_flow_item_parse)(const struct rte_flow_item *item,\n \n struct sfc_flow_item {\n \tenum rte_flow_item_type type;\t\t/* Type of item */\n+\tconst char *name;\t\t\t/* Item name */\n \tenum sfc_flow_item_layers layer;\t/* Layer of item */\n \tenum sfc_flow_item_layers prev_layer;\t/* Previous layer of item */\n \tenum sfc_flow_parse_ctx_type ctx_type;\t/* Parse context type */\n \tsfc_flow_item_parse *parse;\t\t/* Parsing function */\n };\n \n-int sfc_flow_parse_pattern(const struct sfc_flow_item *flow_items,\n+struct sfc_adapter;\n+\n+int sfc_flow_parse_pattern(struct sfc_adapter *sa,\n+\t\t\t const struct sfc_flow_item *flow_items,\n \t\t\t unsigned int nb_flow_items,\n \t\t\t const struct rte_flow_item pattern[],\n \t\t\t struct sfc_flow_parse_ctx *parse_ctx,\n@@ -156,8 +160,6 @@ int sfc_flow_parse_init(const struct rte_flow_item *item,\n \t\t\tunsigned int size,\n \t\t\tstruct rte_flow_error *error);\n \n-struct sfc_adapter;\n-\n void sfc_flow_init(struct sfc_adapter *sa);\n void sfc_flow_fini(struct sfc_adapter *sa);\n int sfc_flow_start(struct sfc_adapter *sa);\ndiff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c\nindex 14fc6fe5be..e6ad6085a6 100644\n--- a/drivers/net/sfc/sfc_mae.c\n+++ b/drivers/net/sfc/sfc_mae.c\n@@ -1829,6 +1829,7 @@ sfc_mae_rule_parse_item_tunnel(const struct rte_flow_item *item,\n static const struct sfc_flow_item sfc_flow_items[] = {\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_PORT_ID,\n+\t\t.name = \"PORT_ID\",\n \t\t/*\n \t\t * In terms of RTE flow, this item is a META one,\n \t\t * and its position in the pattern is don't care.\n@@ -1840,6 +1841,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_PHY_PORT,\n+\t\t.name = \"PHY_PORT\",\n \t\t/*\n \t\t * In terms of RTE flow, this item is a META one,\n \t\t * and its position in the pattern is don't care.\n@@ -1851,6 +1853,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_PF,\n+\t\t.name = \"PF\",\n \t\t/*\n \t\t * In terms of RTE flow, this item is a META one,\n \t\t * and its position in the pattern is don't care.\n@@ -1862,6 +1865,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_VF,\n+\t\t.name = \"VF\",\n \t\t/*\n \t\t * In terms of RTE flow, this item is a META one,\n \t\t * and its position in the pattern is don't care.\n@@ -1873,6 +1877,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_ETH,\n+\t\t.name = \"ETH\",\n \t\t.prev_layer = SFC_FLOW_ITEM_START_LAYER,\n \t\t.layer = SFC_FLOW_ITEM_L2,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_MAE,\n@@ -1880,6 +1885,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_VLAN,\n+\t\t.name = \"VLAN\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L2,\n \t\t.layer = SFC_FLOW_ITEM_L2,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_MAE,\n@@ -1887,6 +1893,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_IPV4,\n+\t\t.name = \"IPV4\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L2,\n \t\t.layer = SFC_FLOW_ITEM_L3,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_MAE,\n@@ -1894,6 +1901,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_IPV6,\n+\t\t.name = \"IPV6\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L2,\n \t\t.layer = SFC_FLOW_ITEM_L3,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_MAE,\n@@ -1901,6 +1909,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_TCP,\n+\t\t.name = \"TCP\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L3,\n \t\t.layer = SFC_FLOW_ITEM_L4,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_MAE,\n@@ -1908,6 +1917,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_UDP,\n+\t\t.name = \"UDP\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L3,\n \t\t.layer = SFC_FLOW_ITEM_L4,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_MAE,\n@@ -1915,6 +1925,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_VXLAN,\n+\t\t.name = \"VXLAN\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L4,\n \t\t.layer = SFC_FLOW_ITEM_START_LAYER,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_MAE,\n@@ -1922,6 +1933,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_GENEVE,\n+\t\t.name = \"GENEVE\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L4,\n \t\t.layer = SFC_FLOW_ITEM_START_LAYER,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_MAE,\n@@ -1929,6 +1941,7 @@ static const struct sfc_flow_item sfc_flow_items[] = {\n \t},\n \t{\n \t\t.type = RTE_FLOW_ITEM_TYPE_NVGRE,\n+\t\t.name = \"NVGRE\",\n \t\t.prev_layer = SFC_FLOW_ITEM_L3,\n \t\t.layer = SFC_FLOW_ITEM_START_LAYER,\n \t\t.ctx_type = SFC_FLOW_PARSE_CTX_MAE,\n@@ -2137,7 +2150,7 @@ sfc_mae_rule_parse_pattern(struct sfc_adapter *sa,\n \tif (rc != 0)\n \t\tgoto fail_encap_parse_init;\n \n-\trc = sfc_flow_parse_pattern(sfc_flow_items, RTE_DIM(sfc_flow_items),\n+\trc = sfc_flow_parse_pattern(sa, sfc_flow_items, RTE_DIM(sfc_flow_items),\n \t\t\t\t pattern, &ctx, error);\n \tif (rc != 0)\n \t\tgoto fail_parse_pattern;\n@@ -2728,6 +2741,22 @@ sfc_mae_rule_parse_action_port_id(struct sfc_adapter *sa,\n \treturn rc;\n }\n \n+static const char * const action_names[] = {\n+\t[RTE_FLOW_ACTION_TYPE_VXLAN_DECAP] = \"VXLAN_DECAP\",\n+\t[RTE_FLOW_ACTION_TYPE_OF_POP_VLAN] = \"OF_POP_VLAN\",\n+\t[RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN] = \"OF_PUSH_VLAN\",\n+\t[RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID] = \"OF_SET_VLAN_VID\",\n+\t[RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP] = \"OF_SET_VLAN_PCP\",\n+\t[RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP] = \"VXLAN_ENCAP\",\n+\t[RTE_FLOW_ACTION_TYPE_FLAG] = \"FLAG\",\n+\t[RTE_FLOW_ACTION_TYPE_MARK] = \"MARK\",\n+\t[RTE_FLOW_ACTION_TYPE_PHY_PORT] = \"PHY_PORT\",\n+\t[RTE_FLOW_ACTION_TYPE_PF] = \"PF\",\n+\t[RTE_FLOW_ACTION_TYPE_VF] = \"VF\",\n+\t[RTE_FLOW_ACTION_TYPE_PORT_ID] = \"PORT_ID\",\n+\t[RTE_FLOW_ACTION_TYPE_DROP] = \"DROP\",\n+};\n+\n static int\n sfc_mae_rule_parse_action(struct sfc_adapter *sa,\n \t\t\t const struct rte_flow_action *action,\n@@ -2821,6 +2850,14 @@ sfc_mae_rule_parse_action(struct sfc_adapter *sa,\n \tif (rc == 0) {\n \t\tbundle->actions_mask |= (1ULL << action->type);\n \t} else if (!custom_error) {\n+\t\tif (action->type < RTE_DIM(action_names)) {\n+\t\t\tconst char *action_name = action_names[action->type];\n+\n+\t\t\tif (action_name != NULL) {\n+\t\t\t\tsfc_err(sa, \"action %s was rejected: %s\",\n+\t\t\t\t\taction_name, strerror(rc));\n+\t\t\t}\n+\t\t}\n \t\trc = rte_flow_error_set(error, rc, RTE_FLOW_ERROR_TYPE_ACTION,\n \t\t\t\tNULL, \"Failed to request the action\");\n \t}\n", "prefixes": [ "v3", "2/2" ] }