Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96145/?format=api
{ "id": 96145, "url": "http://patchwork.dpdk.org/api/patches/96145/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210721085421.13111-8-bingz@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210721085421.13111-8-bingz@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210721085421.13111-8-bingz@nvidia.com", "date": "2021-07-21T08:54:21", "name": "[v3,7/7] net/mlx5: add meter support for trTCM profiles", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "029e304f4e31da3288ba309555b15c261f6ffe4f", "submitter": { "id": 1976, "url": "http://patchwork.dpdk.org/api/people/1976/?format=api", "name": "Bing Zhao", "email": "bingz@nvidia.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210721085421.13111-8-bingz@nvidia.com/mbox/", "series": [ { "id": 17928, "url": "http://patchwork.dpdk.org/api/series/17928/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17928", "date": "2021-07-21T08:54:14", "name": "support yellow color policy in mlx5", "version": 3, "mbox": "http://patchwork.dpdk.org/series/17928/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96145/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/96145/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8E83EA0C50;\n\tWed, 21 Jul 2021 10:55:33 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DF54D410DA;\n\tWed, 21 Jul 2021 10:55:00 +0200 (CEST)", "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2077.outbound.protection.outlook.com [40.107.243.77])\n by mails.dpdk.org (Postfix) with ESMTP id 3F04B4113A\n for <dev@dpdk.org>; Wed, 21 Jul 2021 10:54:57 +0200 (CEST)", "from MWHPR04CA0029.namprd04.prod.outlook.com (2603:10b6:300:ee::15)\n by CY4PR12MB1623.namprd12.prod.outlook.com (2603:10b6:910:6::16) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.26; Wed, 21 Jul\n 2021 08:54:55 +0000", "from CO1NAM11FT016.eop-nam11.prod.protection.outlook.com\n (2603:10b6:300:ee:cafe::22) by MWHPR04CA0029.outlook.office365.com\n (2603:10b6:300:ee::15) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.24 via Frontend\n Transport; Wed, 21 Jul 2021 08:54:55 +0000", "from mail.nvidia.com (216.228.112.34) by\n CO1NAM11FT016.mail.protection.outlook.com (10.13.175.141) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4352.24 via Frontend Transport; Wed, 21 Jul 2021 08:54:54 +0000", "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 21 Jul\n 2021 08:54:52 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=PKYsj/jU+EUrQ/rmnStKkapn3CES4+ZsJWsU442UZg70Bk+5lCumjDAhOkHuEmRjDKYd3Lv5hevew/ZAVsjXHGuI3KUsaPOpDw13sRpab/ufq/mWz6lnkkEJXz4jAfWIvmCuuMqXDyZZcDgYEGPGo4yxcOQAP4oPZ5Rsm8C5jauKAp3hFnXs7UBDH0RgEwzFyVWfgYr1mJ1b6ymPu4acVxoc1it6OOjPaeFxRqJaMFsShpCk+iimdlmLJ9K2vuEjG0o33fftgCjhLrcfIzrjOoFkSVa3Qypvj2BSEhuSnp2GKc1tYRp3FhTKljtxtogUC4d7z2jfV8AzXUZ6t7GhSg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=gPT/D4OUyafIFfbnM8678HTNoT1Fuyc5Di7P+uxxdPc=;\n b=j92wL6Qm8tbdrxOw559l8DIRoWz5pUsyRNqRqIG5cHCMFUGETM1NPXaUzbL6xcNjxx1lHRX1RUNOdcOJ2Uz8IbSRpj/PdIUoT8TtqVtjfJe8PNUWPSMIopMdQwc5y2r1pUMY6wM+HDKqRuegX4xEyse0+Wj8aECFoBJ38E16lpxm6T80rzHGMa6DpUm2sgRyRGKyNyQHburE7hwhAR6Jnp0YPplpYlOlNf+0z9IJw6L12E86Tbf2ooZFxIwh34Ms6rvvFtFeylFKDlOoj0zbZwlXARttP1oEF3RIBUfR4uqotEhjhrnEyWaoSjR3z0QDogmecxAihdDw4z0DTO/bnQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=gPT/D4OUyafIFfbnM8678HTNoT1Fuyc5Di7P+uxxdPc=;\n b=qHrAO1UhiXvxZZGwPMTeaiCWiKs2zZOJJMat1DjU7yWdAx4SIanBfYxI8bbgEkYeYOxauJnJwD3SmKUk50aB/DCq/DBNKm5PTKMbiJsRsVudjUzRbwjPbv/SbKEKoImUtg+9SI5TBpwtwNGRLGqt3BiFNOYVlhCRQcBd9H9sGA/kElLB9Wz88wffq7Dc8IjbHjZ/6kX2j69l+LqlYJuUpuQEa/n8Vpzq8q/vySnGXD5+WC/TB9OQr2ba3RPeNSbMgFdjqhyEt6BLQNUIdiSQP3SVbNlW1kHd0s5+zk63hR526NZy92Ha+MqxDd2eGVJBHK7MfUlK2BFRjkMn3Q0RxQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed)\n header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Bing Zhao <bingz@nvidia.com>", "To": "<viacheslavo@nvidia.com>, <matan@nvidia.com>", "CC": "<dev@dpdk.org>, <orika@nvidia.com>, <rasland@nvidia.com>,\n <thomas@monjalon.net>, <lizh@nvidia.com>, <shunh@nvidia.com>", "Date": "Wed, 21 Jul 2021 11:54:21 +0300", "Message-ID": "<20210721085421.13111-8-bingz@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20210721085421.13111-1-bingz@nvidia.com>", "References": "<20210705155756.21443-1-bingz@nvidia.com>\n <20210721085421.13111-1-bingz@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL101.nvidia.com (172.20.187.10) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "acfba583-b706-480e-e743-08d94c2535d9", "X-MS-TrafficTypeDiagnostic": "CY4PR12MB1623:", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <CY4PR12MB1623756D73F7F442BBB2CFF8D0E39@CY4PR12MB1623.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:5797;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n PGMS95B6/tsJ9vJ38vqDTg+h00eC/bH7uuUU6vsuusHBNifu0Mj43uNsoaWERwnCxWY5PwrMKOxtRsrce65CDbO11uYY1xdpQT20Fmec3jAOigKH1UG8jHspWi5YaSD30xC8y071ukMT9m9XV6HSEgtSDcvEn7MTzjfe57yOCwUXsHhBbFroHYb5USXpYeaYpgULdHsP5qG0pEZCFx1X1aUGwkxOtBjz52auZmT2yqigaTy+UBR8Bq2fi9Qaw2Yfk5SmyPbT73C5Tgo8nV+qFexAHWQ43SiOGdY4cRQ7Lo+rZLNP8p+L5tokw7tYRTIr8qBxEmmaAAs8JwBeY5cBDd0wWOC3mKxm8Yg8MhL4ralXR3nyEbST4tpKiqZYKmi00sJgYL78iB05mWshhhIDw4jgrh2RmiyqxgwZ3dLgGGGd00ZbPJlCEYFo35V5HXBVXpyLS4I7I/wYuj8ZSZ6FUiFWDlQNxOrPSYE0Hv5Z3MEWRDJZlhtU9NOomVe4Ag5zCbglG2BAy8HMld/IGcbY8e8TdLA5lZJIRhDGgeyhqdZWmfQnAORECc3W33MithQQgzInjbbHZ9ur18TL2j6a8N9NY36JztRehVZSPYja8AbwOAoyRRLD7AZOqXsuYJj6uMWjSS2j99S8raonOlXCGaiGbG9DpVyfGgcXeehiE/0RnHJmWcgGZOxCbjnygmHGZjBaPnF5O71Fs+afTKbPoQ==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(136003)(39860400002)(346002)(396003)(376002)(36840700001)(46966006)(86362001)(36906005)(47076005)(1076003)(6286002)(30864003)(356005)(110136005)(83380400001)(55016002)(70206006)(336012)(7696005)(70586007)(478600001)(5660300002)(426003)(7636003)(82310400003)(186003)(82740400003)(6666004)(6636002)(4326008)(16526019)(316002)(8936002)(107886003)(36756003)(2616005)(36860700001)(8676002)(2906002)(54906003)(26005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Jul 2021 08:54:54.9210 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n acfba583-b706-480e-e743-08d94c2535d9", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT016.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY4PR12MB1623", "Subject": "[dpdk-dev] [PATCH v3 7/7] net/mlx5: add meter support for trTCM\n profiles", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The support of RFC2698 and RFC4115 are added in mlx5 PMD. Only the\nASO metering supports these two profiles.\n\nSigned-off-by: Bing Zhao <bingz@nvidia.com>\n---\n doc/guides/nics/mlx5.rst | 1 +\n doc/guides/rel_notes/release_21_08.rst | 1 +\n drivers/common/mlx5/mlx5_prm.h | 5 +-\n drivers/net/mlx5/mlx5_flow_aso.c | 23 ++++-\n drivers/net/mlx5/mlx5_flow_meter.c | 112 ++++++++++++++++---------\n 5 files changed, 98 insertions(+), 44 deletions(-)", "diff": "diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst\nindex 1f5b6fb954..ae267d315f 100644\n--- a/doc/guides/nics/mlx5.rst\n+++ b/doc/guides/nics/mlx5.rst\n@@ -433,6 +433,7 @@ Limitations\n - RED: must be DROP.\n - Policy actions of RSS for green and yellow should have the same configuration except queues.\n - meter profile packet mode is supported.\n+ - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.\n \n - Integrity:\n \ndiff --git a/doc/guides/rel_notes/release_21_08.rst b/doc/guides/rel_notes/release_21_08.rst\nindex 03d4fd059a..e159615deb 100644\n--- a/doc/guides/rel_notes/release_21_08.rst\n+++ b/doc/guides/rel_notes/release_21_08.rst\n@@ -92,6 +92,7 @@ New Features\n * Added support for matching on VXLAN header last 8-bits reserved field.\n * Optimized multi-thread flow rule insertion rate.\n * Added support for metering policy actions of yellow color.\n+ * Added support for metering trTCM RFC2698 and RFC4115.\n \n * **Added Wangxun ngbe PMD.**\n \ndiff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h\nindex 7950070976..88705be9d6 100644\n--- a/drivers/common/mlx5/mlx5_prm.h\n+++ b/drivers/common/mlx5/mlx5_prm.h\n@@ -3031,11 +3031,12 @@ struct mlx5_aso_mtr_dseg {\n #define ASO_DSEG_VALID_OFFSET 31\n #define ASO_DSEG_BO_OFFSET 30\n #define ASO_DSEG_SC_OFFSET 28\n+#define ASO_DSEG_BBOG_OFFSET 27\n #define ASO_DSEG_MTR_MODE 24\n #define ASO_DSEG_CBS_EXP_OFFSET 24\n #define ASO_DSEG_CBS_MAN_OFFSET 16\n-#define ASO_DSEG_CIR_EXP_MASK 0x1F\n-#define ASO_DSEG_CIR_EXP_OFFSET 8\n+#define ASO_DSEG_XIR_EXP_MASK 0x1F\n+#define ASO_DSEG_XIR_EXP_OFFSET 8\n #define ASO_DSEG_EBS_EXP_OFFSET 24\n #define ASO_DSEG_EBS_MAN_OFFSET 16\n #define ASO_DSEG_EXP_MASK 0x1F\ndiff --git a/drivers/net/mlx5/mlx5_flow_aso.c b/drivers/net/mlx5/mlx5_flow_aso.c\nindex 23e22e560a..e11327a11b 100644\n--- a/drivers/net/mlx5/mlx5_flow_aso.c\n+++ b/drivers/net/mlx5/mlx5_flow_aso.c\n@@ -747,10 +747,27 @@ mlx5_aso_mtr_sq_enqueue_single(struct mlx5_aso_sq *sq,\n \t\twqe->aso_dseg.mtrs[dseg_idx].v_bo_sc_bbog_mm =\n \t\t\t\tRTE_BE32((1 << ASO_DSEG_VALID_OFFSET) |\n \t\t\t\t(MLX5_FLOW_COLOR_GREEN << ASO_DSEG_SC_OFFSET));\n-\t/* Only needed for RFC2697. */\n-\tif (fm->profile->srtcm_prm.ebs_eir)\n+\tswitch (fmp->profile.alg) {\n+\tcase RTE_MTR_SRTCM_RFC2697:\n+\t\t/* Only needed for RFC2697. */\n+\t\tif (fm->profile->srtcm_prm.ebs_eir)\n+\t\t\twqe->aso_dseg.mtrs[dseg_idx].v_bo_sc_bbog_mm |=\n+\t\t\t\t\tRTE_BE32(1 << ASO_DSEG_BO_OFFSET);\n+\t\tbreak;\n+\tcase RTE_MTR_TRTCM_RFC2698:\n \t\twqe->aso_dseg.mtrs[dseg_idx].v_bo_sc_bbog_mm |=\n-\t\t\t\tRTE_BE32(1 << ASO_DSEG_BO_OFFSET);\n+\t\t\t\tRTE_BE32(1 << ASO_DSEG_BBOG_OFFSET);\n+\t\tbreak;\n+\tcase RTE_MTR_TRTCM_RFC4115:\n+\tdefault:\n+\t\tbreak;\n+\t}\n+\t/*\n+\t * Note:\n+\t * Due to software performance reason, the token fields will not be\n+\t * set when posting the WQE to ASO SQ. It will be filled by the HW\n+\t * automatically.\n+\t */\n \tsq->head++;\n \tsq->pi += 2;/* Each WQE contains 2 WQEBB's. */\n \trte_io_wmb();\ndiff --git a/drivers/net/mlx5/mlx5_flow_meter.c b/drivers/net/mlx5/mlx5_flow_meter.c\nindex 4f57b7e04e..2d91a6fcf0 100644\n--- a/drivers/net/mlx5/mlx5_flow_meter.c\n+++ b/drivers/net/mlx5/mlx5_flow_meter.c\n@@ -55,7 +55,7 @@ mlx5_flow_meter_action_create(struct mlx5_priv *priv,\n \tMLX5_SET(flow_meter_parameters, fmp, cbs_exponent, val);\n \tval = (cbs_cir >> ASO_DSEG_CBS_MAN_OFFSET) & ASO_DSEG_MAN_MASK;\n \tMLX5_SET(flow_meter_parameters, fmp, cbs_mantissa, val);\n-\tval = (cbs_cir >> ASO_DSEG_CIR_EXP_OFFSET) & ASO_DSEG_EXP_MASK;\n+\tval = (cbs_cir >> ASO_DSEG_XIR_EXP_OFFSET) & ASO_DSEG_EXP_MASK;\n \tMLX5_SET(flow_meter_parameters, fmp, cir_exponent, val);\n \tval = (cbs_cir & ASO_DSEG_MAN_MASK);\n \tMLX5_SET(flow_meter_parameters, fmp, cir_mantissa, val);\n@@ -194,18 +194,18 @@ mlx5_flow_meter_profile_validate(struct rte_eth_dev *dev,\n \t\t\t\t NULL, \"Metering algorithm not supported.\");\n }\n \n-/**\n- * Calculate mantissa and exponent for cir.\n+/*\n+ * Calculate mantissa and exponent for cir / eir.\n *\n- * @param[in] cir\n+ * @param[in] xir\n * Value to be calculated.\n * @param[out] man\n * Pointer to the mantissa.\n * @param[out] exp\n * Pointer to the exp.\n */\n-static void\n-mlx5_flow_meter_cir_man_exp_calc(int64_t cir, uint8_t *man, uint8_t *exp)\n+static inline void\n+mlx5_flow_meter_xir_man_exp_calc(int64_t xir, uint8_t *man, uint8_t *exp)\n {\n \tint64_t _cir;\n \tint64_t delta = INT64_MAX;\n@@ -216,8 +216,8 @@ mlx5_flow_meter_cir_man_exp_calc(int64_t cir, uint8_t *man, uint8_t *exp)\n \tfor (m = 0; m <= 0xFF; m++) { /* man width 8 bit */\n \t\tfor (e = 0; e <= 0x1F; e++) { /* exp width 5bit */\n \t\t\t_cir = (1000000000ULL * m) >> e;\n-\t\t\tif (llabs(cir - _cir) <= delta) {\n-\t\t\t\tdelta = llabs(cir - _cir);\n+\t\t\tif (llabs(xir - _cir) <= delta) {\n+\t\t\t\tdelta = llabs(xir - _cir);\n \t\t\t\t_man = m;\n \t\t\t\t_exp = e;\n \t\t\t}\n@@ -227,7 +227,7 @@ mlx5_flow_meter_cir_man_exp_calc(int64_t cir, uint8_t *man, uint8_t *exp)\n \t*exp = _exp;\n }\n \n-/**\n+/*\n * Calculate mantissa and exponent for xbs.\n *\n * @param[in] xbs\n@@ -237,7 +237,7 @@ mlx5_flow_meter_cir_man_exp_calc(int64_t cir, uint8_t *man, uint8_t *exp)\n * @param[out] exp\n * Pointer to the exp.\n */\n-static void\n+static inline void\n mlx5_flow_meter_xbs_man_exp_calc(uint64_t xbs, uint8_t *man, uint8_t *exp)\n {\n \tint _exp;\n@@ -275,37 +275,63 @@ mlx5_flow_meter_param_fill(struct mlx5_flow_meter_profile *fmp,\n \tstruct mlx5_flow_meter_srtcm_rfc2697_prm *srtcm = &fmp->srtcm_prm;\n \tuint8_t man, exp;\n \tuint32_t cbs_exp, cbs_man, cir_exp, cir_man;\n-\tuint32_t ebs_exp, ebs_man;\n-\tuint64_t cir, cbs, ebs;\n+\tuint32_t eir_exp, eir_man, ebs_exp, ebs_man;\n+\tuint64_t cir, cbs, eir, ebs;\n \n-\tif (fmp->profile.alg != RTE_MTR_SRTCM_RFC2697)\n-\t\treturn -rte_mtr_error_set(error, ENOTSUP,\n+\tif (!priv->sh->meter_aso_en) {\n+\t\t/* Legacy FW metering will only support srTCM. */\n+\t\tif (fmp->profile.alg != RTE_MTR_SRTCM_RFC2697)\n+\t\t\treturn -rte_mtr_error_set(error, ENOTSUP,\n \t\t\t\tRTE_MTR_ERROR_TYPE_METER_PROFILE,\n-\t\t\t\tNULL, \"Metering algorithm not supported.\");\n-\tif (!priv->sh->meter_aso_en && fmp->profile.packet_mode)\n-\t\treturn -rte_mtr_error_set(error, ENOTSUP,\n-\t\t\tRTE_MTR_ERROR_TYPE_METER_PROFILE,\n-\t\t\tNULL, \"Metering algorithm packet mode not supported.\");\n-\tif (priv->sh->meter_aso_en && fmp->profile.packet_mode) {\n-\t\tcir = fmp->profile.srtcm_rfc2697.cir <<\n-\t\t\t\tMLX5_MTRS_PPS_MAP_BPS_SHIFT;\n-\t\tcbs = fmp->profile.srtcm_rfc2697.cbs <<\n-\t\t\t\tMLX5_MTRS_PPS_MAP_BPS_SHIFT;\n-\t\tebs = fmp->profile.srtcm_rfc2697.ebs <<\n-\t\t\t\tMLX5_MTRS_PPS_MAP_BPS_SHIFT;\n-\t} else {\n+\t\t\t\tNULL, \"Metering algorithm is not supported.\");\n+\t\tif (fmp->profile.packet_mode)\n+\t\t\treturn -rte_mtr_error_set(error, ENOTSUP,\n+\t\t\t\tRTE_MTR_ERROR_TYPE_METER_PROFILE, NULL,\n+\t\t\t\t\"Metering algorithm packet mode is not supported.\");\n+\t}\n+\tswitch (fmp->profile.alg) {\n+\tcase RTE_MTR_SRTCM_RFC2697:\n \t\tcir = fmp->profile.srtcm_rfc2697.cir;\n \t\tcbs = fmp->profile.srtcm_rfc2697.cbs;\n+\t\teir = 0;\n \t\tebs = fmp->profile.srtcm_rfc2697.ebs;\n+\t\tbreak;\n+\tcase RTE_MTR_TRTCM_RFC2698:\n+\t\tMLX5_ASSERT(fmp->profile.trtcm_rfc2698.pir >\n+\t\t\t fmp->profile.trtcm_rfc2698.cir &&\n+\t\t\t fmp->profile.trtcm_rfc2698.pbs >\n+\t\t\t fmp->profile.trtcm_rfc2698.cbs);\n+\t\tcir = fmp->profile.trtcm_rfc2698.cir;\n+\t\tcbs = fmp->profile.trtcm_rfc2698.cbs;\n+\t\t/* EIR / EBS are filled with PIR / PBS. */\n+\t\teir = fmp->profile.trtcm_rfc2698.pir;\n+\t\tebs = fmp->profile.trtcm_rfc2698.pbs;\n+\t\tbreak;\n+\tcase RTE_MTR_TRTCM_RFC4115:\n+\t\tcir = fmp->profile.trtcm_rfc4115.cir;\n+\t\tcbs = fmp->profile.trtcm_rfc4115.cbs;\n+\t\teir = fmp->profile.trtcm_rfc4115.eir;\n+\t\tebs = fmp->profile.trtcm_rfc4115.ebs;\n+\t\tbreak;\n+\tdefault:\n+\t\treturn -rte_mtr_error_set(error, EINVAL,\n+\t\t\t\tRTE_MTR_ERROR_TYPE_METER_PROFILE, NULL,\n+\t\t\t\t\"Metering algorithm mode is invalid\");\n+\t}\n+\t/* Adjust the values for PPS mode. */\n+\tif (fmp->profile.packet_mode) {\n+\t\tcir <<= MLX5_MTRS_PPS_MAP_BPS_SHIFT;\n+\t\tcbs <<= MLX5_MTRS_PPS_MAP_BPS_SHIFT;\n+\t\teir <<= MLX5_MTRS_PPS_MAP_BPS_SHIFT;\n+\t\tebs <<= MLX5_MTRS_PPS_MAP_BPS_SHIFT;\n \t}\n \t/* cir = 8G * cir_mantissa * 1/(2^cir_exponent)) Bytes/Sec */\n-\tmlx5_flow_meter_cir_man_exp_calc(cir, &man, &exp);\n+\tmlx5_flow_meter_xir_man_exp_calc(cir, &man, &exp);\n \t/* Check if cir mantissa is too large. */\n-\tif (exp > ASO_DSEG_CIR_EXP_MASK)\n+\tif (exp > ASO_DSEG_XIR_EXP_MASK)\n \t\treturn -rte_mtr_error_set(error, ENOTSUP,\n \t\t\t\t\t RTE_MTR_ERROR_TYPE_MTR_PARAMS, NULL,\n-\t\t\t\t\t \"meter profile parameter cir is\"\n-\t\t\t\t\t \" not supported.\");\n+\t\t\t\t\t \"meter profile parameter cir is not supported.\");\n \tcir_man = man;\n \tcir_exp = exp;\n \t /* cbs = cbs_mantissa * 2^cbs_exponent */\n@@ -314,25 +340,33 @@ mlx5_flow_meter_param_fill(struct mlx5_flow_meter_profile *fmp,\n \tif (exp > ASO_DSEG_EXP_MASK)\n \t\treturn -rte_mtr_error_set(error, ENOTSUP,\n \t\t\t\t\t RTE_MTR_ERROR_TYPE_MTR_PARAMS, NULL,\n-\t\t\t\t\t \"meter profile parameter cbs is\"\n-\t\t\t\t\t \" not supported.\");\n+\t\t\t\t\t \"meter profile parameter cbs is not supported.\");\n \tcbs_man = man;\n \tcbs_exp = exp;\n \tsrtcm->cbs_cir = rte_cpu_to_be_32(cbs_exp << ASO_DSEG_CBS_EXP_OFFSET |\n \t\t\t\t\t cbs_man << ASO_DSEG_CBS_MAN_OFFSET |\n-\t\t\t\t\t cir_exp << ASO_DSEG_CIR_EXP_OFFSET |\n+\t\t\t\t\t cir_exp << ASO_DSEG_XIR_EXP_OFFSET |\n \t\t\t\t\t cir_man);\n+\tmlx5_flow_meter_xir_man_exp_calc(eir, &man, &exp);\n+\t/* Check if eir mantissa is too large. */\n+\tif (exp > ASO_DSEG_XIR_EXP_MASK)\n+\t\treturn -rte_mtr_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_MTR_ERROR_TYPE_MTR_PARAMS, NULL,\n+\t\t\t\t\t \"meter profile parameter eir is not supported.\");\n+\teir_man = man;\n+\teir_exp = exp;\n \tmlx5_flow_meter_xbs_man_exp_calc(ebs, &man, &exp);\n \t/* Check if ebs mantissa is too large. */\n \tif (exp > ASO_DSEG_EXP_MASK)\n \t\treturn -rte_mtr_error_set(error, ENOTSUP,\n \t\t\t\t\t RTE_MTR_ERROR_TYPE_MTR_PARAMS, NULL,\n-\t\t\t\t\t \"meter profile parameter ebs is\"\n-\t\t\t\t\t \" not supported.\");\n+\t\t\t\t\t \"meter profile parameter ebs is not supported.\");\n \tebs_man = man;\n \tebs_exp = exp;\n \tsrtcm->ebs_eir = rte_cpu_to_be_32(ebs_exp << ASO_DSEG_EBS_EXP_OFFSET |\n-\t\t\t\t\t ebs_man << ASO_DSEG_EBS_MAN_OFFSET);\n+\t\t\t\t\t ebs_man << ASO_DSEG_EBS_MAN_OFFSET |\n+\t\t\t\t\t eir_exp << ASO_DSEG_XIR_EXP_OFFSET |\n+\t\t\t\t\t eir_man);\n \tif (srtcm->cbs_cir)\n \t\tfmp->g_support = 1;\n \tif (srtcm->ebs_eir)\n@@ -1008,7 +1042,7 @@ mlx5_flow_meter_action_modify(struct mlx5_priv *priv,\n \t\t\t\tcbs_mantissa, val);\n \t\t}\n \t\tif (modify_bits & MLX5_FLOW_METER_OBJ_MODIFY_FIELD_CIR) {\n-\t\t\tval = (cbs_cir >> ASO_DSEG_CIR_EXP_OFFSET) &\n+\t\t\tval = (cbs_cir >> ASO_DSEG_XIR_EXP_OFFSET) &\n \t\t\t\tASO_DSEG_EXP_MASK;\n \t\t\tMLX5_SET(flow_meter_parameters, attr,\n \t\t\t\tcir_exponent, val);\n@@ -1389,7 +1423,7 @@ mlx5_flow_meter_modify_state(struct mlx5_priv *priv,\n \t\t\t\t&srtcm, modify_bits, 0, 0);\n \telse\n \t\tret = mlx5_flow_meter_action_modify(priv, fm,\n-\t\t\t\t\t\t &fm->profile->srtcm_prm,\n+\t\t\t\t\t\t &fm->profile->srtcm_prm,\n \t\t\t\t\t\t modify_bits, 0, 1);\n \tif (ret)\n \t\treturn -rte_mtr_error_set(error, -ret,\n", "prefixes": [ "v3", "7/7" ] }