Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96155/?format=api
{ "id": 96155, "url": "http://patchwork.dpdk.org/api/patches/96155/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/f0962a6a37fec7be93162bdc4dc4990da72bc012.1626877580.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<f0962a6a37fec7be93162bdc4dc4990da72bc012.1626877580.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/f0962a6a37fec7be93162bdc4dc4990da72bc012.1626877580.git.anatoly.burakov@intel.com", "date": "2021-07-21T14:26:25", "name": "[v1,1/1] power: fix multi-queue scale mode for pmd mgmt", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "66ffa85733b4a4750691530c3e43e17b8f85100c", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/f0962a6a37fec7be93162bdc4dc4990da72bc012.1626877580.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 17937, "url": "http://patchwork.dpdk.org/api/series/17937/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17937", "date": "2021-07-21T14:26:25", "name": "[v1,1/1] power: fix multi-queue scale mode for pmd mgmt", "version": 1, "mbox": "http://patchwork.dpdk.org/series/17937/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96155/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96155/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4D7C1A0C51;\n\tWed, 21 Jul 2021 16:26:39 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1466E4014E;\n\tWed, 21 Jul 2021 16:26:39 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 434844014D\n for <dev@dpdk.org>; Wed, 21 Jul 2021 16:26:37 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Jul 2021 07:26:29 -0700", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.151])\n by fmsmga002.fm.intel.com with ESMTP; 21 Jul 2021 07:26:27 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10052\"; a=\"272558494\"", "E=Sophos;i=\"5.84,258,1620716400\"; d=\"scan'208\";a=\"272558494\"", "E=Sophos;i=\"5.84,258,1620716400\"; d=\"scan'208\";a=\"511810583\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org, David Hunt <david.hunt@intel.com>,\n Konstantin Ananyev <konstantin.ananyev@intel.com>", "Cc": "reshma.pattan@intel.com", "Date": "Wed, 21 Jul 2021 14:26:25 +0000", "Message-Id": "\n <f0962a6a37fec7be93162bdc4dc4990da72bc012.1626877580.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 1/1] power: fix multi-queue scale mode for pmd\n mgmt", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently in scale mode, multi-queue initialization will attempt to\ninitialize and de-initialize the per-lcore power library structures\nmultiple times. Fix it to only do this whenever we either enabling\nfirst queue or disabling last queue.\n\nFixes: 5dff9a72b0ef (\"power: support callbacks for multiple Rx queues\")\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/power/rte_power_pmd_mgmt.c | 19 +++++++++++++------\n 1 file changed, 13 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/power/rte_power_pmd_mgmt.c b/lib/power/rte_power_pmd_mgmt.c\nindex 2586204b93..0ce40f0875 100644\n--- a/lib/power/rte_power_pmd_mgmt.c\n+++ b/lib/power/rte_power_pmd_mgmt.c\n@@ -534,11 +534,15 @@ rte_power_ethdev_pmgmt_queue_enable(unsigned int lcore_id, uint16_t port_id,\n \t\tclb = get_monitor_callback();\n \t\tbreak;\n \tcase RTE_POWER_MGMT_TYPE_SCALE:\n-\t\t/* check if we can add a new queue */\n-\t\tret = check_scale(lcore_id);\n-\t\tif (ret < 0)\n-\t\t\tgoto end;\n \t\tclb = clb_scale_freq;\n+\n+\t\t/* we only have to check this when enabling first queue */\n+\t\tif (lcore_cfg->pwr_mgmt_state != PMD_MGMT_DISABLED)\n+\t\t\tbreak;\n+\t\t/* check if we can add a new queue */\n+\t\tret = check_scale(lcore_id);\n+\t\tif (ret < 0)\n+\t\t\tgoto end;\n \t\tbreak;\n \tcase RTE_POWER_MGMT_TYPE_PAUSE:\n \t\t/* figure out various time-to-tsc conversions */\n@@ -633,9 +637,12 @@ rte_power_ethdev_pmgmt_queue_disable(unsigned int lcore_id,\n \t\trte_eth_remove_rx_callback(port_id, queue_id, queue_cfg->cb);\n \t\tbreak;\n \tcase RTE_POWER_MGMT_TYPE_SCALE:\n-\t\trte_power_freq_max(lcore_id);\n \t\trte_eth_remove_rx_callback(port_id, queue_id, queue_cfg->cb);\n-\t\trte_power_exit(lcore_id);\n+\t\t/* disable power library on this lcore if this was last queue */\n+\t\tif (lcore_cfg->pwr_mgmt_state == PMD_MGMT_DISABLED) {\n+\t\t\trte_power_freq_max(lcore_id);\n+\t\t\trte_power_exit(lcore_id);\n+\t\t}\n \t\tbreak;\n \t}\n \t/*\n", "prefixes": [ "v1", "1/1" ] }