Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96170/?format=api
{ "id": 96170, "url": "http://patchwork.dpdk.org/api/patches/96170/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210721143743.24626-15-xuemingl@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210721143743.24626-15-xuemingl@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210721143743.24626-15-xuemingl@nvidia.com", "date": "2021-07-21T14:37:41", "name": "[v4,14/16] compress/mlx5: migrate to common driver", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "23bdbafe1105634258fb3cd7a84e0504aada3624", "submitter": { "id": 1904, "url": "http://patchwork.dpdk.org/api/people/1904/?format=api", "name": "Xueming Li", "email": "xuemingl@nvidia.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210721143743.24626-15-xuemingl@nvidia.com/mbox/", "series": [ { "id": 17938, "url": "http://patchwork.dpdk.org/api/series/17938/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17938", "date": "2021-07-21T14:37:27", "name": "net/mlx5: support Sub-Function", "version": 4, "mbox": "http://patchwork.dpdk.org/series/17938/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96170/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96170/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6CCD1A0C51;\n\tWed, 21 Jul 2021 16:40:08 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A12744113E;\n\tWed, 21 Jul 2021 16:39:38 +0200 (CEST)", "from NAM04-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam08on2049.outbound.protection.outlook.com [40.107.102.49])\n by mails.dpdk.org (Postfix) with ESMTP id 9E24941164\n for <dev@dpdk.org>; Wed, 21 Jul 2021 16:39:37 +0200 (CEST)", "from BN9PR03CA0228.namprd03.prod.outlook.com (2603:10b6:408:f8::23)\n by BN6PR12MB1828.namprd12.prod.outlook.com (2603:10b6:404:108::9)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.25; Wed, 21 Jul\n 2021 14:39:35 +0000", "from BN8NAM11FT060.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:f8:cafe::20) by BN9PR03CA0228.outlook.office365.com\n (2603:10b6:408:f8::23) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.22 via Frontend\n Transport; Wed, 21 Jul 2021 14:39:35 +0000", "from mail.nvidia.com (216.228.112.34) by\n BN8NAM11FT060.mail.protection.outlook.com (10.13.177.211) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4352.24 via Frontend Transport; Wed, 21 Jul 2021 14:39:35 +0000", "from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 21 Jul\n 2021 14:39:33 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Nmf60psGRqyzZ/DKPYNbsYXSG3MLLU9mGwNdLW04ZfrWQmUYW9YGUv4E1FCCAqffmDztYyYJNPFH6dfP1Rv193YG8WRtB7wVC4XTL6b3s2XH2GmQk7dFiim1KNSV8gpA4ZB1liUSpbJwYHPPctnrKpXyHMeORguBxiY6CFQlLzABMzt4MfOODWfADeD+bcoNI/JAsmqVxKPZAs6WD+G1ZFuJQO1Fw8CQJHBJr4hGOZl+T2oYsde1iei+MAMzpDFrTQNoSqJ9h4m7Q9dQlzyv2y8S0L47rWkSVvNTOHa3xeUfocE8vXesFvut00KfhqwoFRcxoXd3TMMXXoU9kNgtlw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=BOeHXbRB8KYMmw13fPNgKl/aJDNifRRIrsXweF6geO4=;\n b=it/slazCk2/yi9Skt1JNO4SRAt6Hw+xiI/4hGvq6PDgZm7QlCSpu0+/NV5NDStJJsHypGhceGGaSIH+p41Y9Zl4drdvZi5PGBQi1WmADdUSZI6l5GkeQwGFMrUeQBTw4WeUPe5ckYHq/peNNRRYKh3fl4EbdJbFZPt7MPXYh0ZAYDrj1GJAjRSjVMtI8aBIFzODkDaLIbRMh92E7PTV41O2TabyVUONOG4d1ElC9uoYxWzaUYi2IGB/buir7UHuBUOkxvvKPlk7KJtE3Mln+UDQMAxXDEGUgh8jFclRZIo8sc3pjUfhClsQRyIqh8RVigEhguZGTPOrT4Z7p8pO2MA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=marvell.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=BOeHXbRB8KYMmw13fPNgKl/aJDNifRRIrsXweF6geO4=;\n b=JpRB9AhRTS7rjWSpSzS3l5/qeLGn+czrUb25yLSri9mafzaRCTLvR/91Mprp2FbzoaYuUjQlil+hzuFFdXVm19Hm2SGk3cMHuEEQDQg8DHzvmHp2XKnyz+smj2gXyjhMZyRRN2iQpG833oB9ShuMBo6QpXnzAkAoXeKN1yKLyWS2mTOm8Zf+ejSxQl7FqEbnsSXqVg3UshB2Mb1gZQdDfCfyrV+FURzUtljrSKN5vKo9YDR8eZIiMN8fCw08MuMPvXlTYSHknYBjKgRgpX67Vmogg1rBfXqSZjFR+KVaKXXtz5f5GUgGSOvSTO7+iZehz/zqDif9MvLn8LtEqhn1hA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; marvell.com; dkim=none (message not signed)\n header.d=none;marvell.com; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Xueming Li <xuemingl@nvidia.com>", "To": "Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "CC": "<dev@dpdk.org>, <xuemingl@nvidia.com>, Matan Azrad <matan@nvidia.com>,\n Fiona Trahe <fiona.trahe@intel.com>, Ashish Gupta <ashish.gupta@marvell.com>", "Date": "Wed, 21 Jul 2021 22:37:41 +0800", "Message-ID": "<20210721143743.24626-15-xuemingl@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210721143743.24626-1-xuemingl@nvidia.com>", "References": "<20210616040935.311733-1-xuemingl@nvidia.com>\n <20210721143743.24626-1-xuemingl@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.6]", "X-ClientProxiedBy": "HQMAIL105.nvidia.com (172.20.187.12) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "acb0e445-7d06-45d3-8d99-08d94c555c7c", "X-MS-TrafficTypeDiagnostic": "BN6PR12MB1828:", "X-Microsoft-Antispam-PRVS": "\n <BN6PR12MB182886339FED813CEFE9EEE5A1E39@BN6PR12MB1828.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:4303;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n +GxJYBDLB6ZWfzPl2qPg2TTvNIID4uNxXQgiYg8w+68iffQL9ZSftaLaSj9eBLehQlAqcgxagpVqXrOu7LurypFBzH7KJkkrQMvut7nknqGMexV577d7scO1moqePlG2wWdzIJ5pYDEsOPtgLyllA8Df0a2rxEEU5W2fxUZAlV8MoXKRzuZaBFCRw5OSAZ+bmFDkeJdZ2dN14ThzRGMVpNuIN0UnBjvNFl0BDkLJ3zya16vU1k7/B+rETqQNKbIzmKrs4UG4Y60wVejSFybtcN9DZJpPDJpREjgrbKxJ15FvTPYXpxTv4FCvl/3N5LGaCI6/lq1vUWq1anwjaJY70j6F/DfZteYoLLb3Ld7z0KODpgjIU3TY30XhfhKu5NF+sAimqZ1lE/X6KZ8/d13sC9mwfBaNh61W1yCqFnOGrFhb7v/EqUCz/HMtTgeG50wae0+jnLR/EhvPzb+Gv3ndnZ9Uh5p2qIXLmK0m/aM/9zIULsC2RX0Doe593Aui8TZitrLhTca1Ly5QA8G2tVMVnCS2slwstUSzA/LWKW18sC6JXG+uAn7mk3GbYcQQkeExQ3viw68jpLvnF149VnawGNoiAlfypDZUsPWVV3fwSFRvlykpe/yNT7T2vR/LAbk7m47osSHASC4Ntsb1DoTqce0atNm8/HI4vgIOta6SoQOPfgImIufWnMn0Z6yC7yXjjV+jyA8dPZURimS/oCdWFQ==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(46966006)(36840700001)(8676002)(6636002)(316002)(54906003)(36906005)(37006003)(6666004)(8936002)(86362001)(82310400003)(426003)(4326008)(6286002)(6862004)(2616005)(2906002)(356005)(336012)(47076005)(36756003)(1076003)(83380400001)(7636003)(26005)(5660300002)(70206006)(70586007)(186003)(508600001)(16526019)(7696005)(36860700001)(55016002);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "21 Jul 2021 14:39:35.5584 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n acb0e445-7d06-45d3-8d99-08d94c555c7c", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT060.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN6PR12MB1828", "Subject": "[dpdk-dev] [PATCH v4 14/16] compress/mlx5: migrate to common driver", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "To support auxiliary bus, upgrades driver to use mlx5 common driver\nstructure.\n\nSigned-off-by: Xueming Li <xuemingl@nvidia.com>\nAcked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>\n---\n drivers/compress/mlx5/mlx5_compress.c | 71 ++++++---------------------\n 1 file changed, 15 insertions(+), 56 deletions(-)", "diff": "diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c\nindex f5f51c0ebe..9775c81789 100644\n--- a/drivers/compress/mlx5/mlx5_compress.c\n+++ b/drivers/compress/mlx5/mlx5_compress.c\n@@ -5,7 +5,7 @@\n #include <rte_malloc.h>\n #include <rte_log.h>\n #include <rte_errno.h>\n-#include <rte_pci.h>\n+#include <rte_bus_pci.h>\n #include <rte_spinlock.h>\n #include <rte_comp.h>\n #include <rte_compressdev.h>\n@@ -13,7 +13,6 @@\n \n #include <mlx5_glue.h>\n #include <mlx5_common.h>\n-#include <mlx5_common_pci.h>\n #include <mlx5_devx_cmds.h>\n #include <mlx5_common_os.h>\n #include <mlx5_common_devx.h>\n@@ -37,7 +36,6 @@ struct mlx5_compress_xform {\n struct mlx5_compress_priv {\n \tTAILQ_ENTRY(mlx5_compress_priv) next;\n \tstruct ibv_context *ctx; /* Device context. */\n-\tstruct rte_pci_device *pci_dev;\n \tstruct rte_compressdev *cdev;\n \tvoid *uar;\n \tuint32_t pdn; /* Protection Domain number. */\n@@ -780,23 +778,8 @@ mlx5_compress_mr_mem_event_cb(enum rte_mem_event event_type, const void *addr,\n \t}\n }\n \n-/**\n- * DPDK callback to register a PCI device.\n- *\n- * This function spawns compress device out of a given PCI device.\n- *\n- * @param[in] pci_drv\n- * PCI driver structure (mlx5_compress_driver).\n- * @param[in] pci_dev\n- * PCI device information.\n- *\n- * @return\n- * 0 on success, 1 to skip this driver, a negative errno value otherwise\n- * and rte_errno is set.\n- */\n static int\n-mlx5_compress_pci_probe(struct rte_pci_driver *pci_drv,\n-\t\t\tstruct rte_pci_device *pci_dev)\n+mlx5_compress_dev_probe(struct rte_device *dev)\n {\n \tstruct ibv_device *ibv;\n \tstruct rte_compressdev *cdev;\n@@ -805,24 +788,17 @@ mlx5_compress_pci_probe(struct rte_pci_driver *pci_drv,\n \tstruct mlx5_hca_attr att = { 0 };\n \tstruct rte_compressdev_pmd_init_params init_params = {\n \t\t.name = \"\",\n-\t\t.socket_id = pci_dev->device.numa_node,\n+\t\t.socket_id = dev->numa_node,\n \t};\n \n-\tRTE_SET_USED(pci_drv);\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n \t\tDRV_LOG(ERR, \"Non-primary process type is not supported.\");\n \t\trte_errno = ENOTSUP;\n \t\treturn -rte_errno;\n \t}\n-\tibv = mlx5_os_get_ibv_device(&pci_dev->addr);\n-\tif (ibv == NULL) {\n-\t\tDRV_LOG(ERR, \"No matching IB device for PCI slot \"\n-\t\t\tPCI_PRI_FMT \".\", pci_dev->addr.domain,\n-\t\t\tpci_dev->addr.bus, pci_dev->addr.devid,\n-\t\t\tpci_dev->addr.function);\n+\tibv = mlx5_os_get_ibv_dev(dev);\n+\tif (ibv == NULL)\n \t\treturn -rte_errno;\n-\t}\n-\tDRV_LOG(INFO, \"PCI information matches for device \\\"%s\\\".\", ibv->name);\n \tctx = mlx5_glue->dv_open_device(ibv);\n \tif (ctx == NULL) {\n \t\tDRV_LOG(ERR, \"Failed to open IB device \\\"%s\\\".\", ibv->name);\n@@ -838,7 +814,7 @@ mlx5_compress_pci_probe(struct rte_pci_driver *pci_drv,\n \t\trte_errno = ENOTSUP;\n \t\treturn -ENOTSUP;\n \t}\n-\tcdev = rte_compressdev_pmd_create(ibv->name, &pci_dev->device,\n+\tcdev = rte_compressdev_pmd_create(ibv->name, dev,\n \t\t\t\t\t sizeof(*priv), &init_params);\n \tif (cdev == NULL) {\n \t\tDRV_LOG(ERR, \"Failed to create device \\\"%s\\\".\", ibv->name);\n@@ -853,7 +829,6 @@ mlx5_compress_pci_probe(struct rte_pci_driver *pci_drv,\n \tcdev->feature_flags = RTE_COMPDEV_FF_HW_ACCELERATED;\n \tpriv = cdev->data->dev_private;\n \tpriv->ctx = ctx;\n-\tpriv->pci_dev = pci_dev;\n \tpriv->cdev = cdev;\n \tpriv->min_block_size = att.compress_min_block_size;\n \tpriv->sq_ts_format = att.sq_ts_format;\n@@ -884,25 +859,14 @@ mlx5_compress_pci_probe(struct rte_pci_driver *pci_drv,\n \treturn 0;\n }\n \n-/**\n- * DPDK callback to remove a PCI device.\n- *\n- * This function removes all compress devices belong to a given PCI device.\n- *\n- * @param[in] pci_dev\n- * Pointer to the PCI device.\n- *\n- * @return\n- * 0 on success, the function cannot fail.\n- */\n static int\n-mlx5_compress_pci_remove(struct rte_pci_device *pdev)\n+mlx5_compress_dev_remove(struct rte_device *dev)\n {\n \tstruct mlx5_compress_priv *priv = NULL;\n \n \tpthread_mutex_lock(&priv_list_lock);\n \tTAILQ_FOREACH(priv, &mlx5_compress_priv_list, next)\n-\t\tif (rte_pci_addr_cmp(&priv->pci_dev->addr, &pdev->addr) != 0)\n+\t\tif (priv->cdev->device == dev)\n \t\t\tbreak;\n \tif (priv)\n \t\tTAILQ_REMOVE(&mlx5_compress_priv_list, priv, next);\n@@ -929,24 +893,19 @@ static const struct rte_pci_id mlx5_compress_pci_id_map[] = {\n \t}\n };\n \n-static struct mlx5_pci_driver mlx5_compress_driver = {\n-\t.driver_class = MLX5_CLASS_COMPRESS,\n-\t.pci_driver = {\n-\t\t.driver = {\n-\t\t\t.name = RTE_STR(MLX5_COMPRESS_DRIVER_NAME),\n-\t\t},\n-\t\t.id_table = mlx5_compress_pci_id_map,\n-\t\t.probe = mlx5_compress_pci_probe,\n-\t\t.remove = mlx5_compress_pci_remove,\n-\t\t.drv_flags = 0,\n-\t},\n+static struct mlx5_class_driver mlx5_compress_driver = {\n+\t.drv_class = MLX5_CLASS_COMPRESS,\n+\t.name = RTE_STR(MLX5_COMPRESS_DRIVER_NAME),\n+\t.id_table = mlx5_compress_pci_id_map,\n+\t.probe = mlx5_compress_dev_probe,\n+\t.remove = mlx5_compress_dev_remove,\n };\n \n RTE_INIT(rte_mlx5_compress_init)\n {\n \tmlx5_common_init();\n \tif (mlx5_glue != NULL)\n-\t\tmlx5_pci_driver_register(&mlx5_compress_driver);\n+\t\tmlx5_class_driver_register(&mlx5_compress_driver);\n }\n \n RTE_LOG_REGISTER_DEFAULT(mlx5_compress_logtype, NOTICE)\n", "prefixes": [ "v4", "14/16" ] }