Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96200/?format=api
{ "id": 96200, "url": "http://patchwork.dpdk.org/api/patches/96200/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210722095433.1898589-4-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210722095433.1898589-4-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210722095433.1898589-4-andrew.rybchenko@oktetlabs.ru", "date": "2021-07-22T09:54:25", "name": "[v2,03/11] ethdev: fix docs of functions getting xstats by IDs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f32310f28666f9bdf3b53b87cc1c44afd4ef5f26", "submitter": { "id": 2013, "url": "http://patchwork.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210722095433.1898589-4-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 17954, "url": "http://patchwork.dpdk.org/api/series/17954/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17954", "date": "2021-07-22T09:54:22", "name": "net/sfc: provide Rx/Tx doorbells stats", "version": 2, "mbox": "http://patchwork.dpdk.org/series/17954/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96200/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96200/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D3490A0C4E;\n\tThu, 22 Jul 2021 11:55:07 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3590A410F1;\n\tThu, 22 Jul 2021 11:55:00 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 5D62C410FD;\n Thu, 22 Jul 2021 11:54:59 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 2695B7F6D3; Thu, 22 Jul 2021 12:54:59 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id E02FD7F5B3;\n Thu, 22 Jul 2021 12:54:44 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru E02FD7F5B3", "Authentication-Results": "shelob.oktetlabs.ru/E02FD7F5B3; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,\n Ferruh Yigit <ferruh.yigit@intel.com>, Kuba Kozak <kubax.kozak@intel.com>", "Cc": "David Marchand <david.marchand@redhat.com>,\n Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>, stable@dpdk.org,\n Andy Moreton <amoreton@xilinx.com>", "Date": "Thu, 22 Jul 2021 12:54:25 +0300", "Message-Id": "<20210722095433.1898589-4-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210722095433.1898589-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru>\n <20210722095433.1898589-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 03/11] ethdev: fix docs of functions getting\n xstats by IDs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\n\nDocument valid combinations of input arguments in accordance with\ncurrent implementation in ethdev.\n\nFixes: 79c913a42f0 (\"ethdev: retrieve xstats by ID\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n lib/ethdev/rte_ethdev.h | 30 +++++++++++++++++-------------\n 1 file changed, 17 insertions(+), 13 deletions(-)", "diff": "diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h\nindex d2b27c351f..80c42d2f08 100644\n--- a/lib/ethdev/rte_ethdev.h\n+++ b/lib/ethdev/rte_ethdev.h\n@@ -2872,13 +2872,16 @@ int rte_eth_xstats_get(uint16_t port_id, struct rte_eth_xstat *xstats,\n * @param port_id\n * The port identifier of the Ethernet device.\n * @param xstats_names\n- * An rte_eth_xstat_name array of at least *size* elements to\n- * be filled. If set to NULL, the function returns the required number\n- * of elements.\n+ * An array of at least @p size elements to be filled in.\n+ * Must not be NULL if @p ids are specified (not NULL) or @p size is not 0.\n * @param ids\n- * IDs array given by app to retrieve specific statistics\n+ * IDs array given by app to retrieve specific statistics names.\n+ * May be NULL to retrieve all available statistics names.\n * @param size\n- * The size of the xstats_names array (number of elements).\n+ * If @p ids is not NULL, number of elements in the array with requested IDs\n+ * and number of elements in @p xstats_names to put names in. If @p ids is\n+ * NULL, number of elements in @p xstats_names to put all available statistics\n+ * names in.\n * @return\n * - A positive value lower or equal to size: success. The return value\n * is the number of entries filled in the stats table.\n@@ -2886,7 +2889,7 @@ int rte_eth_xstats_get(uint16_t port_id, struct rte_eth_xstat *xstats,\n * is too small. The return value corresponds to the size that should\n * be given to succeed. The entries in the table are not valid and\n * shall not be used by the caller.\n- * - A negative value on error (invalid port id).\n+ * - A negative value on error.\n */\n int\n rte_eth_xstats_get_names_by_id(uint16_t port_id,\n@@ -2899,14 +2902,15 @@ rte_eth_xstats_get_names_by_id(uint16_t port_id,\n * @param port_id\n * The port identifier of the Ethernet device.\n * @param ids\n- * A pointer to an ids array passed by application. This tells which\n- * statistics values function should retrieve. This parameter\n- * can be set to NULL if size is 0. In this case function will retrieve\n- * all available statistics.\n+ * IDs array given by app to retrieve specific statistics.\n+ * May be NULL to retrieve all available statistics.\n * @param values\n- * A pointer to a table to be filled with device statistics values.\n+ * An array of at least @p size elements to be filled in.\n+ * Must not be NULL if @p ids are specified (not NULL) or @p size is not 0.\n * @param size\n- * The size of the ids array (number of elements).\n+ * If @p ids is not NULL, number of elements in the array with requested IDs\n+ * and number of elements in values to put statistics in. If @p ids is NULL,\n+ * number of elements in values to put all available statistics in.\n * @return\n * - A positive value lower or equal to size: success. The return value\n * is the number of entries filled in the stats table.\n@@ -2914,7 +2918,7 @@ rte_eth_xstats_get_names_by_id(uint16_t port_id,\n * is too small. The return value corresponds to the size that should\n * be given to succeed. The entries in the table are not valid and\n * shall not be used by the caller.\n- * - A negative value on error (invalid port id).\n+ * - A negative value on error.\n */\n int rte_eth_xstats_get_by_id(uint16_t port_id, const uint64_t *ids,\n \t\t\t uint64_t *values, unsigned int size);\n", "prefixes": [ "v2", "03/11" ] }