Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 96240,
    "url": "http://patchwork.dpdk.org/api/patches/96240/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210723102454.12206-4-mk@semihalf.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210723102454.12206-4-mk@semihalf.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210723102454.12206-4-mk@semihalf.com",
    "date": "2021-07-23T10:24:51",
    "name": "[v4,3/6] net/ena: trigger reset when Tx prepare fails",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "5ddc3f9604eaa32a188814fce37842ee6993cdf9",
    "submitter": {
        "id": 786,
        "url": "http://patchwork.dpdk.org/api/people/786/?format=api",
        "name": "Michal Krawczyk",
        "email": "mk@semihalf.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210723102454.12206-4-mk@semihalf.com/mbox/",
    "series": [
        {
            "id": 17968,
            "url": "http://patchwork.dpdk.org/api/series/17968/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17968",
            "date": "2021-07-23T10:24:48",
            "name": "net/ena: v2.4.0 driver update",
            "version": 4,
            "mbox": "http://patchwork.dpdk.org/series/17968/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/96240/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/96240/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 83A79A0C46;\n\tFri, 23 Jul 2021 12:26:59 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 197CC410F8;\n\tFri, 23 Jul 2021 12:26:45 +0200 (CEST)",
            "from mail-ej1-f54.google.com (mail-ej1-f54.google.com\n [209.85.218.54]) by mails.dpdk.org (Postfix) with ESMTP id E93AF40DDA\n for <dev@dpdk.org>; Fri, 23 Jul 2021 12:26:40 +0200 (CEST)",
            "by mail-ej1-f54.google.com with SMTP id nd39so2986201ejc.5\n for <dev@dpdk.org>; Fri, 23 Jul 2021 03:26:40 -0700 (PDT)",
            "from DESKTOP-U5LNN3J.localdomain\n (093105178068.dynamic-ww-01.vectranet.pl. [93.105.178.68])\n by smtp.gmail.com with ESMTPSA id jp26sm10506142ejb.28.2021.07.23.03.26.39\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 23 Jul 2021 03:26:39 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=semihalf-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=V4S5VuFuIVM0xDiwmw+bkutu1YZQ0xs0EYeC39TGHVY=;\n b=cVfCLI+5g6FP+1CJ/rBNAgiwtXl691b3l5IEA2sdWPmtzp0+KsvJJbe2OdPdOwZf9W\n 4OtNuv6E8dMBn8We4zUl/ZzF3RbWGdYAB+CEld0dqFtwInfWs4y/2oMRnNtOD09wBDk6\n GWA9mGZPd2U+/0XC/KgQlhzvEQH52i9aXMj8S6EH8mVs2v0f9JYmosylj8s2OxhPQ1HJ\n Mrw4GSlKo8cVB4YaQA/KdvyF3xQh0AYFjxpDjc6YsD4ESyo8cua6A5nrhY2eQf7fccGm\n v4TYcCmrBskByYFjqD0FJEcAHEGnEEtuwu3FZ6XZgQOoktbGYHACI1We3O9aX8HZSjso\n zy4A==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=V4S5VuFuIVM0xDiwmw+bkutu1YZQ0xs0EYeC39TGHVY=;\n b=Tr5Q/L/Dy5mSmYHUMsx5Dpt2D7/Zf08ScozJD0wixfmMSRZhs1Ebt/mjbQ4qkPYBFU\n QyQB1kZ/7CynvBXIBfkkRqphSyXzg9ghK99l/DoF4tfeae7Mw0UnurASo1BiXncf0yab\n WYfFjOQd/PDZD14wX7HX2Mne3BWq/3P5B3Tn4cAtSoNe01fbnJR1nwb2wujooXxe1lbZ\n Z5EEcFl8tQv22mOHjZoEDoggUtB5gVfmmcWVvI3v54nWbPLZbqrgvkP129K3bbuL9jhX\n Em95pSWi50H2u25ZhAnB0cugNdNnjCd/+tXH8nq50OxVWRbRJWu8FfyuGS864Jy+jvn6\n wPuQ==",
        "X-Gm-Message-State": "AOAM532RdT/U7GCBwnDYgYnxLKnvctAQ39+wRjsqoTqY8EPfYIbYXPMb\n hMEz3beRC6Q91whAMiSGy7HCzDFSG8W+yVxD",
        "X-Google-Smtp-Source": "\n ABdhPJyzlWEgTdBoZSMnDSLGqkNDkMhOsHpBo8mrGPnNR1Lu1Z8A9W9StCyW5xFVlzScjg+rlxszrg==",
        "X-Received": "by 2002:a17:906:3e0b:: with SMTP id\n k11mr3953237eji.305.1627036000448;\n Fri, 23 Jul 2021 03:26:40 -0700 (PDT)",
        "From": "Michal Krawczyk <mk@semihalf.com>",
        "To": "dev@dpdk.org",
        "Cc": "ndagan@amazon.com, shaibran@amazon.com, upstream@semihalf.com,\n Michal Krawczyk <mk@semihalf.com>, stable@dpdk.org,\n Shay Agroskin <shayagr@amazon.com>",
        "Date": "Fri, 23 Jul 2021 12:24:51 +0200",
        "Message-Id": "<20210723102454.12206-4-mk@semihalf.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20210723102454.12206-1-mk@semihalf.com>",
        "References": "<20210714104320.4096-1-mk@semihalf.com>\n <20210723102454.12206-1-mk@semihalf.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v4 3/6] net/ena: trigger reset when Tx prepare\n fails",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "If the prepare function failed, then it means the descriptors are in the\ninvalid state.\n\nThis condition now triggers the reset, which should be further handled\nby the application.\n\nTo notify the application about prepare function failure, the error log\nwas added. In general, it should never fail in normal conditions, as the\nTx function checks for the available space in the Tx ring before the\npreparation even starts.\n\nFixes: 2081d5e2e92d (\"net/ena: add reset routine\")\nCc: stable@dpdk.org\n\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\nReviewed-by: Shai Brandes <shaibran@amazon.com>\nReviewed-by: Shay Agroskin <shayagr@amazon.com>\n---\n drivers/net/ena/ena_ethdev.c | 4 ++++\n 1 file changed, 4 insertions(+)",
    "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 2335436b6c..67cd91046a 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -2570,7 +2570,11 @@ static int ena_xmit_mbuf(struct ena_ring *tx_ring, struct rte_mbuf *mbuf)\n \trc = ena_com_prepare_tx(tx_ring->ena_com_io_sq,\t&ena_tx_ctx,\n \t\t&nb_hw_desc);\n \tif (unlikely(rc)) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to prepare Tx buffers, rc: %d\\n\", rc);\n \t\t++tx_ring->tx_stats.prepare_ctx_err;\n+\t\ttx_ring->adapter->reset_reason =\n+\t\t    ENA_REGS_RESET_DRIVER_INVALID_STATE;\n+\t\ttx_ring->adapter->trigger_reset = true;\n \t\treturn rc;\n \t}\n \n",
    "prefixes": [
        "v4",
        "3/6"
    ]
}