Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96254/?format=api
{ "id": 96254, "url": "http://patchwork.dpdk.org/api/patches/96254/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210723131515.2317168-9-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210723131515.2317168-9-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210723131515.2317168-9-andrew.rybchenko@oktetlabs.ru", "date": "2021-07-23T13:15:12", "name": "[v3,08/11] net/sfc: simplify getting of available xstats case", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "856693006677884bd078f2279205541d121231f9", "submitter": { "id": 2013, "url": "http://patchwork.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210723131515.2317168-9-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 17972, "url": "http://patchwork.dpdk.org/api/series/17972/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17972", "date": "2021-07-23T13:15:04", "name": "net/sfc: provide Rx/Tx doorbells stats", "version": 3, "mbox": "http://patchwork.dpdk.org/series/17972/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96254/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96254/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5D62BA0C46;\n\tFri, 23 Jul 2021 15:16:15 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 99A8B410E4;\n\tFri, 23 Jul 2021 15:15:57 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 1B49B41120\n for <dev@dpdk.org>; Fri, 23 Jul 2021 15:15:56 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id DC3167F6D4; Fri, 23 Jul 2021 16:15:55 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id 3069F7F6CB;\n Fri, 23 Jul 2021 16:15:24 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3069F7F6CB", "Authentication-Results": "shelob.oktetlabs.ru/3069F7F6CB; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "David Marchand <david.marchand@redhat.com>,\n Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>", "Date": "Fri, 23 Jul 2021 16:15:12 +0300", "Message-Id": "<20210723131515.2317168-9-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210723131515.2317168-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru>\n <20210723131515.2317168-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 08/11] net/sfc: simplify getting of available\n xstats case", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\n\nThere is no point to recalculate number of available xstats on\neach request. The number is calculated once on device start\nand may be returned on subsequent calls.\n\nSigned-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc_ethdev.c | 16 ++++++++++++++--\n 1 file changed, 14 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex bbc22723f6..f0567a71d0 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -733,6 +733,11 @@ sfc_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,\n \n \tsfc_adapter_lock(sa);\n \n+\tif (unlikely(xstats == NULL)) {\n+\t\tnstats = port->mac_stats_nb_supported;\n+\t\tgoto unlock;\n+\t}\n+\n \trc = sfc_port_update_mac_stats(sa, B_FALSE);\n \tif (rc != 0) {\n \t\tSFC_ASSERT(rc > 0);\n@@ -744,7 +749,7 @@ sfc_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,\n \n \tfor (i = 0; i < EFX_MAC_NSTATS; ++i) {\n \t\tif (EFX_MAC_STAT_SUPPORTED(port->mac_stats_mask, i)) {\n-\t\t\tif (xstats != NULL && nstats < (int)xstats_count) {\n+\t\t\tif (nstats < (int)xstats_count) {\n \t\t\t\txstats[nstats].id = nstats;\n \t\t\t\txstats[nstats].value = mac_stats[i];\n \t\t\t}\n@@ -768,9 +773,16 @@ sfc_xstats_get_names(struct rte_eth_dev *dev,\n \tunsigned int i;\n \tunsigned int nstats = 0;\n \n+\tif (unlikely(xstats_names == NULL)) {\n+\t\tsfc_adapter_lock(sa);\n+\t\tnstats = port->mac_stats_nb_supported;\n+\t\tsfc_adapter_unlock(sa);\n+\t\treturn nstats;\n+\t}\n+\n \tfor (i = 0; i < EFX_MAC_NSTATS; ++i) {\n \t\tif (EFX_MAC_STAT_SUPPORTED(port->mac_stats_mask, i)) {\n-\t\t\tif (xstats_names != NULL && nstats < xstats_count)\n+\t\t\tif (nstats < xstats_count)\n \t\t\t\tstrlcpy(xstats_names[nstats].name,\n \t\t\t\t\tefx_mac_stat_name(sa->nic, i),\n \t\t\t\t\tsizeof(xstats_names[0].name));\n", "prefixes": [ "v3", "08/11" ] }