Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96279/?format=api
{ "id": 96279, "url": "http://patchwork.dpdk.org/api/patches/96279/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1627297180-47307-2-git-send-email-humin29@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1627297180-47307-2-git-send-email-humin29@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1627297180-47307-2-git-send-email-humin29@huawei.com", "date": "2021-07-26T10:59:39", "name": "[v1,1/2] net/hns3: add start/stop Tx datapath request for MP", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d7b9d41da320000389cb3066aa977fb248ec6e48", "submitter": { "id": 1944, "url": "http://patchwork.dpdk.org/api/people/1944/?format=api", "name": "humin (Q)", "email": "humin29@huawei.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1627297180-47307-2-git-send-email-humin29@huawei.com/mbox/", "series": [ { "id": 17989, "url": "http://patchwork.dpdk.org/api/series/17989/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=17989", "date": "2021-07-26T10:59:38", "name": "Features for hns3 PMD", "version": 1, "mbox": "http://patchwork.dpdk.org/series/17989/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96279/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96279/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E15D2A0C47;\n\tMon, 26 Jul 2021 13:00:43 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6D78F410EF;\n\tMon, 26 Jul 2021 13:00:37 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 681B440F35\n for <dev@dpdk.org>; Mon, 26 Jul 2021 13:00:35 +0200 (CEST)", "from dggeme756-chm.china.huawei.com (unknown [172.30.72.56])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GYH1F3RzDz80Sl\n for <dev@dpdk.org>; Mon, 26 Jul 2021 18:56:49 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2176.2; Mon, 26 Jul 2021 19:00:32 +0800" ], "From": "\"Min Hu (Connor)\" <humin29@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@intel.com>, <andrew.rybchenko@oktetlabs.ru>", "Date": "Mon, 26 Jul 2021 18:59:39 +0800", "Message-ID": "<1627297180-47307-2-git-send-email-humin29@huawei.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1627297180-47307-1-git-send-email-humin29@huawei.com>", "References": "<1627297180-47307-1-git-send-email-humin29@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems704-chm.china.huawei.com (10.3.19.181) To\n dggeme756-chm.china.huawei.com (10.3.19.102)", "X-CFilter-Loop": "Reflected", "Subject": "[dpdk-dev] [PATCH v1 1/2] net/hns3: add start/stop Tx datapath\n request for MP", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Huisong Li <lihuisong@huawei.com>\n\nCurrently, hns3 PMD has supported start/stop RxTx datapath request message\nbetween the primary and secondary processes. However, there are some cases\nonly to start/stop Tx datapath. This patch adds start/stop Tx datapath\nrequest for MP.\n\nSigned-off-by: Huisong Li <lihuisong@huawei.com>\nSigned-off-by: Min Hu (Connor) <humin29@huawei.com>\n---\n drivers/net/hns3/hns3_ethdev.h | 4 +++-\n drivers/net/hns3/hns3_mp.c | 50 ++++++++++++++++++++++++++++++++++--------\n drivers/net/hns3/hns3_mp.h | 3 +++\n drivers/net/hns3/hns3_rxtx.c | 4 ++--\n drivers/net/hns3/hns3_rxtx.h | 6 +++++\n 5 files changed, 55 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h\nindex 8e66d9f..2e48ff6 100644\n--- a/drivers/net/hns3/hns3_ethdev.h\n+++ b/drivers/net/hns3/hns3_ethdev.h\n@@ -699,7 +699,9 @@ struct hns3_vtag_cfg {\n /* Request types for IPC. */\n enum hns3_mp_req_type {\n \tHNS3_MP_REQ_START_RXTX = 1,\n-\tHNS3_MP_REQ_STOP_RXTX,\n+\tHNS3_MP_REQ_STOP_RXTX = 2,\n+\tHNS3_MP_REQ_START_TX = 3,\n+\tHNS3_MP_REQ_STOP_TX = 4,\n \tHNS3_MP_REQ_MAX\n };\n \ndiff --git a/drivers/net/hns3/hns3_mp.c b/drivers/net/hns3/hns3_mp.c\nindex a8485f5..cd514ac 100644\n--- a/drivers/net/hns3/hns3_mp.c\n+++ b/drivers/net/hns3/hns3_mp.c\n@@ -73,6 +73,7 @@ mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)\n \tstruct hns3_mp_param *res = (struct hns3_mp_param *)mp_res.param;\n \tconst struct hns3_mp_param *param =\n \t\t(const struct hns3_mp_param *)mp_msg->param;\n+\teth_tx_prep_t prep = NULL;\n \tstruct rte_eth_dev *dev;\n \tint ret;\n \n@@ -87,19 +88,23 @@ mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)\n \t\tPMD_INIT_LOG(INFO, \"port %u starting datapath\",\n \t\t\t dev->data->port_id);\n \t\thns3_set_rxtx_function(dev);\n-\t\trte_mb();\n-\t\tmp_init_msg(dev, &mp_res, param->type);\n-\t\tres->result = 0;\n-\t\tret = rte_mp_reply(&mp_res, peer);\n \t\tbreak;\n \tcase HNS3_MP_REQ_STOP_RXTX:\n \t\tPMD_INIT_LOG(INFO, \"port %u stopping datapath\",\n \t\t\t dev->data->port_id);\n \t\thns3_set_rxtx_function(dev);\n-\t\trte_mb();\n-\t\tmp_init_msg(dev, &mp_res, param->type);\n-\t\tres->result = 0;\n-\t\tret = rte_mp_reply(&mp_res, peer);\n+\t\tbreak;\n+\tcase HNS3_MP_REQ_START_TX:\n+\t\tPMD_INIT_LOG(INFO, \"port %u starting Tx datapath\",\n+\t\t\t dev->data->port_id);\n+\t\tdev->tx_pkt_burst = hns3_get_tx_function(dev, &prep);\n+\t\tdev->tx_pkt_prepare = prep;\n+\t\tbreak;\n+\tcase HNS3_MP_REQ_STOP_TX:\n+\t\tPMD_INIT_LOG(INFO, \"port %u stopping Tx datapath\",\n+\t\t\t dev->data->port_id);\n+\t\tdev->tx_pkt_burst = hns3_dummy_rxtx_burst;\n+\t\tdev->tx_pkt_prepare = NULL;\n \t\tbreak;\n \tdefault:\n \t\trte_errno = EINVAL;\n@@ -107,9 +112,24 @@ mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)\n \t\t\t dev->data->port_id);\n \t\treturn -rte_errno;\n \t}\n+\n+\trte_mb();\n+\tmp_init_msg(dev, &mp_res, param->type);\n+\tres->result = 0;\n+\tret = rte_mp_reply(&mp_res, peer);\n+\n \treturn ret;\n }\n \n+static bool\n+mp_req_type_is_valid(enum hns3_mp_req_type type)\n+{\n+\treturn type == HNS3_MP_REQ_START_RXTX ||\n+\t\ttype == HNS3_MP_REQ_STOP_RXTX ||\n+\t\ttype == HNS3_MP_REQ_START_TX ||\n+\t\ttype == HNS3_MP_REQ_STOP_TX;\n+}\n+\n /*\n * Broadcast request of stopping/starting data-path to secondary processes.\n *\n@@ -132,7 +152,7 @@ mp_req_on_rxtx(struct rte_eth_dev *dev, enum hns3_mp_req_type type)\n \n \tif (rte_eal_process_type() == RTE_PROC_SECONDARY || !hw->secondary_cnt)\n \t\treturn;\n-\tif (type != HNS3_MP_REQ_START_RXTX && type != HNS3_MP_REQ_STOP_RXTX) {\n+\tif (!mp_req_type_is_valid(type)) {\n \t\thns3_err(hw, \"port %u unknown request (req_type %d)\",\n \t\t\t dev->data->port_id, type);\n \t\treturn;\n@@ -189,6 +209,18 @@ void hns3_mp_req_stop_rxtx(struct rte_eth_dev *dev)\n \tmp_req_on_rxtx(dev, HNS3_MP_REQ_STOP_RXTX);\n }\n \n+void\n+hns3_mp_req_stop_tx(struct rte_eth_dev *dev)\n+{\n+\tmp_req_on_rxtx(dev, HNS3_MP_REQ_STOP_TX);\n+}\n+\n+void\n+hns3_mp_req_start_tx(struct rte_eth_dev *dev)\n+{\n+\tmp_req_on_rxtx(dev, HNS3_MP_REQ_START_TX);\n+}\n+\n /*\n * Initialize by primary process.\n */\ndiff --git a/drivers/net/hns3/hns3_mp.h b/drivers/net/hns3/hns3_mp.h\nindex 1a73598..e0e4aea 100644\n--- a/drivers/net/hns3/hns3_mp.h\n+++ b/drivers/net/hns3/hns3_mp.h\n@@ -7,6 +7,9 @@\n \n void hns3_mp_req_start_rxtx(struct rte_eth_dev *dev);\n void hns3_mp_req_stop_rxtx(struct rte_eth_dev *dev);\n+void hns3_mp_req_start_tx(struct rte_eth_dev *dev);\n+void hns3_mp_req_stop_tx(struct rte_eth_dev *dev);\n+\n int hns3_mp_init_primary(void);\n void hns3_mp_uninit_primary(void);\n int hns3_mp_init_secondary(void);\ndiff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex d3fbe08..7d8176f 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -4309,7 +4309,7 @@ hns3_get_tx_prep_needed(struct rte_eth_dev *dev)\n #endif\n }\n \n-static eth_tx_burst_t\n+eth_tx_burst_t\n hns3_get_tx_function(struct rte_eth_dev *dev, eth_tx_prep_t *prep)\n {\n \tstruct hns3_adapter *hns = dev->data->dev_private;\n@@ -4346,7 +4346,7 @@ hns3_get_tx_function(struct rte_eth_dev *dev, eth_tx_prep_t *prep)\n \treturn hns3_xmit_pkts;\n }\n \n-static uint16_t\n+uint16_t\n hns3_dummy_rxtx_burst(void *dpdk_txq __rte_unused,\n \t\t struct rte_mbuf **pkts __rte_unused,\n \t\t uint16_t pkts_n __rte_unused)\ndiff --git a/drivers/net/hns3/hns3_rxtx.h b/drivers/net/hns3/hns3_rxtx.h\nindex 56c1b80..141de7a 100644\n--- a/drivers/net/hns3/hns3_rxtx.h\n+++ b/drivers/net/hns3/hns3_rxtx.h\n@@ -729,6 +729,12 @@ int hns3_tx_burst_mode_get(struct rte_eth_dev *dev,\n const uint32_t *hns3_dev_supported_ptypes_get(struct rte_eth_dev *dev);\n void hns3_init_rx_ptype_tble(struct rte_eth_dev *dev);\n void hns3_set_rxtx_function(struct rte_eth_dev *eth_dev);\n+eth_tx_burst_t hns3_get_tx_function(struct rte_eth_dev *dev,\n+\t\t\t\t eth_tx_prep_t *prep);\n+uint16_t hns3_dummy_rxtx_burst(void *dpdk_txq __rte_unused,\n+\t\t\t struct rte_mbuf **pkts __rte_unused,\n+\t\t\t uint16_t pkts_n __rte_unused);\n+\n uint32_t hns3_get_tqp_intr_reg_offset(uint16_t tqp_intr_id);\n void hns3_set_queue_intr_gl(struct hns3_hw *hw, uint16_t queue_id,\n \t\t\t uint8_t gl_idx, uint16_t gl_value);\n", "prefixes": [ "v1", "1/2" ] }