Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96496/?format=api
{ "id": 96496, "url": "http://patchwork.dpdk.org/api/patches/96496/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210731181327.660296-2-gakhil@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210731181327.660296-2-gakhil@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210731181327.660296-2-gakhil@marvell.com", "date": "2021-07-31T18:13:24", "name": "[1/4] cryptodev: remove LIST_END enumerators", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8bbe65cf7edb041eb77077cb129ca49ca296e1c8", "submitter": { "id": 2094, "url": "http://patchwork.dpdk.org/api/people/2094/?format=api", "name": "Akhil Goyal", "email": "gakhil@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210731181327.660296-2-gakhil@marvell.com/mbox/", "series": [ { "id": 18117, "url": "http://patchwork.dpdk.org/api/series/18117/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18117", "date": "2021-07-31T18:13:23", "name": "cryptodev and security ABI improvements", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18117/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96496/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96496/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C2290A0547;\n\tSat, 31 Jul 2021 20:13:48 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A322840DDC;\n\tSat, 31 Jul 2021 20:13:48 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 6B61840042\n for <dev@dpdk.org>; Sat, 31 Jul 2021 20:13:47 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 16VIAw6f020553; Sat, 31 Jul 2021 11:13:42 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 3a53vr8xff-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Sat, 31 Jul 2021 11:13:41 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Sat, 31 Jul 2021 11:13:40 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Sat, 31 Jul 2021 11:13:40 -0700", "from localhost.localdomain (unknown [10.28.36.185])\n by maili.marvell.com (Postfix) with ESMTP id 650B33F7075;\n Sat, 31 Jul 2021 11:13:36 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=8mbGemHZVbTCrdSW9yDiBKV3EN+FiKf08Z0FbsXEIrc=;\n b=IQoP5HOdQLfI8hN4q4MrJkxhANcTSgr6cXaR6v24Dv2kU7WEm1XmZNZU57GXVhPfpidD\n vmUjgwkrtUyQJJuKKHqyx6HPTCYFI0jU5nxIvPi5vQ/Ql42ni6SS5ZsS/4+twqk46tRT\n HL0R+9zKEZ+USvdj5XjVKI+JlFfrSpfESCyiLFFaR3Z4wHyeY2qk+IABShg0uz9bdfha\n BGhKotPwk0wc1Hlce4QeBIuZjmtDwvYGtK7qdLjGFXbyN3zmrqUAfWH3p7xX64EbFTc5\n 2hcp33eZrh5/GZJI0PmW3/yUn200XhROdj8kgET/mSFhZTspARW+F3Jh20B5nrmUVVeB jQ==", "From": "Akhil Goyal <gakhil@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<thomas@monjalon.net>, <david.marchand@redhat.com>,\n <hemant.agrawal@nxp.com>, <anoobj@marvell.com>,\n <pablo.de.lara.guarch@intel.com>, <fiona.trahe@intel.com>,\n <declan.doherty@intel.com>, <matan@nvidia.com>, <g.singh@nxp.com>,\n <roy.fan.zhang@intel.com>, <jianjay.zhou@huawei.com>,\n <asomalap@amd.com>, <ruifeng.wang@arm.com>,\n Akhil Goyal <gakhil@marvell.com>", "Date": "Sat, 31 Jul 2021 23:43:24 +0530", "Message-ID": "<20210731181327.660296-2-gakhil@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210731181327.660296-1-gakhil@marvell.com>", "References": "<20210731181327.660296-1-gakhil@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "DJVVYveV531IRvt-TYn3rUrnV9bhbppp", "X-Proofpoint-GUID": "DJVVYveV531IRvt-TYn3rUrnV9bhbppp", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790\n definitions=2021-07-31_05:2021-07-30,\n 2021-07-31 signatures=0", "Subject": "[dpdk-dev] [PATCH 1/4] cryptodev: remove LIST_END enumerators", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Remove *_LIST_END enumerators from asymmetric crypto\nlib to avoid ABI breakage for every new addition in\nenums.\n\nSigned-off-by: Akhil Goyal <gakhil@marvell.com>\n---\n app/test/test_cryptodev_asym.c | 4 ++--\n drivers/crypto/qat/qat_asym.c | 2 +-\n lib/cryptodev/rte_crypto_asym.h | 4 ----\n 3 files changed, 3 insertions(+), 7 deletions(-)", "diff": "diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c\nindex 847b074a4f..afa0e91a45 100644\n--- a/app/test/test_cryptodev_asym.c\n+++ b/app/test/test_cryptodev_asym.c\n@@ -542,7 +542,7 @@ test_one_case(const void *test_case, int sessionless)\n \t\tprintf(\" %u) TestCase %s %s\\n\", test_index++,\n \t\t\ttc.modex.description, test_msg);\n \t} else {\n-\t\tfor (i = 0; i < RTE_CRYPTO_ASYM_OP_LIST_END; i++) {\n+\t\tfor (i = 0; i <= RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE; i++) {\n \t\t\tif (tc.modex.xform_type == RTE_CRYPTO_ASYM_XFORM_RSA) {\n \t\t\t\tif (tc.rsa_data.op_type_flags & (1 << i)) {\n \t\t\t\t\tif (tc.rsa_data.key_exp) {\n@@ -1028,7 +1028,7 @@ static inline void print_asym_capa(\n \t\t\trte_crypto_asym_xform_strings[capa->xform_type]);\n \tprintf(\"operation supported -\");\n \n-\tfor (i = 0; i < RTE_CRYPTO_ASYM_OP_LIST_END; i++) {\n+\tfor (i = 0; i <= RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE; i++) {\n \t\t/* check supported operations */\n \t\tif (rte_cryptodev_asym_xform_capability_check_optype(capa, i))\n \t\t\tprintf(\" %s\",\ndiff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c\nindex 85973812a8..026625a4d2 100644\n--- a/drivers/crypto/qat/qat_asym.c\n+++ b/drivers/crypto/qat/qat_asym.c\n@@ -742,7 +742,7 @@ qat_asym_session_configure(struct rte_cryptodev *dev,\n \t\t\terr = -EINVAL;\n \t\t\tgoto error;\n \t\t}\n-\t} else if (xform->xform_type >= RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END\n+\t} else if (xform->xform_type > RTE_CRYPTO_ASYM_XFORM_ECPM\n \t\t\t|| xform->xform_type <= RTE_CRYPTO_ASYM_XFORM_NONE) {\n \t\tQAT_LOG(ERR, \"Invalid asymmetric crypto xform\");\n \t\terr = -EINVAL;\ndiff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h\nindex 9c866f553f..5edf658572 100644\n--- a/lib/cryptodev/rte_crypto_asym.h\n+++ b/lib/cryptodev/rte_crypto_asym.h\n@@ -94,8 +94,6 @@ enum rte_crypto_asym_xform_type {\n \t */\n \tRTE_CRYPTO_ASYM_XFORM_ECPM,\n \t/**< Elliptic Curve Point Multiplication */\n-\tRTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END\n-\t/**< End of list */\n };\n \n /**\n@@ -116,7 +114,6 @@ enum rte_crypto_asym_op_type {\n \t/**< DH Public Key generation operation */\n \tRTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE,\n \t/**< DH Shared Secret compute operation */\n-\tRTE_CRYPTO_ASYM_OP_LIST_END\n };\n \n /**\n@@ -133,7 +130,6 @@ enum rte_crypto_rsa_padding_type {\n \t/**< RSA PKCS#1 OAEP padding scheme */\n \tRTE_CRYPTO_RSA_PADDING_PSS,\n \t/**< RSA PKCS#1 PSS padding scheme */\n-\tRTE_CRYPTO_RSA_PADDING_TYPE_LIST_END\n };\n \n /**\n", "prefixes": [ "1/4" ] }