Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96518/?format=api
{ "id": 96518, "url": "http://patchwork.dpdk.org/api/patches/96518/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210802101847.3462-3-joyce.kong@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210802101847.3462-3-joyce.kong@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210802101847.3462-3-joyce.kong@arm.com", "date": "2021-08-02T10:18:37", "name": "[v1,02/12] test/ring_perf: use compiler atomic builtins for lcores sync", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "083496edcc9d286032e63f43a23635a8a0460b4f", "submitter": { "id": 970, "url": "http://patchwork.dpdk.org/api/people/970/?format=api", "name": "Joyce Kong", "email": "joyce.kong@arm.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210802101847.3462-3-joyce.kong@arm.com/mbox/", "series": [ { "id": 18128, "url": "http://patchwork.dpdk.org/api/series/18128/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18128", "date": "2021-08-02T10:18:35", "name": "use compiler atomic builtins for app", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18128/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96518/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96518/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5C884A0C41;\n\tMon, 2 Aug 2021 12:20:09 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4C69E41136;\n\tMon, 2 Aug 2021 12:20:09 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id A051B40140\n for <dev@dpdk.org>; Mon, 2 Aug 2021 12:20:08 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2A0A5D6E;\n Mon, 2 Aug 2021 03:20:08 -0700 (PDT)", "from net-arm-n1sdp.shanghai.arm.com (net-arm-n1sdp.shanghai.arm.com\n [10.169.208.222])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 700043F70D;\n Mon, 2 Aug 2021 03:20:01 -0700 (PDT)" ], "From": "Joyce Kong <joyce.kong@arm.com>", "To": "thomas@monjalon.net, david.marchand@redhat.com,\n honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com,\n konstantin.ananyev@intel.com, rsanford@akamai.com,\n erik.g.carrillo@intel.com, olivier.matz@6wind.com, yipeng1.wang@intel.com,\n sameh.gobriel@intel.com, bruce.richardson@intel.com,\n vladimir.medvedkin@intel.com, anatoly.burakov@intel.com,\n andrew.rybchenko@oktetlabs.ru, jerinj@marvell.com,\n declan.doherty@intel.com, ciara.power@intel.com, xiaoyun.li@intel.com,\n nicolas.chautru@intel.com, maryam.tahhan@intel.com,\n reshma.pattan@intel.com, cristian.dumitrescu@intel.com", "Cc": "dev@dpdk.org,\n\tnd@arm.com", "Date": "Mon, 2 Aug 2021 05:18:37 -0500", "Message-Id": "<20210802101847.3462-3-joyce.kong@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210802101847.3462-1-joyce.kong@arm.com>", "References": "<20210802101847.3462-1-joyce.kong@arm.com>", "Subject": "[dpdk-dev] [PATCH v1 02/12] test/ring_perf: use compiler atomic\n builtins for lcores sync", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Convert rte_atomic usages to compiler atomic built-ins\nfor lcores sync in ring_perf test cases.\n\nSigned-off-by: Joyce Kong <joyce.kong@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n app/test/test_ring_perf.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c\nindex fd82e20412..2d8bb675a3 100644\n--- a/app/test/test_ring_perf.c\n+++ b/app/test/test_ring_perf.c\n@@ -320,7 +320,7 @@ run_on_core_pair(struct lcore_pair *cores, struct rte_ring *r, const int esize)\n \treturn 0;\n }\n \n-static rte_atomic32_t synchro;\n+static uint32_t synchro;\n static uint64_t queue_count[RTE_MAX_LCORE];\n \n #define TIME_MS 100\n@@ -342,8 +342,7 @@ load_loop_fn_helper(struct thread_params *p, const int esize)\n \n \t/* wait synchro for workers */\n \tif (lcore != rte_get_main_lcore())\n-\t\twhile (rte_atomic32_read(&synchro) == 0)\n-\t\t\trte_pause();\n+\t\trte_wait_until_equal_32(&synchro, 1, __ATOMIC_RELAXED);\n \n \tbegin = rte_get_timer_cycles();\n \twhile (time_diff < hz * TIME_MS / 1000) {\n@@ -398,12 +397,12 @@ run_on_all_cores(struct rte_ring *r, const int esize)\n \t\tparam.r = r;\n \n \t\t/* clear synchro and start workers */\n-\t\trte_atomic32_set(&synchro, 0);\n+\t\t__atomic_store_n(&synchro, 0, __ATOMIC_RELAXED);\n \t\tif (rte_eal_mp_remote_launch(lcore_f, ¶m, SKIP_MAIN) < 0)\n \t\t\treturn -1;\n \n \t\t/* start synchro and launch test on main */\n-\t\trte_atomic32_set(&synchro, 1);\n+\t\t__atomic_store_n(&synchro, 1, __ATOMIC_RELAXED);\n \t\tlcore_f(¶m);\n \n \t\trte_eal_mp_wait_lcore();\n", "prefixes": [ "v1", "02/12" ] }