Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 96560,
    "url": "http://patchwork.dpdk.org/api/patches/96560/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1627925546-29982-8-git-send-email-navasile@linux.microsoft.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1627925546-29982-8-git-send-email-navasile@linux.microsoft.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1627925546-29982-8-git-send-email-navasile@linux.microsoft.com",
    "date": "2021-08-02T17:32:23",
    "name": "[v12,07/10] eal: implement functions for mutex management",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "5cec4cdca865dabb49c4169f27ed09b3e1cac690",
    "submitter": {
        "id": 1668,
        "url": "http://patchwork.dpdk.org/api/people/1668/?format=api",
        "name": "Narcisa Ana Maria Vasile",
        "email": "navasile@linux.microsoft.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1627925546-29982-8-git-send-email-navasile@linux.microsoft.com/mbox/",
    "series": [
        {
            "id": 18146,
            "url": "http://patchwork.dpdk.org/api/series/18146/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18146",
            "date": "2021-08-02T17:32:16",
            "name": "eal: Add EAL API for threading",
            "version": 12,
            "mbox": "http://patchwork.dpdk.org/series/18146/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/96560/comments/",
    "check": "warning",
    "checks": "http://patchwork.dpdk.org/api/patches/96560/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5B8AFA0C41;\n\tMon,  2 Aug 2021 19:33:24 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 16B74411AA;\n\tMon,  2 Aug 2021 19:32:43 +0200 (CEST)",
            "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 7FA3F41178\n for <dev@dpdk.org>; Mon,  2 Aug 2021 19:32:32 +0200 (CEST)",
            "by linux.microsoft.com (Postfix, from userid 1059)\n id 45D1620B36F4; Mon,  2 Aug 2021 10:32:31 -0700 (PDT)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 45D1620B36F4",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1627925551;\n bh=NYhOGcODzwpc4td2qryoZNmEL57zhuuK3mKCpPNyP7s=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=f36swojBDWZvUWdLMaEG3tmvAgC/q2UskJAxpXAfIPoEFOsanAKL/28Yn5REmld8C\n V6gskwwgcDOWLj6hzqly2bym3Ys/juajegKXVhEJqs2u7cv1CQSFZkH+4OyVD2BXIt\n CgZdRldmO/DKPPt2bfbUft6tvwpegh9FBV8EUgTI=",
        "From": "Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>",
        "To": "dev@dpdk.org, thomas@monjalon.net, dmitry.kozliuk@gmail.com,\n khot@microsoft.com, navasile@microsoft.com, dmitrym@microsoft.com,\n roretzla@microsoft.com, talshn@nvidia.com, ocardona@microsoft.com",
        "Cc": "bruce.richardson@intel.com, david.marchand@redhat.com,\n pallavi.kadam@intel.com",
        "Date": "Mon,  2 Aug 2021 10:32:23 -0700",
        "Message-Id": "<1627925546-29982-8-git-send-email-navasile@linux.microsoft.com>",
        "X-Mailer": "git-send-email 1.8.3.1",
        "In-Reply-To": "<1627925546-29982-1-git-send-email-navasile@linux.microsoft.com>",
        "References": "<1627684312-28630-1-git-send-email-navasile@linux.microsoft.com>\n <1627925546-29982-1-git-send-email-navasile@linux.microsoft.com>",
        "Subject": "[dpdk-dev] [PATCH v12 07/10] eal: implement functions for mutex\n management",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Narcisa Vasile <navasile@microsoft.com>\n\nAdd functions for mutex init, destroy, lock, unlock.\n\nAdd RTE_STATIC_MUTEX macro to replace static initialization\nof mutexes.\nWindows does not have a static initializer.\nInitialization is only done through InitializeCriticalSection().\n\nThe RTE_STATIC_MUTEX calls into the rte_thread_mutex_init()\nfunction that performs the actual mutex initialization.\n\nSigned-off-by: Narcisa Vasile <navasile@microsoft.com>\n---\n lib/eal/common/rte_thread.c  | 61 +++++++++++++++++++++++\n lib/eal/include/rte_thread.h | 94 ++++++++++++++++++++++++++++++++++++\n lib/eal/version.map          |  4 ++\n lib/eal/windows/rte_thread.c | 53 ++++++++++++++++++++\n 4 files changed, 212 insertions(+)",
    "diff": "diff --git a/lib/eal/common/rte_thread.c b/lib/eal/common/rte_thread.c\nindex a0a51bc190..ebae4a8af1 100644\n--- a/lib/eal/common/rte_thread.c\n+++ b/lib/eal/common/rte_thread.c\n@@ -251,6 +251,67 @@ rte_thread_detach(rte_thread_t thread_id)\n \treturn pthread_detach((pthread_t)thread_id.opaque_id);\n }\n \n+int\n+rte_thread_mutex_init(rte_thread_mutex *mutex)\n+{\n+\tint ret = 0;\n+\tpthread_mutex_t *m = NULL;\n+\n+\tRTE_VERIFY(mutex != NULL);\n+\n+\tm = calloc(1, sizeof(*m));\n+\tif (m == NULL) {\n+\t\tRTE_LOG(DEBUG, EAL, \"Unable to initialize mutex. Insufficient memory!\\n\");\n+\t\tret = ENOMEM;\n+\t\tgoto cleanup;\n+\t}\n+\n+\tret = pthread_mutex_init(m, NULL);\n+\tif (ret != 0) {\n+\t\tRTE_LOG(DEBUG, EAL, \"Failed to init mutex. ret = %d\\n\", ret);\n+\t\tgoto cleanup;\n+\t}\n+\n+\tmutex->mutex_id = m;\n+\tm = NULL;\n+\n+cleanup:\n+\tfree(m);\n+\treturn ret;\n+}\n+\n+int\n+rte_thread_mutex_lock(rte_thread_mutex *mutex)\n+{\n+\tRTE_VERIFY(mutex != NULL);\n+\n+\treturn pthread_mutex_lock((pthread_mutex_t *)mutex->mutex_id);\n+}\n+\n+int\n+rte_thread_mutex_unlock(rte_thread_mutex *mutex)\n+{\n+\tRTE_VERIFY(mutex != NULL);\n+\n+\treturn pthread_mutex_unlock((pthread_mutex_t *)mutex->mutex_id);\n+}\n+\n+int\n+rte_thread_mutex_destroy(rte_thread_mutex *mutex)\n+{\n+\tint ret = 0;\n+\tRTE_VERIFY(mutex != NULL);\n+\n+\tret = pthread_mutex_destroy((pthread_mutex_t *)mutex->mutex_id);\n+\tif (ret != 0)\n+\t\tRTE_LOG(DEBUG, EAL, \"Unable to destroy mutex, ret = %d\\n\", ret);\n+\n+\tfree(mutex->mutex_id);\n+\tmutex->mutex_id = NULL;\n+\n+\treturn ret;\n+}\n+\n int\n rte_thread_key_create(rte_thread_key *key, void (*destructor)(void *))\n {\ndiff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h\nindex 098c3ba343..7e813b573d 100644\n--- a/lib/eal/include/rte_thread.h\n+++ b/lib/eal/include/rte_thread.h\n@@ -56,6 +56,26 @@ typedef struct {\n \n #endif /* RTE_HAS_CPUSET */\n \n+#define RTE_DECLARE_MUTEX(private_lock)          rte_thread_mutex private_lock\n+\n+#define RTE_DEFINE_MUTEX(private_lock)\\\n+RTE_INIT(__rte_ ## private_lock ## _init)\\\n+{\\\n+\tRTE_VERIFY(rte_thread_mutex_init(&private_lock) == 0);\\\n+}\n+\n+#define RTE_STATIC_MUTEX(private_lock)\\\n+static RTE_DECLARE_MUTEX(private_lock);\\\n+RTE_DEFINE_MUTEX(private_lock)\n+\n+\n+/**\n+ * Thread mutex representation.\n+ */\n+typedef struct rte_thread_mutex_tag {\n+\tvoid *mutex_id;  /**< mutex identifier */\n+} rte_thread_mutex;\n+\n /**\n  * TLS key type, an opaque pointer.\n  */\n@@ -268,6 +288,28 @@ int rte_thread_join(rte_thread_t thread_id, unsigned long *value_ptr);\n __rte_experimental\n int rte_thread_detach(rte_thread_t thread_id);\n \n+/**\n+ * Set core affinity of the current thread.\n+ * Support both EAL and non-EAL thread and update TLS.\n+ *\n+ * @param cpusetp\n+ *   Pointer to CPU affinity to set.\n+ *\n+ * @return\n+ *   On success, return 0; otherwise return -1;\n+ */\n+int rte_thread_set_affinity(rte_cpuset_t *cpusetp);\n+\n+/**\n+ * Get core affinity of the current thread.\n+ *\n+ * @param cpusetp\n+ *   Pointer to CPU affinity of current thread.\n+ *   It presumes input is not NULL, otherwise it causes panic.\n+ *\n+ */\n+void rte_thread_get_affinity(rte_cpuset_t *cpusetp);\n+\n #endif /* RTE_HAS_CPUSET */\n \n /**\n@@ -287,6 +329,58 @@ __rte_experimental\n int rte_thread_set_priority(rte_thread_t thread_id,\n \t\tenum rte_thread_priority priority);\n \n+/**\n+ * Initializes a mutex.\n+ *\n+ * @param mutex\n+ *    The mutex to be initialized.\n+ *\n+ * @return\n+ *   On success, return 0.\n+ *   On failure, return a positive errno-style error number.\n+ */\n+__rte_experimental\n+int rte_thread_mutex_init(rte_thread_mutex *mutex);\n+\n+/**\n+ * Locks a mutex.\n+ *\n+ * @param mutex\n+ *    The mutex to be locked.\n+ *\n+ * @return\n+ *   On success, return 0.\n+ *   On failure, return a positive errno-style error number.\n+ */\n+__rte_experimental\n+int rte_thread_mutex_lock(rte_thread_mutex *mutex);\n+\n+/**\n+ * Unlocks a mutex.\n+ *\n+ * @param mutex\n+ *    The mutex to be unlocked.\n+ *\n+ * @return\n+ *   On success, return 0.\n+ *   On failure, return a positive errno-style error number.\n+ */\n+__rte_experimental\n+int rte_thread_mutex_unlock(rte_thread_mutex *mutex);\n+\n+/**\n+ * Releases all resources associated with a mutex.\n+ *\n+ * @param mutex\n+ *    The mutex to be uninitialized.\n+ *\n+ * @return\n+ *   On success, return 0.\n+ *   On failure, return a positive errno-style error number.\n+ */\n+__rte_experimental\n+int rte_thread_mutex_destroy(rte_thread_mutex *mutex);\n+\n /**\n  * Create a TLS data key visible to all threads in the process.\n  * the created key is later used to get/set a value.\ndiff --git a/lib/eal/version.map b/lib/eal/version.map\nindex 02994dd3fb..a1c7a8e87d 100644\n--- a/lib/eal/version.map\n+++ b/lib/eal/version.map\n@@ -439,6 +439,10 @@ EXPERIMENTAL {\n \trte_thread_create;\n \trte_thread_join;\n \trte_thread_detach;\n+\trte_thread_mutex_init;\n+\trte_thread_mutex_lock;\n+\trte_thread_mutex_unlock;\n+\trte_thread_mutex_destroy;\n };\n \n INTERNAL {\ndiff --git a/lib/eal/windows/rte_thread.c b/lib/eal/windows/rte_thread.c\nindex e5e420fadd..23f00cfba2 100644\n--- a/lib/eal/windows/rte_thread.c\n+++ b/lib/eal/windows/rte_thread.c\n@@ -447,6 +447,59 @@ rte_thread_detach(rte_thread_t thread_id)\n \treturn 0;\n }\n \n+int\n+rte_thread_mutex_init(rte_thread_mutex *mutex)\n+{\n+\tint ret = 0;\n+\tCRITICAL_SECTION *m = NULL;\n+\n+\tRTE_VERIFY(mutex != NULL);\n+\n+\tm = calloc(1, sizeof(*m));\n+\tif (m == NULL) {\n+\t\tRTE_LOG(DEBUG, EAL, \"Unable to initialize mutex. Insufficient memory!\\n\");\n+\t\tret = ENOMEM;\n+\t\tgoto cleanup;\n+\t}\n+\n+\tInitializeCriticalSection(m);\n+\tmutex->mutex_id = m;\n+\tm = NULL;\n+\n+cleanup:\n+\treturn ret;\n+}\n+\n+int\n+rte_thread_mutex_lock(rte_thread_mutex *mutex)\n+{\n+\tRTE_VERIFY(mutex != NULL);\n+\n+\tEnterCriticalSection(mutex->mutex_id);\n+\treturn 0;\n+}\n+\n+int\n+rte_thread_mutex_unlock(rte_thread_mutex *mutex)\n+{\n+\tRTE_VERIFY(mutex != NULL);\n+\n+\tLeaveCriticalSection(mutex->mutex_id);\n+\treturn 0;\n+}\n+\n+int\n+rte_thread_mutex_destroy(rte_thread_mutex *mutex)\n+{\n+\tRTE_VERIFY(mutex != NULL);\n+\n+\tDeleteCriticalSection(mutex->mutex_id);\n+\tfree(mutex->mutex_id);\n+\tmutex->mutex_id = NULL;\n+\n+\treturn 0;\n+}\n+\n int\n rte_thread_key_create(rte_thread_key *key,\n \t\t__rte_unused void (*destructor)(void *))\n",
    "prefixes": [
        "v12",
        "07/10"
    ]
}