Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96655/?format=api
{ "id": 96655, "url": "http://patchwork.dpdk.org/api/patches/96655/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210804072647.2077832-2-shunh@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210804072647.2077832-2-shunh@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210804072647.2077832-2-shunh@nvidia.com", "date": "2021-08-04T07:26:46", "name": "[v1,1/2] net/mlx5: fix meter flow counter traslation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d6a569151c9cd12587550dd331428a8517a01b0d", "submitter": { "id": 2212, "url": "http://patchwork.dpdk.org/api/people/2212/?format=api", "name": "Shun Hao", "email": "shunh@nvidia.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210804072647.2077832-2-shunh@nvidia.com/mbox/", "series": [ { "id": 18181, "url": "http://patchwork.dpdk.org/api/series/18181/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18181", "date": "2021-08-04T07:26:45", "name": "Fix Meter Hierarchy related issues", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18181/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96655/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96655/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0D986A0C45;\n\tWed, 4 Aug 2021 09:27:41 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E09E841211;\n\tWed, 4 Aug 2021 09:27:40 +0200 (CEST)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2067.outbound.protection.outlook.com [40.107.237.67])\n by mails.dpdk.org (Postfix) with ESMTP id 557EB4014F;\n Wed, 4 Aug 2021 09:27:39 +0200 (CEST)", "from DM6PR02CA0041.namprd02.prod.outlook.com (2603:10b6:5:177::18)\n by BYAPR12MB4743.namprd12.prod.outlook.com (2603:10b6:a03:a5::26) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.26; Wed, 4 Aug\n 2021 07:27:37 +0000", "from DM6NAM11FT056.eop-nam11.prod.protection.outlook.com\n (2603:10b6:5:177:cafe::20) by DM6PR02CA0041.outlook.office365.com\n (2603:10b6:5:177::18) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend\n Transport; Wed, 4 Aug 2021 07:27:37 +0000", "from mail.nvidia.com (216.228.112.32) by\n DM6NAM11FT056.mail.protection.outlook.com (10.13.173.99) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4373.18 via Frontend Transport; Wed, 4 Aug 2021 07:27:37 +0000", "from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL109.nvidia.com\n (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 4 Aug\n 2021 00:27:36 -0700", "from nvidia.com (172.20.187.5) by DRHQMAIL107.nvidia.com\n (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 4 Aug 2021\n 07:27:34 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=BjbAZ0Sf2fyz5sdV/FnR1oyzH+LlNzqyO+g+pXNApeWyuM7G6NtSI7vCE+zFHfrnn6NEqxZww3tkIZfz0kPfQ+4DRGT/eqYy3hb6mH2FGzF1sTvzaxpKsAuuHblmDr+SpfBVyUI1n+t3PQvKDBBBO7eckifOJplZ7ts/vmOmM4pBY4XhTXgDiObqOqSdPE7XDl5Yb5SXyDqwGz2gyiNoKOvyfCI2SoiT/Sb/vPWDOKBGJqv8U/pnH1dLeCq38exV3+2JqzLi6/PzHjro/iU/TcKtMXZWN3GU6d29u8rTrwFWq8KnpMtkqOuK6svr+CKbHyghe9K0d5fP1qL20OolvQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=UMGCg/eYZlYkfHi55FxQ3o9n+qmLbqMal3JAPhn8PWk=;\n b=kKHA8Y3f8RA4fXjVjWLxYVnKoAeXbpFv7X/E1D2m/rEJxuZ55wMNrOrcXHNchfezSnmqE2E7+NuqL+gFolaYyHdYkiPpq/463t7d2Yqwwou8IMthRaC/2wFlqRMU/8ziOT2HBIAiL9CZXJnQ/65mO2lzI6xrpoeO5B+OuJZ+EG5QwtVLE4/sh4d+ybnvK8VUgF09wXx8MEx1awGGF/8M1euIffUXPXk8WucvscMBgPwVK9hcxdwqnUlhtOd+3FyB1/qPxYFPVcc82WYM1XxQdz8wryy024uuVGBn3sQ77w0wvJTHP/OHw7mXBoox0kLekd4/Ntf+WQVmCrpC21r6ww==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.32) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=UMGCg/eYZlYkfHi55FxQ3o9n+qmLbqMal3JAPhn8PWk=;\n b=gLVpdTGQMPDuEvRbDVimOK83xxtvUjWA76hhk9V9HqQrEJWXr4KRwvzWNCW7WFW1OkSgGLtz0YBWGyWlptVLvh5I9f6CcQP/HXbyCbLmmtK2hInJfahvTJU+E7mfsY/2Yf3EBdqY4/R8UsnQ+3VkzHm2YsJN2e7B8WLT2OGb/sjvA41i4ZtG37KY4W/jY3nZ5v7R76eU+rYR9p+7SkcMyTE5YfMwYMThzMj7wYBbGFnILKN1SvRhOi7sCBztnqeYH3B8XqRx8FZaQWpq7Tvkk8gkXoBzSWVnUyCehzr3gxFrMkrehV0Uz8k2L3/N2LeMZ2r/kxbbLPNOucwdJ3Ji1g==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.32)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.32 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.32; helo=mail.nvidia.com;", "From": "Shun Hao <shunh@nvidia.com>", "To": "<orika@nvidia.com>, <viacheslavo@nvidia.com>, <matan@nvidia.com>, \"Shahaf\n Shuler\" <shahafs@nvidia.com>, Michael Baum <michaelba@nvidia.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <rasland@nvidia.com>,\n <stable@dpdk.org>", "Date": "Wed, 4 Aug 2021 10:26:46 +0300", "Message-ID": "<20210804072647.2077832-2-shunh@nvidia.com>", "X-Mailer": "git-send-email 2.20.0", "In-Reply-To": "<20210804072647.2077832-1-shunh@nvidia.com>", "References": "<20210804072647.2077832-1-shunh@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL101.nvidia.com (172.20.187.10) To\n DRHQMAIL107.nvidia.com (10.27.9.16)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "7cc9529c-c687-48ad-1624-08d9571955fb", "X-MS-TrafficTypeDiagnostic": "BYAPR12MB4743:", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <BYAPR12MB47437D50859DF2AAC39230C5C0F19@BYAPR12MB4743.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:8273;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n DBBGdd5Z+tLxMu9f9IJcjgmn/cW6aw6QHDEXMRdn3C3YGUW4gXOZPfHQCtMobz2tkhr+7fh/0EJ7YwXJUJ0lkIKxhzy3r6pZex/NlQJcsttt5JRAoHGhz5TFV1OOTHWcq2gH2C7QMNqbSh7JtwZkDC9oaI3UiFqcdjbhYq2wM3HL5qSBp6WU3IOLkhh5MT+qJO1v6BEEDid8/XusqpllS2SnuwPXHKDzYCvVB1lz5xHi6zWdTN3t/Wi5PihcxA0iFTjCl7aw7rf1eYpbq/Fc383xf5phEgycwKtcUfE16um6oNhTDTZ9tY39rpzjwoAeVNd6gRBU+xHxWDOyxl4oBRQBpwqwXKXgJKov8fRcsvnHlgMk6hwa4fR6VAeeClyzc2yoWEov7Q3XE8WATjj1S+Zfs47qGqYMA8CwFzCvyqHsaALMO6DGeMnr+glJlhcdLXUtkzE1VkM9Bwb7GRVDqUk6gsSzUQ6o9xvnFahWEi1AZq/Q5hofhRs5rDnzm0mJa+Bq5X+UNVQ/v03pPbWma/e4qYEAa/0QpSKOH33z2zUYT4XoRIlBM3Tw5ZVPIStSUZAtSyWzCPSA7cAjX+qwXeMcYgciUubXWjgL+bQI96we7abXfmTBE1W5ZV4Nw7KpPrsxfZ7DG/XPb5g62W66dQYcHggCJXveiMOvQ2F2lpajaQ4CKRR+EBG6m0wUgryWAHWOAD+bJcf2yvLJTN7zBQ==", "X-Forefront-Antispam-Report": "CIP:216.228.112.32; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid01.nvidia.com; CAT:NONE;\n SFS:(4636009)(39860400002)(396003)(136003)(376002)(346002)(36840700001)(46966006)(5660300002)(36860700001)(336012)(2616005)(316002)(1076003)(36756003)(426003)(7636003)(110136005)(82740400003)(478600001)(356005)(8676002)(6666004)(6286002)(54906003)(6636002)(26005)(186003)(16526019)(70586007)(2906002)(86362001)(8936002)(70206006)(7696005)(82310400003)(83380400001)(4326008)(55016002)(47076005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 Aug 2021 07:27:37.6833 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 7cc9529c-c687-48ad-1624-08d9571955fb", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.32];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT056.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BYAPR12MB4743", "Subject": "[dpdk-dev] [PATCH v1 1/2] net/mlx5: fix meter flow counter\n traslation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When an RTE flow uses a meter without any modify packet action,\nthere will be an internal drop flow with meter counter created,\nmatching the same 5-tuple as the original flow.\n\nIn this case, the meter flow count action is wrongly reused as the\noriginal flow counter, leading to wrong flow statistics.\n\nAdd a check in the count action translation to detect the meter case\nand use the meter drop dedicated counter in the meter 5-tuple flow\nonly.\n\nFixes: f3191849f2c2 (\"net/mlx5: support flow count action handle\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shun Hao <shunh@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 27 ++++++++++++++++++++-------\n 1 file changed, 20 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 4644ae46bd..f54440c6f5 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -12824,13 +12824,26 @@ flow_dv_translate(struct rte_eth_dev *dev,\n \t\t\taction_flags |= MLX5_FLOW_ACTION_AGE;\n \t\t\tbreak;\n \t\tcase MLX5_RTE_FLOW_ACTION_TYPE_COUNT:\n-\t\t\tflow->counter = (uint32_t)(uintptr_t)(action->conf);\n-\t\t\tcnt_act = flow_dv_counter_get_by_idx(dev, flow->counter,\n-\t\t\t\t\t\t\t NULL);\n-\t\t\t__atomic_fetch_add(&cnt_act->shared_info.refcnt, 1,\n-\t\t\t\t\t __ATOMIC_RELAXED);\n-\t\t\t/* Save information first, will apply later. */\n-\t\t\taction_flags |= MLX5_FLOW_ACTION_COUNT;\n+\t\t\tcnt_act = flow_dv_counter_get_by_idx(dev,\n+\t\t\t\t\t(uint32_t)(uintptr_t)action->conf,\n+\t\t\t\t\tNULL);\n+\t\t\tMLX5_ASSERT(cnt_act != NULL);\n+\t\t\t/**\n+\t\t\t * When creating meter drop flow in drop table, the\n+\t\t\t * counter should not overwrite the rte flow counter.\n+\t\t\t */\n+\t\t\tif (attr->group == MLX5_FLOW_TABLE_LEVEL_METER &&\n+\t\t\t dev_flow->dv.table_id == MLX5_MTR_TABLE_ID_DROP) {\n+\t\t\t\tdev_flow->dv.actions[actions_n++] =\n+\t\t\t\t\t\t\tcnt_act->action;\n+\t\t\t} else {\n+\t\t\t\tflow->counter =\n+\t\t\t\t\t(uint32_t)(uintptr_t)(action->conf);\n+\t\t\t\t__atomic_fetch_add(&cnt_act->shared_info.refcnt,\n+\t\t\t\t\t\t1, __ATOMIC_RELAXED);\n+\t\t\t\t/* Save information first, will apply later. */\n+\t\t\t\taction_flags |= MLX5_FLOW_ACTION_COUNT;\n+\t\t\t}\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_COUNT:\n \t\t\tif (!dev_conf->devx) {\n", "prefixes": [ "v1", "1/2" ] }