Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96656/?format=api
{ "id": 96656, "url": "http://patchwork.dpdk.org/api/patches/96656/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210804072647.2077832-3-shunh@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210804072647.2077832-3-shunh@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210804072647.2077832-3-shunh@nvidia.com", "date": "2021-08-04T07:26:47", "name": "[v1,2/2] net/mlx5: fix domains detection in meter hierarchy", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1d6ee22fdfb0f91622f9640c14d8348a3a52b297", "submitter": { "id": 2212, "url": "http://patchwork.dpdk.org/api/people/2212/?format=api", "name": "Shun Hao", "email": "shunh@nvidia.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210804072647.2077832-3-shunh@nvidia.com/mbox/", "series": [ { "id": 18181, "url": "http://patchwork.dpdk.org/api/series/18181/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18181", "date": "2021-08-04T07:26:45", "name": "Fix Meter Hierarchy related issues", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18181/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96656/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/96656/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 373C2A0C45;\n\tWed, 4 Aug 2021 09:27:48 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B5F3B41224;\n\tWed, 4 Aug 2021 09:27:45 +0200 (CEST)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2079.outbound.protection.outlook.com [40.107.236.79])\n by mails.dpdk.org (Postfix) with ESMTP id 9C0504121E;\n Wed, 4 Aug 2021 09:27:44 +0200 (CEST)", "from BN9P222CA0003.NAMP222.PROD.OUTLOOK.COM (2603:10b6:408:10c::8)\n by DM5PR12MB1658.namprd12.prod.outlook.com (2603:10b6:4:5::8) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.4373.20; Wed, 4 Aug 2021 07:27:42 +0000", "from BN8NAM11FT036.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:10c:cafe::6) by BN9P222CA0003.outlook.office365.com\n (2603:10b6:408:10c::8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend\n Transport; Wed, 4 Aug 2021 07:27:42 +0000", "from mail.nvidia.com (216.228.112.34) by\n BN8NAM11FT036.mail.protection.outlook.com (10.13.177.168) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4394.16 via Frontend Transport; Wed, 4 Aug 2021 07:27:41 +0000", "from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 4 Aug\n 2021 07:27:41 +0000", "from nvidia.com (172.20.187.5) by DRHQMAIL107.nvidia.com\n (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 4 Aug 2021\n 07:27:38 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=ccctwJ9QSvNurP01QWqZl3hhMog4Svh9G7lHHTKaMlgXrlaJP57tQAu/CSphUhQNN/wMIZYClhB55OvYZbQ5heh4vgVUbeAWsqT3V18Re33aQ6P4BwbCvWMmAw3UOnAG/OLGx4HviU2Fib1E+XbE04r9Ws5aQE9ZwbcPUTJdJGl+l+bZPJ4aZ0azjO+kXr/80I7ASmsBR2oXCJC6OZp5wlFonk4rfgy4P61YYz4HETxFwkI02VN7nXFD8XARKNKOcdjVid7S408k/+IEu7EYJXlN4G6LjBF0rlNjRllX0i4ewiAKBpgiPQHQSFbq4JhIWEaCnDahYYudio4lA261sw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=HvRzXxugb8xnPPt7dB6NkHpL3ibe4xL239B1CGuObWk=;\n b=ATS647twqXuR+zBYD2Q6RuGmgxh7hjbUgaZTpVS2MeegqHtHkOG9XFX0OYwNNKU85zj1Jh9ag5VfpyEYD3ju6jO7aFKMqtI96D5xon+b4GL5tJEW4wnIJCklW0qumlqT12zWNlbYMLGCbrmjCWFiUM8ofAahV5HXexcrQTt1OxMEYfI0TpEg/Cy4Q4xQpNvZivOS8BS0VmhQXqyMhlbW79WA9VxoaPWnql18sL03OoJa5YtTnqIgNyv5bADeCYODKCvgOZZxmHvpoW9pfAvZF+3/6u9AwRhFN9E1X4KsAGq0NT6GhWxGa8xvk5LmT9Mec/edvjaWuHDZRpDPSNHXKA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=HvRzXxugb8xnPPt7dB6NkHpL3ibe4xL239B1CGuObWk=;\n b=rZk4a5yQf3ZPB9cluy3BDI6eHRMUyfzsRjIWWlosXY9H0JeL5/J4lU+z+kPAyeEF03/gAa9JPOAHCDhkEB2lSJg3VxXOZko/ELdwmmSG8sRt3Od+/7jv8WT5Rc0zE/MFpDlF0RfcV74ycfoHUX3JhDNvDtzzJ3dwKY6hhKSU5ZLJyihonzmbx0Azm6CmaW/Psn948h3U6ka+DwJLoBhr8SzFZKJMlnEeY+NaNfEw3h3n6TtAbJG/7u76fkcKtdqwwJvE+uRVZu8yqOtL+zJiyIJBbMb02UKFPggl0n/hLIoP2vWGZopHytkX7JJ3Tl/VvwBemQjhvVRFiUCb+00C6g==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Shun Hao <shunh@nvidia.com>", "To": "<orika@nvidia.com>, <viacheslavo@nvidia.com>, <matan@nvidia.com>, \"Shahaf\n Shuler\" <shahafs@nvidia.com>", "CC": "<dev@dpdk.org>, <thomas@monjalon.net>, <rasland@nvidia.com>,\n <stable@dpdk.org>", "Date": "Wed, 4 Aug 2021 10:26:47 +0300", "Message-ID": "<20210804072647.2077832-3-shunh@nvidia.com>", "X-Mailer": "git-send-email 2.20.0", "In-Reply-To": "<20210804072647.2077832-1-shunh@nvidia.com>", "References": "<20210804072647.2077832-1-shunh@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL101.nvidia.com (172.20.187.10) To\n DRHQMAIL107.nvidia.com (10.27.9.16)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "29d30f22-dfc6-4e8d-7328-08d957195877", "X-MS-TrafficTypeDiagnostic": "DM5PR12MB1658:", "X-LD-Processed": "43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr", "X-Microsoft-Antispam-PRVS": "\n <DM5PR12MB165888D8FF80397D135B680EC0F19@DM5PR12MB1658.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:8882;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n ZP3zf9Pui8suFq44tF6YZ+bHbS49JtZ+uowIIAHPXSY3xQg0fRE7hHTRLwE5lzufD3xf74nY5sowhovTAGHgmFewafgnspW8NArN+biIc2xxwnbfIUjlIln9E178SBQLIbNX0GtxPJl/1jImCrk8JOHk1poztjg/vZSKpS85VpjvF01+2/Q3Tz7PyNOJNabBlyfUerCbxqsVjVekdwNY4eTt+DwncyOaAxfvLQXDncPiZQe+ZcDSFRsbLemuDqIzfO6m1aBpcZhtWVwiNWqrtVJ5uAxAe0NdFD1+TQni6J1d66lj7cr64ZdR8PTmoAKe8v9UNr3RdRoh0LOjmPp/uH2T3R3QPzNi3nLqr60iEWR5WbDxIC+wSQC+Bed/hFAzRK2Kw8V98BnPb3BGGBaNZ70rrf4jmsRf3jUPpE4eGIpqXTFEOt7ufHD21kPH087MZm+xmSFhXa4zJTYeeuVzgCtueMgCnQY84kB9bna7WJ7WZNwKBbhju5g08H4Ri9hrclCSSFPv/DyLCIEM5VpR7NPb+4T/fokiFqYpzZw/7UUz3kgVa/+pvA4w5NMLpREv2FQ0mvyF+UR+9S7k79p8OfP5h3rRVE3a8cHnquNMyjL6Wmr0VjvlByHYn+W9veyWn4GBgt6odiUA2n+oDm7EQYZOSYp07+TmRNDHuG8YEtARHUABxzq3FhuqPOWKnnWO/FM/TG0Aqn/MII/20SU5fQ==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(136003)(396003)(376002)(346002)(39860400002)(36840700001)(46966006)(6636002)(186003)(26005)(36906005)(6286002)(8676002)(16526019)(36860700001)(86362001)(2616005)(316002)(336012)(110136005)(54906003)(83380400001)(55016002)(82310400003)(36756003)(7696005)(8936002)(356005)(47076005)(426003)(1076003)(5660300002)(4326008)(478600001)(70206006)(70586007)(82740400003)(2906002)(7636003)(6666004);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 Aug 2021 07:27:41.8008 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 29d30f22-dfc6-4e8d-7328-08d957195877", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT036.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM5PR12MB1658", "Subject": "[dpdk-dev] [PATCH v1 2/2] net/mlx5: fix domains detection in meter\n hierarchy", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Meters in one hierarchy might support different domains. For\nexample, one meter may support ingress only, but the root meter\ncan support all the domains.\n\nIf the later meter in the meter hierarchy wrongly doesn't inherit\nthe first meter's domains, it will lead to invalid domain table\naccess.\n\nFix is when creating meter hierarchy, try to inherit the first meter\ndomains in the meter hierarchy.\n\nFixes: a3b7af90baba (\"net/mlx5: validate meter action in policy\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shun Hao <shunh@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 16 ++++++++++++----\n 1 file changed, 12 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex f54440c6f5..31d857030f 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -17527,6 +17527,7 @@ flow_dv_validate_policy_mtr_hierarchy(struct rte_eth_dev *dev,\n \t\t\t\t\tRTE_MTR_ERROR_TYPE_POLICER_ACTION_GREEN,\n \t\t\t\t\tNULL,\n \t\t\t\t\t\"Multiple fate actions not supported.\");\n+\t*hierarchy_domain = 0;\n \twhile (true) {\n \t\tfm = mlx5_flow_meter_find(priv, meter_id, NULL);\n \t\tif (!fm)\n@@ -17539,7 +17540,12 @@ flow_dv_validate_policy_mtr_hierarchy(struct rte_eth_dev *dev,\n \t\t\t\"Non termination meter not supported in hierarchy.\");\n \t\tpolicy = mlx5_flow_meter_policy_find(dev, fm->policy_id, NULL);\n \t\tMLX5_ASSERT(policy);\n-\t\tif (!policy->is_hierarchy) {\n+\t\t/**\n+\t\t * Only inherit the supported domains of the first meter in\n+\t\t * hierarchy.\n+\t\t * One meter supports at least one domain.\n+\t\t */\n+\t\tif (!*hierarchy_domain) {\n \t\t\tif (policy->transfer)\n \t\t\t\t*hierarchy_domain |=\n \t\t\t\t\t\tMLX5_MTR_DOMAIN_TRANSFER_BIT;\n@@ -17548,6 +17554,8 @@ flow_dv_validate_policy_mtr_hierarchy(struct rte_eth_dev *dev,\n \t\t\t\t\t\tMLX5_MTR_DOMAIN_INGRESS_BIT;\n \t\t\tif (policy->egress)\n \t\t\t\t*hierarchy_domain |= MLX5_MTR_DOMAIN_EGRESS_BIT;\n+\t\t}\n+\t\tif (!policy->is_hierarchy) {\n \t\t\t*is_rss = policy->is_rss;\n \t\t\tbreak;\n \t\t}\n@@ -17825,11 +17833,11 @@ flow_dv_validate_mtr_policy_acts(struct rte_eth_dev *dev,\n \t\t\t * so MARK action is only in ingress domain.\n \t\t\t */\n \t\t\tdomain_color[i] = MLX5_MTR_DOMAIN_INGRESS_BIT;\n-\t\telse if (action_flags[i] &\n-\t\t\t MLX5_FLOW_ACTION_METER_WITH_TERMINATED_POLICY)\n-\t\t\tdomain_color[i] = hierarchy_domain;\n \t\telse\n \t\t\tdomain_color[i] = def_domain;\n+\t\tif (action_flags[i] &\n+\t\t MLX5_FLOW_ACTION_METER_WITH_TERMINATED_POLICY)\n+\t\t\tdomain_color[i] &= hierarchy_domain;\n \t\t/*\n \t\t * Non-termination actions only support NIC Tx domain.\n \t\t * The adjustion should be skipped when there is no\n", "prefixes": [ "v1", "2/2" ] }