Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96765/?format=api
{ "id": 96765, "url": "http://patchwork.dpdk.org/api/patches/96765/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210810025140.1698163-27-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210810025140.1698163-27-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210810025140.1698163-27-qi.z.zhang@intel.com", "date": "2021-08-10T02:51:38", "name": "[26/28] net/ice/base: rename and add a setter function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "182b6a7f8c00ba9739217fdd8e455f171c54ab78", "submitter": { "id": 504, "url": "http://patchwork.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210810025140.1698163-27-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 18242, "url": "http://patchwork.dpdk.org/api/series/18242/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18242", "date": "2021-08-10T02:51:12", "name": "ice: base code update", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18242/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96765/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96765/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BCEABA0C54;\n\tTue, 10 Aug 2021 04:51:14 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BC0B4411FB;\n\tTue, 10 Aug 2021 04:49:40 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id F21EB411F5\n for <dev@dpdk.org>; Tue, 10 Aug 2021 04:49:38 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Aug 2021 19:49:38 -0700", "from dpdk51.sh.intel.com ([10.67.111.142])\n by fmsmga008.fm.intel.com with ESMTP; 09 Aug 2021 19:49:36 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10070\"; a=\"202002222\"", "E=Sophos;i=\"5.84,309,1620716400\"; d=\"scan'208\";a=\"202002222\"", "E=Sophos;i=\"5.84,309,1620716400\"; d=\"scan'208\";a=\"483823822\"" ], "X-ExtLoop1": "1", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "qiming.yang@intel.com", "Cc": "junfeng.guo@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>", "Date": "Tue, 10 Aug 2021 10:51:38 +0800", "Message-Id": "<20210810025140.1698163-27-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.26.2", "In-Reply-To": "<20210810025140.1698163-1-qi.z.zhang@intel.com>", "References": "<20210810025140.1698163-1-qi.z.zhang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 26/28] net/ice/base: rename and add a setter\n function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Rename ucast_shared to umac_shared, as \"umac\" is a more widely\nused shorthand for \"unicast MAC\".\n\nAlso add a helper function to set this flag. This helper is\nexpected to be called by core drivers.\n\nSigned-off-by: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ice/base/ice_common.c | 11 +++++++++++\n drivers/net/ice/base/ice_common.h | 1 +\n drivers/net/ice/base/ice_switch.c | 8 ++++----\n drivers/net/ice/base/ice_type.h | 3 ++-\n 4 files changed, 18 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c\nindex ad9df0d3a2..9c6649b6c5 100644\n--- a/drivers/net/ice/base/ice_common.c\n+++ b/drivers/net/ice/base/ice_common.c\n@@ -864,6 +864,17 @@ void ice_print_rollback_msg(struct ice_hw *hw)\n \t\t nvm_str, hw->fw_maj_ver, hw->fw_min_ver);\n }\n \n+/**\n+ * ice_set_umac_shared\n+ * @hw: pointer to the hw struct\n+ *\n+ * Set boolean flag to allow unicast MAC sharing\n+ */\n+void ice_set_umac_shared(struct ice_hw *hw)\n+{\n+\thw->umac_shared = true;\n+}\n+\n /**\n * ice_init_hw - main hardware initialization routine\n * @hw: pointer to the hardware structure\ndiff --git a/drivers/net/ice/base/ice_common.h b/drivers/net/ice/base/ice_common.h\nindex ac6b487347..e84308444d 100644\n--- a/drivers/net/ice/base/ice_common.h\n+++ b/drivers/net/ice/base/ice_common.h\n@@ -23,6 +23,7 @@ enum ice_fw_modes {\n \n enum ice_status ice_init_fltr_mgmt_struct(struct ice_hw *hw);\n void ice_cleanup_fltr_mgmt_struct(struct ice_hw *hw);\n+void ice_set_umac_shared(struct ice_hw *hw);\n enum ice_status ice_init_hw(struct ice_hw *hw);\n void ice_deinit_hw(struct ice_hw *hw);\n enum ice_status ice_check_reset(struct ice_hw *hw);\ndiff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c\nindex 2d8904d2c3..9179f66c20 100644\n--- a/drivers/net/ice/base/ice_switch.c\n+++ b/drivers/net/ice/base/ice_switch.c\n@@ -4681,7 +4681,7 @@ ice_aq_get_res_descs(struct ice_hw *hw, u16 num_entries,\n * @sw: pointer to switch info struct for which function add rule\n * @lport: logic port number on which function add rule\n *\n- * IMPORTANT: When the ucast_shared flag is set to false and m_list has\n+ * IMPORTANT: When the umac_shared flag is set to false and m_list has\n * multiple unicast addresses, the function assumes that all the\n * addresses are unique in a given add_mac call. It doesn't\n * check for duplicates in this case, removing duplicates from a given\n@@ -4724,7 +4724,7 @@ ice_add_mac_rule(struct ice_hw *hw, struct LIST_HEAD_TYPE *m_list,\n \t\tif (m_list_itr->fltr_info.lkup_type != ICE_SW_LKUP_MAC ||\n \t\t IS_ZERO_ETHER_ADDR(add))\n \t\t\treturn ICE_ERR_PARAM;\n-\t\tif (IS_UNICAST_ETHER_ADDR(add) && !hw->ucast_shared) {\n+\t\tif (IS_UNICAST_ETHER_ADDR(add) && !hw->umac_shared) {\n \t\t\t/* Don't overwrite the unicast address */\n \t\t\tice_acquire_lock(rule_lock);\n \t\t\tif (ice_find_rule_entry(rule_head,\n@@ -4735,7 +4735,7 @@ ice_add_mac_rule(struct ice_hw *hw, struct LIST_HEAD_TYPE *m_list,\n \t\t\tice_release_lock(rule_lock);\n \t\t\tnum_unicast++;\n \t\t} else if (IS_MULTICAST_ETHER_ADDR(add) ||\n-\t\t\t (IS_UNICAST_ETHER_ADDR(add) && hw->ucast_shared)) {\n+\t\t\t (IS_UNICAST_ETHER_ADDR(add) && hw->umac_shared)) {\n \t\t\tm_list_itr->status =\n \t\t\t\tice_add_rule_internal(hw, recp_list, lport,\n \t\t\t\t\t\t m_list_itr);\n@@ -5424,7 +5424,7 @@ ice_remove_mac_rule(struct ice_hw *hw, struct LIST_HEAD_TYPE *m_list,\n \n \t\tlist_itr->fltr_info.fwd_id.hw_vsi_id =\n \t\t\t\t\tice_get_hw_vsi_num(hw, vsi_handle);\n-\t\tif (IS_UNICAST_ETHER_ADDR(add) && !hw->ucast_shared) {\n+\t\tif (IS_UNICAST_ETHER_ADDR(add) && !hw->umac_shared) {\n \t\t\t/* Don't remove the unicast address that belongs to\n \t\t\t * another VSI on the switch, since it is not being\n \t\t\t * shared...\ndiff --git a/drivers/net/ice/base/ice_type.h b/drivers/net/ice/base/ice_type.h\nindex 4e33d14c6d..56ee628f10 100644\n--- a/drivers/net/ice/base/ice_type.h\n+++ b/drivers/net/ice/base/ice_type.h\n@@ -1194,7 +1194,8 @@ struct ice_hw {\n \t/* INTRL granularity in 1 us */\n \tu8 intrl_gran;\n \n-\tu8 ucast_shared;\t/* true if VSIs can share unicast addr */\n+\t/* true if VSIs can share unicast MAC addr */\n+\tu8 umac_shared;\n \n #define ICE_PHY_PER_NAC\t\t1\n #define ICE_MAX_QUAD\t\t2\n", "prefixes": [ "26/28" ] }