Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96789/?format=api
{ "id": 96789, "url": "http://patchwork.dpdk.org/api/patches/96789/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210810195020.1423013-4-gakhil@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210810195020.1423013-4-gakhil@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210810195020.1423013-4-gakhil@marvell.com", "date": "2021-08-10T19:50:19", "name": "[v2,3/4] examples/fips_validation: remove illegal usage of APIs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fe32326883cf795c09d8b80b0de9d8e63bb82a2c", "submitter": { "id": 2094, "url": "http://patchwork.dpdk.org/api/people/2094/?format=api", "name": "Akhil Goyal", "email": "gakhil@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210810195020.1423013-4-gakhil@marvell.com/mbox/", "series": [ { "id": 18250, "url": "http://patchwork.dpdk.org/api/series/18250/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18250", "date": "2021-08-10T19:50:16", "name": "cryptodev: expose driver interface as internal", "version": 2, "mbox": "http://patchwork.dpdk.org/series/18250/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96789/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96789/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 57CC3A0C43;\n\tTue, 10 Aug 2021 21:51:06 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D7FE6411D7;\n\tTue, 10 Aug 2021 21:51:02 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 0A931411C5\n for <dev@dpdk.org>; Tue, 10 Aug 2021 21:51:00 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id\n 17AJoZQl008924; Tue, 10 Aug 2021 12:50:54 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com with ESMTP id 3abfu2kx1v-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 10 Aug 2021 12:50:54 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Tue, 10 Aug 2021 12:50:52 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Tue, 10 Aug 2021 12:50:52 -0700", "from localhost.localdomain (unknown [10.28.36.185])\n by maili.marvell.com (Postfix) with ESMTP id 9CCD45E6881;\n Tue, 10 Aug 2021 12:50:47 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=uvO8sR6cP1T/dZr3vOCN8uZ0aI9hkhZ9Nozi35bFqKI=;\n b=khLEaySGHeIE/sLegXIfGDfgLTFGQtmIzUVbwp1URTp2voWYg8sMOuUuwjxfoC12c6o1\n 6lzG/XDzELissKoTcNHmoG1z5/nURCMvKsp7t9Uvkke8y/WfMzH1909uS4oGzkALsgpf\n b27UytbAvXq+DnuyNNv2kR6K8kFHT/ijG6nE440kPXwdNZaNkis++IH3E2Lpyfq7nDA+\n NKdiM3NGakkXVpKlddFT6DHzXWOyjvGmfaVy3cAQA8kyFnxvZ2syu5tAGun2qDmyBNSJ\n SRhF1+OVJd4LxUhR4jsAtfpGpOJ7L37+9p9zDi7iuPZozcmE4Xhq/BKcWEL1kRaQ2bDW 9Q==", "From": "Akhil Goyal <gakhil@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<anoobj@marvell.com>, <radu.nicolau@intel.com>,\n <declan.doherty@intel.com>,\n <hemant.agrawal@nxp.com>, <matan@nvidia.com>,\n <konstantin.ananyev@intel.com>, <thomas@monjalon.net>,\n <roy.fan.zhang@intel.com>, <asomalap@amd.com>, <ruifeng.wang@arm.com>,\n <ajit.khaparde@broadcom.com>, <pablo.de.lara.guarch@intel.com>,\n <fiona.trahe@intel.com>, <adwivedi@marvell.com>,\n <michaelsh@marvell.com>, <rnagadheeraj@marvell.com>,\n <jianjay.zhou@huawei.com>, Akhil Goyal <gakhil@marvell.com>", "Date": "Wed, 11 Aug 2021 01:20:19 +0530", "Message-ID": "<20210810195020.1423013-4-gakhil@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210810195020.1423013-1-gakhil@marvell.com>", "References": "<20210805200236.1180289-1-gakhil@marvell.com>\n <20210810195020.1423013-1-gakhil@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "uuVM2x29ZdoytjFOtPQwpn22Ksm0_fTV", "X-Proofpoint-GUID": "uuVM2x29ZdoytjFOtPQwpn22Ksm0_fTV", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790\n definitions=2021-08-10_08:2021-08-10,\n 2021-08-10 signatures=0", "Subject": "[dpdk-dev] [PATCH v2 3/4] examples/fips_validation: remove illegal\n usage of APIs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Some of the cryptodev APIs are not allowed to be used\nby application directly. Hence removing the usage of\n1. queue_pair_release: it is not required, as configure\n of queue pair release the previous queue pairs and the\n dev is not directly exposed to application, hence cannot\n use its ops from app.\n2. rte_cryptodev_stop: it can be used directly without\n checking if the device is started or not.\n3. rte_cryptodev_pmd_destroy: application should use\n rte_cryptodev_close instead.\n\nSigned-off-by: Akhil Goyal <gakhil@marvell.com>\n---\n examples/fips_validation/fips_dev_self_test.c | 19 ++-----------------\n examples/fips_validation/main.c | 7 ++-----\n 2 files changed, 4 insertions(+), 22 deletions(-)", "diff": "diff --git a/examples/fips_validation/fips_dev_self_test.c b/examples/fips_validation/fips_dev_self_test.c\nindex 17e85973c0..b4eab05a98 100644\n--- a/examples/fips_validation/fips_dev_self_test.c\n+++ b/examples/fips_validation/fips_dev_self_test.c\n@@ -3,7 +3,7 @@\n */\n \n #include <rte_cryptodev.h>\n-#include <rte_cryptodev_pmd.h>\n+#include <rte_malloc.h>\n \n #include \"fips_dev_self_test.h\"\n \n@@ -1523,12 +1523,6 @@ static void\n fips_dev_auto_test_uninit(uint8_t dev_id,\n \t\tstruct fips_dev_auto_test_env *env)\n {\n-\tstruct rte_cryptodev *dev = rte_cryptodev_pmd_get_dev(dev_id);\n-\tuint32_t i;\n-\n-\tif (!dev)\n-\t\treturn;\n-\n \tif (env->mbuf)\n \t\trte_pktmbuf_free(env->mbuf);\n \tif (env->op)\n@@ -1542,16 +1536,7 @@ fips_dev_auto_test_uninit(uint8_t dev_id,\n \tif (env->sess_priv_pool)\n \t\trte_mempool_free(env->sess_priv_pool);\n \n-\tif (dev->data->dev_started)\n-\t\trte_cryptodev_stop(dev_id);\n-\n-\tif (dev->data->nb_queue_pairs) {\n-\t\tfor (i = 0; i < dev->data->nb_queue_pairs; i++)\n-\t\t\t(*dev->dev_ops->queue_pair_release)(dev, i);\n-\t\tdev->data->nb_queue_pairs = 0;\n-\t\trte_free(dev->data->queue_pairs);\n-\t\tdev->data->queue_pairs = NULL;\n-\t}\n+\trte_cryptodev_stop(dev_id);\n }\n \n static int\ndiff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c\nindex e892078f0e..a8daad1f48 100644\n--- a/examples/fips_validation/main.c\n+++ b/examples/fips_validation/main.c\n@@ -7,7 +7,7 @@\n #include <dirent.h>\n \n #include <rte_cryptodev.h>\n-#include <rte_cryptodev_pmd.h>\n+#include <rte_malloc.h>\n #include <rte_mempool.h>\n #include <rte_mbuf.h>\n #include <rte_string_fns.h>\n@@ -73,10 +73,7 @@ cryptodev_fips_validate_app_int(void)\n \tif (env.self_test) {\n \t\tret = fips_dev_self_test(env.dev_id, env.broken_test_config);\n \t\tif (ret < 0) {\n-\t\t\tstruct rte_cryptodev *cryptodev =\n-\t\t\t\t\trte_cryptodev_pmd_get_dev(env.dev_id);\n-\n-\t\t\trte_cryptodev_pmd_destroy(cryptodev);\n+\t\t\trte_cryptodev_close(env.dev_id);\n \n \t\t\treturn ret;\n \t\t}\n", "prefixes": [ "v2", "3/4" ] }