Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96793/?format=api
{ "id": 96793, "url": "http://patchwork.dpdk.org/api/patches/96793/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210811061720.1901041-2-feifei.wang2@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210811061720.1901041-2-feifei.wang2@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210811061720.1901041-2-feifei.wang2@arm.com", "date": "2021-08-11T06:17:20", "name": "[v2,1/1] devtools: add relative path support for ABI compatibility check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d4976b7516228d65d03c26fa26c8b6096e350ecc", "submitter": { "id": 1771, "url": "http://patchwork.dpdk.org/api/people/1771/?format=api", "name": "Feifei Wang", "email": "feifei.wang2@arm.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210811061720.1901041-2-feifei.wang2@arm.com/mbox/", "series": [ { "id": 18252, "url": "http://patchwork.dpdk.org/api/series/18252/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18252", "date": "2021-08-11T06:17:19", "name": "relative path support for ABI compatibility check", "version": 2, "mbox": "http://patchwork.dpdk.org/series/18252/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96793/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/96793/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5D210A0547;\n\tWed, 11 Aug 2021 08:17:38 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C72C440E50;\n\tWed, 11 Aug 2021 08:17:33 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 1B1DE40E03\n for <dev@dpdk.org>; Wed, 11 Aug 2021 08:17:33 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 87D4F1FB;\n Tue, 10 Aug 2021 23:17:32 -0700 (PDT)", "from net-x86-dell-8268.shanghai.arm.com\n (net-x86-dell-8268.shanghai.arm.com [10.169.210.99])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 366E83F718;\n Tue, 10 Aug 2021 23:17:29 -0700 (PDT)" ], "From": "Feifei Wang <feifei.wang2@arm.com>", "To": "Bruce Richardson <bruce.richardson@intel.com>", "Cc": "dev@dpdk.org, nd@arm.com, Phil Yang <phil.yang@arm.com>,\n Feifei Wang <feifei.wang2@arm.com>,\n =?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>,\n Ruifeng Wang <ruifeng.wang@arm.com>", "Date": "Wed, 11 Aug 2021 14:17:20 +0800", "Message-Id": "<20210811061720.1901041-2-feifei.wang2@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210811061720.1901041-1-feifei.wang2@arm.com>", "References": "<20210601015653.14499-1-feifei.wang2@arm.com>\n <20210811061720.1901041-1-feifei.wang2@arm.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/1] devtools: add relative path support for\n ABI compatibility check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Phil Yang <phil.yang@arm.com>\n\nBecause dpdk guide does not limit the relative path for ABI\ncompatibility check, users maybe set 'DPDK_ABI_REF_DIR' as a relative\npath:\n\n~/dpdk/devtools$ DPDK_ABI_REF_VERSION=v19.11 DPDK_ABI_REF_DIR=build-gcc-shared\n./test-meson-builds.sh\n\nAnd if the DESTDIR is not an absolute path, ninja complains:\n+ install_target build-gcc-shared/v19.11/build build-gcc-shared/v19.11/build-gcc-shared\n+ rm -rf build-gcc-shared/v19.11/build-gcc-shared\n+ echo 'DESTDIR=build-gcc-shared/v19.11/build-gcc-shared ninja -C build-gcc-shared/v19.11/build install'\n+ DESTDIR=build-gcc-shared/v19.11/build-gcc-shared\n+ ninja -C build-gcc-shared/v19.11/build install\n...\nValueError: dst_dir must be absolute, got build-gcc-shared/v19.11/build-gcc-shared/usr/local/share/dpdk/\nexamples/bbdev_app\n...\nError: install directory 'build-gcc-shared/v19.11/build-gcc-shared' does not exist.\n\nTo fix this, add relative path support using 'readlink -f'.\n\nSigned-off-by: Phil Yang <phil.yang@arm.com>\nSigned-off-by: Feifei Wang <feifei.wang2@arm.com>\nReviewed-by: Juraj Linkeš <juraj.linkes@pantheon.tech>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n devtools/test-meson-builds.sh | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh\nindex 9ec8e2bc7e..8ddde95276 100755\n--- a/devtools/test-meson-builds.sh\n+++ b/devtools/test-meson-builds.sh\n@@ -168,7 +168,8 @@ build () # <directory> <target cc | cross file> <ABI check> [meson options]\n \tconfig $srcdir $builds_dir/$targetdir $cross --werror $*\n \tcompile $builds_dir/$targetdir\n \tif [ -n \"$DPDK_ABI_REF_VERSION\" -a \"$abicheck\" = ABI ] ; then\n-\t\tabirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION\n+\t\tabirefdir=$(readlink -f \\\n+\t\t\t${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION)\n \t\tif [ ! -d $abirefdir/$targetdir ]; then\n \t\t\t# clone current sources\n \t\t\tif [ ! -d $abirefdir/src ]; then\n", "prefixes": [ "v2", "1/1" ] }