Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96819/?format=api
{ "id": 96819, "url": "http://patchwork.dpdk.org/api/patches/96819/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210812020020.12656-2-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210812020020.12656-2-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210812020020.12656-2-jiawenwu@trustnetic.com", "date": "2021-08-12T02:00:18", "name": "[1/3] net/txgbe: fix link status when device stopped", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "81c489c88f3d3fb99dab31c8bd63f6f440bf7d8e", "submitter": { "id": 1932, "url": "http://patchwork.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210812020020.12656-2-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 18258, "url": "http://patchwork.dpdk.org/api/series/18258/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18258", "date": "2021-08-12T02:00:17", "name": "Fixes for txgbe", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18258/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96819/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96819/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 76EE6A0C4D;\n\tThu, 12 Aug 2021 04:00:43 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BFA7F411FA;\n\tThu, 12 Aug 2021 04:00:40 +0200 (CEST)", "from smtpbg501.qq.com (smtpbg501.qq.com [203.205.250.101])\n by mails.dpdk.org (Postfix) with ESMTP id 2A040411FC\n for <dev@dpdk.org>; Thu, 12 Aug 2021 04:00:37 +0200 (CEST)", "from jiawenwu.trustnetic.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Thu, 12 Aug 2021 10:00:27 +0800 (CST)" ], "X-QQ-mid": "bizesmtp31t1628733628tga64ogm", "X-QQ-SSF": "01400000002000E0F000B00A0000000", "X-QQ-FEAT": "ttxN9vkG2OQjSuvoPZrYCcMCLANOv3MRSBLyLEd8n9zd0nUStXj/kGH4kwjgj\n NAX1RVKFIcpHNV4dJVwUalyY4U33gSR2mjSecBOitXdgp4QncnyjIyfxeKXikLl+tc7/ayZ\n tvVlTBLr4rCNhHQlSXjO4GkwyJA5VCm1fKEl+HeV2o3rUiLV4aXs6ScWzjHAkoVnS8+OOr/\n wS8aQz0DY+ISItP+jhkeZgap06hceOprJ66+amlE/AC+sqZefdIGAbAxcYkE4GKrf7QBdIi\n p+UdvDLEW1IBlG68IpkXx7diRz4xG7bj7YjnTPNaiEPpAc1KqOECIh9xscBaL4TGLdqhbYg\n Y+0cEt2Pby8kacb8sXFYMjgccWabQ==", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>,\n\tstable@dpdk.org", "Date": "Thu, 12 Aug 2021 10:00:18 +0800", "Message-Id": "<20210812020020.12656-2-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20210812020020.12656-1-jiawenwu@trustnetic.com>", "References": "<20210812020020.12656-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign7", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH 1/3] net/txgbe: fix link status when device\n stopped", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When device is stopped, the port status is not changed and only the Tx\nlaser is turned off by hardware design.\n\nFixes: 0c061eadec59 (\"net/txgbe: add link status change\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/base/txgbe_type.h | 1 +\n drivers/net/txgbe/txgbe_ethdev.c | 4 ++++\n drivers/net/txgbe/txgbe_ethdev_vf.c | 2 ++\n 3 files changed, 7 insertions(+)", "diff": "diff --git a/drivers/net/txgbe/base/txgbe_type.h b/drivers/net/txgbe/base/txgbe_type.h\nindex 823c6756e7..d95467f9f8 100644\n--- a/drivers/net/txgbe/base/txgbe_type.h\n+++ b/drivers/net/txgbe/base/txgbe_type.h\n@@ -781,6 +781,7 @@ struct txgbe_hw {\n \tint api_version;\n \tbool allow_unsupported_sfp;\n \tbool need_crosstalk_fix;\n+\tbool dev_start;\n \tstruct txgbe_devargs devarg;\n \n \tuint64_t isb_dma;\ndiff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c\nindex e62675520a..0063994688 100644\n--- a/drivers/net/txgbe/txgbe_ethdev.c\n+++ b/drivers/net/txgbe/txgbe_ethdev.c\n@@ -1664,6 +1664,7 @@ txgbe_dev_start(struct rte_eth_dev *dev)\n \t\treturn -1;\n \thw->mac.start_hw(hw);\n \thw->mac.get_link_status = true;\n+\thw->dev_start = true;\n \n \t/* configure PF module if SRIOV enabled */\n \ttxgbe_pf_host_configure(dev);\n@@ -1933,6 +1934,7 @@ txgbe_dev_stop(struct rte_eth_dev *dev)\n \n \thw->adapter_stopped = true;\n \tdev->data->dev_started = 0;\n+\thw->dev_start = false;\n \n \treturn 0;\n }\n@@ -2735,6 +2737,8 @@ txgbe_dev_link_update_share(struct rte_eth_dev *dev,\n \t\t\t\ttxgbe_dev_setup_link_alarm_handler, dev);\n \t\t}\n \t\treturn rte_eth_linkstatus_set(dev, &link);\n+\t} else if (!hw->dev_start) {\n+\t\treturn rte_eth_linkstatus_set(dev, &link);\n \t}\n \n \tintr->flags &= ~TXGBE_FLAG_NEED_LINK_CONFIG;\ndiff --git a/drivers/net/txgbe/txgbe_ethdev_vf.c b/drivers/net/txgbe/txgbe_ethdev_vf.c\nindex 0bae6ffd1f..18ed94bd27 100644\n--- a/drivers/net/txgbe/txgbe_ethdev_vf.c\n+++ b/drivers/net/txgbe/txgbe_ethdev_vf.c\n@@ -628,6 +628,7 @@ txgbevf_dev_start(struct rte_eth_dev *dev)\n \t\treturn err;\n \t}\n \thw->mac.get_link_status = true;\n+\thw->dev_start = true;\n \n \t/* negotiate mailbox API version to use with the PF. */\n \ttxgbevf_negotiate_api(hw);\n@@ -749,6 +750,7 @@ txgbevf_dev_stop(struct rte_eth_dev *dev)\n \t}\n \n \tadapter->rss_reta_updated = 0;\n+\thw->dev_start = false;\n \n \treturn 0;\n }\n", "prefixes": [ "1/3" ] }