Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96820/?format=api
{ "id": 96820, "url": "http://patchwork.dpdk.org/api/patches/96820/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210812020020.12656-3-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210812020020.12656-3-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210812020020.12656-3-jiawenwu@trustnetic.com", "date": "2021-08-12T02:00:19", "name": "[2/3] net/txgbe: fix to read SFP module's SFF-8472 data", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "485198cb0ff23a311d6ffc3bbf516e44f8066028", "submitter": { "id": 1932, "url": "http://patchwork.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210812020020.12656-3-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 18258, "url": "http://patchwork.dpdk.org/api/series/18258/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18258", "date": "2021-08-12T02:00:17", "name": "Fixes for txgbe", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18258/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96820/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96820/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1C37CA0C4D;\n\tThu, 12 Aug 2021 04:00:49 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E5D6741205;\n\tThu, 12 Aug 2021 04:00:41 +0200 (CEST)", "from smtpbguseast2.qq.com (smtpbguseast2.qq.com [54.204.34.130])\n by mails.dpdk.org (Postfix) with ESMTP id CBC76411FC\n for <dev@dpdk.org>; Thu, 12 Aug 2021 04:00:39 +0200 (CEST)", "from jiawenwu.trustnetic.com (unknown [183.129.236.74])\n by esmtp6.qq.com (ESMTP) with\n id ; Thu, 12 Aug 2021 10:00:29 +0800 (CST)" ], "X-QQ-mid": "bizesmtp31t1628733630tkn2cpgl", "X-QQ-SSF": "01400000002000E0F000B00A0000000", "X-QQ-FEAT": "tSE3IANCkAth1H90zJHD3nKfno1qtcS+ji76fUIM56OlTa6yRxzMr9BFaijHv\n 3AenfGIvvUYLDmxoDduiDOiKRpyZ5JzFU3Q34uiDHNSVLcEdaOFDU1hFefN3ltucaLN/v5j\n hVPuUvG+aYx1E1xR//sShvgh4jqGFujkTOLQTygRPU7sIvA13PaQgbtn8AC+Y+VAiIdbvCr\n rBl0ZimGcpsALmSUR1tU0NyXAFphk4Ov2g8Ve3U0LQ5gNIlQNiKRh9/CcQqvPre8eMbIN/N\n 007+hkSB8tZ3XSGT16holwescF1Oadupn2vPZlyexTVwo2mLVS++G1sov06vqrfds3ZJ89o\n tvoCX6+Y3joR7KWO0A=", "X-QQ-GoodBg": "2", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>,\n\tstable@dpdk.org", "Date": "Thu, 12 Aug 2021 10:00:19 +0800", "Message-Id": "<20210812020020.12656-3-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.21.0.windows.1", "In-Reply-To": "<20210812020020.12656-1-jiawenwu@trustnetic.com>", "References": "<20210812020020.12656-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybgforeign:qybgforeign5", "X-QQ-Bgrelay": "1", "Subject": "[dpdk-dev] [PATCH 2/3] net/txgbe: fix to read SFP module's SFF-8472\n data", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix the I2C target address selection to read SFP module's SFF-8472 data.\n\nFixes: 8f09fb4642fa (\"net/txgbe: add module identify\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/base/txgbe_phy.c | 18 +++++++-----------\n 1 file changed, 7 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/txgbe/base/txgbe_phy.c b/drivers/net/txgbe/base/txgbe_phy.c\nindex 3e9f507212..2db87ae0c5 100644\n--- a/drivers/net/txgbe/base/txgbe_phy.c\n+++ b/drivers/net/txgbe/base/txgbe_phy.c\n@@ -8,7 +8,7 @@\n #include \"txgbe_mng.h\"\n #include \"txgbe_phy.h\"\n \n-static void txgbe_i2c_start(struct txgbe_hw *hw);\n+static void txgbe_i2c_start(struct txgbe_hw *hw, u8 dev_addr);\n static void txgbe_i2c_stop(struct txgbe_hw *hw);\n static s32 txgbe_handle_bp_flow(u32 link_mode, struct txgbe_hw *hw);\n static void txgbe_get_bp_ability(struct txgbe_backplane_ability *ability,\n@@ -1248,11 +1248,9 @@ s32 txgbe_write_i2c_eeprom(struct txgbe_hw *hw, u8 byte_offset,\n s32 txgbe_read_i2c_byte_unlocked(struct txgbe_hw *hw, u8 byte_offset,\n \t\t\t\t\t u8 dev_addr, u8 *data)\n {\n-\tUNREFERENCED_PARAMETER(dev_addr);\n-\n \tDEBUGFUNC(\"txgbe_read_i2c_byte\");\n \n-\ttxgbe_i2c_start(hw);\n+\ttxgbe_i2c_start(hw, dev_addr);\n \n \t/* wait tx empty */\n \tif (!po32m(hw, TXGBE_I2CICR, TXGBE_I2CICR_TXEMPTY,\n@@ -1314,11 +1312,9 @@ s32 txgbe_read_i2c_byte(struct txgbe_hw *hw, u8 byte_offset,\n s32 txgbe_write_i2c_byte_unlocked(struct txgbe_hw *hw, u8 byte_offset,\n \t\t\t\t\t u8 dev_addr, u8 data)\n {\n-\tUNREFERENCED_PARAMETER(dev_addr);\n-\n \tDEBUGFUNC(\"txgbe_write_i2c_byte\");\n \n-\ttxgbe_i2c_start(hw);\n+\ttxgbe_i2c_start(hw, dev_addr);\n \n \t/* wait tx empty */\n \tif (!po32m(hw, TXGBE_I2CICR, TXGBE_I2CICR_TXEMPTY,\n@@ -1369,7 +1365,7 @@ s32 txgbe_write_i2c_byte(struct txgbe_hw *hw, u8 byte_offset,\n *\n * Sets I2C start condition (High -> Low on SDA while SCL is High)\n **/\n-static void txgbe_i2c_start(struct txgbe_hw *hw)\n+static void txgbe_i2c_start(struct txgbe_hw *hw, u8 dev_addr)\n {\n \tDEBUGFUNC(\"txgbe_i2c_start\");\n \n@@ -1380,9 +1376,9 @@ static void txgbe_i2c_start(struct txgbe_hw *hw)\n \t\tTXGBE_I2CCON_SPEED(1) |\n \t\tTXGBE_I2CCON_RESTART |\n \t\tTXGBE_I2CCON_SDIA));\n-\twr32(hw, TXGBE_I2CTAR, TXGBE_I2C_SLAVEADDR);\n-\twr32(hw, TXGBE_I2CSSSCLHCNT, 600);\n-\twr32(hw, TXGBE_I2CSSSCLLCNT, 600);\n+\twr32(hw, TXGBE_I2CTAR, dev_addr >> 1);\n+\twr32(hw, TXGBE_I2CSSSCLHCNT, 200);\n+\twr32(hw, TXGBE_I2CSSSCLLCNT, 200);\n \twr32(hw, TXGBE_I2CRXTL, 0); /* 1byte for rx full signal */\n \twr32(hw, TXGBE_I2CTXTL, 4);\n \twr32(hw, TXGBE_I2CSCLTMOUT, 0xFFFFFF);\n", "prefixes": [ "2/3" ] }