Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96843/?format=api
{ "id": 96843, "url": "http://patchwork.dpdk.org/api/patches/96843/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210812111105.54307-3-wangzhihong.wzh@bytedance.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210812111105.54307-3-wangzhihong.wzh@bytedance.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210812111105.54307-3-wangzhihong.wzh@bytedance.com", "date": "2021-08-12T11:11:03", "name": "[v3,2/4] app/testpmd: use rte_ipv4_cksum in flowgen", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "248abcc7703e05abbf162b26318efe119bf54f91", "submitter": { "id": 2312, "url": "http://patchwork.dpdk.org/api/people/2312/?format=api", "name": "王志宏", "email": "wangzhihong.wzh@bytedance.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210812111105.54307-3-wangzhihong.wzh@bytedance.com/mbox/", "series": [ { "id": 18261, "url": "http://patchwork.dpdk.org/api/series/18261/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18261", "date": "2021-08-12T11:11:01", "name": "app/testpmd: flowgen fixes and improvements", "version": 3, "mbox": "http://patchwork.dpdk.org/series/18261/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96843/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96843/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 57AE6A0C56;\n\tThu, 12 Aug 2021 13:11:26 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5202241200;\n\tThu, 12 Aug 2021 13:11:21 +0200 (CEST)", "from mail-pj1-f50.google.com (mail-pj1-f50.google.com\n [209.85.216.50]) by mails.dpdk.org (Postfix) with ESMTP id C756441200\n for <dev@dpdk.org>; Thu, 12 Aug 2021 13:11:19 +0200 (CEST)", "by mail-pj1-f50.google.com with SMTP id\n hv22-20020a17090ae416b0290178c579e424so10143172pjb.3\n for <dev@dpdk.org>; Thu, 12 Aug 2021 04:11:19 -0700 (PDT)", "from C02D70YZMD6R.bytedance.net ([139.177.225.243])\n by smtp.gmail.com with ESMTPSA id l126sm3291830pgl.14.2021.08.12.04.11.15\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Thu, 12 Aug 2021 04:11:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bytedance-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=M/6WQKhhcHJZ8lH4P5Iti9nBeBhth8hCt890WgpnHJ8=;\n b=FpL6RYpbIcZuHpHoCLSrZgXFwwfFzpKLMCPo1K7biRNVUGO+Z3jjXYdWmW68ABYScu\n GrgHys8N0W4E8bml0kFiMxYTNzdyFPycF3u8SSMXQpuQSQQhb9/gi15yxv6uc1uKEswd\n 0z+pe3GvcNUV414VakbJF4R8GftmDnsiYIx2MPyy7VT033mgzuNNI0ZtfMng+trtATJw\n A1yZ7bSad5HkrXAJ1YY5U2ptP938ZMgGK6UuolLmcfDtWBi07DWbRqJe9sdqEp/Sn9xj\n TVnGxF/SM+1uLGOu5D/DOVazr3BIzGi2Ry0+3gHMi/sCNBo5PqdPFMbETYaG0q9o12IZ\n cCNg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=M/6WQKhhcHJZ8lH4P5Iti9nBeBhth8hCt890WgpnHJ8=;\n b=geEXYQH48qQdVVnNUnuQDwMsE+Bglmyyg4WPO9NrAlQWH/O/NDehr3Pb/Z1V6O62M9\n k4XIL3gSzT36QlgyAtAx+qDRjkf2hHyauhn8zdujGiFVFU4LzOo9oK8ajIM5V9AQBP24\n XlTtccwGPvreVhvf7qqVpECg2b1rsvyeSI9FcVG2uWzPFu061ix4KF+FPqO+vx6svo75\n 5Oug51Ldpp5fe0k4O164a5UVu+qfZH0rc63rA27Ou7VLJoriMkZhNBPhho+Ca8ajLI07\n G8riQ1OgXDSDyFRnfPcSObai8f4Hut/xaJ3S5ybcyuPZ5xPuYIelcz0SEBBy/cvCeVxL\n k++Q==", "X-Gm-Message-State": "AOAM532GKZzt2lw0UTvn+nF3aBli6Nhaa3oTC+n9ozXZjQnQ8+oPNZc4\n +b4wKkbMC84ReA34Hn/p4WIh2Nu3PUF1Osbj", "X-Google-Smtp-Source": "\n ABdhPJzayYkzurXXHGLNqwSEehsIi8vzMRqPik+sccNFkYqvaewhM4jaVtJV3DzgPzsEDWRT2agvHA==", "X-Received": "by 2002:a17:90a:8909:: with SMTP id u9mr429303pjn.9.1628766678520;\n Thu, 12 Aug 2021 04:11:18 -0700 (PDT)", "From": "Zhihong Wang <wangzhihong.wzh@bytedance.com>", "To": "dev@dpdk.org, ferruh.yigit@intel.com, xiaoyun.li@intel.com,\n aman.deep.singh@intel.com, irusskikh@marvell.com, cchemparathy@tilera.com", "Cc": "Zhihong Wang <wangzhihong.wzh@bytedance.com>", "Date": "Thu, 12 Aug 2021 19:11:03 +0800", "Message-Id": "<20210812111105.54307-3-wangzhihong.wzh@bytedance.com>", "X-Mailer": "git-send-email 2.24.3 (Apple Git-128)", "In-Reply-To": "<20210812111105.54307-1-wangzhihong.wzh@bytedance.com>", "References": "<20210809062548.30187-1-wangzhihong.wzh@bytedance.com>\n <20210812111105.54307-1-wangzhihong.wzh@bytedance.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 2/4] app/testpmd: use rte_ipv4_cksum in flowgen", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use the rte_ipv4_cksum API to replace local ip_sum implementation.\n\nSigned-off-by: Zhihong Wang <wangzhihong.wzh@bytedance.com>\n---\n app/test-pmd/flowgen.c | 25 +------------------------\n 1 file changed, 1 insertion(+), 24 deletions(-)", "diff": "diff --git a/app/test-pmd/flowgen.c b/app/test-pmd/flowgen.c\nindex f2e6255c36..96d0cc79df 100644\n--- a/app/test-pmd/flowgen.c\n+++ b/app/test-pmd/flowgen.c\n@@ -53,28 +53,6 @@ static struct rte_ether_addr cfg_ether_dst =\n \n #define IP_DEFTTL 64 /* from RFC 1340. */\n \n-/* Use this type to inform GCC that ip_sum violates aliasing rules. */\n-typedef unaligned_uint16_t alias_int16_t __attribute__((__may_alias__));\n-\n-static inline uint16_t\n-ip_sum(const alias_int16_t *hdr, int hdr_len)\n-{\n-\tuint32_t sum = 0;\n-\n-\twhile (hdr_len > 1)\n-\t{\n-\t\tsum += *hdr++;\n-\t\tif (sum & 0x80000000)\n-\t\t\tsum = (sum & 0xFFFF) + (sum >> 16);\n-\t\thdr_len -= 2;\n-\t}\n-\n-\twhile (sum >> 16)\n-\t\tsum = (sum & 0xFFFF) + (sum >> 16);\n-\n-\treturn ~sum;\n-}\n-\n /*\n * Multi-flow generation mode.\n *\n@@ -160,8 +138,7 @@ pkt_burst_flow_gen(struct fwd_stream *fs)\n \t\t\t\t\t\t\t\t next_flow);\n \t\t\tip_hdr->total_length\t= RTE_CPU_TO_BE_16(pkt_size -\n \t\t\t\t\t\t\t\t sizeof(*eth_hdr));\n-\t\t\tip_hdr->hdr_checksum\t= ip_sum((const alias_int16_t *)ip_hdr,\n-\t\t\t\t\t\t\t sizeof(*ip_hdr));\n+\t\t\tip_hdr->hdr_checksum\t= rte_ipv4_cksum(ip_hdr);\n \n \t\t\t/* Initialize UDP header. */\n \t\t\tudp_hdr = (struct rte_udp_hdr *)(ip_hdr + 1);\n", "prefixes": [ "v3", "2/4" ] }