Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96870/?format=api
{ "id": 96870, "url": "http://patchwork.dpdk.org/api/patches/96870/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210812142436.108053-2-ciara.power@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210812142436.108053-2-ciara.power@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210812142436.108053-2-ciara.power@intel.com", "date": "2021-08-12T14:24:34", "name": "[v1,1/2] examples/fips_validation: fix unused malloc", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6dc5fd75740e15d25332e9ded27011be932fe5aa", "submitter": { "id": 978, "url": "http://patchwork.dpdk.org/api/people/978/?format=api", "name": "Power, Ciara", "email": "ciara.power@intel.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210812142436.108053-2-ciara.power@intel.com/mbox/", "series": [ { "id": 18266, "url": "http://patchwork.dpdk.org/api/series/18266/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18266", "date": "2021-08-12T14:24:33", "name": "fips validation app fixes", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18266/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96870/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/96870/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 98236A0C4E;\n\tThu, 12 Aug 2021 16:24:48 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D075D41124;\n\tThu, 12 Aug 2021 16:24:44 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 549F2410F8;\n Thu, 12 Aug 2021 16:24:43 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Aug 2021 07:24:42 -0700", "from silpixa00400355.ir.intel.com (HELO\n silpixa00400355.ger.corp.intel.com) ([10.237.223.24])\n by FMSMGA003.fm.intel.com with ESMTP; 12 Aug 2021 07:24:39 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10074\"; a=\"279103352\"", "E=Sophos;i=\"5.84,316,1620716400\"; d=\"scan'208\";a=\"279103352\"", "E=Sophos;i=\"5.84,316,1620716400\"; d=\"scan'208\";a=\"517474755\"" ], "X-ExtLoop1": "1", "From": "Ciara Power <ciara.power@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, roy.fan.zhang@intel.com,\n Ciara Power <ciara.power@intel.com>, damianx.nowak@intel.com,\n Marko Kovacevic <marko.kovacevic@intel.com>", "Date": "Thu, 12 Aug 2021 14:24:34 +0000", "Message-Id": "<20210812142436.108053-2-ciara.power@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210812142436.108053-1-ciara.power@intel.com>", "References": "<20210812142436.108053-1-ciara.power@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 1/2] examples/fips_validation: fix unused\n malloc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The val.val pointer is allocated memory, however this memory is then\nfreed in get_writeback_data() without being used beforehand.\nThe pointer is then allocated memory again before use,\nso the very first allocation is removed as it was unnecessary.\n\nFixes: f4797bae0050 (\"examples/fips_validation: support plain SHA\")\nCc: damianx.nowak@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\n---\n examples/fips_validation/main.c | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c\nindex c175fe6ac2..2db00620ce 100644\n--- a/examples/fips_validation/main.c\n+++ b/examples/fips_validation/main.c\n@@ -1635,7 +1635,6 @@ fips_mct_sha_test(void)\n \tint ret;\n \tuint32_t i, j;\n \n-\tval.val = rte_malloc(NULL, (MAX_DIGEST_SIZE*SHA_MD_BLOCK), 0);\n \tfor (i = 0; i < SHA_MD_BLOCK; i++)\n \t\tmd[i].val = rte_malloc(NULL, (MAX_DIGEST_SIZE*2), 0);\n \n", "prefixes": [ "v1", "1/2" ] }