Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96878/?format=api
{ "id": 96878, "url": "http://patchwork.dpdk.org/api/patches/96878/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210813062154.62985-1-haiyue.wang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210813062154.62985-1-haiyue.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210813062154.62985-1-haiyue.wang@intel.com", "date": "2021-08-13T06:21:54", "name": "[v1] net/ice: fix memzone leak when device init failed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ede465889235ca17ce0d2d1436e276c8aa8f0b30", "submitter": { "id": 1044, "url": "http://patchwork.dpdk.org/api/people/1044/?format=api", "name": "Wang, Haiyue", "email": "haiyue.wang@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210813062154.62985-1-haiyue.wang@intel.com/mbox/", "series": [ { "id": 18273, "url": "http://patchwork.dpdk.org/api/series/18273/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18273", "date": "2021-08-13T06:21:54", "name": "[v1] net/ice: fix memzone leak when device init failed", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18273/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96878/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/96878/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 074C8A0C4D;\n\tFri, 13 Aug 2021 08:45:45 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7B92E40DF4;\n\tFri, 13 Aug 2021 08:45:45 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id C6B6E40151;\n Fri, 13 Aug 2021 08:45:42 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Aug 2021 23:45:41 -0700", "from npg-dpdk-haiyue-1.sh.intel.com ([10.67.118.197])\n by orsmga008.jf.intel.com with ESMTP; 12 Aug 2021 23:45:38 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10074\"; a=\"195099940\"", "E=Sophos;i=\"5.84,318,1620716400\"; d=\"scan'208\";a=\"195099940\"", "E=Sophos;i=\"5.84,318,1620716400\"; d=\"scan'208\";a=\"470005971\"" ], "X-ExtLoop1": "1", "From": "Haiyue Wang <haiyue.wang@intel.com>", "To": "dev@dpdk.org", "Cc": "qi.z.zhang@intel.com, Haiyue Wang <haiyue.wang@intel.com>,\n stable@dpdk.org,\n David Marchand <david.marchand@redhat.com>,\n Qiming Yang <qiming.yang@intel.com>, Xiaolong Ye <xiaolong.ye@intel.com>,\n Beilei Xing <beilei.xing@intel.com>, Ying A Wang <ying.a.wang@intel.com>", "Date": "Fri, 13 Aug 2021 14:21:54 +0800", "Message-Id": "<20210813062154.62985-1-haiyue.wang@intel.com>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1] net/ice: fix memzone leak when device init\n failed", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When flow engine initialization or FXP resource reset failed, it needs\nto free the memory zone and unregister the interrupt callback.\n\nBugzilla ID: 752\nFixes: 84dc7a95a2d3 (\"net/ice: enable flow director engine\")\nFixes: 7615a6895009 (\"net/ice: rework for generic flow enabling\")\nFixes: 7edc7158d771 (\"net/ice: cleanup RSS/FDIR profile on device init\")\nCc: stable@dpdk.org\n\nReported-by: David Marchand <david.marchand@redhat.com>\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n drivers/net/ice/ice_ethdev.c | 10 ++++++++--\n drivers/net/ice/ice_fdir_filter.c | 2 ++\n 2 files changed, 10 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 64ee569525..8d62b84805 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -2139,20 +2139,26 @@ ice_dev_init(struct rte_eth_dev *dev)\n \t\tret = ice_flow_init(ad);\n \t\tif (ret) {\n \t\t\tPMD_INIT_LOG(ERR, \"Failed to initialize flow\");\n-\t\t\treturn ret;\n+\t\t\tgoto err_flow_init;\n \t\t}\n \t}\n \n \tret = ice_reset_fxp_resource(hw);\n \tif (ret) {\n \t\tPMD_INIT_LOG(ERR, \"Failed to reset fxp resource\");\n-\t\treturn ret;\n+\t\tgoto err_flow_init;\n \t}\n \n \tpf->supported_rxdid = ice_get_supported_rxdid(hw);\n \n \treturn 0;\n \n+err_flow_init:\n+\tice_flow_uninit(ad);\n+\trte_intr_disable(intr_handle);\n+\tice_pf_disable_irq0(hw);\n+\trte_intr_callback_unregister(intr_handle,\n+\t\t\t\t ice_interrupt_handler, dev);\n err_pf_setup:\n \tice_res_pool_destroy(&pf->msix_pool);\n err_msix_pool_init:\ndiff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c\nindex 82adb1fc8b..7ba65b9b04 100644\n--- a/drivers/net/ice/ice_fdir_filter.c\n+++ b/drivers/net/ice/ice_fdir_filter.c\n@@ -651,8 +651,10 @@ ice_fdir_teardown(struct ice_pf *pf)\n \n \tice_tx_queue_release(pf->fdir.txq);\n \tpf->fdir.txq = NULL;\n+\trte_eth_dma_zone_free(eth_dev, \"fdir_tx_ring\", ICE_FDIR_QUEUE_ID);\n \tice_rx_queue_release(pf->fdir.rxq);\n \tpf->fdir.rxq = NULL;\n+\trte_eth_dma_zone_free(eth_dev, \"fdir_rx_ring\", ICE_FDIR_QUEUE_ID);\n \tice_fdir_prof_rm_all(pf);\n \tice_fdir_prof_free(hw);\n \tice_release_vsi(vsi);\n", "prefixes": [ "v1" ] }