Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96886/?format=api
{ "id": 96886, "url": "http://patchwork.dpdk.org/api/patches/96886/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210813080548.38637-3-wangzhihong.wzh@bytedance.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210813080548.38637-3-wangzhihong.wzh@bytedance.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210813080548.38637-3-wangzhihong.wzh@bytedance.com", "date": "2021-08-13T08:05:46", "name": "[v5,2/4] app/testpmd: use rte_ipv4_cksum in flowgen", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "248abcc7703e05abbf162b26318efe119bf54f91", "submitter": { "id": 2312, "url": "http://patchwork.dpdk.org/api/people/2312/?format=api", "name": "王志宏", "email": "wangzhihong.wzh@bytedance.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210813080548.38637-3-wangzhihong.wzh@bytedance.com/mbox/", "series": [ { "id": 18277, "url": "http://patchwork.dpdk.org/api/series/18277/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18277", "date": "2021-08-13T08:05:44", "name": "app/testpmd: flowgen fixes and improvements", "version": 5, "mbox": "http://patchwork.dpdk.org/series/18277/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96886/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96886/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 518D5A0C4D;\n\tFri, 13 Aug 2021 10:06:12 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 04AEA41249;\n\tFri, 13 Aug 2021 10:06:04 +0200 (CEST)", "from mail-pj1-f46.google.com (mail-pj1-f46.google.com\n [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 8D16340140\n for <dev@dpdk.org>; Fri, 13 Aug 2021 10:06:03 +0200 (CEST)", "by mail-pj1-f46.google.com with SMTP id nt11so14207526pjb.2\n for <dev@dpdk.org>; Fri, 13 Aug 2021 01:06:03 -0700 (PDT)", "from C02D70YZMD6R.bytedance.net ([139.177.225.227])\n by smtp.gmail.com with ESMTPSA id 17sm1118192pjd.3.2021.08.13.01.05.59\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Fri, 13 Aug 2021 01:06:01 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bytedance-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=4WkkGbrM9kTA3awyUAX53a5Faspeo7cNKAEaYZ117zk=;\n b=qL9pA4rxQqcj5LEO8BzTg+WGjPpcqmJEeAnO9CZgdfKsELEr7MhTIIxz3bYW/iwcDv\n F0EaM7yIWYdbOCX4yv/yY0i1WjDPQh3Ep1svjRXBJRXlV2EP6x26wo0IbJ6eCYksGV3u\n W27zyjs9vH4fWujXjNwnPs9flHI683q7g9PTX1qIl0bjiuettdI8EPE9QBGoSnruuhwm\n hK0wEO6idNLCO/sz50kTOuNaaUwtQ3c6uvnepIPs2EAoK9s/7QwcqP8hRbyoWvcGFusc\n TMuvkiOntbK+KSQNR5peC6SbxyGumsK2D7+yCx69pk8nvx5RBvx9OhhBbWoPieg/H2ZI\n HlLg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=4WkkGbrM9kTA3awyUAX53a5Faspeo7cNKAEaYZ117zk=;\n b=d7Y1LVMv/+DWZEKHZJzhDCMCLSEaK0HMMkYhLXhQev7rm1dII8Bn/ld9B+XM2LtCLU\n n69YzOgGQegf+jjxOSlkiAj6caONe9VJfT7QFwVQe6sgCknSu+o24rkTSEtL471pRpm1\n L0ja93XjgPOtf1IXsny+JpeysDmqL1d0PkuHh2o6DjN8safkXUII2zW0r7cZzfa0KmyU\n tbAoQ6RQCPen4mQQj6e2f52aK4aG05h2NwPFSMLDtKOyUz9TRmWgQ3A+zZ8y8AjGHBdb\n eb6Y084o+0BNVc1xs/g5flB/msFG/aZzN9gJvxL5sgc963MQvWGvmTSmWVfViD1ziOK9\n dGRA==", "X-Gm-Message-State": "AOAM5327Y+ilYUuwYsCNKl3XbD7o58exuGBO84ba72VI0s2zp/82X/Hk\n omGbrp5jtfG8+H+tVIOKnVim5jZ0SIdtEQ==", "X-Google-Smtp-Source": "\n ABdhPJxtytvHe1B1tfkmreck8jN0dmmdAN9wCiP4Wu00mL461OWDcuHiRWpLORFWYnLeyNtcZSwfrQ==", "X-Received": "by 2002:a65:5186:: with SMTP id h6mr1293465pgq.62.1628841962481;\n Fri, 13 Aug 2021 01:06:02 -0700 (PDT)", "From": "Zhihong Wang <wangzhihong.wzh@bytedance.com>", "To": "dev@dpdk.org, ferruh.yigit@intel.com, xiaoyun.li@intel.com,\n aman.deep.singh@intel.com, irusskikh@marvell.com, cchemparathy@tilera.com", "Cc": "Zhihong Wang <wangzhihong.wzh@bytedance.com>", "Date": "Fri, 13 Aug 2021 16:05:46 +0800", "Message-Id": "<20210813080548.38637-3-wangzhihong.wzh@bytedance.com>", "X-Mailer": "git-send-email 2.24.3 (Apple Git-128)", "In-Reply-To": "<20210813080548.38637-1-wangzhihong.wzh@bytedance.com>", "References": "<20210809062548.30187-1-wangzhihong.wzh@bytedance.com>\n <20210813080548.38637-1-wangzhihong.wzh@bytedance.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 2/4] app/testpmd: use rte_ipv4_cksum in flowgen", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use the rte_ipv4_cksum API to replace local ip_sum implementation.\n\nSigned-off-by: Zhihong Wang <wangzhihong.wzh@bytedance.com>\nAcked-by: Xiaoyun Li <xiaoyun.li@intel.com>\n---\n app/test-pmd/flowgen.c | 25 +------------------------\n 1 file changed, 1 insertion(+), 24 deletions(-)", "diff": "diff --git a/app/test-pmd/flowgen.c b/app/test-pmd/flowgen.c\nindex f2e6255c36..96d0cc79df 100644\n--- a/app/test-pmd/flowgen.c\n+++ b/app/test-pmd/flowgen.c\n@@ -53,28 +53,6 @@ static struct rte_ether_addr cfg_ether_dst =\n \n #define IP_DEFTTL 64 /* from RFC 1340. */\n \n-/* Use this type to inform GCC that ip_sum violates aliasing rules. */\n-typedef unaligned_uint16_t alias_int16_t __attribute__((__may_alias__));\n-\n-static inline uint16_t\n-ip_sum(const alias_int16_t *hdr, int hdr_len)\n-{\n-\tuint32_t sum = 0;\n-\n-\twhile (hdr_len > 1)\n-\t{\n-\t\tsum += *hdr++;\n-\t\tif (sum & 0x80000000)\n-\t\t\tsum = (sum & 0xFFFF) + (sum >> 16);\n-\t\thdr_len -= 2;\n-\t}\n-\n-\twhile (sum >> 16)\n-\t\tsum = (sum & 0xFFFF) + (sum >> 16);\n-\n-\treturn ~sum;\n-}\n-\n /*\n * Multi-flow generation mode.\n *\n@@ -160,8 +138,7 @@ pkt_burst_flow_gen(struct fwd_stream *fs)\n \t\t\t\t\t\t\t\t next_flow);\n \t\t\tip_hdr->total_length\t= RTE_CPU_TO_BE_16(pkt_size -\n \t\t\t\t\t\t\t\t sizeof(*eth_hdr));\n-\t\t\tip_hdr->hdr_checksum\t= ip_sum((const alias_int16_t *)ip_hdr,\n-\t\t\t\t\t\t\t sizeof(*ip_hdr));\n+\t\t\tip_hdr->hdr_checksum\t= rte_ipv4_cksum(ip_hdr);\n \n \t\t\t/* Initialize UDP header. */\n \t\t\tudp_hdr = (struct rte_udp_hdr *)(ip_hdr + 1);\n", "prefixes": [ "v5", "2/4" ] }