Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96888/?format=api
{ "id": 96888, "url": "http://patchwork.dpdk.org/api/patches/96888/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210813080548.38637-5-wangzhihong.wzh@bytedance.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210813080548.38637-5-wangzhihong.wzh@bytedance.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210813080548.38637-5-wangzhihong.wzh@bytedance.com", "date": "2021-08-13T08:05:48", "name": "[v5,4/4] app/testpmd: use per-core variable in flowgen", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "acdbcebf97f9ed0618f25f1ace2c2d55b6b2f8d3", "submitter": { "id": 2312, "url": "http://patchwork.dpdk.org/api/people/2312/?format=api", "name": "王志宏", "email": "wangzhihong.wzh@bytedance.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210813080548.38637-5-wangzhihong.wzh@bytedance.com/mbox/", "series": [ { "id": 18277, "url": "http://patchwork.dpdk.org/api/series/18277/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18277", "date": "2021-08-13T08:05:44", "name": "app/testpmd: flowgen fixes and improvements", "version": 5, "mbox": "http://patchwork.dpdk.org/series/18277/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96888/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/96888/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CE2A8A0C4D;\n\tFri, 13 Aug 2021 10:06:24 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C7E3E40DF4;\n\tFri, 13 Aug 2021 10:06:12 +0200 (CEST)", "from mail-pj1-f51.google.com (mail-pj1-f51.google.com\n [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 3076740140\n for <dev@dpdk.org>; Fri, 13 Aug 2021 10:06:11 +0200 (CEST)", "by mail-pj1-f51.google.com with SMTP id\n n13-20020a17090a4e0d00b0017946980d8dso589690pjh.5\n for <dev@dpdk.org>; Fri, 13 Aug 2021 01:06:11 -0700 (PDT)", "from C02D70YZMD6R.bytedance.net ([139.177.225.227])\n by smtp.gmail.com with ESMTPSA id 17sm1118192pjd.3.2021.08.13.01.06.06\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Fri, 13 Aug 2021 01:06:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bytedance-com.20150623.gappssmtp.com; s=20150623;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=6GemkUaa0vlWs1s4rI5ZT/10n8WuoFezQYnYqnEzzJo=;\n b=azXEJ3F/4fhPC4e+Cw98q/LNnub3arNJA+rMcuFL1KQQ8LuzQPC61Svmhbxo4Bj4t5\n w68WuoVavC45nC6+xN1KNH8VJ/DAZLQ1tGOURW9PgcovNHTi7kwGzIa4qUmN+4T0Gdj/\n HmvBSdxlRiEihQPzZ6MllX+lii0MKKRvZi1uc8SIvZfR17yoERL2BuXopU9Kj3mUTwPe\n uWX2GKoOnWD9/iZ2pmtxCeaoOtsFDfhmEKNBQXGfOc14TIhV4mQqLXZD8hIaz/vrJGmJ\n 9Zln8ZJ6y65hrZyzots4f96EfRlHkS3+tEc6HcOLpBoaKrTT7/uxy7PrFIuVLAvTaJ3c\n uNaw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20161025;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=6GemkUaa0vlWs1s4rI5ZT/10n8WuoFezQYnYqnEzzJo=;\n b=nbrY7g1WZ8Jz7Afy3W2IXcZs7YNhJTB2rhFXP/6ksqrrIX6HByoB2tx2WmqQpTOgdA\n trGoXw4qE/VfeUPJVKT34gwCheqoWxp6I4WsWQiKkPDNMV9AIBzF98FNDJsyl4QCi8lU\n M7cJUQgjOBfTU90y2EYUGRcCOvGYcP0OcxTUy9ym8OwtyF/7f/JwUx105r9Plf/laQ60\n Xwm4W9L2T1cM1AvkmEfADLZzWJ0kdTdCQZyRDcGcK2Jlj0xa+SW5+X7lJF5426FAYT6t\n 0JvB1TGp9e8vGLMD073p13ou4k3GNrLEz+TDtArFlxEMV/jEHcWXUGd+6df8xxHqznuF\n q5MQ==", "X-Gm-Message-State": "AOAM533UsAJCSnBEjiU5MfCSKzC8+ScvjXP7XN/LBE3lq61JsOeTWNKY\n qPFxKPdtcVR3G3OYgPq7vitZs4IwHO3+Vg==", "X-Google-Smtp-Source": "\n ABdhPJzzxDMNhklRdR2DOEfFK1L5RLfh4DYygG38IixDKtY6awoQP4IlafHvsKLHaMPBb1KDHfSDrQ==", "X-Received": "by 2002:a63:5901:: with SMTP id n1mr1254494pgb.378.1628841970140;\n Fri, 13 Aug 2021 01:06:10 -0700 (PDT)", "From": "Zhihong Wang <wangzhihong.wzh@bytedance.com>", "To": "dev@dpdk.org, ferruh.yigit@intel.com, xiaoyun.li@intel.com,\n aman.deep.singh@intel.com, irusskikh@marvell.com, cchemparathy@tilera.com", "Cc": "Zhihong Wang <wangzhihong.wzh@bytedance.com>", "Date": "Fri, 13 Aug 2021 16:05:48 +0800", "Message-Id": "<20210813080548.38637-5-wangzhihong.wzh@bytedance.com>", "X-Mailer": "git-send-email 2.24.3 (Apple Git-128)", "In-Reply-To": "<20210813080548.38637-1-wangzhihong.wzh@bytedance.com>", "References": "<20210809062548.30187-1-wangzhihong.wzh@bytedance.com>\n <20210813080548.38637-1-wangzhihong.wzh@bytedance.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 4/4] app/testpmd: use per-core variable in\n flowgen", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use per-core variable for flow indexing to solve cache contention in\nmulti-core scenarios.\n\nSigned-off-by: Zhihong Wang <wangzhihong.wzh@bytedance.com>\nAcked-by: Xiaoyun Li <xiaoyun.li@intel.com>\n---\nv5: replace modulo operation to improve performance\nv4: use loop local variable to improve performance\n\n app/test-pmd/flowgen.c | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test-pmd/flowgen.c b/app/test-pmd/flowgen.c\nindex 229794ee9c..9348618d0f 100644\n--- a/app/test-pmd/flowgen.c\n+++ b/app/test-pmd/flowgen.c\n@@ -53,6 +53,8 @@ static struct rte_ether_addr cfg_ether_dst =\n \n #define IP_DEFTTL 64 /* from RFC 1340. */\n \n+RTE_DEFINE_PER_LCORE(int, _next_flow);\n+\n /*\n * Multi-flow generation mode.\n *\n@@ -80,7 +82,7 @@ pkt_burst_flow_gen(struct fwd_stream *fs)\n \tuint32_t retry;\n \tuint64_t tx_offloads;\n \tuint64_t start_tsc = 0;\n-\tstatic int next_flow = 0;\n+\tint next_flow = RTE_PER_LCORE(_next_flow);\n \n \tget_start_cycles(&start_tsc);\n \n@@ -163,7 +165,8 @@ pkt_burst_flow_gen(struct fwd_stream *fs)\n \t\t}\n \t\tpkts_burst[nb_pkt] = pkt;\n \n-\t\tnext_flow = (next_flow + 1) % cfg_n_flows;\n+\t\tif (++next_flow >= (int)cfg_n_flows)\n+\t\t\tnext_flow = 0;\n \t}\n \n \tnb_tx = rte_eth_tx_burst(fs->tx_port, fs->tx_queue, pkts_burst, nb_pkt);\n@@ -193,6 +196,8 @@ pkt_burst_flow_gen(struct fwd_stream *fs)\n \t\t} while (++nb_tx < nb_pkt);\n \t}\n \n+\tRTE_PER_LCORE(_next_flow) = next_flow;\n+\n \tget_end_cycles(fs, start_tsc);\n }\n \n", "prefixes": [ "v5", "4/4" ] }