Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96940/?format=api
{ "id": 96940, "url": "http://patchwork.dpdk.org/api/patches/96940/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1629093590-115-4-git-send-email-anoobj@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1629093590-115-4-git-send-email-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1629093590-115-4-git-send-email-anoobj@marvell.com", "date": "2021-08-16T05:59:50", "name": "[3/3] test/crypto: add outbound known vector tests", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4993e8753dccfe3b9cf5d09f49a0dd92f34b2bc2", "submitter": { "id": 1205, "url": "http://patchwork.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1629093590-115-4-git-send-email-anoobj@marvell.com/mbox/", "series": [ { "id": 18292, "url": "http://patchwork.dpdk.org/api/series/18292/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18292", "date": "2021-08-16T05:59:47", "name": "Add user specified IV with lookaside IPsec", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18292/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96940/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/96940/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 34507A0C46;\n\tMon, 16 Aug 2021 08:00:51 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 891784114C;\n\tMon, 16 Aug 2021 08:00:48 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 195FA41123\n for <dev@dpdk.org>; Mon, 16 Aug 2021 08:00:46 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id\n 17FMSmSm017193;\n Sun, 15 Aug 2021 23:00:46 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com with ESMTP id 3af0pthwjx-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Sun, 15 Aug 2021 23:00:46 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Sun, 15 Aug 2021 23:00:44 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Sun, 15 Aug 2021 23:00:44 -0700", "from HY-LT1002.marvell.com (unknown [10.193.36.215])\n by maili.marvell.com (Postfix) with ESMTP id 7A2C85B695C;\n Sun, 15 Aug 2021 23:00:39 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=E4RHCop3usnpjvFIhtaN0++JUxMBFZT3Quvk8sESZzE=;\n b=ZZQxbSwUMPu8qqw+jSYALFIH/rP4r6+kLY1asSeHO3b1pB2/g0hPyjGOAyFQSzLQDTqZ\n xbf7VJmNXGDtgVfUQh4Z+GdE5fXSRsscvF9Obc7XoDxF9kzarkty50+U03Km5JfTuc5S\n yb6DBaJDKCgrHPXjHzAsGV4XEFg9eSwK1BRtGbQZVUS+4x9UPF2GN/RSA5TVNL5esBtP\n f20frnsGGAshbFv+s6MAwclU7wcGNLUq849i4MN8M50CJMtWgvGpiqgNB5Xi1oauTBz6\n Xj2Qj9epAeZPMZdFid72ZYFkLWl1Lvvf8Ld3q7e1g1L2/oYqJbm8KQy44/ttiSrMNj+o kg==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>, Declan Doherty\n <declan.doherty@intel.com>, Fan Zhang <roy.fan.zhang@intel.com>,\n \"Konstantin Ananyev\" <konstantin.ananyev@intel.com>", "CC": "Anoob Joseph <anoobj@marvell.com>, Jerin Jacob <jerinj@marvell.com>,\n Archana Muniganti <marchana@marvell.com>, Tejasree Kondoj\n <ktejasree@marvell.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, \"Radu\n Nicolau\" <radu.nicolau@intel.com>,\n Ciara Power <ciara.power@intel.com>, <dev@dpdk.org>", "Date": "Mon, 16 Aug 2021 11:29:50 +0530", "Message-ID": "<1629093590-115-4-git-send-email-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1629093590-115-1-git-send-email-anoobj@marvell.com>", "References": "<1629093590-115-1-git-send-email-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "hILn4-f6laIHowfD4Vu4S9DSvBDh5i83", "X-Proofpoint-ORIG-GUID": "hILn4-f6laIHowfD4Vu4S9DSvBDh5i83", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475\n definitions=2021-08-16_02,2021-08-13_02,2020-04-07_01", "Subject": "[dpdk-dev] [PATCH 3/3] test/crypto: add outbound known vector tests", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add outbound known vector tests. The tests would be skipped on PMDs\nwhich do not support IV provided by application.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Tejasree Kondoj <ktejasree@marvell.com>\n---\n app/test/test_cryptodev.c | 44 ++++++++++++++++++++++++++++++++\n app/test/test_cryptodev_security_ipsec.c | 16 +++++++++++-\n 2 files changed, 59 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex 71e6c1a..dfc49e0 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -8975,6 +8975,22 @@ test_ipsec_proto_process(const struct ipsec_test_data td[],\n \t\tut_params->op->sym->m_src = ut_params->ibuf;\n \t\tut_params->op->sym->m_dst = NULL;\n \n+\t\t/* Copy IV in crypto operation when IV generation is disabled */\n+\t\tif (dir == RTE_SECURITY_IPSEC_SA_DIR_EGRESS &&\n+\t\t ipsec_xform.options.iv_gen_disable == 1) {\n+\t\t\tuint8_t *iv = rte_crypto_op_ctod_offset(ut_params->op,\n+\t\t\t\t\t\t\t\tuint8_t *,\n+\t\t\t\t\t\t\t\tIV_OFFSET);\n+\t\t\tint len;\n+\n+\t\t\tif (td[i].aead)\n+\t\t\t\tlen = td[i].xform.aead.aead.iv.length;\n+\t\t\telse\n+\t\t\t\tlen = td[i].xform.chain.cipher.cipher.iv.length;\n+\n+\t\t\tmemcpy(iv, td[i].iv.data, len);\n+\t\t}\n+\n \t\t/* Process crypto operation */\n \t\tprocess_crypto_request(dev_id, ut_params->op);\n \n@@ -9012,6 +9028,22 @@ test_ipsec_proto_process(const struct ipsec_test_data td[],\n }\n \n static int\n+test_ipsec_proto_known_vec(const void *test_data)\n+{\n+\tstruct ipsec_test_data td_outb;\n+\tstruct ipsec_test_flags flags;\n+\n+\tmemset(&flags, 0, sizeof(flags));\n+\n+\tmemcpy(&td_outb, test_data, sizeof(td_outb));\n+\n+\t/* Disable IV gen to be able to test with known vectors */\n+\ttd_outb.ipsec_xform.options.iv_gen_disable = 1;\n+\n+\treturn test_ipsec_proto_process(&td_outb, NULL, 1, false, &flags);\n+}\n+\n+static int\n test_ipsec_proto_known_vec_inb(const void *td_outb)\n {\n \tstruct ipsec_test_flags flags;\n@@ -14003,6 +14035,18 @@ static struct unit_test_suite ipsec_proto_testsuite = {\n \t.setup = ipsec_proto_testsuite_setup,\n \t.unit_test_cases = {\n \t\tTEST_CASE_NAMED_WITH_DATA(\n+\t\t\t\"Outbound known vector (ESP tunnel mode IPv4 AES-GCM 128)\",\n+\t\t\tut_setup_security, ut_teardown,\n+\t\t\ttest_ipsec_proto_known_vec, &pkt_aes_128_gcm),\n+\t\tTEST_CASE_NAMED_WITH_DATA(\n+\t\t\t\"Outbound known vector (ESP tunnel mode IPv4 AES-GCM 192)\",\n+\t\t\tut_setup_security, ut_teardown,\n+\t\t\ttest_ipsec_proto_known_vec, &pkt_aes_192_gcm),\n+\t\tTEST_CASE_NAMED_WITH_DATA(\n+\t\t\t\"Outbound known vector (ESP tunnel mode IPv4 AES-GCM 256)\",\n+\t\t\tut_setup_security, ut_teardown,\n+\t\t\ttest_ipsec_proto_known_vec, &pkt_aes_256_gcm),\n+\t\tTEST_CASE_NAMED_WITH_DATA(\n \t\t\t\"Inbound known vector (ESP tunnel mode IPv4 AES-GCM 128)\",\n \t\t\tut_setup_security, ut_teardown,\n \t\t\ttest_ipsec_proto_known_vec_inb, &pkt_aes_128_gcm),\ndiff --git a/app/test/test_cryptodev_security_ipsec.c b/app/test/test_cryptodev_security_ipsec.c\nindex 78c7f3a..a0b37e7 100644\n--- a/app/test/test_cryptodev_security_ipsec.c\n+++ b/app/test/test_cryptodev_security_ipsec.c\n@@ -76,6 +76,15 @@ test_ipsec_sec_caps_verify(struct rte_security_ipsec_xform *ipsec_xform,\n \t\treturn -ENOTSUP;\n \t}\n \n+\tif ((ipsec_xform->direction == RTE_SECURITY_IPSEC_SA_DIR_EGRESS) &&\n+\t (ipsec_xform->options.iv_gen_disable == 1) &&\n+\t (sec_cap->ipsec.options.iv_gen_disable != 1)) {\n+\t\tif (!silent)\n+\t\t\tRTE_LOG(INFO, USER1,\n+\t\t\t\t\"Application provided IV is not supported\\n\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\n \treturn 0;\n }\n \n@@ -160,9 +169,11 @@ test_ipsec_td_prepare(const struct crypto_param *param1,\n \n \t\ttd->xform.aead.aead.algo = param1->alg.aead;\n \t\ttd->xform.aead.aead.key.length = param1->key_length;\n+\n+\t\tif (flags->iv_gen)\n+\t\t\ttd->ipsec_xform.options.iv_gen_disable = 0;\n \t}\n \n-\tRTE_SET_USED(flags);\n \tRTE_SET_USED(param2);\n }\n \n@@ -183,6 +194,9 @@ test_ipsec_td_update(struct ipsec_test_data td_inb[],\n \t\t\tint icv_pos = td_inb[i].input_text.len - 4;\n \t\t\ttd_inb[i].input_text.data[icv_pos] += 1;\n \t\t}\n+\n+\t\t/* Clear outbound specific flags */\n+\t\ttd_inb[i].ipsec_xform.options.iv_gen_disable = 0;\n \t}\n }\n \n", "prefixes": [ "3/3" ] }