Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96961/?format=api
{ "id": 96961, "url": "http://patchwork.dpdk.org/api/patches/96961/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210817032723.3997054-4-jerinj@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210817032723.3997054-4-jerinj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210817032723.3997054-4-jerinj@marvell.com", "date": "2021-08-17T03:27:20", "name": "[v2,3/6] eal: support libunwind based backtrace", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ad0450bfb9d69be65a5587a6d8756600075768c3", "submitter": { "id": 1188, "url": "http://patchwork.dpdk.org/api/people/1188/?format=api", "name": "Jerin Jacob Kollanukkaran", "email": "jerinj@marvell.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210817032723.3997054-4-jerinj@marvell.com/mbox/", "series": [ { "id": 18300, "url": "http://patchwork.dpdk.org/api/series/18300/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18300", "date": "2021-08-17T03:27:17", "name": "support oops handling", "version": 2, "mbox": "http://patchwork.dpdk.org/series/18300/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96961/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96961/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E1E1AA0548;\n\tTue, 17 Aug 2021 05:30:13 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CECAF41179;\n\tTue, 17 Aug 2021 05:30:12 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id A224741173\n for <dev@dpdk.org>; Tue, 17 Aug 2021 05:30:11 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id\n 17H2m146006952;\n Mon, 16 Aug 2021 20:30:08 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com with ESMTP id 3ag4n0r3ua-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 16 Aug 2021 20:30:08 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 16 Aug 2021 20:30:07 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 16 Aug 2021 20:30:06 -0700", "from jerin-lab.marvell.com (jerin-lab.marvell.com [10.28.34.14])\n by maili.marvell.com (Postfix) with ESMTP id 600873F70C1;\n Mon, 16 Aug 2021 20:30:01 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=EAgptWyKHT4v6Ze/bE48WNBxLpUk69lCXPDlMiIKirQ=;\n b=j8NLK7+XHA3OSbzfHR9rxLNeaNa5vwnbNTlA+XlIn6Wn6H4zphqeGpfZElfTdafZtrTx\n lyvIlneRQtsn8RTJ2n8wgoQyRdJDZo0Gvz24AkfxAlqYV2k6nQ33hS7vuBC8LrCK0FYT\n 1JJxqBmy1Pz5U7F/N13mgpMEWcMautIGNN2OyFRaQbS/s2Dr/DQhzpNTOYauBRVwYseH\n 6pT2lrlZAiZPbxAqismJfufzWgKH/HSxwEQKEwx/xeqpYCLkn8fKKtSXKs5J5rKHPYeu\n pp8e80OuUrDl4bFZxnGpsdrxCGm65z6tyqWYQ1/4ieqQ7N0ez4h0DNCt6W5C0nquZef+ wg==", "From": "<jerinj@marvell.com>", "To": "<dev@dpdk.org>, Aaron Conole <aconole@redhat.com>, Michael Santana\n <maicolgabriel@hotmail.com>, Bruce Richardson <bruce.richardson@intel.com>", "CC": "<thomas@monjalon.net>, <david.marchand@redhat.com>,\n <dmitry.kozliuk@gmail.com>, <navasile@linux.microsoft.com>,\n <dmitrym@microsoft.com>, <pallavi.kadam@intel.com>,\n <konstantin.ananyev@intel.com>, <ruifeng.wang@arm.com>,\n <viktorin@rehivetech.com>, <drc@linux.vnet.ibm.com>, Jerin Jacob\n <jerinj@marvell.com>", "Date": "Tue, 17 Aug 2021 08:57:20 +0530", "Message-ID": "<20210817032723.3997054-4-jerinj@marvell.com>", "X-Mailer": "git-send-email 2.32.0", "In-Reply-To": "<20210817032723.3997054-1-jerinj@marvell.com>", "References": "<20210730084938.2426128-2-jerinj@marvell.com>\n <20210817032723.3997054-1-jerinj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "5-ldC3d7udj6QKMny1Bjtj-HxQFS63WE", "X-Proofpoint-ORIG-GUID": "5-ldC3d7udj6QKMny1Bjtj-HxQFS63WE", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475\n definitions=2021-08-17_01,2021-08-16_02,2020-04-07_01", "Subject": "[dpdk-dev] [PATCH v2 3/6] eal: support libunwind based backtrace", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Jerin Jacob <jerinj@marvell.com>\n\nadding optional libwind library dependency to DPDK for\nenhanced backtrace based on ucontext.\n\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\n---\n .github/workflows/build.yml | 2 +-\n .travis.yml | 2 +-\n config/meson.build | 8 +++++++\n lib/eal/unix/eal_oops.c | 47 +++++++++++++++++++++++++++++++++++++\n 4 files changed, 57 insertions(+), 2 deletions(-)", "diff": "diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml\nindex 7dac20ddeb..caaca207a6 100644\n--- a/.github/workflows/build.yml\n+++ b/.github/workflows/build.yml\n@@ -93,7 +93,7 @@ jobs:\n run: sudo apt install -y ccache libnuma-dev python3-setuptools\n python3-wheel python3-pip python3-pyelftools ninja-build libbsd-dev\n libpcap-dev libibverbs-dev libcrypto++-dev libfdt-dev libjansson-dev\n- libarchive-dev\n+ libarchive-dev libunwind-dev\n - name: Install libabigail build dependencies if no cache is available\n if: env.ABI_CHECKS == 'true' && steps.libabigail-cache.outputs.cache-hit != 'true'\n run: sudo apt install -y autoconf automake libtool pkg-config libxml2-dev\ndiff --git a/.travis.yml b/.travis.yml\nindex 23067d9e3c..e72b156014 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -16,7 +16,7 @@ addons:\n packages: &required_packages\n - [libnuma-dev, python3-setuptools, python3-wheel, python3-pip, python3-pyelftools, ninja-build]\n - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson-dev]\n- - [libarchive-dev]\n+ - [libarchive-dev, libunwind-dev]\n \n _aarch64_packages: &aarch64_packages\n - *required_packages\ndiff --git a/config/meson.build b/config/meson.build\nindex e80421003b..26a85dab6b 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -236,6 +236,14 @@ if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false\n dpdk_extra_ldflags += '-latomic'\n endif\n \n+# check for libunwind\n+unwind_dep = dependency('libunwind', required: false, method: 'pkg-config')\n+if unwind_dep.found() and cc.has_header('libunwind.h', dependencies: unwind_dep)\n+ dpdk_conf.set('RTE_USE_LIBUNWIND', 1)\n+ add_project_link_arguments('-lunwind', language: 'c')\n+ dpdk_extra_ldflags += '-lunwind'\n+endif\n+\n # add -include rte_config to cflags\n add_project_arguments('-include', 'rte_config.h', language: 'c')\n \ndiff --git a/lib/eal/unix/eal_oops.c b/lib/eal/unix/eal_oops.c\nindex 7b12cfd5f5..a7f00ecd4e 100644\n--- a/lib/eal/unix/eal_oops.c\n+++ b/lib/eal/unix/eal_oops.c\n@@ -26,6 +26,50 @@ struct oops_signal {\n \n static struct oops_signal signals_db[RTE_DIM(oops_signals)];\n \n+#if defined(RTE_USE_LIBUNWIND)\n+\n+#define BACKTRACE_DEPTH 256\n+#define UNW_LOCAL_ONLY\n+#include <libunwind.h>\n+\n+static void\n+back_trace_dump(ucontext_t *context)\n+{\n+\tunw_cursor_t cursor;\n+\tunw_word_t ip, off;\n+\tint rc, level = 0;\n+\tchar name[256];\n+\n+\tif (context == NULL) {\n+\t\trte_dump_stack();\n+\t\treturn;\n+\t}\n+\n+\trc = unw_init_local(&cursor, (unw_context_t *)context);\n+\tif (rc < 0)\n+\t\tgoto fail;\n+\n+\tfor (;;) {\n+\t\trc = unw_get_reg(&cursor, UNW_REG_IP, &ip);\n+\t\tif (rc < 0)\n+\t\t\tgoto fail;\n+\t\trc = unw_get_proc_name(&cursor, name, sizeof(name), &off);\n+\t\tif (rc == 0)\n+\t\t\toops_print(\"[%16p]: %s()+0x%\" PRIx64 \"\\n\", (void *)ip,\n+\t\t\t\t name, (uint64_t)off);\n+\t\telse\n+\t\t\toops_print(\"[%16p]: <unknown>\\n\", (void *)ip);\n+\t\trc = unw_step(&cursor);\n+\t\tif (rc <= 0 || ++level >= BACKTRACE_DEPTH)\n+\t\t\tbreak;\n+\t}\n+\treturn;\n+fail:\n+\toops_print(\"libunwind call failed %s\\n\", unw_strerror(rc));\n+}\n+\n+#else\n+\n static void\n back_trace_dump(ucontext_t *context)\n {\n@@ -33,6 +77,9 @@ back_trace_dump(ucontext_t *context)\n \n \trte_dump_stack();\n }\n+\n+#endif\n+\n static void\n siginfo_dump(int sig, siginfo_t *info)\n {\n", "prefixes": [ "v2", "3/6" ] }