Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 96990,
    "url": "http://patchwork.dpdk.org/api/patches/96990/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1629207767-262-6-git-send-email-anoobj@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1629207767-262-6-git-send-email-anoobj@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1629207767-262-6-git-send-email-anoobj@marvell.com",
    "date": "2021-08-17T13:42:47",
    "name": "[5/5] test/crypto: add packets hard expiry tests",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "9576d552c262b908ed4c433a5cbbea09d896701b",
    "submitter": {
        "id": 1205,
        "url": "http://patchwork.dpdk.org/api/people/1205/?format=api",
        "name": "Anoob Joseph",
        "email": "anoobj@marvell.com"
    },
    "delegate": {
        "id": 6690,
        "url": "http://patchwork.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1629207767-262-6-git-send-email-anoobj@marvell.com/mbox/",
    "series": [
        {
            "id": 18313,
            "url": "http://patchwork.dpdk.org/api/series/18313/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18313",
            "date": "2021-08-17T13:42:42",
            "name": "Add SA lifetime in security",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/18313/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/96990/comments/",
    "check": "warning",
    "checks": "http://patchwork.dpdk.org/api/patches/96990/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B22F6A0548;\n\tTue, 17 Aug 2021 15:43:44 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7A39E411BA;\n\tTue, 17 Aug 2021 15:43:43 +0200 (CEST)",
            "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 6D4AB411A8\n for <dev@dpdk.org>; Tue, 17 Aug 2021 15:43:41 +0200 (CEST)",
            "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id\n 17H2lbqK006738;\n Tue, 17 Aug 2021 06:43:40 -0700",
            "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com with ESMTP id 3ag4n0tajc-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 17 Aug 2021 06:43:40 -0700",
            "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Tue, 17 Aug 2021 06:43:39 -0700",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Tue, 17 Aug 2021 06:43:39 -0700",
            "from HY-LT1002.marvell.com (unknown [10.193.70.144])\n by maili.marvell.com (Postfix) with ESMTP id 4424B3F7045;\n Tue, 17 Aug 2021 06:43:33 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=U0FYp4Dqo4EuNC69WRlmbxbNsUgBuUE578gapZmbKxg=;\n b=dsudmcn4yP8OyNAxiRbEuhG4K5kJ2Iu4QyoDaljYZsjmKMZWE/8Dsmeo1nv7Oa2R2aaB\n dXUEhjFUhy9bdd/1Q2iXJ1nAJOEI7iTBHZfVlxoycfaEbX3cQWTWH1xBXIyvV4X9s4eI\n Q1b101SKyWJEEtDHqxKzIEF/57YYT1+FTeFPiGoPNg7HmpfMgrPguSVZK6kHn4NXBECN\n IC5CDbs04X/nbGmhHHjFp4Lq6yAH1JuNCOAabKXAWQ5CapCFqZz/VLY7BI2wJ45LfaxO\n sIbrQqSZQGtp8j5jIuG/InJgao3FR25CbgeZWHkVVHGFTBqAD2RLjIMnO+kdrMUOVwD+ 4A==",
        "From": "Anoob Joseph <anoobj@marvell.com>",
        "To": "Akhil Goyal <gakhil@marvell.com>, Declan Doherty\n <declan.doherty@intel.com>, Fan Zhang <roy.fan.zhang@intel.com>,\n \"Konstantin Ananyev\" <konstantin.ananyev@intel.com>",
        "CC": "Anoob Joseph <anoobj@marvell.com>, Jerin Jacob <jerinj@marvell.com>,\n Archana Muniganti <marchana@marvell.com>, Tejasree Kondoj\n <ktejasree@marvell.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, \"Radu\n Nicolau\" <radu.nicolau@intel.com>,\n Ciara Power <ciara.power@intel.com>, <dev@dpdk.org>",
        "Date": "Tue, 17 Aug 2021 19:12:47 +0530",
        "Message-ID": "<1629207767-262-6-git-send-email-anoobj@marvell.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1629207767-262-1-git-send-email-anoobj@marvell.com>",
        "References": "<1629207767-262-1-git-send-email-anoobj@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-GUID": "C6FdpXtCKpQEx8xxzMHiaJVFFAVbkpTW",
        "X-Proofpoint-ORIG-GUID": "C6FdpXtCKpQEx8xxzMHiaJVFFAVbkpTW",
        "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475\n definitions=2021-08-17_04,2021-08-17_02,2020-04-07_01",
        "Subject": "[dpdk-dev] [PATCH 5/5] test/crypto: add packets hard expiry tests",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add tests to validate packets hard expiry handling.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\n---\n app/test/test_cryptodev.c                | 19 ++++++++++++++++++-\n app/test/test_cryptodev_security_ipsec.c | 22 +++++++++++++++++++---\n app/test/test_cryptodev_security_ipsec.h |  1 +\n 3 files changed, 38 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex 2baa569..a7374bf 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -9065,7 +9065,8 @@ test_ipsec_proto_all(const struct ipsec_test_flags *flags)\n \tint ret;\n \n \tif (flags->iv_gen ||\n-\t    flags->sa_expiry_pkts_soft)\n+\t    flags->sa_expiry_pkts_soft ||\n+\t    flags->sa_expiry_pkts_hard)\n \t\tnb_pkts = IPSEC_TEST_PACKETS_MAX;\n \n \tfor (i = 0; i < RTE_DIM(aead_list); i++) {\n@@ -9142,6 +9143,18 @@ test_ipsec_proto_sa_exp_pkts_soft(const void *data __rte_unused)\n }\n \n static int\n+test_ipsec_proto_sa_exp_pkts_hard(const void *data __rte_unused)\n+{\n+\tstruct ipsec_test_flags flags;\n+\n+\tmemset(&flags, 0, sizeof(flags));\n+\n+\tflags.sa_expiry_pkts_hard = true;\n+\n+\treturn test_ipsec_proto_all(&flags);\n+}\n+\n+static int\n test_ipsec_proto_err_icv_corrupt(const void *data __rte_unused)\n {\n \tstruct ipsec_test_flags flags;\n@@ -14084,6 +14097,10 @@ static struct unit_test_suite ipsec_proto_testsuite  = {\n \t\t\tut_setup_security, ut_teardown,\n \t\t\ttest_ipsec_proto_sa_exp_pkts_soft),\n \t\tTEST_CASE_NAMED_ST(\n+\t\t\t\"SA expiry packets hard\",\n+\t\t\tut_setup_security, ut_teardown,\n+\t\t\ttest_ipsec_proto_sa_exp_pkts_hard),\n+\t\tTEST_CASE_NAMED_ST(\n \t\t\t\"Negative test: ICV corruption\",\n \t\t\tut_setup_security, ut_teardown,\n \t\t\ttest_ipsec_proto_err_icv_corrupt),\ndiff --git a/app/test/test_cryptodev_security_ipsec.c b/app/test/test_cryptodev_security_ipsec.c\nindex 9eb610c..efb4c7e 100644\n--- a/app/test/test_cryptodev_security_ipsec.c\n+++ b/app/test/test_cryptodev_security_ipsec.c\n@@ -199,6 +199,10 @@ test_ipsec_td_update(struct ipsec_test_data td_inb[],\n \t\t\ttd_inb[i].input_text.data[icv_pos] += 1;\n \t\t}\n \n+\t\tif (flags->sa_expiry_pkts_hard)\n+\t\t\ttd_inb[i].ipsec_xform.life.packets_hard_limit =\n+\t\t\t\t\tIPSEC_TEST_PACKETS_MAX - 1;\n+\n \t\t/* Clear outbound specific flags */\n \t\ttd_inb[i].ipsec_xform.options.iv_gen_disable = 0;\n \t}\n@@ -281,9 +285,10 @@ test_ipsec_td_verify(struct rte_mbuf *m, const struct ipsec_test_data *td,\n \tuint8_t *output_text = rte_pktmbuf_mtod(m, uint8_t *);\n \tuint32_t skip, len = rte_pktmbuf_pkt_len(m);\n \n-\t/* For negative tests, no need to do verification */\n-\tif (flags->icv_corrupt &&\n-\t    td->ipsec_xform.direction == RTE_SECURITY_IPSEC_SA_DIR_INGRESS)\n+\t/* For tests with status as error for test success, skip verification */\n+\tif (td->ipsec_xform.direction == RTE_SECURITY_IPSEC_SA_DIR_INGRESS &&\n+\t    (flags->icv_corrupt ||\n+\t     flags->sa_expiry_pkts_hard))\n \t\treturn TEST_SUCCESS;\n \n \tif (len != td->output_text.len) {\n@@ -376,6 +381,17 @@ test_ipsec_status_check(struct rte_crypto_op *op,\n {\n \tint ret = TEST_SUCCESS;\n \n+\tif (dir == RTE_SECURITY_IPSEC_SA_DIR_INGRESS &&\n+\t    flags->sa_expiry_pkts_hard &&\n+\t    pkt_num == IPSEC_TEST_PACKETS_MAX) {\n+\t\tif (op->status != RTE_CRYPTO_OP_STATUS_ERROR) {\n+\t\t\tprintf(\"SA hard expiry (pkts) test failed\\n\");\n+\t\t\treturn TEST_FAILED;\n+\t\t} else {\n+\t\t\treturn TEST_SUCCESS;\n+\t\t}\n+\t}\n+\n \tif (dir == RTE_SECURITY_IPSEC_SA_DIR_INGRESS && flags->icv_corrupt) {\n \t\tif (op->status != RTE_CRYPTO_OP_STATUS_ERROR) {\n \t\t\tprintf(\"ICV corruption test case failed\\n\");\ndiff --git a/app/test/test_cryptodev_security_ipsec.h b/app/test/test_cryptodev_security_ipsec.h\nindex 921c58d..2d3dd59 100644\n--- a/app/test/test_cryptodev_security_ipsec.h\n+++ b/app/test/test_cryptodev_security_ipsec.h\n@@ -50,6 +50,7 @@ struct ipsec_test_data {\n struct ipsec_test_flags {\n \tbool display_alg;\n \tbool sa_expiry_pkts_soft;\n+\tbool sa_expiry_pkts_hard;\n \tbool icv_corrupt;\n \tbool iv_gen;\n };\n",
    "prefixes": [
        "5/5"
    ]
}