Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/96993/?format=api
{ "id": 96993, "url": "http://patchwork.dpdk.org/api/patches/96993/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210817134441.1966618-3-michaelba@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210817134441.1966618-3-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210817134441.1966618-3-michaelba@nvidia.com", "date": "2021-08-17T13:44:22", "name": "[RFC,02/21] net/mlx5: fix PCI probing error flow", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "cb96a5e73573b38cfd47843da408232d18d53179", "submitter": { "id": 1949, "url": "http://patchwork.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210817134441.1966618-3-michaelba@nvidia.com/mbox/", "series": [ { "id": 18314, "url": "http://patchwork.dpdk.org/api/series/18314/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18314", "date": "2021-08-17T13:44:20", "name": "mlx5: sharing global MR cache between drivers", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18314/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/96993/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/96993/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0AFBFA0548;\n\tTue, 17 Aug 2021 15:45:36 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D4071411BD;\n\tTue, 17 Aug 2021 15:45:23 +0200 (CEST)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2040.outbound.protection.outlook.com [40.107.93.40])\n by mails.dpdk.org (Postfix) with ESMTP id AA48E411B6;\n Tue, 17 Aug 2021 15:45:21 +0200 (CEST)", "from BN9PR03CA0285.namprd03.prod.outlook.com (2603:10b6:408:f5::20)\n by CY4PR1201MB0104.namprd12.prod.outlook.com (2603:10b6:910:1d::16)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.21; Tue, 17 Aug\n 2021 13:45:20 +0000", "from BN8NAM11FT062.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:f5:cafe::7d) by BN9PR03CA0285.outlook.office365.com\n (2603:10b6:408:f5::20) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16 via Frontend\n Transport; Tue, 17 Aug 2021 13:45:20 +0000", "from mail.nvidia.com (216.228.112.36) by\n BN8NAM11FT062.mail.protection.outlook.com (10.13.177.34) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4415.14 via Frontend Transport; Tue, 17 Aug 2021 13:45:19 +0000", "from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL101.nvidia.com\n (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug\n 2021 13:45:18 +0000", "from nvidia.com (172.20.187.6) by DRHQMAIL107.nvidia.com\n (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug\n 2021 13:45:17 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=josNKzYUXOitTGuuqfuY2NvZOMaZ+hM446zk6SivB/QtYJEL16HkWF5wj/YOEXR9wNOW/eNn0meEOxgc3hsphMjWCJRkP0c2Ezae1Iry6HLkv1kOnB9fb8tmgXQp7xU+AD8kD/4/w7180Pfd9ej632Nh8cd39WC0rSs6x7tTILL2VkLgx3DOad7ZZmlIBbiXAvbk7OEqWew2ehQd7KYbkL2CMcu5sncVPrdMdsGUwgBdBX0YZwoSrrb4PtD2QfhduU9slIBMGwz+MCQZ0cUOqLchhsLYceBchEP2+fSaC+JH2xb4dDE720X2RShtwcMnwuvnuWeDl5jSM3tluVPh1Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=K4LgXbnLSi+y7JrIJvSI2QtzJXe8m+1yWHKToS1s3BU=;\n b=KIpNfwVZ/EosaKkzSaVIDvCxnfjmZ6197ex61VmOOVf4SJtnnlcYf1P9ehT7g+tRG5URFoobv5QcFahwH4gH72ADRwCiciJ1VGxpchATjwusaD1thN6AQOISImBUa2AQ3x2m/+QRxFIUkhW4E8AQj7vE3sqpPdZup3HueNgCWL6fd7VTq9HRbMGRR8b6B76ZjTcxE0GdhxdHwSnBGK3vFAz5jloV1tSkuppCbJOTBTZ3a0RK7tyi/PpbfN6d8Mrf74sUxCVH77Xwl9YEm6KS3Edely4i6Kgl08wfe0kzOqW7UpZMlZ2pfVOUkCGWy5uaKM1PCFzqiN2GVNGAr5QSfg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.36) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=K4LgXbnLSi+y7JrIJvSI2QtzJXe8m+1yWHKToS1s3BU=;\n b=lUUubme9iSDo2ZX2upQY/FwIZTWffWiLbn5eXK7cmLI82vrERq35Q5P/CF5GNeoZy62FscqEenuuWUQm+8lVU/OIP+uMUGf+n/UdLCePVgoANu0gHyUL07DGYD3P6p99OeQcEVuN+KsOBBh8+KhFwJWRMdIF2n4NJWzCEebEPwd3t8RIOW7lYmpZKUpP8SpUU5sPPln9HiQyWty9D5FgZn2AngdrBMzCZHdCGF5sIU4fARsnNC7bKoeYuduY87t1a5ChkMTtcEQnQ8OFcrlYsQbRXF8euB+VgI+mYde5xtCxx1LXV6Yr4WVBY5Ngac4MHyrXrhd2A6hGNpNa4DXQtA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.36)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.36 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.36; helo=mail.nvidia.com;", "From": "Michael Baum <michaelba@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>, <stable@dpdk.org>", "Date": "Tue, 17 Aug 2021 16:44:22 +0300", "Message-ID": "<20210817134441.1966618-3-michaelba@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210817134441.1966618-1-michaelba@nvidia.com>", "References": "<20210817134441.1966618-1-michaelba@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.6]", "X-ClientProxiedBy": "HQMAIL111.nvidia.com (172.20.187.18) To\n DRHQMAIL107.nvidia.com (10.27.9.16)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "ee72ca34-8876-4b73-3abd-08d9618540f9", "X-MS-TrafficTypeDiagnostic": "CY4PR1201MB0104:", "X-Microsoft-Antispam-PRVS": "\n <CY4PR1201MB0104C5BFE8C6DC93F692F4B1CCFE9@CY4PR1201MB0104.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:4303;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n PVt138q5FObe8Yk4EYC2visWT3YVVDxIPCZjGTsG4eslMFMIZ1WBeeXHR9Aq0CihgQTD9LfsYiO0vFwtlM191SJnDUwl2VBl+h5Gx5VYWJTj1tu855OaZMO4+TRD+ohKPXmZbD2n5lEEf87FQ6geTYrAeZgbOjxuC3ae/R7yyKJDTrcSe0r56nnhs2Xh7oBoW58Vsd4rhpnGlP7+7dmgAd/noCPyaFa/egYCSBFKZQtIHRr4r/AGrF9AuuBeeK5naRQgrLHsjzr5MiqpsjUsht3hhpg+IufjYt5Nf4+w++tbvZ7OJIiE3BBpITp4DV6h+DThkG0XKbTh9x2e/MqrjLJiRKYvKUyRsj7N/if8kdPAarhzTr0IBdjV5AYIkiVZfOduuJxSGkSgiCWsbdQGWANP+N6RAiW0AqBVcw8e/A3C88mvEh4oo4OuZw1llwReCqRnjRUkRHgV1rlTS7VIAt4JmOhVLw3xGb60ANMDDServIdjjeMozdq4p1qqkU2WJXsdZ+ohRBDInp3PhtmX9sqvGQ36kJLKyGpCUYlmxvvQmrudjy+o58QRYYyN1ZcmmqYdSSLF3QPWdkk4YtsZsCQQnZW4cD7Yqck7oasIcoBlqkoWGxC55bWWBEesNo9wdwi6f8gv91lJtyT7DZq9+gogzFN8h59+06cD2lakIPoCvQbe3LzUjt9jaZd99gkub+vfr+UcyH2fkpPVOEUqXQ==", "X-Forefront-Antispam-Report": "CIP:216.228.112.36; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid05.nvidia.com; CAT:NONE;\n SFS:(4636009)(396003)(136003)(376002)(39860400002)(346002)(46966006)(36840700001)(316002)(450100002)(4326008)(478600001)(186003)(26005)(8936002)(336012)(7696005)(426003)(54906003)(36860700001)(6286002)(55016002)(16526019)(8676002)(70586007)(70206006)(2906002)(6916009)(82740400003)(1076003)(5660300002)(47076005)(7636003)(83380400001)(356005)(82310400003)(36756003)(2616005)(6666004)(86362001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "17 Aug 2021 13:45:19.6696 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n ee72ca34-8876-4b73-3abd-08d9618540f9", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.36];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT062.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY4PR1201MB0104", "Subject": "[dpdk-dev] [RFC 02/21] net/mlx5: fix PCI probing error flow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In PCI probing, there is internal probe function that is called several\ntimes for several PFs.\n\nWhen one of them fails, the previous PFs are not destroyed what nay\ncause a memory leak.\n\nDestroy them.\n\nFixes: 08c2772fc747 (\"net/mlx5: support list of representor PF\")\nCc: stable@dpdk.org\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\n---\n drivers/net/mlx5/linux/mlx5_os.c | 13 ++++++++++++-\n drivers/net/mlx5/mlx5.c | 2 +-\n drivers/net/mlx5/mlx5.h | 1 +\n 3 files changed, 14 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex 5f8766aa48..3d204f99f7 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -2700,9 +2700,20 @@ mlx5_os_pci_probe(struct rte_pci_device *pci_dev)\n \n \tif (eth_da.nb_ports > 0) {\n \t\t/* Iterate all port if devargs pf is range: \"pf[0-1]vf[...]\". */\n-\t\tfor (p = 0; p < eth_da.nb_ports; p++)\n+\t\tfor (p = 0; p < eth_da.nb_ports; p++) {\n \t\t\tret = mlx5_os_pci_probe_pf(pci_dev, ð_da,\n \t\t\t\t\t\t eth_da.ports[p]);\n+\t\t\tif (ret)\n+\t\t\t\tbreak;\n+\t\t}\n+\t\tif (ret) {\n+\t\t\tDRV_LOG(ERR, \"Probe of PCI device \" PCI_PRI_FMT \" \"\n+\t\t\t\t\"aborted due to proding failure of PF %u\",\n+\t\t\t\tpci_dev->addr.domain, pci_dev->addr.bus,\n+\t\t\t\tpci_dev->addr.devid, pci_dev->addr.function,\n+\t\t\t\teth_da.ports[p]);\n+\t\t\tmlx5_net_remove(&pci_dev->device);\n+\t\t}\n \t} else {\n \t\tret = mlx5_os_pci_probe_pf(pci_dev, ð_da, 0);\n \t}\ndiff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex f0ec2d1279..02ea2e781e 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -2386,7 +2386,7 @@ mlx5_eth_find_next(uint16_t port_id, struct rte_device *odev)\n * @return\n * 0 on success, the function cannot fail.\n */\n-static int\n+int\n mlx5_net_remove(struct rte_device *dev)\n {\n \tuint16_t port_id;\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex e02714e231..3581414b78 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -1483,6 +1483,7 @@ int mlx5_udp_tunnel_port_add(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_udp_tunnel *udp_tunnel);\n uint16_t mlx5_eth_find_next(uint16_t port_id, struct rte_device *odev);\n int mlx5_dev_close(struct rte_eth_dev *dev);\n+int mlx5_net_remove(struct rte_device *dev);\n bool mlx5_is_hpf(struct rte_eth_dev *dev);\n bool mlx5_is_sf_repr(struct rte_eth_dev *dev);\n void mlx5_age_event_prepare(struct mlx5_dev_ctx_shared *sh);\n", "prefixes": [ "RFC", "02/21" ] }