Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97007/?format=api
{ "id": 97007, "url": "http://patchwork.dpdk.org/api/patches/97007/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210817134441.1966618-17-michaelba@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210817134441.1966618-17-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210817134441.1966618-17-michaelba@nvidia.com", "date": "2021-08-17T13:44:36", "name": "[RFC,16/21] common/mlx5: add HCA attributes to context device structure", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "14a60985a7ab209bf72b034ab7e3205dc80e9754", "submitter": { "id": 1949, "url": "http://patchwork.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210817134441.1966618-17-michaelba@nvidia.com/mbox/", "series": [ { "id": 18314, "url": "http://patchwork.dpdk.org/api/series/18314/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18314", "date": "2021-08-17T13:44:20", "name": "mlx5: sharing global MR cache between drivers", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18314/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/97007/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/97007/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 95F64A0548;\n\tTue, 17 Aug 2021 15:47:37 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BD0A641278;\n\tTue, 17 Aug 2021 15:45:46 +0200 (CEST)", "from NAM04-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam08on2078.outbound.protection.outlook.com [40.107.100.78])\n by mails.dpdk.org (Postfix) with ESMTP id B0C674126B\n for <dev@dpdk.org>; Tue, 17 Aug 2021 15:45:44 +0200 (CEST)", "from CO2PR04CA0096.namprd04.prod.outlook.com (2603:10b6:104:6::22)\n by DM6PR12MB3626.namprd12.prod.outlook.com (2603:10b6:5:11f::18) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.15; Tue, 17 Aug\n 2021 13:45:41 +0000", "from CO1NAM11FT010.eop-nam11.prod.protection.outlook.com\n (2603:10b6:104:6:cafe::1c) by CO2PR04CA0096.outlook.office365.com\n (2603:10b6:104:6::22) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend\n Transport; Tue, 17 Aug 2021 13:45:41 +0000", "from mail.nvidia.com (216.228.112.32) by\n CO1NAM11FT010.mail.protection.outlook.com (10.13.175.88) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4415.14 via Frontend Transport; Tue, 17 Aug 2021 13:45:41 +0000", "from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL109.nvidia.com\n (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug\n 2021 06:45:40 -0700", "from nvidia.com (172.20.187.6) by DRHQMAIL107.nvidia.com\n (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug\n 2021 13:45:39 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=UGxlvERB/kWdJq+YuuE2/HPX1lT2FUndsGr7AJFfoeZKjF1IcBHy5eMsU5OnGNJNQC/yVFNR0KbC3CcQ2jRhiKLlOlPZfg8Jfq7exwgOqnYBv4zrRt5X/oD7UHQz+YtBbDqO7ItrRfCJnpRcBrY8YByC4AZE9uBmjsgKVoFSUzXweonFgMKJ5RFbe6HopPKT95Xh/bH3wXnzDIJLP/PinzbDN+sjpII0XZKEPK0tgNIQMVWNXRqJbrUjKzeGjVt6phUUjoknyI5CLj3nwTGpnHS9FngIMiGqVh9nLHbhL/p1qYbSVcrWzy2w9yqxCcihssNrW2ZSu58BMb71UdfhmA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=2oH15DylRNXwsEYZaWcDHwPiHA39924brnOzY0e5SuA=;\n b=lltj3EJFk+4txwxyLmMNtfZkYizt8P6+IR0S1xE9tysdyzTt7sogynFyix2ehxHsFq4v4+2p59v2ioFkp47EdxEeRbdgYDOiNhmDx/uZ2T59bVR1a/1s9MerNANBudEs5Fk1lQ5Zf/RniwULh75VT0CQ+S9HaxEnMXf5R68QZ1t1L5DgIc2D6SETYw0cTF70fQyK5iegO5e3b79hzUwWQlN1XB7c8Id9aV0aNimU1PMjZs81ubZNpRzAA40Cd1QwvlYOR4X2nQOG9hYimKbWuvOs6UglCC6ElHOgrkKhG0jOCZt510eRIr0oyY1gT99/GqevWJ1dyzzqDwvEi15EaQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.32) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=2oH15DylRNXwsEYZaWcDHwPiHA39924brnOzY0e5SuA=;\n b=lucSasbWuSv376rDNZijB274adOHjzZTuuFGyvFa/hIDK1jHoCdBCHy0xNIjor3+6NJR7q8ooHNVfk8FgC9S/juiJH6DW4Rj9EEWY2Oqtt2ObJkEGLYhIrxQKVdgdvggubOeExZXXO9+tt9n0C9bVUxd+i+oV4m0ceY1MPYlIu4OExul+QxM+zm6nRdzlC7i8BR6uTFoR2R4KRU1HX5X38asNEMEoy3tjFGPGsSK89VO059slpnCZ6qBOjDBSoyv438/DLIdvUV9N3Re/WoPFAEzpNgfSiZRmRt6MgpwhzUKDeHmUHw0SR0CNSrl86yga8BR0UPqMpD1PQ58ObLOyA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.32)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.32 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.32; helo=mail.nvidia.com;", "From": "Michael Baum <michaelba@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Date": "Tue, 17 Aug 2021 16:44:36 +0300", "Message-ID": "<20210817134441.1966618-17-michaelba@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210817134441.1966618-1-michaelba@nvidia.com>", "References": "<20210817134441.1966618-1-michaelba@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.6]", "X-ClientProxiedBy": "HQMAIL111.nvidia.com (172.20.187.18) To\n DRHQMAIL107.nvidia.com (10.27.9.16)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "80f3235c-80e6-44d7-fb04-08d961854dbe", "X-MS-TrafficTypeDiagnostic": "DM6PR12MB3626:", "X-Microsoft-Antispam-PRVS": "\n <DM6PR12MB36267973060D34D8011C7D10CCFE9@DM6PR12MB3626.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:6790;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n xsAWWzIPd+N8pZavZZAl3vp7V96LoaJZtWJsOqkXOOvVenxnXkZg9Kq3AGZgkVsmGPM/XAJffhpmK28sIgTtvMm1+Oy0AQz4F8Fyl6vx80bkEboFmndS1Z3PoO13yhq3lDHCA0w+Sl2ipQ9pFEB1B2YcQ9kOELhxA1N3uY547KS/Ht7SQcuuZlicMgGr7QrXf7YlXT0ufJcEsep5URdMjKHQDgsTMNHR7CprjFd/5kU0uE5vU1fCskLg34aQog0suCopLm8ElM8zxKnCqB8x6Iotoa8qDSdFxEFqomdBCn4wE1EZTvMOKpYAaiMlqlOInOa5ZLtXKn2+dUxXPkNpvR1gjp/rdThpe/vdec7aNMwbu9WwhFeL42KpzVrM+qKaEME2vqqSsJTTNcujRHenNSDgiyfR4nEKXI8iKV1FK0cCwQ2ZHIm3QTqJ/R9y8KGmDghtGGDiQIJYONcJcQFQVk1bZPhlfR3NXCr/yJTpt0p9ydYLjbqk0FtSsOT/rzsnQBBAEpVP28thQZp3OF3AZzrGa8mhJ7+xKC7vzVcG8WY2rClhtIPWdw6uqSDcc1sszPBQhBzMnz3558ega0j7Q8a62RSgNMpBiTdDtvLRSAn1vZ2umBHLjKC/mMPAA2OSJ0yF8Cu2FlcenSOYn/B/tnDnBUbArhGgBzw+WE1UEQZrJwjLsQLctdyTC5dGFi9O0nuGRyPpS2ffW6Dr10nJBA==", "X-Forefront-Antispam-Report": "CIP:216.228.112.32; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid01.nvidia.com; CAT:NONE;\n SFS:(4636009)(346002)(39860400002)(136003)(376002)(396003)(36840700001)(46966006)(54906003)(26005)(2906002)(6916009)(5660300002)(478600001)(8676002)(6286002)(316002)(426003)(336012)(7636003)(356005)(7696005)(47076005)(70586007)(70206006)(4326008)(36860700001)(82740400003)(6666004)(107886003)(36756003)(83380400001)(16526019)(186003)(86362001)(55016002)(1076003)(8936002)(2616005)(82310400003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "17 Aug 2021 13:45:41.1892 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 80f3235c-80e6-44d7-fb04-08d961854dbe", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.32];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT010.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB3626", "Subject": "[dpdk-dev] [RFC 16/21] common/mlx5: add HCA attributes to context\n device structure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add HCA attributes structure as a field of context device structure.\nIt query in common probing, and check if the device supports the chosen\nclasses.\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\n---\n drivers/common/mlx5/mlx5_common.c | 67 ++++++++++++++++++++++++++++++-\n drivers/common/mlx5/mlx5_common.h | 9 +++--\n 2 files changed, 70 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/mlx5_common.c b/drivers/common/mlx5/mlx5_common.c\nindex b500e7834e..e4c1984700 100644\n--- a/drivers/common/mlx5/mlx5_common.c\n+++ b/drivers/common/mlx5/mlx5_common.c\n@@ -310,6 +310,56 @@ mlx5_dev_to_pci_str(const struct rte_device *dev, char *addr, size_t size)\n #endif\n }\n \n+/**\n+ * Validate HCA attributes.\n+ *\n+ * @param attr\n+ * Attributes device values.\n+ * @param classes\n+ * Chosen classes come from device arguments.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+static int\n+mlx5_hca_attr_validate(struct mlx5_hca_attr *attr, uint32_t classes)\n+{\n+\tif (classes & MLX5_CLASS_VDPA) {\n+\t\tif (!attr->vdpa.valid || !attr->vdpa.max_num_virtio_queues) {\n+\t\t\tDRV_LOG(ERR,\n+\t\t\t\t\"Not enough capabilities to support vDPA, maybe old FW/OFED version?\");\n+\t\t\trte_errno = ENOTSUP;\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t}\n+\tif (classes & MLX5_CLASS_REGEX) {\n+\t\tif (!attr->regex || attr->regexp_num_of_engines == 0) {\n+\t\t\tDRV_LOG(ERR,\n+\t\t\t\t\"Not enough capabilities to support RegEx, maybe old FW/OFED version?\");\n+\t\t\trte_errno = ENOTSUP;\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t}\n+\tif (classes & MLX5_CLASS_COMPRESS) {\n+\t\tif (attr->mmo_compress_en == 0 ||\n+\t\t attr->mmo_decompress_en == 0 || attr->mmo_dma_en == 0) {\n+\t\t\tDRV_LOG(ERR,\n+\t\t\t\t\"Not enough capabilities to support compress operations, maybe old FW/OFED version?\");\n+\t\t\trte_errno = ENOTSUP;\n+\t\t\treturn -ENOTSUP;\n+\t\t}\n+\t}\n+\tif (classes & MLX5_CLASS_CRYPTO) {\n+\t\tif (attr->crypto == 0 || attr->aes_xts == 0) {\n+\t\t\tDRV_LOG(ERR,\n+\t\t\t\t\"Not enough capabilities to support crypto operations, maybe old FW/OFED version?\");\n+\t\t\trte_errno = ENOTSUP;\n+\t\t\treturn -ENOTSUP;\n+\t\t}\n+\t}\n+\treturn 0;\n+}\n+\n /**\n * Uninitialize context device and release all its resources.\n *\n@@ -379,6 +429,13 @@ mlx5_dev_ctx_prepare(struct mlx5_dev_ctx *dev_ctx, struct rte_device *dev,\n \tret = mlx5_os_pd_create(dev_ctx);\n \tif (ret)\n \t\tgoto error;\n+\t/* Query HCA attributes. */\n+\tret = mlx5_devx_cmd_query_hca_attr(dev_ctx->ctx, &dev_ctx->hca_attr);\n+\tif (ret) {\n+\t\tDRV_LOG(ERR, \"Unable to read HCA capabilities.\");\n+\t\trte_errno = ENOTSUP;\n+\t\tgoto error;\n+\t}\n \treturn ret;\n error:\n \tmlx5_dev_ctx_release(dev_ctx);\n@@ -507,13 +564,19 @@ mlx5_common_dev_probe(struct rte_device *eal_dev)\n \t\tnew_device = true;\n \t} else {\n \t\t/* Validate combination here. */\n-\t\tret = is_valid_class_combination(classes |\n-\t\t\t\t\t\t dev->classes_loaded);\n+\t\tret = is_valid_class_combination(classes | dev->classes_loaded);\n \t\tif (ret != 0) {\n \t\t\tDRV_LOG(ERR, \"Unsupported mlx5 classes combination.\");\n \t\t\treturn ret;\n \t\t}\n \t}\n+\tif (dev->ctx.ctx) {\n+\t\t/* Validate HCA attributes here. */\n+\t\tret = mlx5_hca_attr_validate(&dev->ctx.hca_attr,\n+\t\t\t\t\t classes | dev->classes_loaded);\n+\t\tif (ret)\n+\t\t\tgoto class_err;\n+\t}\n \tret = drivers_probe(dev, classes);\n \tif (ret)\n \t\tgoto class_err;\ndiff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h\nindex 644dc58bc9..da03e160d2 100644\n--- a/drivers/common/mlx5/mlx5_common.h\n+++ b/drivers/common/mlx5/mlx5_common.h\n@@ -329,10 +329,11 @@ void mlx5_common_init(void);\n * Contains HW device objects which belong to same device with multiple drivers.\n */\n struct mlx5_dev_ctx {\n-\tvoid *ctx;\t/* Verbs/DV/DevX context. */\n-\tvoid *pd;\t/* Protection Domain. */\n-\tuint32_t pdn;\t/* Protection Domain Number. */\n-\tint numa_node;\t/* Numa node of device. */\n+\tvoid *ctx;\t\t\t/* Verbs/DV/DevX context. */\n+\tvoid *pd;\t\t\t/* Protection Domain. */\n+\tuint32_t pdn;\t\t\t/* Protection Domain Number. */\n+\tint numa_node;\t\t\t/* Numa node of device. */\n+\tstruct mlx5_hca_attr hca_attr; /* HCA attributes. */\n };\n \n struct mlx5_common_device {\n", "prefixes": [ "RFC", "16/21" ] }