Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97082/?format=api
{ "id": 97082, "url": "http://patchwork.dpdk.org/api/patches/97082/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1629321579-10788-3-git-send-email-navasile@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1629321579-10788-3-git-send-email-navasile@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1629321579-10788-3-git-send-email-navasile@linux.microsoft.com", "date": "2021-08-18T21:19:35", "name": "[v4,2/6] eal: add function for control thread creation", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "238c3fd47706e15f11fba1ce04706be9559ba217", "submitter": { "id": 1668, "url": "http://patchwork.dpdk.org/api/people/1668/?format=api", "name": "Narcisa Ana Maria Vasile", "email": "navasile@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1629321579-10788-3-git-send-email-navasile@linux.microsoft.com/mbox/", "series": [ { "id": 18338, "url": "http://patchwork.dpdk.org/api/series/18338/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18338", "date": "2021-08-18T21:19:34", "name": "Enable the internal EAL thread API", "version": 4, "mbox": "http://patchwork.dpdk.org/series/18338/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/97082/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/97082/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2C774A0C55;\n\tWed, 18 Aug 2021 23:19:58 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CB380411F1;\n\tWed, 18 Aug 2021 23:19:48 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 4D8EF4069C\n for <dev@dpdk.org>; Wed, 18 Aug 2021 23:19:45 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1059)\n id 903A720C335B; Wed, 18 Aug 2021 14:19:44 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 903A720C335B", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1629321584;\n bh=i9+xnTh9K5TOp46rymmv8mM+/xhXF3T13c9UguTFVI8=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=glTn+mYoaUrrcue1+LUmBCDOPqmUDk0s0bKZ1obb/PSUYUZDFNWSIx8HHYAvohXkY\n z4RRtw+cbAgaERLsy6/9aqeb2QyOAjReRzMX8GdditCpQlQZ8Qj1yx0UacZNMGVKLy\n rmxas0dcn4PRd/zbp5H690Nf9SXxGjX1S+gRvYSQ=", "From": "Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>", "To": "dev@dpdk.org, thomas@monjalon.net, dmitry.kozliuk@gmail.com,\n khot@microsoft.com, navasile@microsoft.com, dmitrym@microsoft.com,\n roretzla@microsoft.com, talshn@nvidia.com, ocardona@microsoft.com", "Cc": "bruce.richardson@intel.com, david.marchand@redhat.com,\n pallavi.kadam@intel.com", "Date": "Wed, 18 Aug 2021 14:19:35 -0700", "Message-Id": "<1629321579-10788-3-git-send-email-navasile@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1629321579-10788-1-git-send-email-navasile@linux.microsoft.com>", "References": "<1629294247-5207-7-git-send-email-navasile@linux.microsoft.com>\n <1629321579-10788-1-git-send-email-navasile@linux.microsoft.com>", "Subject": "[dpdk-dev] [PATCH v4 2/6] eal: add function for control thread\n creation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Narcisa Vasile <navasile@microsoft.com>\n\nThe existing rte_ctrl_thread_create() function will be replaced\nwith rte_thread_ctrl_thread_create() that uses the internal\nEAL thread API.\n\nThis patch only introduces the new control thread creation\nfunction. Replacing of the old function needs to be done according\nto the ABI change procedures, to avoid an ABI break.\n\nSigned-off-by: Narcisa Vasile <navasile@microsoft.com>\n---\n lib/eal/common/eal_common_thread.c | 81 ++++++++++++++++++++++++++++++\n lib/eal/include/rte_thread.h | 27 ++++++++++\n lib/eal/version.map | 1 +\n 3 files changed, 109 insertions(+)", "diff": "diff --git a/lib/eal/common/eal_common_thread.c b/lib/eal/common/eal_common_thread.c\nindex 1a52f42a2b..79545c67d9 100644\n--- a/lib/eal/common/eal_common_thread.c\n+++ b/lib/eal/common/eal_common_thread.c\n@@ -259,6 +259,87 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,\n \treturn -ret;\n }\n \n+struct rte_thread_ctrl_ctx {\n+\trte_thread_func start_routine;\n+\tvoid *arg;\n+\tconst char *name;\n+};\n+\n+static void *ctrl_thread_wrapper(void *arg)\n+{\n+\tstruct internal_config *conf = eal_get_internal_configuration();\n+\trte_cpuset_t *cpuset = &conf->ctrl_cpuset;\n+\tstruct rte_thread_ctrl_ctx *ctx = arg;\n+\trte_thread_func start_routine = ctx->start_routine;\n+\tvoid *routine_arg = ctx->arg;\n+\n+\t__rte_thread_init(rte_lcore_id(), cpuset);\n+\n+\tif (ctx->name != NULL) {\n+\t\tif (rte_thread_name_set(rte_thread_self(), ctx->name) < 0)\n+\t\t\tRTE_LOG(DEBUG, EAL, \"Cannot set name for ctrl thread\\n\");\n+\t}\n+\n+\tfree(arg);\n+\n+\treturn start_routine(routine_arg);\n+}\n+\n+int\n+rte_thread_ctrl_thread_create(rte_thread_t *thread, const char *name,\n+\t\trte_thread_func start_routine, void *arg)\n+{\n+\tint ret;\n+\trte_thread_attr_t attr;\n+\tstruct internal_config *conf = eal_get_internal_configuration();\n+\trte_cpuset_t *cpuset = &conf->ctrl_cpuset;\n+\tstruct rte_thread_ctrl_ctx *ctx = NULL;\n+\n+\tif (start_routine == NULL) {\n+\t\tret = EINVAL;\n+\t\tgoto cleanup;\n+\t}\n+\n+\tctx = malloc(sizeof(*ctx));\n+\tif (ctx == NULL) {\n+\t\tret = ENOMEM;\n+\t\tgoto cleanup;\n+\t}\n+\n+\tctx->start_routine = start_routine;\n+\tctx->arg = arg;\n+\tctx->name = name;\n+\n+\tret = rte_thread_attr_init(&attr);\n+\tif (ret != 0) {\n+\t\tRTE_LOG(DEBUG, EAL, \"Cannot init ctrl thread attributes\\n\");\n+\t\tgoto cleanup;\n+\t}\n+\n+\tret = rte_thread_attr_set_affinity(&attr, cpuset);\n+\tif (ret != 0) {\n+\t\tRTE_LOG(DEBUG, EAL, \"Cannot set afifnity attribute for ctrl thread\\n\");\n+\t\tgoto cleanup;\n+\t}\n+\tret = rte_thread_attr_set_priority(&attr, RTE_THREAD_PRIORITY_NORMAL);\n+\tif (ret != 0) {\n+\t\tRTE_LOG(DEBUG, EAL, \"Cannot set priority attribute for ctrl thread\\n\");\n+\t\tgoto cleanup;\n+\t}\n+\n+\tret = rte_thread_create(thread, &attr, ctrl_thread_wrapper, ctx);\n+\tif (ret != 0) {\n+\t\tRTE_LOG(DEBUG, EAL, \"Cannot create ctrl thread\\n\");\n+\t\tgoto cleanup;\n+\t}\n+\n+\treturn 0;\n+\n+cleanup:\n+\tfree(ctx);\n+\treturn ret;\n+}\n+\n int\n rte_thread_register(void)\n {\ndiff --git a/lib/eal/include/rte_thread.h b/lib/eal/include/rte_thread.h\nindex 2f6258e336..e34101cc98 100644\n--- a/lib/eal/include/rte_thread.h\n+++ b/lib/eal/include/rte_thread.h\n@@ -455,6 +455,33 @@ int rte_thread_barrier_destroy(rte_thread_barrier *barrier);\n __rte_experimental\n int rte_thread_name_set(rte_thread_t thread_id, const char *name);\n \n+/**\n+ * Create a control thread.\n+ *\n+ * Set affinity and thread name. The affinity of the new thread is based\n+ * on the CPU affinity retrieved at the time rte_eal_init() was called,\n+ * the dataplane and service lcores are then excluded.\n+ *\n+ * @param thread\n+ * Filled with the thread id of the new created thread.\n+ *\n+ * @param name\n+ * The name of the control thread (max 16 characters including '\\0').\n+ *\n+ * @param start_routine\n+ * Function to be executed by the new thread.\n+ *\n+ * @param arg\n+ * Argument passed to start_routine.\n+ *\n+ * @return\n+ * On success, return 0;\n+ * On failure, return a positive errno-style error number.\n+ */\n+__rte_experimental\n+int rte_thread_ctrl_thread_create(rte_thread_t *thread, const char *name,\n+\t\trte_thread_func start_routine, void *arg);\n+\n /**\n * Create a TLS data key visible to all threads in the process.\n * the created key is later used to get/set a value.\ndiff --git a/lib/eal/version.map b/lib/eal/version.map\nindex 7ce8dcea07..67569b1bf9 100644\n--- a/lib/eal/version.map\n+++ b/lib/eal/version.map\n@@ -447,6 +447,7 @@ EXPERIMENTAL {\n \trte_thread_barrier_wait;\n \trte_thread_barrier_destroy;\n \trte_thread_name_set;\n+\trte_thread_ctrl_thread_create;\n };\n \n INTERNAL {\n", "prefixes": [ "v4", "2/6" ] }