Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97100/?format=api
{ "id": 97100, "url": "http://patchwork.dpdk.org/api/patches/97100/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210819070908.25773-2-joyce.kong@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210819070908.25773-2-joyce.kong@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210819070908.25773-2-joyce.kong@arm.com", "date": "2021-08-19T07:09:01", "name": "[v1,1/8] examples/bbdev_app: use compiler atomics for flag sync", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "74eb9b6acc024e7486d2f40459a818ef178963c3", "submitter": { "id": 970, "url": "http://patchwork.dpdk.org/api/people/970/?format=api", "name": "Joyce Kong", "email": "joyce.kong@arm.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210819070908.25773-2-joyce.kong@arm.com/mbox/", "series": [ { "id": 18348, "url": "http://patchwork.dpdk.org/api/series/18348/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18348", "date": "2021-08-19T07:09:00", "name": "use compiler atomic builtins for examples", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18348/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/97100/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/97100/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3832DA0C47;\n\tThu, 19 Aug 2021 09:09:34 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BB455411FD;\n\tThu, 19 Aug 2021 09:09:29 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 1DE8F411FA\n for <dev@dpdk.org>; Thu, 19 Aug 2021 09:09:29 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8C805101E;\n Thu, 19 Aug 2021 00:09:28 -0700 (PDT)", "from net-arm-n1sdp.shanghai.arm.com (net-arm-n1sdp.shanghai.arm.com\n [10.169.208.222])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 36E8F3F40C;\n Thu, 19 Aug 2021 00:09:25 -0700 (PDT)" ], "From": "Joyce Kong <joyce.kong@arm.com>", "To": "Nicolas Chautru <nicolas.chautru@intel.com>", "Cc": "dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com,\n honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com, nd@arm.com", "Date": "Thu, 19 Aug 2021 02:09:01 -0500", "Message-Id": "<20210819070908.25773-2-joyce.kong@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210819070908.25773-1-joyce.kong@arm.com>", "References": "<20210819070908.25773-1-joyce.kong@arm.com>", "Subject": "[dpdk-dev] [PATCH v1 1/8] examples/bbdev_app: use compiler atomics\n for flag sync", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Convert rte_atomic usages to compiler atomic built-ins\nfor global_exit_flag sync.\n\nSigned-off-by: Joyce Kong <joyce.kong@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n examples/bbdev_app/main.c | 13 ++++++-------\n 1 file changed, 6 insertions(+), 7 deletions(-)", "diff": "diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c\nindex 5251db0b16..75c620ea75 100644\n--- a/examples/bbdev_app/main.c\n+++ b/examples/bbdev_app/main.c\n@@ -18,7 +18,6 @@\n #include <getopt.h>\n #include <signal.h>\n \n-#include <rte_atomic.h>\n #include <rte_common.h>\n #include <rte_eal.h>\n #include <rte_cycles.h>\n@@ -167,7 +166,7 @@ static const struct app_config_params def_app_config = {\n \t.num_dec_cores = 1,\n };\n \n-static rte_atomic16_t global_exit_flag;\n+static uint16_t global_exit_flag;\n \n /* display usage */\n static inline void\n@@ -279,7 +278,7 @@ static void\n signal_handler(int signum)\n {\n \tprintf(\"\\nSignal %d received\\n\", signum);\n-\trte_atomic16_set(&global_exit_flag, 1);\n+\t__atomic_store_n(&global_exit_flag, 1, __ATOMIC_RELAXED);\n }\n \n static void\n@@ -328,7 +327,7 @@ check_port_link_status(uint16_t port_id)\n \tfflush(stdout);\n \n \tfor (count = 0; count <= MAX_CHECK_TIME &&\n-\t\t\t!rte_atomic16_read(&global_exit_flag); count++) {\n+\t\t\t!__atomic_load_n(&global_exit_flag, __ATOMIC_RELAXED); count++) {\n \t\tmemset(&link, 0, sizeof(link));\n \t\tlink_get_err = rte_eth_link_get_nowait(port_id, &link);\n \n@@ -682,7 +681,7 @@ stats_loop(void *arg)\n {\n \tstruct stats_lcore_params *stats_lcore = arg;\n \n-\twhile (!rte_atomic16_read(&global_exit_flag)) {\n+\twhile (!__atomic_load_n(&global_exit_flag, __ATOMIC_RELAXED)) {\n \t\tprint_stats(stats_lcore);\n \t\trte_delay_ms(500);\n \t}\n@@ -928,7 +927,7 @@ processing_loop(void *arg)\n \tconst bool run_decoder = (lcore_conf->core_type &\n \t\t\t(1 << RTE_BBDEV_OP_TURBO_DEC));\n \n-\twhile (!rte_atomic16_read(&global_exit_flag)) {\n+\twhile (!__atomic_load_n(&global_exit_flag, __ATOMIC_RELAXED)) {\n \t\tif (run_encoder)\n \t\t\trun_encoding(lcore_conf);\n \t\tif (run_decoder)\n@@ -1062,7 +1061,7 @@ main(int argc, char **argv)\n \t\t.align = __alignof__(struct rte_mbuf *),\n \t};\n \n-\trte_atomic16_init(&global_exit_flag);\n+\t__atomic_store_n(&global_exit_flag, 0, __ATOMIC_RELAXED);\n \n \tsigret = signal(SIGTERM, signal_handler);\n \tif (sigret == SIG_ERR)\n", "prefixes": [ "v1", "1/8" ] }