Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97105/?format=api
{ "id": 97105, "url": "http://patchwork.dpdk.org/api/patches/97105/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210819070908.25773-7-joyce.kong@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210819070908.25773-7-joyce.kong@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210819070908.25773-7-joyce.kong@arm.com", "date": "2021-08-19T07:09:06", "name": "[v1,6/8] examples/vm_power_manager: use compiler atomics for sync", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b936d539be87ef65b54cec709cb829eda91cd34e", "submitter": { "id": 970, "url": "http://patchwork.dpdk.org/api/people/970/?format=api", "name": "Joyce Kong", "email": "joyce.kong@arm.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210819070908.25773-7-joyce.kong@arm.com/mbox/", "series": [ { "id": 18348, "url": "http://patchwork.dpdk.org/api/series/18348/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18348", "date": "2021-08-19T07:09:00", "name": "use compiler atomic builtins for examples", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18348/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/97105/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/97105/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 87D31A0C47;\n\tThu, 19 Aug 2021 09:10:18 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3D98B41232;\n\tThu, 19 Aug 2021 09:09:44 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 64BB341232\n for <dev@dpdk.org>; Thu, 19 Aug 2021 09:09:43 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EAA52101E;\n Thu, 19 Aug 2021 00:09:42 -0700 (PDT)", "from net-arm-n1sdp.shanghai.arm.com (net-arm-n1sdp.shanghai.arm.com\n [10.169.208.222])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 977DA3F40C;\n Thu, 19 Aug 2021 00:09:40 -0700 (PDT)" ], "From": "Joyce Kong <joyce.kong@arm.com>", "To": "David Hunt <david.hunt@intel.com>", "Cc": "dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com,\n honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com, nd@arm.com", "Date": "Thu, 19 Aug 2021 02:09:06 -0500", "Message-Id": "<20210819070908.25773-7-joyce.kong@arm.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210819070908.25773-1-joyce.kong@arm.com>", "References": "<20210819070908.25773-1-joyce.kong@arm.com>", "Subject": "[dpdk-dev] [PATCH v1 6/8] examples/vm_power_manager: use compiler\n atomics for sync", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Convert rte_atomic32_cmpset to compiler atomic CAS\noperation for channel status sync.\n\nSigned-off-by: Joyce Kong <joyce.kong@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n examples/vm_power_manager/channel_monitor.c | 11 ++++++-----\n 1 file changed, 6 insertions(+), 5 deletions(-)", "diff": "diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c\nindex 99f81544d7..3c20406f7c 100644\n--- a/examples/vm_power_manager/channel_monitor.c\n+++ b/examples/vm_power_manager/channel_monitor.c\n@@ -25,7 +25,6 @@\n #include <rte_log.h>\n #include <rte_memory.h>\n #include <rte_malloc.h>\n-#include <rte_atomic.h>\n #include <rte_cycles.h>\n #include <rte_ethdev.h>\n #ifdef RTE_NET_I40E\n@@ -829,8 +828,9 @@ process_request(struct rte_power_channel_packet *pkt,\n \tif (chan_info == NULL)\n \t\treturn -1;\n \n-\tif (rte_atomic32_cmpset(&(chan_info->status), CHANNEL_MGR_CHANNEL_CONNECTED,\n-\t\t\tCHANNEL_MGR_CHANNEL_PROCESSING) == 0)\n+\tuint32_t channel_connected = CHANNEL_MGR_CHANNEL_CONNECTED;\n+\tif (__atomic_compare_exchange_n(&(chan_info->status), &channel_connected,\n+\t\tCHANNEL_MGR_CHANNEL_PROCESSING, 0, __ATOMIC_RELAXED, __ATOMIC_RELAXED) == 0)\n \t\treturn -1;\n \n \tif (pkt->command == RTE_POWER_CPU_POWER) {\n@@ -934,8 +934,9 @@ process_request(struct rte_power_channel_packet *pkt,\n \t * Return is not checked as channel status may have been set to DISABLED\n \t * from management thread\n \t */\n-\trte_atomic32_cmpset(&(chan_info->status), CHANNEL_MGR_CHANNEL_PROCESSING,\n-\t\t\tCHANNEL_MGR_CHANNEL_CONNECTED);\n+\tuint32_t channel_processing = CHANNEL_MGR_CHANNEL_PROCESSING;\n+\t__atomic_compare_exchange_n(&(chan_info->status), &channel_processing,\n+\t\tCHANNEL_MGR_CHANNEL_CONNECTED, 0, __ATOMIC_RELAXED, __ATOMIC_RELAXED);\n \treturn 0;\n \n }\n", "prefixes": [ "v1", "6/8" ] }