Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97454/?format=api
{ "id": 97454, "url": "http://patchwork.dpdk.org/api/patches/97454/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210827065717.1838258-37-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210827065717.1838258-37-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210827065717.1838258-37-andrew.rybchenko@oktetlabs.ru", "date": "2021-08-27T06:57:15", "name": "[36/38] net/sfc: use switch port ID as representor ID", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "91f4ddc37c0bf605e8356f1b290c6cf9dcf498ce", "submitter": { "id": 2013, "url": "http://patchwork.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210827065717.1838258-37-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 18492, "url": "http://patchwork.dpdk.org/api/series/18492/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18492", "date": "2021-08-27T06:56:39", "name": "net/sfc: support port representors", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18492/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/97454/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/97454/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 72950A0C41;\n\tFri, 27 Aug 2021 09:01:37 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5B6B641256;\n\tFri, 27 Aug 2021 08:59:41 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 0256C41256\n for <dev@dpdk.org>; Fri, 27 Aug 2021 08:59:40 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id CEAB87F6EC; Fri, 27 Aug 2021 09:59:39 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id C60B87F6F9;\n Fri, 27 Aug 2021 09:57:36 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru C60B87F6F9", "Authentication-Results": "shelob.oktetlabs.ru/C60B87F6F9; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>,\n Andy Moreton <amoreton@xilinx.com>", "Date": "Fri, 27 Aug 2021 09:57:15 +0300", "Message-Id": "<20210827065717.1838258-37-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210827065717.1838258-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 36/38] net/sfc: use switch port ID as representor\n ID", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>\n\nRepresentor IDs must be unique for each representor. VFs, which are\ncurrently used, are not unique as they may repeat in combination with\ndifferent PCI controllers and PFs. On the other hand, switch port IDs\nare unique, so they are a better fit for this role.\n\nSigned-off-by: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\nReviewed-by: Andy Moreton <amoreton@xilinx.com>\n---\n drivers/net/sfc/sfc_repr.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_repr.c b/drivers/net/sfc/sfc_repr.c\nindex d50efe6562..4cbfdbcb66 100644\n--- a/drivers/net/sfc/sfc_repr.c\n+++ b/drivers/net/sfc/sfc_repr.c\n@@ -921,7 +921,6 @@ static const struct eth_dev_ops sfc_repr_dev_ops = {\n \n struct sfc_repr_init_data {\n \tuint16_t\t\tpf_port_id;\n-\tuint16_t\t\trepr_id;\n \tuint16_t\t\tswitch_domain_id;\n \tefx_mport_sel_t\t\tmport_sel;\n \tefx_pcie_interface_t\tintf;\n@@ -979,7 +978,7 @@ sfc_repr_eth_dev_init(struct rte_eth_dev *dev, void *init_params)\n \t}\n \n \tret = sfc_repr_proxy_add_port(repr_data->pf_port_id,\n-\t\t\t\t repr_data->repr_id,\n+\t\t\t\t srs->switch_port_id,\n \t\t\t\t dev->data->port_id,\n \t\t\t\t &repr_data->mport_sel);\n \tif (ret != 0) {\n@@ -1006,7 +1005,7 @@ sfc_repr_eth_dev_init(struct rte_eth_dev *dev, void *init_params)\n \tdev->process_private = sr;\n \n \tsrs->pf_port_id = repr_data->pf_port_id;\n-\tsrs->repr_id = repr_data->repr_id;\n+\tsrs->repr_id = srs->switch_port_id;\n \tsrs->switch_domain_id = repr_data->switch_domain_id;\n \n \tdev->data->dev_flags |= RTE_ETH_DEV_REPRESENTOR;\n@@ -1034,7 +1033,7 @@ sfc_repr_eth_dev_init(struct rte_eth_dev *dev, void *init_params)\n \n fail_alloc_sr:\n \t(void)sfc_repr_proxy_del_port(repr_data->pf_port_id,\n-\t\t\t\t repr_data->repr_id);\n+\t\t\t\t srs->switch_port_id);\n \n fail_create_port:\n fail_mae_assign_switch_port:\n@@ -1087,7 +1086,6 @@ sfc_repr_create(struct rte_eth_dev *parent,\n \tif (dev == NULL) {\n \t\tmemset(&repr_data, 0, sizeof(repr_data));\n \t\trepr_data.pf_port_id = parent->data->port_id;\n-\t\trepr_data.repr_id = entity->vf;\n \t\trepr_data.switch_domain_id = switch_domain_id;\n \t\trepr_data.mport_sel = *mport_sel;\n \t\trepr_data.intf = entity->intf;\n", "prefixes": [ "36/38" ] }