Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/97639/?format=api
http://patchwork.dpdk.org/api/patches/97639/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210831203732.3411134-3-michaelba@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210831203732.3411134-3-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210831203732.3411134-3-michaelba@nvidia.com", "date": "2021-08-31T20:37:28", "name": "[2/6] net/mlx5: fix PCI probing error flow", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cb96a5e73573b38cfd47843da408232d18d53179", "submitter": { "id": 1949, "url": "http://patchwork.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210831203732.3411134-3-michaelba@nvidia.com/mbox/", "series": [ { "id": 18580, "url": "http://patchwork.dpdk.org/api/series/18580/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18580", "date": "2021-08-31T20:37:26", "name": "mlx5: some independent fixes", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18580/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/97639/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/97639/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E9A20A0C58;\n\tTue, 31 Aug 2021 22:38:16 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0728A41145;\n\tTue, 31 Aug 2021 22:38:06 +0200 (CEST)", "from NAM12-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam12on2079.outbound.protection.outlook.com [40.107.244.79])\n by mails.dpdk.org (Postfix) with ESMTP id C19EC410FA;\n Tue, 31 Aug 2021 22:38:02 +0200 (CEST)", "from MWHPR22CA0037.namprd22.prod.outlook.com (2603:10b6:300:69::23)\n by MN2PR12MB3375.namprd12.prod.outlook.com (2603:10b6:208:cc::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Tue, 31 Aug\n 2021 20:38:01 +0000", "from CO1NAM11FT059.eop-nam11.prod.protection.outlook.com\n (2603:10b6:300:69:cafe::93) by MWHPR22CA0037.outlook.office365.com\n (2603:10b6:300:69::23) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.18 via Frontend\n Transport; Tue, 31 Aug 2021 20:38:00 +0000", "from mail.nvidia.com (216.228.112.32) by\n CO1NAM11FT059.mail.protection.outlook.com (10.13.174.160) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4457.17 via Frontend Transport; Tue, 31 Aug 2021 20:38:00 +0000", "from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL109.nvidia.com\n (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 31 Aug\n 2021 13:38:00 -0700", "from nvidia.com (172.20.187.6) by DRHQMAIL107.nvidia.com\n (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 31 Aug\n 2021 20:37:58 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=WMcjqkVShJwxNOP16FyCSqWTV+4PCfUiw462A+OIMIK7P3dxymW36lJzadIqCprA79y8NGaCciBYux7tMIZl5uw7se29E8H6zCeqeUsYLCfyGElSv0cCzCBWkH95B7A/k3VZKoVz76Ur2t3z29QARWh6DZnHTlV2gDtjzLSfEw5N3F8/90wRWymvV0G4o5Gx+pQ51lZsGE2BDhHKO/9O/c5MCHOHgC9RoNdGmWJKWqgM6lf0/PRxCUwIuRrCgeT6VCjJqawVhH5es/te49S70aHjK61K/jaMojtZP23zhxnH487QhxlMKJnhA0hexGslLVSdBzkiqTtOPsGvAuPZvQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=B1HFx0KjCksIhz1cOLOsjRQyo3M8oNgjsbuwGXwkQP4=;\n b=dhaYWudDAuwAwX/caoTuzKu0Zg7yz+3IOT6Pa7ovLYT+QwdUgE7c7tbkBFYwK4v+FmGfN21t+0gS5ACSdhsV9AC0HFOeGAquGVQBR/IJLf50VOy+ArSFNOMqrbo7FR65fZbTPpijb+Iprk3sRpUwUZQYACz2LJSnddLg+h1GnnIDNBMVb1eQ5sDlH/2Ehjlj697toiIoM8urRGsYnlEaEDIulbpx322hSOq0PSA3nk6r6IM9kOmLm+Rrcx976qCtAGUd/I3AIAGzTF+K6M3EQ+OoALVxiVZ7sBLLa/WyfnpkGKKWVWz9brkuwpZIN79NnmUO8bBG07zlWt+X5WbSiw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.32) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=B1HFx0KjCksIhz1cOLOsjRQyo3M8oNgjsbuwGXwkQP4=;\n b=T+ZEBO+gL6dQTMZQb/RMDs+Y/URHBhjnYMivZyTMuA2+xn1VnhkXrSc1SYjHk3KjDF46F9XgKBUNkKdIId7K1lNfxhrZuHPrthgytX+ADjFyUfIlqaud0vI13KoDvz8XO83adEdBSB5K3CXL21EtXfIyU8gKCfswwBhbkV/tkcUBjS2Bmhm44QtKwpmIEEs60cpq66Yn6F/ozOGfGhZnNrt/y1kYfrZP9LxA/br7W6O91fkSaS0ZRerZTu1KLxWyo94Ht1rcH08nJuHL2EnbdUfCxACfDJhb+NQcymmHJ+tsIZ7j8liqX55RtpsQYPWqmj2cgVDRnPLYRiMJOa7aEg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.32)\n smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed)\n header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.32 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.32; helo=mail.nvidia.com;", "From": "Michael Baum <michaelba@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>, <stable@dpdk.org>", "Date": "Tue, 31 Aug 2021 23:37:28 +0300", "Message-ID": "<20210831203732.3411134-3-michaelba@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210831203732.3411134-1-michaelba@nvidia.com>", "References": "<20210831203732.3411134-1-michaelba@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.6]", "X-ClientProxiedBy": "HQMAIL101.nvidia.com (172.20.187.10) To\n DRHQMAIL107.nvidia.com (10.27.9.16)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "91bcfa42-b4c4-4b60-4f5f-08d96cbf3977", "X-MS-TrafficTypeDiagnostic": "MN2PR12MB3375:", "X-Microsoft-Antispam-PRVS": "\n <MN2PR12MB3375B25AD5CACE5922CB2B16CCCC9@MN2PR12MB3375.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:4303;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n j5rF29GiSan0OwYH3xtRuuUJF+1CZacbPLmiI6UPDL63r9J5J87OUvdLaqrOMyahB3gY9iu+3GNie8fb/KJnzo6bEtDaB40pDrQqDUQs8tSvSPWFvyd8cwM70NHpYrMgSGvbsCx35v7Y59CFopio3ze4X7kUCHjKR4TjlqDTfHykRNIk7v1cUG+F/Nrd/3cYPBrNG/GQvGZAKx/dIOfUh13R/ZY4Cp6F+t95jU9Fl5Y/9hUyf7kPJY22VoUxFPYz4oYyX6KhGn4GCPh3JcGPZRGqdFyU78QTk/bQDTJePMAeabN/JEweVXDVMFJauYsUPz+eeidMpcc+MZ7b3MDLLubMF+W2XIBVtvBt0N9RQNokJDCJJIKzKGzvhkWMdfwMgsz1FZuCoBaa8NMHzY7W84ixNCNH8f1ydMPXp8U1CZ7m9LbwtgeHPFm+1ua0E5K/i9qP4eSfz6aVAIbZhKP4csY8btVZI4LM6lJOxOKnSOrEQFmLlEbE26nlaCoPw+4mTj0gmD6O/niYKjqlSOiRa613Z84pjs/PvXnrn1LtN232n5CzNLYuPdcOBI0SjKWV+5BBFyywo1cSHDeS+Vuu0Pz0KYXbl63M8l/j6FXWuq3tJaKReEBce6Wv+IaJbkGZUlK+79t5nSAEIozA55WmokJQozgbYhMBeetgz/xGPK8ii4OvXGSkwMmmxkJTvjADhvjlatD5Nu8nYvrd5dfrMQ==", "X-Forefront-Antispam-Report": "CIP:216.228.112.32; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid01.nvidia.com; CAT:NONE;\n SFS:(4636009)(346002)(39860400002)(396003)(376002)(136003)(46966006)(36840700001)(6286002)(83380400001)(36860700001)(316002)(8676002)(7636003)(86362001)(82310400003)(6666004)(5660300002)(54906003)(426003)(7696005)(47076005)(2906002)(82740400003)(16526019)(186003)(70586007)(450100002)(8936002)(1076003)(4326008)(36756003)(336012)(6916009)(26005)(478600001)(356005)(2616005)(70206006)(55016002);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "31 Aug 2021 20:38:00.7170 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 91bcfa42-b4c4-4b60-4f5f-08d96cbf3977", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.32];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT059.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN2PR12MB3375", "Subject": "[dpdk-dev] [PATCH 2/6] net/mlx5: fix PCI probing error flow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In PCI probing, there is internal probe function that is called several\ntimes for several PFs.\n\nWhen one of them fails, the previous PFs are not destroyed what may\ncause a memory leak.\n\nDestroy them.\n\nFixes: 08c2772fc747 (\"net/mlx5: support list of representor PF\")\nCc: stable@dpdk.org\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\n---\n drivers/net/mlx5/linux/mlx5_os.c | 13 ++++++++++++-\n drivers/net/mlx5/mlx5.c | 2 +-\n drivers/net/mlx5/mlx5.h | 1 +\n 3 files changed, 14 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c\nindex 5f8766aa48..3d204f99f7 100644\n--- a/drivers/net/mlx5/linux/mlx5_os.c\n+++ b/drivers/net/mlx5/linux/mlx5_os.c\n@@ -2700,9 +2700,20 @@ mlx5_os_pci_probe(struct rte_pci_device *pci_dev)\n \n \tif (eth_da.nb_ports > 0) {\n \t\t/* Iterate all port if devargs pf is range: \"pf[0-1]vf[...]\". */\n-\t\tfor (p = 0; p < eth_da.nb_ports; p++)\n+\t\tfor (p = 0; p < eth_da.nb_ports; p++) {\n \t\t\tret = mlx5_os_pci_probe_pf(pci_dev, ð_da,\n \t\t\t\t\t\t eth_da.ports[p]);\n+\t\t\tif (ret)\n+\t\t\t\tbreak;\n+\t\t}\n+\t\tif (ret) {\n+\t\t\tDRV_LOG(ERR, \"Probe of PCI device \" PCI_PRI_FMT \" \"\n+\t\t\t\t\"aborted due to proding failure of PF %u\",\n+\t\t\t\tpci_dev->addr.domain, pci_dev->addr.bus,\n+\t\t\t\tpci_dev->addr.devid, pci_dev->addr.function,\n+\t\t\t\teth_da.ports[p]);\n+\t\t\tmlx5_net_remove(&pci_dev->device);\n+\t\t}\n \t} else {\n \t\tret = mlx5_os_pci_probe_pf(pci_dev, ð_da, 0);\n \t}\ndiff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex f0ec2d1279..02ea2e781e 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -2386,7 +2386,7 @@ mlx5_eth_find_next(uint16_t port_id, struct rte_device *odev)\n * @return\n * 0 on success, the function cannot fail.\n */\n-static int\n+int\n mlx5_net_remove(struct rte_device *dev)\n {\n \tuint16_t port_id;\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex e02714e231..3581414b78 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -1483,6 +1483,7 @@ int mlx5_udp_tunnel_port_add(struct rte_eth_dev *dev,\n \t\t\t struct rte_eth_udp_tunnel *udp_tunnel);\n uint16_t mlx5_eth_find_next(uint16_t port_id, struct rte_device *odev);\n int mlx5_dev_close(struct rte_eth_dev *dev);\n+int mlx5_net_remove(struct rte_device *dev);\n bool mlx5_is_hpf(struct rte_eth_dev *dev);\n bool mlx5_is_sf_repr(struct rte_eth_dev *dev);\n void mlx5_age_event_prepare(struct mlx5_dev_ctx_shared *sh);\n", "prefixes": [ "2/6" ] }{ "id": 97639, "url": "