Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 98508,
    "url": "http://patchwork.dpdk.org/api/patches/98508/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210909231312.2572006-7-honnappa.nagarahalli@arm.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210909231312.2572006-7-honnappa.nagarahalli@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210909231312.2572006-7-honnappa.nagarahalli@arm.com",
    "date": "2021-09-09T23:13:12",
    "name": "[v2,6/6] test/ring: use relaxed barriers for ring stress test",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "689772aa99700c82d1fdf5991f8f7487b61cac87",
    "submitter": {
        "id": 1045,
        "url": "http://patchwork.dpdk.org/api/people/1045/?format=api",
        "name": "Honnappa Nagarahalli",
        "email": "honnappa.nagarahalli@arm.com"
    },
    "delegate": {
        "id": 24651,
        "url": "http://patchwork.dpdk.org/api/users/24651/?format=api",
        "username": "dmarchand",
        "first_name": "David",
        "last_name": "Marchand",
        "email": "david.marchand@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210909231312.2572006-7-honnappa.nagarahalli@arm.com/mbox/",
    "series": [
        {
            "id": 18807,
            "url": "http://patchwork.dpdk.org/api/series/18807/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18807",
            "date": "2021-09-09T23:13:06",
            "name": "Use correct memory ordering in eal functions",
            "version": 2,
            "mbox": "http://patchwork.dpdk.org/series/18807/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/98508/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/98508/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 981A0A0547;\n\tFri, 10 Sep 2021 01:14:02 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BD6FE41142;\n\tFri, 10 Sep 2021 01:13:47 +0200 (CEST)",
            "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id B3BF941120\n for <dev@dpdk.org>; Fri, 10 Sep 2021 01:13:42 +0200 (CEST)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 29CAB106F;\n Thu,  9 Sep 2021 16:13:42 -0700 (PDT)",
            "from 2p2660v4-1.austin.arm.com (2p2660v4-1.austin.arm.com\n [10.118.13.211])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 21C553F73D;\n Thu,  9 Sep 2021 16:13:42 -0700 (PDT)"
        ],
        "From": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>",
        "To": "dev@dpdk.org, honnappa.nagarahalli@arm.com, konstantin.ananyev@intel.com,\n david.marchand@redhat.com, feifei.wang2@arm.com",
        "Cc": "ruifeng.wang@arm.com, nd@arm.com, Ola Liljedahl <ola.liljedahl@arm.com>,\n Feifei Wang <feifei.wang@arm.com>",
        "Date": "Thu,  9 Sep 2021 18:13:12 -0500",
        "Message-Id": "<20210909231312.2572006-7-honnappa.nagarahalli@arm.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20210909231312.2572006-1-honnappa.nagarahalli@arm.com>",
        "References": "<20210224212018.17576-1-honnappa.nagarahalli@arm.com>\n <20210909231312.2572006-1-honnappa.nagarahalli@arm.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v2 6/6] test/ring: use relaxed barriers for ring\n stress test",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "wrk_cmd variable is used to signal the worker thread to start\nor stop the stress test loop. Relaxed barriers are used\nto achieve the same.\n\nSigned-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Ola Liljedahl <ola.liljedahl@arm.com>\nReviewed-by: Feifei Wang <feifei.wang@arm.com>\n---\n app/test/test_ring_stress_impl.h | 18 +++++++++---------\n 1 file changed, 9 insertions(+), 9 deletions(-)",
    "diff": "diff --git a/app/test/test_ring_stress_impl.h b/app/test/test_ring_stress_impl.h\nindex f9ca63b908..ee8293bb04 100644\n--- a/app/test/test_ring_stress_impl.h\n+++ b/app/test/test_ring_stress_impl.h\n@@ -22,7 +22,7 @@ enum {\n \tWRK_CMD_RUN,\n };\n \n-static volatile uint32_t wrk_cmd __rte_cache_aligned;\n+static volatile uint32_t wrk_cmd __rte_cache_aligned = WRK_CMD_STOP;\n \n /* test run-time in seconds */\n static const uint32_t run_time = 60;\n@@ -197,10 +197,12 @@ test_worker(void *arg, const char *fname, int32_t prcs)\n \tfill_ring_elm(&def_elm, UINT32_MAX);\n \tfill_ring_elm(&loc_elm, lc);\n \n-\twhile (wrk_cmd != WRK_CMD_RUN) {\n-\t\trte_smp_rmb();\n+\t/* Acquire ordering is not required as the main is not\n+\t * really releasing any data through 'wrk_cmd' to\n+\t * the worker.\n+\t */\n+\twhile (__atomic_load_n(&wrk_cmd, __ATOMIC_RELAXED) != WRK_CMD_RUN)\n \t\trte_pause();\n-\t}\n \n \tcl = rte_rdtsc_precise();\n \n@@ -242,7 +244,7 @@ test_worker(void *arg, const char *fname, int32_t prcs)\n \n \t\tlcore_stat_update(&la->stats, 1, num, tm0 + tm1, prcs);\n \n-\t} while (wrk_cmd == WRK_CMD_RUN);\n+\t} while (__atomic_load_n(&wrk_cmd, __ATOMIC_RELAXED) == WRK_CMD_RUN);\n \n \tcl = rte_rdtsc_precise() - cl;\n \tif (prcs == 0)\n@@ -356,14 +358,12 @@ test_mt1(int (*test)(void *))\n \t}\n \n \t/* signal worker to start test */\n-\twrk_cmd = WRK_CMD_RUN;\n-\trte_smp_wmb();\n+\t__atomic_store_n(&wrk_cmd, WRK_CMD_RUN, __ATOMIC_RELEASE);\n \n \tusleep(run_time * US_PER_S);\n \n \t/* signal worker to start test */\n-\twrk_cmd = WRK_CMD_STOP;\n-\trte_smp_wmb();\n+\t__atomic_store_n(&wrk_cmd, WRK_CMD_STOP, __ATOMIC_RELEASE);\n \n \t/* wait for workers and collect stats. */\n \tmc = rte_lcore_id();\n",
    "prefixes": [
        "v2",
        "6/6"
    ]
}