Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98615/?format=api
{ "id": 98615, "url": "http://patchwork.dpdk.org/api/patches/98615/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210910123003.85448-8-cristian.dumitrescu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210910123003.85448-8-cristian.dumitrescu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210910123003.85448-8-cristian.dumitrescu@intel.com", "date": "2021-09-10T12:29:47", "name": "[08/24] pipeline: create inline functions for learn instruction", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7b92f3b434ae9c368c28e0fe77fc4c3838df1e11", "submitter": { "id": 19, "url": "http://patchwork.dpdk.org/api/people/19/?format=api", "name": "Cristian Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210910123003.85448-8-cristian.dumitrescu@intel.com/mbox/", "series": [ { "id": 18838, "url": "http://patchwork.dpdk.org/api/series/18838/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18838", "date": "2021-09-10T12:29:44", "name": "[01/24] pipeline: move data structures to internal header file", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18838/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/98615/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/98615/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A0019A0548;\n\tFri, 10 Sep 2021 14:31:54 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8F2E54117B;\n\tFri, 10 Sep 2021 14:30:37 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id A779541130\n for <dev@dpdk.org>; Fri, 10 Sep 2021 14:30:23 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Sep 2021 05:30:11 -0700", "from silpixa00400573.ir.intel.com (HELO\n silpixa00400573.ger.corp.intel.com) ([10.237.223.107])\n by orsmga001.jf.intel.com with ESMTP; 10 Sep 2021 05:30:10 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10102\"; a=\"243386267\"", "E=Sophos;i=\"5.85,282,1624345200\"; d=\"scan'208\";a=\"243386267\"", "E=Sophos;i=\"5.85,282,1624345200\"; d=\"scan'208\";a=\"514279729\"" ], "X-ExtLoop1": "1", "From": "Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 10 Sep 2021 13:29:47 +0100", "Message-Id": "<20210910123003.85448-8-cristian.dumitrescu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210910123003.85448-1-cristian.dumitrescu@intel.com>", "References": "<20210910123003.85448-1-cristian.dumitrescu@intel.com>", "Subject": "[dpdk-dev] [PATCH 08/24] pipeline: create inline functions for\n learn instruction", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\n---\n lib/pipeline/rte_swx_pipeline.c | 36 ++--------------\n lib/pipeline/rte_swx_pipeline_internal.h | 55 ++++++++++++++++++++++++\n 2 files changed, 58 insertions(+), 33 deletions(-)", "diff": "diff --git a/lib/pipeline/rte_swx_pipeline.c b/lib/pipeline/rte_swx_pipeline.c\nindex 6c6d8e52a5..ca12f34b01 100644\n--- a/lib/pipeline/rte_swx_pipeline.c\n+++ b/lib/pipeline/rte_swx_pipeline.c\n@@ -2230,27 +2230,8 @@ instr_learn_exec(struct rte_swx_pipeline *p)\n {\n \tstruct thread *t = &p->threads[p->thread_id];\n \tstruct instruction *ip = t->ip;\n-\tuint64_t action_id = ip->learn.action_id;\n-\tuint32_t learner_id = t->learner_id;\n-\tstruct rte_swx_table_state *ts = &t->table_state[p->n_tables +\n-\t\tp->n_selectors + learner_id];\n-\tstruct learner_runtime *l = &t->learners[learner_id];\n-\tstruct learner_statistics *stats = &p->learner_stats[learner_id];\n-\tuint32_t status;\n-\n-\t/* Table. */\n-\tstatus = rte_swx_table_learner_add(ts->obj,\n-\t\t\t\t\t l->mailbox,\n-\t\t\t\t\t t->time,\n-\t\t\t\t\t action_id,\n-\t\t\t\t\t l->action_data[action_id]);\n-\n-\tTRACE(\"[Thread %2u] learner %u learn %s\\n\",\n-\t p->thread_id,\n-\t learner_id,\n-\t status ? \"ok\" : \"error\");\n \n-\tstats->n_pkts_learn[status] += 1;\n+\t__instr_learn_exec(p, t, ip);\n \n \t/* Thread. */\n \tthread_ip_inc(p);\n@@ -2279,20 +2260,9 @@ static inline void\n instr_forget_exec(struct rte_swx_pipeline *p)\n {\n \tstruct thread *t = &p->threads[p->thread_id];\n-\tuint32_t learner_id = t->learner_id;\n-\tstruct rte_swx_table_state *ts = &t->table_state[p->n_tables +\n-\t\tp->n_selectors + learner_id];\n-\tstruct learner_runtime *l = &t->learners[learner_id];\n-\tstruct learner_statistics *stats = &p->learner_stats[learner_id];\n-\n-\t/* Table. */\n-\trte_swx_table_learner_delete(ts->obj, l->mailbox);\n-\n-\tTRACE(\"[Thread %2u] learner %u forget\\n\",\n-\t p->thread_id,\n-\t learner_id);\n+\tstruct instruction *ip = t->ip;\n \n-\tstats->n_pkts_forget += 1;\n+\t__instr_forget_exec(p, t, ip);\n \n \t/* Thread. */\n \tthread_ip_inc(p);\ndiff --git a/lib/pipeline/rte_swx_pipeline_internal.h b/lib/pipeline/rte_swx_pipeline_internal.h\nindex 312490f11a..24096a23b6 100644\n--- a/lib/pipeline/rte_swx_pipeline_internal.h\n+++ b/lib/pipeline/rte_swx_pipeline_internal.h\n@@ -1960,4 +1960,59 @@ __instr_hdr_invalidate_exec(struct rte_swx_pipeline *p __rte_unused,\n \tt->valid_headers = MASK64_BIT_CLR(t->valid_headers, header_id);\n }\n \n+/*\n+ * learn.\n+ */\n+static inline void\n+__instr_learn_exec(struct rte_swx_pipeline *p,\n+\t\t struct thread *t,\n+\t\t const struct instruction *ip)\n+{\n+\tuint64_t action_id = ip->learn.action_id;\n+\tuint32_t learner_id = t->learner_id;\n+\tstruct rte_swx_table_state *ts = &t->table_state[p->n_tables +\n+\t\tp->n_selectors + learner_id];\n+\tstruct learner_runtime *l = &t->learners[learner_id];\n+\tstruct learner_statistics *stats = &p->learner_stats[learner_id];\n+\tuint32_t status;\n+\n+\t/* Table. */\n+\tstatus = rte_swx_table_learner_add(ts->obj,\n+\t\t\t\t\t l->mailbox,\n+\t\t\t\t\t t->time,\n+\t\t\t\t\t action_id,\n+\t\t\t\t\t l->action_data[action_id]);\n+\n+\tTRACE(\"[Thread %2u] learner %u learn %s\\n\",\n+\t p->thread_id,\n+\t learner_id,\n+\t status ? \"ok\" : \"error\");\n+\n+\tstats->n_pkts_learn[status] += 1;\n+}\n+\n+/*\n+ * forget.\n+ */\n+static inline void\n+__instr_forget_exec(struct rte_swx_pipeline *p,\n+\t\t struct thread *t,\n+\t\t const struct instruction *ip __rte_unused)\n+{\n+\tuint32_t learner_id = t->learner_id;\n+\tstruct rte_swx_table_state *ts = &t->table_state[p->n_tables +\n+\t\tp->n_selectors + learner_id];\n+\tstruct learner_runtime *l = &t->learners[learner_id];\n+\tstruct learner_statistics *stats = &p->learner_stats[learner_id];\n+\n+\t/* Table. */\n+\trte_swx_table_learner_delete(ts->obj, l->mailbox);\n+\n+\tTRACE(\"[Thread %2u] learner %u forget\\n\",\n+\t p->thread_id,\n+\t learner_id);\n+\n+\tstats->n_pkts_forget += 1;\n+}\n+\n #endif\n", "prefixes": [ "08/24" ] }