Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98619/?format=api
{ "id": 98619, "url": "http://patchwork.dpdk.org/api/patches/98619/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210910123003.85448-16-cristian.dumitrescu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210910123003.85448-16-cristian.dumitrescu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210910123003.85448-16-cristian.dumitrescu@intel.com", "date": "2021-09-10T12:29:55", "name": "[16/24] pipeline: enable persistent instruction meta-data", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "508e91be2deae70bc39befb0a701e27619188399", "submitter": { "id": 19, "url": "http://patchwork.dpdk.org/api/people/19/?format=api", "name": "Cristian Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210910123003.85448-16-cristian.dumitrescu@intel.com/mbox/", "series": [ { "id": 18838, "url": "http://patchwork.dpdk.org/api/series/18838/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18838", "date": "2021-09-10T12:29:44", "name": "[01/24] pipeline: move data structures to internal header file", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18838/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/98619/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/98619/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 23D18A0547;\n\tFri, 10 Sep 2021 14:32:18 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 49DCD41190;\n\tFri, 10 Sep 2021 14:30:42 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id D8B5241141\n for <dev@dpdk.org>; Fri, 10 Sep 2021 14:30:24 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Sep 2021 05:30:19 -0700", "from silpixa00400573.ir.intel.com (HELO\n silpixa00400573.ger.corp.intel.com) ([10.237.223.107])\n by orsmga001.jf.intel.com with ESMTP; 10 Sep 2021 05:30:18 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10102\"; a=\"243386308\"", "E=Sophos;i=\"5.85,282,1624345200\"; d=\"scan'208\";a=\"243386308\"", "E=Sophos;i=\"5.85,282,1624345200\"; d=\"scan'208\";a=\"514279798\"" ], "X-ExtLoop1": "1", "From": "Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "To": "dev@dpdk.org", "Date": "Fri, 10 Sep 2021 13:29:55 +0100", "Message-Id": "<20210910123003.85448-16-cristian.dumitrescu@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210910123003.85448-1-cristian.dumitrescu@intel.com>", "References": "<20210910123003.85448-1-cristian.dumitrescu@intel.com>", "Subject": "[dpdk-dev] [PATCH 16/24] pipeline: enable persistent instruction\n meta-data", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Save the instruction meta-data for later use instead of freeing it up\nonce the instruction translation is completed.\n\nSigned-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\n---\n lib/pipeline/rte_swx_pipeline.c | 9 ++++++---\n lib/pipeline/rte_swx_pipeline_internal.h | 2 ++\n 2 files changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/pipeline/rte_swx_pipeline.c b/lib/pipeline/rte_swx_pipeline.c\nindex 8b64c57652..4099e364f5 100644\n--- a/lib/pipeline/rte_swx_pipeline.c\n+++ b/lib/pipeline/rte_swx_pipeline.c\n@@ -6456,13 +6456,14 @@ instruction_config(struct rte_swx_pipeline *p,\n \n \tif (a) {\n \t\ta->instructions = instr;\n+\t\ta->instruction_data = data;\n \t\ta->n_instructions = n_instructions;\n \t} else {\n \t\tp->instructions = instr;\n+\t\tp->instruction_data = data;\n \t\tp->n_instructions = n_instructions;\n \t}\n \n-\tfree(data);\n \treturn 0;\n \n error:\n@@ -6811,8 +6812,8 @@ action_build(struct rte_swx_pipeline *p)\n {\n \tstruct action *action;\n \n-\tp->action_instructions = calloc(p->n_actions,\n-\t\t\t\t\tsizeof(struct instruction *));\n+\t/* p->action_instructions. */\n+\tp->action_instructions = calloc(p->n_actions, sizeof(struct instruction *));\n \tCHECK(p->action_instructions, ENOMEM);\n \n \tTAILQ_FOREACH(action, &p->actions, node)\n@@ -6841,6 +6842,7 @@ action_free(struct rte_swx_pipeline *p)\n \t\t\tbreak;\n \n \t\tTAILQ_REMOVE(&p->actions, action, node);\n+\t\tfree(action->instruction_data);\n \t\tfree(action->instructions);\n \t\tfree(action);\n \t}\n@@ -8777,6 +8779,7 @@ rte_swx_pipeline_free(struct rte_swx_pipeline *p)\n \tif (!p)\n \t\treturn;\n \n+\tfree(p->instruction_data);\n \tfree(p->instructions);\n \n \tmetarray_free(p);\ndiff --git a/lib/pipeline/rte_swx_pipeline_internal.h b/lib/pipeline/rte_swx_pipeline_internal.h\nindex efd136196f..7a02d6cb5f 100644\n--- a/lib/pipeline/rte_swx_pipeline_internal.h\n+++ b/lib/pipeline/rte_swx_pipeline_internal.h\n@@ -693,6 +693,7 @@ struct action {\n \tstruct struct_type *st;\n \tint *args_endianness; /* 0 = Host Byte Order (HBO); 1 = Network Byte Order (NBO). */\n \tstruct instruction *instructions;\n+\tstruct instruction_data *instruction_data;\n \tuint32_t n_instructions;\n \tuint32_t id;\n };\n@@ -1388,6 +1389,7 @@ struct rte_swx_pipeline {\n \tstruct regarray_runtime *regarray_runtime;\n \tstruct metarray_runtime *metarray_runtime;\n \tstruct instruction *instructions;\n+\tstruct instruction_data *instruction_data;\n \tstruct thread threads[RTE_SWX_PIPELINE_THREADS_MAX];\n \n \tuint32_t n_structs;\n", "prefixes": [ "16/24" ] }