Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/98956/?format=api
{ "id": 98956, "url": "http://patchwork.dpdk.org/api/patches/98956/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210915214052.143098-2-dmitry.kozliuk@gmail.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210915214052.143098-2-dmitry.kozliuk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210915214052.143098-2-dmitry.kozliuk@gmail.com", "date": "2021-09-15T21:40:48", "name": "[1/5] compressdev: rename fields for Windows compatibility", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e3cd059eed0e9ca90e9681ec68730207099b98a2", "submitter": { "id": 1581, "url": "http://patchwork.dpdk.org/api/people/1581/?format=api", "name": "Dmitry Kozlyuk", "email": "dmitry.kozliuk@gmail.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210915214052.143098-2-dmitry.kozliuk@gmail.com/mbox/", "series": [ { "id": 18953, "url": "http://patchwork.dpdk.org/api/series/18953/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18953", "date": "2021-09-15T21:40:47", "name": "lib: Windows compatibility renaming", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18953/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/98956/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/98956/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 955D0A0C41;\n\tWed, 15 Sep 2021 23:41:07 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D25BF410E0;\n\tWed, 15 Sep 2021 23:41:02 +0200 (CEST)", "from mail-lf1-f41.google.com (mail-lf1-f41.google.com\n [209.85.167.41]) by mails.dpdk.org (Postfix) with ESMTP id D32FE4003C\n for <dev@dpdk.org>; Wed, 15 Sep 2021 23:41:00 +0200 (CEST)", "by mail-lf1-f41.google.com with SMTP id i7so9845005lfr.13\n for <dev@dpdk.org>; Wed, 15 Sep 2021 14:41:00 -0700 (PDT)", "from sovereign.. (broadband-37-110-65-23.ip.moscow.rt.ru.\n [37.110.65.23])\n by smtp.gmail.com with ESMTPSA id o4sm85989lfi.16.2021.09.15.14.40.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 Sep 2021 14:40:59 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=alfCy+6jX511g0kVPSW28xQKdwJuSD1AESWa1MiO/8o=;\n b=qREZlsuIhxtoULuv7GcOIhZFG1/ciI9EAZ7Q0qN+apm2dY1i9PjmPCv4J/qF9rUtIl\n wpMCvjWm9iEJk7c9/n4KSGtC6VJ1txq6aKSn041dppER3Mv/PT6vySr44tO7byZBH/uj\n 0gBuLJYnozMh9RozbozL4ADmWDDVXkKXepvf+z9Ju+NitMnVAQgXDzyW6QK8c3+xbwnX\n GwMlWjvkAw/r3PD4Xo0B8vs9IpjLMyyykOuZz49fvjUHW828ObogVzwb3WltOtD7Cb2c\n YQeiS2uFnQezSt1DkZGDQlsce3moYz/orJfV4p+v4N3iqkxV1emmfxbSiQd8I28SFw3+\n 6nxg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=alfCy+6jX511g0kVPSW28xQKdwJuSD1AESWa1MiO/8o=;\n b=FIDVxPjS/bkLcW6gveZoUo49hzUK8oXlK3eRnivLWHtnntlSdqJKxO/aq+sEk4rMVw\n RqvE+x4yMASb+Ftq6O+Zeab3kQ4QzxxZRTIwbF/bPHNFzlEV1TK3vUqmUAbsEODkUuib\n Hxf6hWDr/yXkSvyYaAMoTZyZQGzBSdPMz4ZGqS3NAYU5AMiFgzisgbaiSARZ9niu0m3P\n A0i28BcVAZbeUX5p2qQeAHI0/kxOspKiz2IdoULjhzM73SVL3iVhmJFKQYTMS2uE0I5i\n kV/Ls3ue97S4boCFnPiS1Rvbvamqs9pXmh3MsI7emtbVbCrjXO/MaIgV8S1Ct3J6wOXL\n y9GA==", "X-Gm-Message-State": "AOAM533tgWWLD/MvWDkQinO/hjUwNFPPbetvcjd1PUD+/sCtHDtPVVep\n G098T24hI9R/kGqzLdvgY9Xdx/tvJbQcHQ==", "X-Google-Smtp-Source": "\n ABdhPJyCI7wwrMhk1uXj/bK+wBSzXGXz+GdyBoKvJTWRXm7OUpO0kv6BuuLB3tUkBrDEvMRxCnfSqg==", "X-Received": "by 2002:a2e:4951:: with SMTP id b17mr1934699ljd.414.1631742060039;\n Wed, 15 Sep 2021 14:41:00 -0700 (PDT)", "From": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>", "To": "dev@dpdk.org", "Cc": "Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Ashish Gupta <ashish.gupta@marvell.com>,\n Fiona Trahe <fiona.trahe@intel.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>, Ray Kinsella <mdr@ashroe.eu>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Date": "Thu, 16 Sep 2021 00:40:48 +0300", "Message-Id": "<20210915214052.143098-2-dmitry.kozliuk@gmail.com>", "X-Mailer": "git-send-email 2.29.3", "In-Reply-To": "<20210915214052.143098-1-dmitry.kozliuk@gmail.com>", "References": "<20210915214052.143098-1-dmitry.kozliuk@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/5] compressdev: rename fields for Windows\n compatibility", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Windows SDK headers define `min` and `max` macros which break definition\nof `struct rte_param_log2_range`. Rename the structure fields\nto `minimum` and `maximum` to allow inclusion of both DPDK and Windows\nheaders in the same file. Deprecation notice:\nhttps://mails.dpdk.org/archives/dev/2021-July/215270.html\n\nSigned-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>\n---\n app/test-compress-perf/comp_perf_test_common.c | 6 +++---\n app/test-compress-perf/main.c | 2 +-\n doc/guides/rel_notes/deprecation.rst | 3 ---\n doc/guides/rel_notes/release_20_11.rst | 3 +++\n drivers/compress/isal/isal_compress_pmd_ops.c | 4 ++--\n drivers/compress/mlx5/mlx5_compress.c | 2 +-\n drivers/compress/octeontx/otx_zip_pmd.c | 4 ++--\n drivers/compress/qat/qat_comp_pmd.c | 2 +-\n drivers/compress/zlib/zlib_pmd_ops.c | 4 ++--\n lib/compressdev/rte_compressdev.h | 4 ++--\n 10 files changed, 17 insertions(+), 17 deletions(-)", "diff": "diff --git a/app/test-compress-perf/comp_perf_test_common.c b/app/test-compress-perf/comp_perf_test_common.c\nindex b402a0d839..b85323049f 100644\n--- a/app/test-compress-perf/comp_perf_test_common.c\n+++ b/app/test-compress-perf/comp_perf_test_common.c\n@@ -35,10 +35,10 @@ param_range_check(uint16_t size, const struct rte_param_log2_range *range)\n \tunsigned int next_size;\n \n \t/* Check lower/upper bounds */\n-\tif (size < range->min)\n+\tif (size < range->minimum)\n \t\treturn -1;\n \n-\tif (size > range->max)\n+\tif (size > range->maximum)\n \t\treturn -1;\n \n \t/* If range is actually only one value, size is correct */\n@@ -46,7 +46,7 @@ param_range_check(uint16_t size, const struct rte_param_log2_range *range)\n \t\treturn 0;\n \n \t/* Check if value is one of the supported sizes */\n-\tfor (next_size = range->min; next_size <= range->max;\n+\tfor (next_size = range->minimum; next_size <= range->maximum;\n \t\t\tnext_size += range->increment)\n \t\tif (size == next_size)\n \t\t\treturn 0;\ndiff --git a/app/test-compress-perf/main.c b/app/test-compress-perf/main.c\nindex cc9951a9b1..9fe6160f4a 100644\n--- a/app/test-compress-perf/main.c\n+++ b/app/test-compress-perf/main.c\n@@ -93,7 +93,7 @@ comp_perf_check_capabilities(struct comp_test_data *test_data, uint8_t cdev_id)\n \t\t}\n \t} else\n \t\t/* Set window size to PMD maximum if none was specified */\n-\t\ttest_data->window_sz = cap->window_size.max;\n+\t\ttest_data->window_sz = cap->window_size.maximum;\n \n \t/* Check if chained mbufs is supported */\n \tif (test_data->max_sgl_segs > 1 &&\ndiff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 76a4abfd6b..7b848528ff 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -196,9 +196,6 @@ Deprecation Notices\n and ``rte_vhost_driver_set_protocol_features`` functions will be removed\n and the API functions will be made stable in DPDK 21.11.\n \n-* compressdev: ``min`` and ``max`` fields of ``rte_param_log2_range`` structure\n- will be renamed in DPDK 21.11 to avoid conflict with Windows Sockets headers.\n-\n * cryptodev: ``min`` and ``max`` fields of ``rte_crypto_param_range`` structure\n will be renamed in DPDK 21.11 to avoid conflict with Windows Sockets headers.\n \ndiff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst\nindex d07fd815dc..d93790c3b1 100644\n--- a/doc/guides/rel_notes/release_20_11.rst\n+++ b/doc/guides/rel_notes/release_20_11.rst\n@@ -662,6 +662,9 @@ API Changes\n * sched: Removed ``tb_rate``, ``tc_rate``, ``tc_period`` and ``tb_size``\n from ``struct rte_sched_subport_params``.\n \n+* compressdev: Renamed ``min`` and ``max`` fields of ``rte_param_log2_range``\n+ structure to ``minimum`` and ``maximum``, respectively.\n+\n \n ABI Changes\n -----------\ndiff --git a/drivers/compress/isal/isal_compress_pmd_ops.c b/drivers/compress/isal/isal_compress_pmd_ops.c\nindex 9b42147a0b..3a736794dc 100644\n--- a/drivers/compress/isal/isal_compress_pmd_ops.c\n+++ b/drivers/compress/isal/isal_compress_pmd_ops.c\n@@ -22,8 +22,8 @@ static const struct rte_compressdev_capabilities isal_pmd_capabilities[] = {\n \t\t\t\t\tRTE_COMP_FF_CRC32_CHECKSUM |\n \t\t\t\t\tRTE_COMP_FF_ADLER32_CHECKSUM,\n \t\t.window_size = {\n-\t\t\t.min = 15,\n-\t\t\t.max = 15,\n+\t\t\t.minimum = 15,\n+\t\t\t.maximum = 15,\n \t\t\t.increment = 0\n \t\t},\n \t},\ndiff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c\nindex c5e0a83a8c..5ec936c7db 100644\n--- a/drivers/compress/mlx5/mlx5_compress.c\n+++ b/drivers/compress/mlx5/mlx5_compress.c\n@@ -90,7 +90,7 @@ static const struct rte_compressdev_capabilities mlx5_caps[] = {\n \t\t\t\t RTE_COMP_FF_SHAREABLE_PRIV_XFORM |\n \t\t\t\t RTE_COMP_FF_HUFFMAN_FIXED |\n \t\t\t\t RTE_COMP_FF_HUFFMAN_DYNAMIC,\n-\t\t.window_size = {.min = 10, .max = 15, .increment = 1},\n+\t\t.window_size = {.minimum = 10, .maximum = 15, .increment = 1},\n \t},\n \t{\n \t\t.algo = RTE_COMP_ALGO_LIST_END,\ndiff --git a/drivers/compress/octeontx/otx_zip_pmd.c b/drivers/compress/octeontx/otx_zip_pmd.c\nindex dd62285b86..9b8aef9809 100644\n--- a/drivers/compress/octeontx/otx_zip_pmd.c\n+++ b/drivers/compress/octeontx/otx_zip_pmd.c\n@@ -19,8 +19,8 @@ static const struct rte_compressdev_capabilities\n \t\t\t\t\tRTE_COMP_FF_HUFFMAN_DYNAMIC,\n \t\t/* Non sharable Priv XFORM and Stateless */\n \t\t.window_size = {\n-\t\t\t\t.min = 1,\n-\t\t\t\t.max = 14,\n+\t\t\t\t.minimum = 1,\n+\t\t\t\t.maximum = 14,\n \t\t\t\t.increment = 1\n \t\t\t\t/* size supported 2^1 to 2^14 */\n \t\t},\ndiff --git a/drivers/compress/qat/qat_comp_pmd.c b/drivers/compress/qat/qat_comp_pmd.c\nindex caac7839e9..b79d35b85d 100644\n--- a/drivers/compress/qat/qat_comp_pmd.c\n+++ b/drivers/compress/qat/qat_comp_pmd.c\n@@ -29,7 +29,7 @@ static const struct rte_compressdev_capabilities qat_comp_gen_capabilities[] = {\n \t\t\t\tRTE_COMP_FF_OOP_SGL_IN_LB_OUT |\n \t\t\t\tRTE_COMP_FF_OOP_LB_IN_SGL_OUT |\n \t\t\t\tRTE_COMP_FF_STATEFUL_DECOMPRESSION,\n-\t .window_size = {.min = 15, .max = 15, .increment = 0} },\n+\t .window_size = {.minimum = 15, .maximum = 15, .increment = 0} },\n \t{RTE_COMP_ALGO_LIST_END, 0, {0, 0, 0} } };\n \n static void\ndiff --git a/drivers/compress/zlib/zlib_pmd_ops.c b/drivers/compress/zlib/zlib_pmd_ops.c\nindex 0a73aed949..50222f942e 100644\n--- a/drivers/compress/zlib/zlib_pmd_ops.c\n+++ b/drivers/compress/zlib/zlib_pmd_ops.c\n@@ -16,8 +16,8 @@ static const struct rte_compressdev_capabilities zlib_pmd_capabilities[] = {\n \t\t\t\t\tRTE_COMP_FF_HUFFMAN_FIXED |\n \t\t\t\t\tRTE_COMP_FF_HUFFMAN_DYNAMIC),\n \t\t.window_size = {\n-\t\t\t.min = 8,\n-\t\t\t.max = 15,\n+\t\t\t.minimum = 8,\n+\t\t\t.maximum = 15,\n \t\t\t.increment = 1\n \t\t},\n \t},\ndiff --git a/lib/compressdev/rte_compressdev.h b/lib/compressdev/rte_compressdev.h\nindex 2840c27c6c..c6cea3e9c4 100644\n--- a/lib/compressdev/rte_compressdev.h\n+++ b/lib/compressdev/rte_compressdev.h\n@@ -30,8 +30,8 @@ extern \"C\" {\n * Final value will be 2^value.\n */\n struct rte_param_log2_range {\n-\tuint8_t min;\t/**< Minimum log2 value */\n-\tuint8_t max;\t/**< Maximum log2 value */\n+\tuint8_t minimum;\t/**< Minimum log2 value */\n+\tuint8_t maximum;\t/**< Maximum log2 value */\n \tuint8_t increment;\n \t/**< If a range of sizes are supported,\n \t * this parameter is used to indicate\n", "prefixes": [ "1/5" ] }