Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99022/?format=api
{ "id": 99022, "url": "http://patchwork.dpdk.org/api/patches/99022/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com", "date": "2021-09-16T10:36:37", "name": "[v1,1/2] vfio: make API return values consistent", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "175650eae1f44ec331028bd4927a6dda7a652ab1", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 18978, "url": "http://patchwork.dpdk.org/api/series/18978/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18978", "date": "2021-09-16T10:36:37", "name": "[v1,1/2] vfio: make API return values consistent", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18978/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/99022/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/99022/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CA2A1A0C41;\n\tThu, 16 Sep 2021 12:36:42 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AFD304069E;\n\tThu, 16 Sep 2021 12:36:42 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 51C744003F\n for <dev@dpdk.org>; Thu, 16 Sep 2021 12:36:41 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Sep 2021 03:36:40 -0700", "from silpixa00401191.ir.intel.com ([10.55.128.95])\n by fmsmga008.fm.intel.com with ESMTP; 16 Sep 2021 03:36:39 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10108\"; a=\"209764354\"", "E=Sophos;i=\"5.85,298,1624345200\"; d=\"scan'208\";a=\"209764354\"", "E=Sophos;i=\"5.85,298,1624345200\"; d=\"scan'208\";a=\"509258147\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 16 Sep 2021 10:36:37 +0000", "Message-Id": "\n <25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, when VFIO support is not compiled, FreeBSD and Linux have\ndifferent return values. Fix Linux implementation to follow FreeBSD one.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n\nNotes:\n Current minimum support Linux kernel is 4.4, and Meson build file sets the\n RTE_EAL_VFIO config option to `true` simply because we are compiling for Linux.\n So, it looks like VFIO support is pretty much assumed on Linux, so i think we\n can safely drop the fallback dummy implementation from Linux altogether?\n\n lib/eal/linux/eal_vfio.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/eal/linux/eal_vfio.c b/lib/eal/linux/eal_vfio.c\nindex 25add2fa5d..b9e4d3ad3c 100644\n--- a/lib/eal/linux/eal_vfio.c\n+++ b/lib/eal/linux/eal_vfio.c\n@@ -2111,19 +2111,19 @@ rte_vfio_enable(__rte_unused const char *modname)\n int\n rte_vfio_is_enabled(__rte_unused const char *modname)\n {\n-\treturn -1;\n+\treturn 0;\n }\n \n int\n rte_vfio_noiommu_is_enabled(void)\n {\n-\treturn -1;\n+\treturn 0;\n }\n \n int\n rte_vfio_clear_group(__rte_unused int vfio_group_fd)\n {\n-\treturn -1;\n+\treturn 0;\n }\n \n int\n", "prefixes": [ "v1", "1/2" ] }