Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99023/?format=api
{ "id": 99023, "url": "http://patchwork.dpdk.org/api/patches/99023/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/67c4e47e511558e2442c73c57c1764df656720e3.1631788595.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<67c4e47e511558e2442c73c57c1764df656720e3.1631788595.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/67c4e47e511558e2442c73c57c1764df656720e3.1631788595.git.anatoly.burakov@intel.com", "date": "2021-09-16T10:36:38", "name": "[v1,2/2] vfio: add errno on unsupported platforms", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6d6ee36c8997d59b868aa9b61acd287bcb09b869", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/67c4e47e511558e2442c73c57c1764df656720e3.1631788595.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 18978, "url": "http://patchwork.dpdk.org/api/series/18978/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=18978", "date": "2021-09-16T10:36:37", "name": "[v1,1/2] vfio: make API return values consistent", "version": 1, "mbox": "http://patchwork.dpdk.org/series/18978/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/99023/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/99023/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AF130A0C41;\n\tThu, 16 Sep 2021 12:36:46 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BB130410F0;\n\tThu, 16 Sep 2021 12:36:43 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id EC1414003F\n for <dev@dpdk.org>; Thu, 16 Sep 2021 12:36:41 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 16 Sep 2021 03:36:41 -0700", "from silpixa00401191.ir.intel.com ([10.55.128.95])\n by fmsmga008.fm.intel.com with ESMTP; 16 Sep 2021 03:36:40 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10108\"; a=\"209764356\"", "E=Sophos;i=\"5.85,298,1624345200\"; d=\"scan'208\";a=\"209764356\"", "E=Sophos;i=\"5.85,298,1624345200\"; d=\"scan'208\";a=\"509258160\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 16 Sep 2021 10:36:38 +0000", "Message-Id": "\n <67c4e47e511558e2442c73c57c1764df656720e3.1631788595.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "\n <25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com>", "References": "\n <25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 2/2] vfio: add errno on unsupported platforms", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, when code is running on FreeBSD (or using fallback Linux\nimplementation), there is no way to distinguish between a geniune error\nand a \"VFIO is unsupported\" error. Fix the dummy implemnetations to also\nset the rte_errno flag.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/eal/freebsd/eal.c | 12 ++++++++++++\n lib/eal/linux/eal_vfio.c | 12 ++++++++++++\n 2 files changed, 24 insertions(+)", "diff": "diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex 6cee5ae369..6d249edb11 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -1000,6 +1000,7 @@ int rte_vfio_setup_device(__rte_unused const char *sysfs_base,\n \t\t __rte_unused int *vfio_dev_fd,\n \t\t __rte_unused struct vfio_device_info *device_info)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -1007,11 +1008,13 @@ int rte_vfio_release_device(__rte_unused const char *sysfs_base,\n \t\t\t__rte_unused const char *dev_addr,\n \t\t\t__rte_unused int fd)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n int rte_vfio_enable(__rte_unused const char *modname)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -1035,30 +1038,35 @@ rte_vfio_get_group_num(__rte_unused const char *sysfs_base,\n \t\t __rte_unused const char *dev_addr,\n \t\t __rte_unused int *iommu_group_num)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n int\n rte_vfio_get_container_fd(void)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n int\n rte_vfio_get_group_fd(__rte_unused int iommu_group_num)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n int\n rte_vfio_container_create(void)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n int\n rte_vfio_container_destroy(__rte_unused int container_fd)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -1066,6 +1074,7 @@ int\n rte_vfio_container_group_bind(__rte_unused int container_fd,\n \t\t__rte_unused int iommu_group_num)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -1073,6 +1082,7 @@ int\n rte_vfio_container_group_unbind(__rte_unused int container_fd,\n \t\t__rte_unused int iommu_group_num)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -1082,6 +1092,7 @@ rte_vfio_container_dma_map(__rte_unused int container_fd,\n \t\t\t__rte_unused uint64_t iova,\n \t\t\t__rte_unused uint64_t len)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -1091,5 +1102,6 @@ rte_vfio_container_dma_unmap(__rte_unused int container_fd,\n \t\t\t__rte_unused uint64_t iova,\n \t\t\t__rte_unused uint64_t len)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\ndiff --git a/lib/eal/linux/eal_vfio.c b/lib/eal/linux/eal_vfio.c\nindex b9e4d3ad3c..bb4c225aed 100644\n--- a/lib/eal/linux/eal_vfio.c\n+++ b/lib/eal/linux/eal_vfio.c\n@@ -2092,6 +2092,7 @@ rte_vfio_setup_device(__rte_unused const char *sysfs_base,\n \t\t__rte_unused int *vfio_dev_fd,\n \t\t__rte_unused struct vfio_device_info *device_info)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -2099,12 +2100,14 @@ int\n rte_vfio_release_device(__rte_unused const char *sysfs_base,\n \t\t__rte_unused const char *dev_addr, __rte_unused int fd)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n int\n rte_vfio_enable(__rte_unused const char *modname)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -2131,30 +2134,35 @@ rte_vfio_get_group_num(__rte_unused const char *sysfs_base,\n \t\t__rte_unused const char *dev_addr,\n \t\t__rte_unused int *iommu_group_num)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n int\n rte_vfio_get_container_fd(void)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n int\n rte_vfio_get_group_fd(__rte_unused int iommu_group_num)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n int\n rte_vfio_container_create(void)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n int\n rte_vfio_container_destroy(__rte_unused int container_fd)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -2162,6 +2170,7 @@ int\n rte_vfio_container_group_bind(__rte_unused int container_fd,\n \t\t__rte_unused int iommu_group_num)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -2169,6 +2178,7 @@ int\n rte_vfio_container_group_unbind(__rte_unused int container_fd,\n \t\t__rte_unused int iommu_group_num)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -2178,6 +2188,7 @@ rte_vfio_container_dma_map(__rte_unused int container_fd,\n \t\t__rte_unused uint64_t iova,\n \t\t__rte_unused uint64_t len)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -2187,6 +2198,7 @@ rte_vfio_container_dma_unmap(__rte_unused int container_fd,\n \t\t__rte_unused uint64_t iova,\n \t\t__rte_unused uint64_t len)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n", "prefixes": [ "v1", "2/2" ] }