Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99346/?format=api
{ "id": 99346, "url": "http://patchwork.dpdk.org/api/patches/99346/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210921110038.115560-1-hkalra@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210921110038.115560-1-hkalra@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210921110038.115560-1-hkalra@marvell.com", "date": "2021-09-21T11:00:37", "name": "[1/2] common/cnxk: clear rvum interrupts", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "568f0e3e5a2eca69a863be166041a95f95e0d0d5", "submitter": { "id": 1182, "url": "http://patchwork.dpdk.org/api/people/1182/?format=api", "name": "Harman Kalra", "email": "hkalra@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210921110038.115560-1-hkalra@marvell.com/mbox/", "series": [ { "id": 19053, "url": "http://patchwork.dpdk.org/api/series/19053/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=19053", "date": "2021-09-21T11:00:37", "name": "[1/2] common/cnxk: clear rvum interrupts", "version": 1, "mbox": "http://patchwork.dpdk.org/series/19053/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/99346/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/99346/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9CC84A0C4C;\n\tTue, 21 Sep 2021 13:00:57 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 33F6D40683;\n\tTue, 21 Sep 2021 13:00:57 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 8E2FD4003C\n for <dev@dpdk.org>; Tue, 21 Sep 2021 13:00:55 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18KMaovk005379\n for <dev@dpdk.org>; Tue, 21 Sep 2021 04:00:54 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com with ESMTP id 3b7384hvr1-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Tue, 21 Sep 2021 04:00:54 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Tue, 21 Sep 2021 04:00:52 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Tue, 21 Sep 2021 04:00:52 -0700", "from localhost.localdomain (unknown [10.29.52.211])\n by maili.marvell.com (Postfix) with ESMTP id CA5D93F70A1;\n Tue, 21 Sep 2021 04:00:50 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-type; s=pfpt0220;\n bh=IrY9LStoRtgq+a7x8+Q5YhWnG/kr80Yo183Cc0Nnl3Y=;\n b=JQ/ThE02JEtOAgKQtRXZjtfSqtYCAAdXiy+MuPGheZinfbSwD02GOYwACM4/7+yQfAV6\n l+eSeewwXZxhmu0c6VB1cAUzBMG7SKsLxCaRzzJ0xR9Pfe2gIhYZQTS8pxetmMLatAec\n DwDz1XbC7ZBQvmSePF4kRz5UFbDrN71/Xhfo0OMmaDjZGA1NTtybMCMAqAOgkpBS2aj0\n LAvdUwRX+qmLLb38Gxo0+Z4EJywGBjq7omIuBnvFjX89HcOln/HtnnuUG4Trqxj3L3cr\n JyNEH8jRXUk8Fu5Upsb6jDIpjPY8KCh1IYDyXOFdgg2atIxZmB4oeflfCmbqiMthRrMj 7Q==", "From": "Harman Kalra <hkalra@marvell.com>", "To": "<dev@dpdk.org>, Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "Harman Kalra <hkalra@marvell.com>", "Date": "Tue, 21 Sep 2021 16:30:37 +0530", "Message-ID": "<20210921110038.115560-1-hkalra@marvell.com>", "X-Mailer": "git-send-email 2.18.0", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "fmPp3reApBx4DQEECPaibSINGXWy3SAo", "X-Proofpoint-ORIG-GUID": "fmPp3reApBx4DQEECPaibSINGXWy3SAo", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475\n definitions=2021-09-21_01,2021-09-20_01,2020-04-07_01", "Subject": "[dpdk-dev] [PATCH 1/2] common/cnxk: clear rvum interrupts", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As per an known HW issue RVUM interrupts may get dropped, If an RVUM\ninterrupt event occurs when PCCPF_XXX_MSIX_CAP_HDR[MSIXEN]=0 then no\ninterrupt is triggered, which is expected. But after MSIXEN is set to\n1, subsequently if same interrupts event occurs again, still no\ninterrupt will be triggered.\n\nAs a workaround, all RVUM interrupt lines should be cleared between\nMSIXEN=0 and MSIXEN=1.\n\nSigned-off-by: Harman Kalra <hkalra@marvell.com>\n---\n drivers/common/cnxk/roc_dev.c | 35 +++++++++++++++++++++++++++++++++++\n 1 file changed, 35 insertions(+)", "diff": "diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c\nindex 4e204373dc..ce6980cbe4 100644\n--- a/drivers/common/cnxk/roc_dev.c\n+++ b/drivers/common/cnxk/roc_dev.c\n@@ -884,6 +884,38 @@ vf_flr_register_irqs(struct plt_pci_device *pci_dev, struct dev *dev)\n \treturn 0;\n }\n \n+static void\n+clear_rvum_interrupts(struct dev *dev)\n+{\n+\tuint64_t intr;\n+\tint i;\n+\n+\tif (dev_is_vf(dev)) {\n+\t\t/* Clear VF mbox interrupt */\n+\t\tintr = plt_read64(dev->bar2 + RVU_VF_INT);\n+\t\tif (intr)\n+\t\t\tplt_write64(intr, dev->bar2 + RVU_VF_INT);\n+\t} else {\n+\t\t/* Clear AF PF interrupt line */\n+\t\tintr = plt_read64(dev->bar2 + RVU_PF_INT);\n+\t\tif (intr)\n+\t\t\tplt_write64(intr, dev->bar2 + RVU_PF_INT);\n+\t\tfor (i = 0; i < MAX_VFPF_DWORD_BITS; ++i) {\n+\t\t\t/* Clear MBOX interrupts */\n+\t\t\tintr = plt_read64(dev->bar2 + RVU_PF_VFPF_MBOX_INTX(i));\n+\t\t\tif (intr)\n+\t\t\t\tplt_write64(intr,\n+\t\t\t\t\t dev->bar2 +\n+\t\t\t\t\t\t RVU_PF_VFPF_MBOX_INTX(i));\n+\t\t\t/* Clear VF FLR interrupts */\n+\t\t\tintr = plt_read64(dev->bar2 + RVU_PF_VFFLR_INTX(i));\n+\t\t\tif (intr)\n+\t\t\t\tplt_write64(intr,\n+\t\t\t\t\t dev->bar2 + RVU_PF_VFFLR_INTX(i));\n+\t\t}\n+\t}\n+}\n+\n int\n dev_active_vfs(struct dev *dev)\n {\n@@ -1090,6 +1122,9 @@ dev_init(struct dev *dev, struct plt_pci_device *pci_dev)\n \t\tintr_offset = RVU_PF_INT;\n \t}\n \n+\t/* Clear all RVUM interrupts */\n+\tclear_rvum_interrupts(dev);\n+\n \t/* Initialize the local mbox */\n \trc = mbox_init(&dev->mbox_local, mbox, bar2, direction, 1, intr_offset);\n \tif (rc)\n", "prefixes": [ "1/2" ] }