Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99782/?format=api
{ "id": 99782, "url": "http://patchwork.dpdk.org/api/patches/99782/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210927122650.30881-10-nipun.gupta@nxp.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210927122650.30881-10-nipun.gupta@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210927122650.30881-10-nipun.gupta@nxp.com", "date": "2021-09-27T12:26:48", "name": "[09/11] raw/dpaa2_qdma: use correct params for config and queue setup", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "743da1a8dab64401c783ad250a05df02477b8352", "submitter": { "id": 471, "url": "http://patchwork.dpdk.org/api/people/471/?format=api", "name": "Nipun Gupta", "email": "nipun.gupta@nxp.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210927122650.30881-10-nipun.gupta@nxp.com/mbox/", "series": [ { "id": 19191, "url": "http://patchwork.dpdk.org/api/series/19191/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=19191", "date": "2021-09-27T12:26:39", "name": "NXP DPAAx Bus and PMD changes", "version": 1, "mbox": "http://patchwork.dpdk.org/series/19191/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/99782/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/99782/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7759FA0548;\n\tMon, 27 Sep 2021 14:27:53 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 81BF641139;\n\tMon, 27 Sep 2021 14:27:06 +0200 (CEST)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n by mails.dpdk.org (Postfix) with ESMTP id 880FF40E3C\n for <dev@dpdk.org>; Mon, 27 Sep 2021 14:26:56 +0200 (CEST)", "from inva020.nxp.com (localhost [127.0.0.1])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 681611A1E68;\n Mon, 27 Sep 2021 14:26:56 +0200 (CEST)", "from aprdc01srsp001v.ap-rdc01.nxp.com\n (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 2EC751A13F8;\n Mon, 27 Sep 2021 14:26:56 +0200 (CEST)", "from lsv03274.swis.in-blr01.nxp.com (lsv03274.swis.in-blr01.nxp.com\n [92.120.147.114])\n by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 7B989183AD26;\n Mon, 27 Sep 2021 20:26:55 +0800 (+08)" ], "From": "nipun.gupta@nxp.com", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@intel.com, hemant.agrawal@nxp.com,\n sachin.saxena@nxp.com, Nipun Gupta <nipun.gupta@nxp.com>", "Date": "Mon, 27 Sep 2021 17:56:48 +0530", "Message-Id": "<20210927122650.30881-10-nipun.gupta@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20210927122650.30881-1-nipun.gupta@nxp.com>", "References": "<20210927122650.30881-1-nipun.gupta@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "Subject": "[dpdk-dev] [PATCH 09/11] raw/dpaa2_qdma: use correct params for\n config and queue setup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Nipun Gupta <nipun.gupta@nxp.com>\n\nRAW configure and Queue setup APIs support size parameter for\nconfigure. This patch supports the same for DPAA2 QDMA PMD APIs\n\nSigned-off-by: Nipun Gupta <nipun.gupta@nxp.com>\n---\n drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 12 +++++++++---\n drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h | 8 ++++----\n 2 files changed, 13 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c\nindex c961e18d67..2048c2c514 100644\n--- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c\n+++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c\n@@ -1,5 +1,5 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright 2018-2020 NXP\n+ * Copyright 2018-2021 NXP\n */\n \n #include <string.h>\n@@ -1146,8 +1146,11 @@ dpaa2_qdma_configure(const struct rte_rawdev *rawdev,\n \n \tDPAA2_QDMA_FUNC_TRACE();\n \n-\tif (config_size != sizeof(*qdma_config))\n+\tif (config_size != sizeof(*qdma_config)) {\n+\t\tDPAA2_QDMA_ERR(\"Config size mismatch. Expected %ld, Got: %ld\",\n+\t\t\tsizeof(*qdma_config), config_size);\n \t\treturn -EINVAL;\n+\t}\n \n \t/* In case QDMA device is not in stopped state, return -EBUSY */\n \tif (qdma_dev->state == 1) {\n@@ -1247,8 +1250,11 @@ dpaa2_qdma_queue_setup(struct rte_rawdev *rawdev,\n \n \tDPAA2_QDMA_FUNC_TRACE();\n \n-\tif (conf_size != sizeof(*q_config))\n+\tif (conf_size != sizeof(*q_config)) {\n+\t\tDPAA2_QDMA_ERR(\"Config size mismatch. Expected %ld, Got: %ld\",\n+\t\t\tsizeof(*q_config), conf_size);\n \t\treturn -EINVAL;\n+\t}\n \n \trte_spinlock_lock(&qdma_dev->lock);\n \ndiff --git a/drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h b/drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h\nindex cc1ac25451..1314474271 100644\n--- a/drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h\n+++ b/drivers/raw/dpaa2_qdma/rte_pmd_dpaa2_qdma.h\n@@ -1,5 +1,5 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright 2018-2020 NXP\n+ * Copyright 2018-2021 NXP\n */\n \n #ifndef __RTE_PMD_DPAA2_QDMA_H__\n@@ -177,13 +177,13 @@ struct rte_qdma_queue_config {\n #define rte_qdma_info rte_rawdev_info\n #define rte_qdma_start(id) rte_rawdev_start(id)\n #define rte_qdma_reset(id) rte_rawdev_reset(id)\n-#define rte_qdma_configure(id, cf) rte_rawdev_configure(id, cf)\n+#define rte_qdma_configure(id, cf, sz) rte_rawdev_configure(id, cf, sz)\n #define rte_qdma_dequeue_buffers(id, buf, num, ctxt) \\\n \trte_rawdev_dequeue_buffers(id, buf, num, ctxt)\n #define rte_qdma_enqueue_buffers(id, buf, num, ctxt) \\\n \trte_rawdev_enqueue_buffers(id, buf, num, ctxt)\n-#define rte_qdma_queue_setup(id, qid, cfg) \\\n-\trte_rawdev_queue_setup(id, qid, cfg)\n+#define rte_qdma_queue_setup(id, qid, cfg, sz) \\\n+\trte_rawdev_queue_setup(id, qid, cfg, sz)\n \n /*TODO introduce per queue stats API in rawdew */\n /**\n", "prefixes": [ "09/11" ] }