Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/99906/?format=api
{ "id": 99906, "url": "http://patchwork.dpdk.org/api/patches/99906/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210928112912.785412-3-andrew.rybchenko@oktetlabs.ru/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210928112912.785412-3-andrew.rybchenko@oktetlabs.ru>", "list_archive_url": "https://inbox.dpdk.org/dev/20210928112912.785412-3-andrew.rybchenko@oktetlabs.ru", "date": "2021-09-28T11:29:03", "name": "[02/11] net/sfc: rename accumulative SW stats to total", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "935526dea2202a6490a73d91d39a226b8d51db27", "submitter": { "id": 2013, "url": "http://patchwork.dpdk.org/api/people/2013/?format=api", "name": "Andrew Rybchenko", "email": "Andrew.Rybchenko@oktetlabs.ru" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210928112912.785412-3-andrew.rybchenko@oktetlabs.ru/mbox/", "series": [ { "id": 19227, "url": "http://patchwork.dpdk.org/api/series/19227/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=19227", "date": "2021-09-28T11:29:01", "name": "net/sfc: support per-queue stats on EF100", "version": 1, "mbox": "http://patchwork.dpdk.org/series/19227/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/99906/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/99906/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7BCFCA0032;\n\tTue, 28 Sep 2021 13:29:48 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7CB70410EF;\n\tTue, 28 Sep 2021 13:29:40 +0200 (CEST)", "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id 5F27D40DF6\n for <dev@dpdk.org>; Tue, 28 Sep 2021 13:29:36 +0200 (CEST)", "by shelob.oktetlabs.ru (Postfix, from userid 122)\n id 284457F6D2; Tue, 28 Sep 2021 14:29:36 +0300 (MSK)", "from aros.oktetlabs.ru (aros.oktetlabs.ru [192.168.38.17])\n by shelob.oktetlabs.ru (Postfix) with ESMTP id 3C39A7F6D3;\n Tue, 28 Sep 2021 14:29:31 +0300 (MSK)" ], "X-Spam-Checker-Version": "SpamAssassin 3.4.2 (2018-09-13) on shelob.oktetlabs.ru", "X-Spam-Level": "", "X-Spam-Status": "No, score=0.8 required=5.0 tests=ALL_TRUSTED,\n DKIM_ADSP_DISCARD,\n URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2", "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 3C39A7F6D3", "Authentication-Results": "shelob.oktetlabs.ru/3C39A7F6D3; dkim=none;\n dkim-atps=neutral", "From": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "To": "dev@dpdk.org", "Cc": "Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>", "Date": "Tue, 28 Sep 2021 14:29:03 +0300", "Message-Id": "<20210928112912.785412-3-andrew.rybchenko@oktetlabs.ru>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210928112912.785412-1-andrew.rybchenko@oktetlabs.ru>", "References": "<20210928112912.785412-1-andrew.rybchenko@oktetlabs.ru>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 02/11] net/sfc: rename accumulative SW stats to\n total", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\n\nThis is a better word used in RTE docs.\n\nSigned-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n drivers/net/sfc/sfc_sw_stats.c | 52 +++++++++++++++++-----------------\n 1 file changed, 26 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_sw_stats.c b/drivers/net/sfc/sfc_sw_stats.c\nindex 2b8b1b56e9..a9f1790d38 100644\n--- a/drivers/net/sfc/sfc_sw_stats.c\n+++ b/drivers/net/sfc/sfc_sw_stats.c\n@@ -126,7 +126,7 @@ sfc_sw_stat_get_queue_count(struct sfc_adapter *sa,\n static unsigned int\n sfc_sw_xstat_per_queue_get_count(unsigned int nb_queues)\n {\n-\t/* Take into account the accumulative xstat of all queues */\n+\t/* Take into account the total xstat of all queues */\n \treturn nb_queues > 0 ? 1 + nb_queues : 0;\n }\n \n@@ -160,7 +160,7 @@ sfc_sw_stat_get_names(struct sfc_adapter *sa,\n \t*nb_supported += sfc_sw_xstat_per_queue_get_count(nb_queues);\n \n \t/*\n-\t * The order of each software xstat type is the accumulative xstat\n+\t * The order of each software xstat type is the total xstat\n \t * followed by per-queue xstats.\n \t */\n \tif (*nb_written < xstats_names_sz) {\n@@ -206,7 +206,7 @@ sfc_sw_xstat_get_names_by_id(struct sfc_adapter *sa,\n \t*nb_supported += sfc_sw_xstat_per_queue_get_count(nb_queues);\n \n \t/*\n-\t * The order of each software xstat type is the accumulative xstat\n+\t * The order of each software xstat type is the total xstat\n \t * followed by per-queue xstats.\n \t */\n \tfor (i = 0; i < size; i++) {\n@@ -232,8 +232,8 @@ sfc_sw_xstat_get_values(struct sfc_adapter *sa,\n {\n \tunsigned int qid;\n \tuint64_t value;\n-\tstruct rte_eth_xstat *accum_xstat;\n-\tbool count_accum_value = false;\n+\tstruct rte_eth_xstat *total_xstat;\n+\tbool count_total_value = false;\n \tunsigned int nb_queues;\n \n \tnb_queues = sfc_sw_stat_get_queue_count(sa, sw_xstat);\n@@ -242,12 +242,12 @@ sfc_sw_xstat_get_values(struct sfc_adapter *sa,\n \t*nb_supported += sfc_sw_xstat_per_queue_get_count(nb_queues);\n \n \t/*\n-\t * The order of each software xstat type is the accumulative xstat\n+\t * The order of each software xstat type is the total xstat\n \t * followed by per-queue xstats.\n \t */\n \tif (*nb_written < xstats_size) {\n-\t\tcount_accum_value = true;\n-\t\taccum_xstat = &xstats[*nb_written];\n+\t\tcount_total_value = true;\n+\t\ttotal_xstat = &xstats[*nb_written];\n \t\txstats[*nb_written].id = *nb_written;\n \t\txstats[*nb_written].value = 0;\n \t\t(*nb_written)++;\n@@ -262,8 +262,8 @@ sfc_sw_xstat_get_values(struct sfc_adapter *sa,\n \t\t\t(*nb_written)++;\n \t\t}\n \n-\t\tif (count_accum_value)\n-\t\t\taccum_xstat->value += value;\n+\t\tif (count_total_value)\n+\t\t\ttotal_xstat->value += value;\n \t}\n }\n \n@@ -278,9 +278,9 @@ sfc_sw_xstat_get_values_by_id(struct sfc_adapter *sa,\n \trte_spinlock_t *bmp_lock = &sa->sw_xstats.queues_bitmap_lock;\n \tstruct rte_bitmap *bmp = sa->sw_xstats.queues_bitmap;\n \tunsigned int id_base = *nb_supported;\n-\tbool count_accum_value = false;\n-\tunsigned int accum_value_idx;\n-\tuint64_t accum_value = 0;\n+\tbool count_total_value = false;\n+\tunsigned int total_value_idx;\n+\tuint64_t total_value = 0;\n \tunsigned int i, qid;\n \tunsigned int nb_queues;\n \n@@ -294,32 +294,32 @@ sfc_sw_xstat_get_values_by_id(struct sfc_adapter *sa,\n \t*nb_supported += sfc_sw_xstat_per_queue_get_count(nb_queues);\n \n \t/*\n-\t * The order of each software xstat type is the accumulative xstat\n+\t * The order of each software xstat type is the total xstat\n \t * followed by per-queue xstats.\n \t */\n \tfor (i = 0; i < ids_size; i++) {\n \t\tif (id_base <= ids[i] && ids[i] <= (id_base + nb_queues)) {\n \t\t\tif (ids[i] == id_base) { /* Accumulative value */\n-\t\t\t\tcount_accum_value = true;\n-\t\t\t\taccum_value_idx = i;\n+\t\t\t\tcount_total_value = true;\n+\t\t\t\ttotal_value_idx = i;\n \t\t\t\tcontinue;\n \t\t\t}\n \t\t\tqid = ids[i] - id_base - 1;\n \t\t\tvalues[i] = sw_xstat->get_val(sa, qid);\n-\t\t\taccum_value += values[i];\n+\t\t\ttotal_value += values[i];\n \n \t\t\trte_bitmap_set(bmp, qid);\n \t\t}\n \t}\n \n-\tif (count_accum_value) {\n-\t\tvalues[accum_value_idx] = 0;\n+\tif (count_total_value) {\n+\t\tvalues[total_value_idx] = 0;\n \t\tfor (qid = 0; qid < nb_queues; ++qid) {\n \t\t\tif (rte_bitmap_get(bmp, qid) != 0)\n \t\t\t\tcontinue;\n-\t\t\tvalues[accum_value_idx] += sw_xstat->get_val(sa, qid);\n+\t\t\tvalues[total_value_idx] += sw_xstat->get_val(sa, qid);\n \t\t}\n-\t\tvalues[accum_value_idx] += accum_value;\n+\t\tvalues[total_value_idx] += total_value;\n \t}\n \n unlock:\n@@ -457,7 +457,7 @@ sfc_sw_xstat_reset(struct sfc_adapter *sa, struct sfc_sw_xstat_descr *sw_xstat,\n {\n \tunsigned int nb_queues;\n \tunsigned int qid;\n-\tuint64_t *accum_xstat_reset;\n+\tuint64_t *total_xstat_reset;\n \n \tSFC_ASSERT(sfc_adapter_is_locked(sa));\n \n@@ -466,16 +466,16 @@ sfc_sw_xstat_reset(struct sfc_adapter *sa, struct sfc_sw_xstat_descr *sw_xstat,\n \t\treturn;\n \n \t/*\n-\t * The order of each software xstat type is the accumulative xstat\n+\t * The order of each software xstat type is the total xstat\n \t * followed by per-queue xstats.\n \t */\n-\taccum_xstat_reset = reset_vals;\n-\t*accum_xstat_reset = 0;\n+\ttotal_xstat_reset = reset_vals;\n+\t*total_xstat_reset = 0;\n \treset_vals++;\n \n \tfor (qid = 0; qid < nb_queues; ++qid) {\n \t\treset_vals[qid] = sw_xstat->get_val(sa, qid);\n-\t\t*accum_xstat_reset += reset_vals[qid];\n+\t\t*total_xstat_reset += reset_vals[qid];\n \t}\n }\n \n", "prefixes": [ "02/11" ] }