ethdev: fix endian annotation for spi item
Checks
Commit Message
spi should be set with network endian values.
While 0xffffffff == htonl(0xffffffff), this missing annotation is caught
by sparse when compiling ovs (dpdk-latest branch).
Fixes: d4b684f7197a ("net: add ESP header to generic flow steering")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/librte_ethdev/rte_flow.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 8/20/19 4:45 PM, David Marchand wrote:
> spi should be set with network endian values.
> While 0xffffffff == htonl(0xffffffff), this missing annotation is caught
> by sparse when compiling ovs (dpdk-latest branch).
>
> Fixes: d4b684f7197a ("net: add ESP header to generic flow steering")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
On 8/23/2019 11:17 AM, Andrew Rybchenko wrote:
> On 8/20/19 4:45 PM, David Marchand wrote:
>> spi should be set with network endian values.
>> While 0xffffffff == htonl(0xffffffff), this missing annotation is caught
>> by sparse when compiling ovs (dpdk-latest branch).
>>
>> Fixes: d4b684f7197a ("net: add ESP header to generic flow steering")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
Applied to dpdk-next-net/master, thanks.
@@ -935,7 +935,7 @@ struct rte_flow_item_esp {
#ifndef __cplusplus
static const struct rte_flow_item_esp rte_flow_item_esp_mask = {
.hdr = {
- .spi = 0xffffffff,
+ .spi = RTE_BE32(0xffffffff),
},
};
#endif